guile: fixed installed-vs-shipped error (parallel issue)

PATCH Superseded Robert Yang 2 participants 5 messages Jan 7, 2015 – Jan 8, 2015

lore

Share & tools

lore

Robert Yang

author

2015-01-07 14:55 UTC #0 lore raw

cover guile: fixed installed-vs-shipped error (parallel issue)

The following changes since commit dba30c2395792b553b69ce0b44cc75ff2dbdb317:

kernel.bbclass: fix do_unpack function when S ends with slash (2015-01-07 14:30:13 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/guile
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/guile

Robert Yang (1):
guile: fixed installed-vs-shipped error

 .../guile/files/libguile-Makefile.am-depends.patch |   39 ++++++++++++++++++++
 meta/recipes-devtools/guile/guile_2.0.11.bb        |    1 +
 2 files changed, 40 insertions(+)
 create mode 100644 meta/recipes-devtools/guile/files/libguile-Makefile.am-depends.patch

Signature · 1 line

1.7.9.5

Robert Yang

author

2015-01-07 14:55 UTC #1 lore raw

PATCH 1/1 guile: fixed installed-vs-shipped error

Fixed:
guile-2.0.11: guile: Files/directories were installed but not shipped
/usr/lib64/libguile-2.0*-gdb.scm [installed-vs-shipped]

This is because when there is no file in the directory:
for f in libguile-2.0*; do

    [snip]

done

The f would be libguile-2.0* itself, make sure the libs are installed firstly will fix the problem.

Signed-off-by Robert Yang <[email protected]>

---
 .../guile/files/libguile-Makefile.am-depends.patch |   39 ++++++++++++++++++++
 meta/recipes-devtools/guile/guile_2.0.11.bb        |    1 +
 2 files changed, 40 insertions(+)
 create mode 100644 meta/recipes-devtools/guile/files/libguile-Makefile.am-depends.patch

meta/recipes-devtools/guile/files/libguile-Makefile.am-depends.patch new file +39 -0

new file mode 100644
index 0000000..1045cbe
@@ -0,0 +1,39 @@
+From 9c4e120a7a87db34d22a50883a5a525170b480d7 Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Tue, 6 Jan 2015 23:10:51 -0800
+Subject: [PATCH] libguile/Makefile.am: install-data-hook: depends on
+ install-libLTLIBRARIES
+
+It may install such a file:
+/usr/lib64/libguile-2.0*-gdb.scm
+
+This is because when there is no file in the directory:
+for f in libguile-2.0*; do
+    [snip]
+done
+
+The f would be libguile-2.0* itself.
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ libguile/Makefile.am |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/libguile/Makefile.am b/libguile/Makefile.am
+index 281faac..fe0a3ba 100644
+--- a/libguile/Makefile.am
++++ b/libguile/Makefile.am
+@@ -449,7 +449,7 @@ EXTRA_libguile_@GUILE_EFFECTIVE_VERSION@_la_SOURCES = _scm.h		\
+ install-exec-hook:
+ 	rm -f $(DESTDIR)$(bindir)/guile-snarf.awk
+ 
+-install-data-hook: libguile-2.0-gdb.scm
++install-data-hook: libguile-2.0-gdb.scm install-libLTLIBRARIES
+ 	@$(MKDIR_P) $(DESTDIR)$(libdir)
+ ## We want to install libguile-2.0-gdb.scm as SOMETHING-gdb.scm.
+ ## SOMETHING is the full name of the final library.  We want to ignore
+-- 
+1.7.9.5
+

meta/recipes-devtools/guile/guile_2.0.11.bb +1 -0

index f2c0759..f5388aa 100644
@@ -21,6 +21,7 @@ SRC_URI = "${GNU_MIRROR}/guile/guile-${PV}.tar.xz \
            file://arm_endianness.patch \
            file://arm_aarch64.patch \
            file://workaround-ice-ssa-corruption.patch \
+           file://libguile-Makefile.am-depends.patch \
            "
 
 #           file://debian/0001-Change-guile-to-guile-X.Y-for-info-pages.patch

Signature · 1 line

1.7.9.5

Richard Purdie

2015-01-08 09:20 UTC #2 lore raw

Re: [PATCH 1/1] guile: fixed installed-vs-shipped error

Quoted 12 lines · Robert Yang

Fixed:
guile-2.0.11: guile: Files/directories were installed but not shipped
/usr/lib64/libguile-2.0*-gdb.scm [installed-vs-shipped]
This is because when there is no file in the directory:
for f in libguile-2.0*; do
    [snip]
done
The f would be libguile-2.0* itself, make sure the libs are installed firstly will fix the problem.

Quoted 6 lines

Signed-off-by Robert Yang <[email protected]>

---
 .../guile/files/libguile-Makefile.am-depends.patch |   39 ++++++++++++++++++++
 meta/recipes-devtools/guile/guile_2.0.11.bb        |    1 +
 2 files changed, 40 insertions(+)
 create mode 100644 meta/recipes-devtools/guile/files/libguile-Makefile.am-depends.patch

Not sure if this is as a result of this patch or a different issue but we saw:

https://autobuilder.yoctoproject.org/main/builders/nightly-x86-64-lsb/builds/153/steps/BuildImages_1/logs/stdio

in a build containing this patch. Looks like some dependency is missing and its trying to install the lib twice?

Cheers,

Richard

Robert Yang

author

2015-01-08 09:26 UTC #3 lore raw

Re: [PATCH 1/1] guile: fixed installed-vs-shipped error

Quoted 20 lines · Richard Purdie

Quoted 12 lines · Robert Yang
Fixed:
guile-2.0.11: guile: Files/directories were installed but not shipped
/usr/lib64/libguile-2.0*-gdb.scm [installed-vs-shipped]
This is because when there is no file in the directory:
for f in libguile-2.0*; do
     [snip]
done
The f would be libguile-2.0* itself, make sure the libs are installed firstly will fix the problem.
Quoted 6 lines
Signed-off-by Robert Yang <[email protected]>
---
  .../guile/files/libguile-Makefile.am-depends.patch |   39 ++++++++++++++++++++
  meta/recipes-devtools/guile/guile_2.0.11.bb        |    1 +
  2 files changed, 40 insertions(+)
create mode 100644 meta/recipes-devtools/guile/files/libguile-Makefile.am-depends.patch

Quoted 7 lines

Not sure if this is as a result of this patch or a different issue but we saw:
https://autobuilder.yoctoproject.org/main/builders/nightly-x86-64-lsb/builds/153/steps/BuildImages_1/logs/stdio
in a build containing this patch. Looks like some dependency is missing and its trying to install the lib twice?

OK, I will take a look it.

// Robert

Quoted 7 lines

Cheers,
Richard

Robert Yang

author

2015-01-08 23:39 UTC #4 lore raw

Re: [PATCH 1/1] guile: fixed installed-vs-shipped error

In reply to Richard Purdie

Quoted 20 lines · Richard Purdie

Quoted 12 lines · Robert Yang
Fixed:
guile-2.0.11: guile: Files/directories were installed but not shipped
/usr/lib64/libguile-2.0*-gdb.scm [installed-vs-shipped]
This is because when there is no file in the directory:
for f in libguile-2.0*; do
     [snip]
done
The f would be libguile-2.0* itself, make sure the libs are installed firstly will fix the problem.
Quoted 6 lines
Signed-off-by Robert Yang <[email protected]>
---
  .../guile/files/libguile-Makefile.am-depends.patch |   39 ++++++++++++++++++++
  meta/recipes-devtools/guile/guile_2.0.11.bb        |    1 +
  2 files changed, 40 insertions(+)
create mode 100644 meta/recipes-devtools/guile/files/libguile-Makefile.am-depends.patch

Quoted 7 lines

Not sure if this is as a result of this patch or a different issue but we saw:
https://autobuilder.yoctoproject.org/main/builders/nightly-x86-64-lsb/builds/153/steps/BuildImages_1/logs/stdio
in a build containing this patch. Looks like some dependency is missing and its trying to install the lib twice?

Hi RP,

I found the reason:
install-data-hook: libguile-2.0-gdb.scm install-libLTLIBRARIES

would make it have another parallel issue with install-exec-am, I will fix it as:

install-exec-hook: libguile-2.0-gdb.scm

since install-exec-am depends on install-libLTLIBRARIES, rather than use install-data-hook.

I'm sorry about this, will send an update patch after more testing.

// Robert

Quoted 7 lines

Cheers,
Richard