sunxi: Initial Inet 86VS support.
Hi,
Quoted 5 lines · Hans de Goede
Hi,
Quoted 1 line · Michal Suchanek
Signed-off-by Michal Suchanek <[email protected]>
Quoted 8 lines
Thanks, I've merged this with a number of changes:
- Cleaned it up a bit
- Ported it to our new simplified dram config code in u-boot-sunxi/next
- Added OTG (host mode) support, so that you can hookup a keyboard and interact with u-boot (kernel otg host support is coming soonish too)
- Fixed the dtb name from sun5i-inet-86vs.dtb to sun5i-a13-inet-86vs.dtb to match the upstream kernel dts / dtb naming scheme.
Talking about upstream dts files, it would be great if you could officially submit one for the Inet 86VS upstream:
1) Drop any nand bits you may have in there as the nand code is not upstream yet
2) We've recently adapted a new style for upstream dts files, please reformat
the dts you've accordingly, see e.g.:
https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?h=sunxi/dt-for-3.20&id=19a08b6b3f782f577b4b0fef9b6e60beba66c2f3
3) Write a proper commit message with a short description of the board, and
be sure to add a Signed-off-by: Michal Suchanek <[email protected]>
4) Be sure to send the patch directly to Maxime Ripard, with [email protected] in the Cc, you may Cc other people / lists too, but you must send it to
those 2 addresses.
Regards,
Hans
Quoted 15 lines · Hans de Goede
Hi,
Quoted 12 lines · Hans de Goede
Hi,
Quoted 2 lines · Michal Suchanek
Signed-off-by Michal Suchanek <[email protected]>Thanks, I've merged this with a number of changes:
- Cleaned it up a bit
- Ported it to our new simplified dram config code in u-boot-sunxi/next
Thanks for looking into this.
I don't really know what counts as 'clean' config. There are multiple ways to specify an option and different configs use different ways.
Quoted 2 lines
Quoted 2 lines
- Added OTG (host mode) support, so that you can hookup a keyboard and interact with u-boot (kernel otg host support is coming soonish too)
I did not have OTG in my tree when writing this. Maybe I Should pull some more patches.
Quoted 3 lines
Quoted 2 lines
- Fixed the dtb name from sun5i-inet-86vs.dtb to sun5i-a13-inet-86vs.dtb to match the upstream kernel dts / dtb naming scheme.
Speaking of testing
I use FEL to boot the new u-boot and kernel. What was the way to build FEL spl since we have no separate FEL defconfigs?
And even if there is option to enable fel it does not change to SD uart, does it?
It probably should not by default even on devices without uart but selecting SD uart is required to have console.
Quoted 10 lines
Talking about upstream dts files, it would be great if you could officially submit one for the Inet 86VS upstream:
1) Drop any nand bits you may have in there as the nand code is not upstream yet
2) We've recently adapted a new style for upstream dts files, please reformat
the dts you've accordingly, see e.g.:
Quoted 8 lines
https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?h=sunxi/dt-for-3.20&id=19a08b6b3f782f577b4b0fef9b6e60beba66c2f3
3) Write a proper commit message with a short description of the board, and
be sure to add a Signed-off-by: Michal Suchanek <[email protected]>
4) Be sure to send the patch directly to Maxime Ripard, with [email protected]
in the Cc, you may Cc other people / lists too, but you must send it to
those 2 addresses.
My DT file is not complete. The nand part would probably be better in a separate patch but I would like to have console working.
Thanks
Michal