Skip to contentSkip to conversation

meta: several fixes

PATCH In review Robert Yang 3 participants 11 messages Feb 12, 2015 – Feb 13, 2015

lore
Share & tools
lore
#0 lore raw

cover meta: several fixes

The following changes since commit 6bf5cbbcac80ee818cc932d69227e70e41ce02d3:

libtool: Fix option parsing performance regression (2015-02-10 22:36:09 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/fixes
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/fixes

Robert Yang (7):
Revert "libtool: avoid running automake/autoconf --version"
libtool: don't execute automake and autoconf on every invocation
rt-tests: fix gzip command
gcc-sanitizers: check gcc-build-internal before link
btrfs-tools: fix for parallel build
btrfs-tools: remove nodocs.patch
neard: do not ship version.h

 .../neard/Makefile.am-do-not-ship-version.h.patch  |   36 ++++++++++
 meta/recipes-connectivity/neard/neard_0.15.bb      |    1 +
 .../btrfs-tools/btrfs-tools/fix-parallel.patch     |   32 +++++++++
 .../btrfs-tools/btrfs-tools/nodocs.patch           |   22 ------
 .../btrfs-tools/btrfs-tools_git.bb                 |    5 +-
 meta/recipes-devtools/gcc/gcc-sanitizers.inc       |    4 +-
 meta/recipes-devtools/libtool/libtool-2.4.5.inc    |    2 +-
 .../avoid-running-automake-autoconf-version.patch  |   54 ---------------
 ...-t-execute-automake-and-autoconf-on-every.patch |   71 ++++++++++++++++++++
 .../rt-tests/files/Makefile-fix-gzip-command.patch |   30 +++++++++
 meta/recipes-rt/rt-tests/rt-tests.inc              |    1 +
 11 files changed, 179 insertions(+), 79 deletions(-)
 create mode 100644 meta/recipes-connectivity/neard/neard/Makefile.am-do-not-ship-version.h.patch
 create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/fix-parallel.patch
 delete mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/nodocs.patch
 delete mode 100644 meta/recipes-devtools/libtool/libtool/avoid-running-automake-autoconf-version.patch
 create mode 100644 meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch
 create mode 100644 meta/recipes-rt/rt-tests/files/Makefile-fix-gzip-command.patch
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/7 Revert "libtool: avoid running automake/autoconf --version"

This reverts commit 1f53edeaf9ea59dd55459a6d5a93829fb4983839.

There is a better fix on upstream, will backport it.

---
 meta/recipes-devtools/libtool/libtool-2.4.5.inc    |    1 -
 .../avoid-running-automake-autoconf-version.patch  |   54 --------------------
 2 files changed, 55 deletions(-)
 delete mode 100644 meta/recipes-devtools/libtool/libtool/avoid-running-automake-autoconf-version.patch
meta/recipes-devtools/libtool/libtool-2.4.5.inc +0 -1
index 909c7da..88e281f 100644
@@ -18,7 +18,6 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
            file://dont-depend-on-help2man.patch \
            file://fix-resolve-lt-sysroot.patch \
            file://nohardcodepaths.patch \
-           file://avoid-running-automake-autoconf-version.patch \
            file://unwind-opt-parsing.patch \
           "
 
meta/recipes-devtools/libtool/libtool/avoid-running-automake-autoconf-version.patch deleted +0 -54

54 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 2/7 libtool: don't execute automake and autoconf on every invocation

In reply to Robert Yang

From the origin commit message:
Regression from 2.4.2 was causing noticable slow-down in builds that call libtool many times.
* build-aux/ltmain.in (func_help): Override func_help() from gl/build-aux/options-parser to only run automake --version and autoconf --version when libtool --help is executed on the command line.

---
 meta/recipes-devtools/libtool/libtool-2.4.5.inc    |    1 +
 ...-t-execute-automake-and-autoconf-on-every.patch |   71 ++++++++++++++++++++
 2 files changed, 72 insertions(+)
 create mode 100644 meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch
meta/recipes-devtools/libtool/libtool-2.4.5.inc +1 -0
index 88e281f..0f6bdc8 100644
@@ -19,6 +19,7 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
            file://fix-resolve-lt-sysroot.patch \
            file://nohardcodepaths.patch \
            file://unwind-opt-parsing.patch \
+           file://libtool-don-t-execute-automake-and-autoconf-on-every.patch \
           "
 
 SRC_URI[md5sum] = "7d30ed9fa6bb11270ebb31639a37bd54"
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +71 -0

71 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#5 lore raw

PATCH 3/7 rt-tests: fix gzip command

In reply to Robert Yang

The "-c" doesn't work in command "gzip file -c", need use "gzip -c file"

---
 .../rt-tests/files/Makefile-fix-gzip-command.patch |   30 ++++++++++++++++++++
 meta/recipes-rt/rt-tests/rt-tests.inc              |    1 +
 2 files changed, 31 insertions(+)
 create mode 100644 meta/recipes-rt/rt-tests/files/Makefile-fix-gzip-command.patch
meta/recipes-rt/rt-tests/files/Makefile-fix-gzip-command.patch new file +30 -0
new file mode 100644
index 0000000..0a35ddc
@@ -0,0 +1,30 @@
+From 07b5ed42d7041ccc084889eaa96817aa097bf461 Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Tue, 3 Feb 2015 03:10:25 +0000
+Subject: [PATCH] Makefile: fix gzip command
+
+The "-c" doesn't work in command "gzip file -c", need use "gzip -c file"
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index 219a591..c7d147a 100644
+--- a/Makefile
++++ b/Makefile
+@@ -144,7 +144,7 @@ install_hwlatdetect: hwlatdetect
+ 		install -D -m 755 src/hwlatdetect/hwlatdetect.py $(DESTDIR)$(PYLIB)/hwlatdetect.py ; \
+ 		rm -f "$(DESTDIR)$(bindir)/hwlatdetect" ; \
+ 		ln -s $(PYLIB)/hwlatdetect.py "$(DESTDIR)$(bindir)/hwlatdetect" ; \
+-		gzip src/hwlatdetect/hwlatdetect.8 -c >"$(DESTDIR)$(mandir)/man8/hwlatdetect.8.gz" ; \
++		gzip -c src/hwlatdetect/hwlatdetect.8 >"$(DESTDIR)$(mandir)/man8/hwlatdetect.8.gz" ; \
+ 	fi
+ 
+ .PHONY: release
+-- 
+2.0.1
+
meta/recipes-rt/rt-tests/rt-tests.inc +1 -0
index 7fbe6d4..4942701 100644
@@ -7,6 +7,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/clrkwllms/rt-tests.git
            file://0002-rt-tests-Break-out-install_hwlatdetect.patch \
            file://added-missing-dependencies.patch \
            file://hackbench-fix-error-check.patch \
+           file://Makefile-fix-gzip-command.patch \
 "
 
 S = "${WORKDIR}/git"
Signature · 1 line
1.7.9.5
#6 lore raw

PATCH 4/7 gcc-sanitizers: check gcc-build-internal before link

In reply to Robert Yang

The ${STAGING_INCDIR_NATIVE}/gcc-build-internal-$mtarget may not exist when use the external sdk toolchain, we need check before link for it.

Fixed:
run.do_configure.12538: 149: cd: can't cd to sysroots/x86_64-linux/usr/include/gcc-build-internal-x86_64-wrs-linux

(LOCAL REV: NOT UPSTREAM) -- Sent to oe-core on 20150204

---
 meta/recipes-devtools/gcc/gcc-sanitizers.inc |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-sanitizers.inc +3 -1
index 35c9247..c987ccb 100644
@@ -14,7 +14,9 @@ EXTRA_OECONF_PATHS = "\
 do_configure () {
     mtarget=`echo ${TARGET_SYS} | sed -e s#-${SDKPKGSUFFIX}##`
     target=`echo ${TARGET_SYS} | sed -e s#-${SDKPKGSUFFIX}##`
-    hardlinkdir ${STAGING_INCDIR_NATIVE}/gcc-build-internal-$mtarget ${B}
+    if [ -d ${STAGING_INCDIR_NATIVE}/gcc-build-internal-$mtarget ]; then
+        hardlinkdir ${STAGING_INCDIR_NATIVE}/gcc-build-internal-$mtarget ${B}
+    fi
 
     echo "Configuring libsanitizer"
     rm -rf ${B}/$target/libsanitizer/
Signature · 1 line
1.7.9.5
#7 lore raw

PATCH 5/7 btrfs-tools: fix for parallel build

In reply to Robert Yang

Fixed:
mkfs.c:300:46: error: 'BTRFS_BUILD_VERSION' undeclared (first use in this function)
fprintf(stderr, "mkfs.btrfs, part of %s\n", BTRFS_BUILD_VERSION);

---
 .../btrfs-tools/btrfs-tools/fix-parallel.patch     |   32 ++++++++++++++++++++
 .../btrfs-tools/btrfs-tools_git.bb                 |    5 ++-
 2 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/fix-parallel.patch
meta/recipes-devtools/btrfs-tools/btrfs-tools/fix-parallel.patch new file +32 -0
new file mode 100644
index 0000000..65c31a4
@@ -0,0 +1,32 @@
+From 373eb51328b5e10529763cad441210e6b0efb24e Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Wed, 11 Feb 2015 22:08:41 -0800
+Subject: [PATCH] Makefile: fix for parallel build
+
+Fixed:
+mkfs.c:300:46: error: 'BTRFS_BUILD_VERSION' undeclared (first use in this function)
+  fprintf(stderr, "mkfs.btrfs, part of %s\n", BTRFS_BUILD_VERSION);
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ Makefile |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index 9c69ada..30c6f06 100644
+--- a/Makefile
++++ b/Makefile
+@@ -118,7 +118,7 @@ else
+ 	AM_CFLAGS += -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2
+ endif
+ 
+-%.o.d: %.c
++%.o.d: %.c version.h
+ 	$(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
+ 
+ .c.o:
+-- 
+1.7.9.5
+
meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb +4 -1
index ef85057..d800426 100644
@@ -13,7 +13,10 @@ SECTION = "base"
 DEPENDS = "util-linux attr e2fsprogs lzo acl"
 
 SRCREV = "44cdb62d3478c834f41c87ea79d261b9c8982dce"
-SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git"
+SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git \
+           file://fix-parallel.patch \
+"
+
 S = "${WORKDIR}/git"
 
 PV = "3.14.2+git${SRCPV}"
Signature · 1 line
1.7.9.5
#9 lore raw

PATCH 6/7 btrfs-tools: remove nodocs.patch

In reply to Robert Yang

It isn't used anymore, the docs is disabled by DISABLE_DOCUMENTATION=1.

---
 .../btrfs-tools/btrfs-tools/nodocs.patch           |   22 --------------------
 1 file changed, 22 deletions(-)
 delete mode 100644 meta/recipes-devtools/btrfs-tools/btrfs-tools/nodocs.patch
meta/recipes-devtools/btrfs-tools/btrfs-tools/nodocs.patch deleted +0 -22
deleted file mode 100644
index 6df4e10..0000000
@@ -1,22 +0,0 @@
-Doc generation requires xmlto and ascidoc which we don't have right now.
-Disable doc generation until such times as we have the right dependencies.
-
-RP 2014/7/16
-
-Upstream-Status: Inappropriate
-
-Index: git/Makefile
-===================================================================
---- git.orig/Makefile	2014-07-16 13:21:43.289386655 +0000
-+++ git/Makefile	2014-07-16 13:42:46.453421079 +0000
-@@ -57,8 +57,8 @@
- btrfs_fragment_libs = -lgd -lpng -ljpeg -lfreetype
- 
- SUBDIRS =
--BUILDDIRS = $(patsubst %,build-%,$(SUBDIRS)) build-Documentation
--INSTALLDIRS = $(patsubst %,install-%,$(SUBDIRS)) install-Documentation
-+BUILDDIRS = $(patsubst %,build-%,$(SUBDIRS))
-+INSTALLDIRS = $(patsubst %,install-%,$(SUBDIRS))
- CLEANDIRS = $(patsubst %,clean-%,$(SUBDIRS))
- 
- .PHONY: $(SUBDIRS)
Signature · 1 line
1.7.9.5
#10 lore raw

PATCH 7/7 neard: do not ship version.h

In reply to Robert Yang

The HEADERS' name has been changed to pkginclude_HEADERS, so use nodist_pkginclude_HEADERS, otherwise version.h would be shipped.

It would cause other pkgs failed to build if ship version.h to usr/include/version.h

---
 .../neard/Makefile.am-do-not-ship-version.h.patch  |   36 ++++++++++++++++++++
 meta/recipes-connectivity/neard/neard_0.15.bb      |    1 +
 2 files changed, 37 insertions(+)
 create mode 100644 meta/recipes-connectivity/neard/neard/Makefile.am-do-not-ship-version.h.patch
meta/recipes-connectivity/neard/neard/Makefile.am-do-not-ship-version.h.patch new file +36 -0
new file mode 100644
index 0000000..16875e0
@@ -0,0 +1,36 @@
+From bfd32d68cfc9f1e31dab88e07446d1c02bc80b5e Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Thu, 12 Feb 2015 00:39:29 -0800
+Subject: [PATCH] Makefile.am: do not ship version.h
+
+The HEADERS' name has been changed to pkginclude_HEADERS, so use
+nodist_pkginclude_HEADERS, otherwise version.h would be shipped.
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ Makefile.am |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 3334790..69cd58f 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -10,11 +10,11 @@ pkginclude_HEADERS = include/types.h include/log.h include/plugin.h \
+ 			include/tlv.h include/setting.h include/device.h \
+ 			include/nfc_copy.h include/snep.h
+ 
+-nodist_include_HEADERS = include/version.h
++nodist_pkginclude_HEADERS = include/version.h
+ 
+ noinst_HEADERS = include/dbus.h
+ 
+-local_headers = $(foreach file,$(pkginclude_HEADERS) $(nodist_include_HEADERS) \
++local_headers = $(foreach file,$(pkginclude_HEADERS) $(nodist_pkginclude_HEADERS) \
+ 			$(noinst_HEADERS), include/near/$(notdir $(file)))
+ 
+ gdbus_sources = gdbus/gdbus.h gdbus/mainloop.c gdbus/watch.c \
+-- 
+1.7.9.5
+
meta/recipes-connectivity/neard/neard_0.15.bb +1 -0
index c92a171..508c622 100644
@@ -3,6 +3,7 @@ require neard.inc
 SRC_URI = "${KERNELORG_MIRROR}/linux/network/nfc/${BP}.tar.xz \
            file://neard.in \
            file://Makefile.am-fix-parallel-issue.patch \
+           file://Makefile.am-do-not-ship-version.h.patch \
           "
 SRC_URI[md5sum] = "b746ce62eeef88e8de90765e00a75a1c"
 SRC_URI[sha256sum] = "651f6513d32cdaf8a426255d03aff38a6620a89b0567ec2b36606c6330a93353"
Signature · 1 line
1.7.9.5
#3 lore raw

Re: [PATCH 2/7] libtool: don't execute automake and autoconf on every invocation

In reply to Robert Yang
Quoted 40 lines · Robert Yang

From the origin commit message:
Regression from 2.4.2 was causing noticable slow-down in builds that call libtool many times.
* build-aux/ltmain.in (func_help): Override func_help() from gl/build-aux/options-parser to only run automake --version and autoconf --version when libtool --help is executed on the command line.

---
 meta/recipes-devtools/libtool/libtool-2.4.5.inc    |    1 +
 ...-t-execute-automake-and-autoconf-on-every.patch |   71 ++++++++++++++++++++
 2 files changed, 72 insertions(+)
 create mode 100644 meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch
meta/recipes-devtools/libtool/libtool-2.4.5.inc +1 -0
index 88e281f..0f6bdc8 100644
@@ -19,6 +19,7 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
            file://fix-resolve-lt-sysroot.patch \
            file://nohardcodepaths.patch \
            file://unwind-opt-parsing.patch \
+           file://libtool-don-t-execute-automake-and-autoconf-on-every.patch \
           "
 
 SRC_URI[md5sum] = "7d30ed9fa6bb11270ebb31639a37bd54"
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +7 -0
new file mode 100644
index 0000000..f48f09c
@@ -0,0 +1,71 @@
+From 408cfb9c5fa8a666917167ffb806cb19deded429 Mon Sep 17 00:00:00 2001
+From: "Gary V. Vaughan" <[email protected]>
+Date: Fri, 6 Feb 2015 12:58:34 +0000
+Subject: [PATCH] libtool: don't execute automake and autoconf on every
+ invocation.
+
+Regression from 2.4.2 was causing noticable slow-down in builds

meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch line 17

Quoted 10 lines
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +10 -0
+that call libtool many times.
+* build-aux/ltmain.in (func_help): Override func_help() from
+gl/build-aux/options-parser to only run automake --version and
+autoconf --version when libtool --help is executed on the command
+line.
+* NO-THANKS: Add Robert Yang.
+Reported by Robert Yang
+
+Signed-off-by: Gary V. Vaughan <[email protected]>
+

typo

meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch line 18

Quoted 1 line
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +1 -0
+Updated: Change NO-THANKS to THANKS to apply the patch since upsream
                                                                ^^^^^^^
Quoted 40 lines
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +40 -0
+renamed it.
+
+Upstream-Stauts: Backport
+
+Signed-off-by: Robert Yang <[email protected]>
+
+---
+ THANKS           |    1 +
+ build-aux/ltmain.in |    9 ++++++++-
+ 2 files changed, 9 insertions(+), 1 deletion(-)
+
+diff --git a/THANKS b/THANKS
+index 0ab162d..aa7aa8c 100644
+--- a/THANKS
++++ b/THANKS
+@@ -258,6 +258,7 @@ Robert Garron                       [email protected]
+ Robert Millan                       [email protected]
+ Robert Ögren                        [email protected]
+ Roberto Bagnara                     [email protected]
++Robert Yang                         [email protected]
+ Roger Cornelius                     [email protected]
+ Roland Mainz                        [email protected]
+ Roumen Petrov                       [email protected]
+diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
+index 46a0bb5..d5cf07a 100644
+--- a/build-aux/ltmain.in
++++ b/build-aux/ltmain.in
+@@ -127,7 +127,12 @@ usage_message="Options:
+ "
+ 
+ # Additional text appended to 'usage_message' in response to '--help'.
+-long_help_message=$long_help_message"
++func_help ()
++{
++    $debug_cmd
++
++    func_usage_message
++    $ECHO "$long_help_message
+ 
+ MODE must be one of the following:

meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch line 68

Quoted 10 lines
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +10 -0
+ 
+@@ -158,6 +163,8 @@ include the following information:
+ Report bugs to <@PACKAGE_BUGREPORT@>.
+ GNU @PACKAGE@ home page: <@PACKAGE_URL@>.
+ General help using GNU software: <http://www.gnu.org/gethelp/>."
++    exit 0
++}
+ 
+ 
+ # func_lo2o OBJECT-NAME

Bye Henning

#4 lore raw

Re: [PATCH 2/7] libtool: don't execute automake and autoconf on every invocation

Quoted 53 lines · Henning Heinold
Quoted 40 lines · Robert Yang

From the origin commit message:
Regression from 2.4.2 was causing noticable slow-down in builds that call libtool many times.
* build-aux/ltmain.in (func_help): Override func_help() from gl/build-aux/options-parser to only run automake --version and autoconf --version when libtool --help is executed on the command line.

---
  meta/recipes-devtools/libtool/libtool-2.4.5.inc    |    1 +
  ...-t-execute-automake-and-autoconf-on-every.patch |   71 ++++++++++++++++++++
  2 files changed, 72 insertions(+)

create mode 100644 meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch

meta/recipes-devtools/libtool/libtool-2.4.5.inc +1 -0
index 88e281f..0f6bdc8 100644
@@ -19,6 +19,7 @@ SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
             file://fix-resolve-lt-sysroot.patch \
             file://nohardcodepaths.patch \
             file://unwind-opt-parsing.patch \
+           file://libtool-don-t-execute-automake-and-autoconf-on-every.patch \
            "
 
  SRC_URI[md5sum] = "7d30ed9fa6bb11270ebb31639a37bd54"
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +7 -0
new file mode 100644
index 0000000..f48f09c
@@ -0,0 +1,71 @@
+From 408cfb9c5fa8a666917167ffb806cb19deded429 Mon Sep 17 00:00:00 2001
+From: "Gary V. Vaughan" <[email protected]>
+Date: Fri, 6 Feb 2015 12:58:34 +0000
+Subject: [PATCH] libtool: don't execute automake and autoconf on every
+ invocation.
+
+Regression from 2.4.2 was causing noticable slow-down in builds

meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch line 17

Quoted 10 lines
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +10 -0
+that call libtool many times.
+* build-aux/ltmain.in (func_help): Override func_help() from
+gl/build-aux/options-parser to only run automake --version and
+autoconf --version when libtool --help is executed on the command
+line.
+* NO-THANKS: Add Robert Yang.
+Reported by Robert Yang
+
+Signed-off-by: Gary V. Vaughan <[email protected]>
+

typo

Quoted 2 lines

meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch line 18

Quoted 1 line
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +1 -0
+Updated: Change NO-THANKS to THANKS to apply the patch since upsream
                                                                 ^^^^^^^

Thanks, fixed in the repo.

// Robert

Quoted 53 lines
Quoted 40 lines
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +40 -0
+renamed it.
+
+Upstream-Stauts: Backport
+
+Signed-off-by: Robert Yang <[email protected]>
+
+---
+ THANKS           |    1 +
+ build-aux/ltmain.in |    9 ++++++++-
+ 2 files changed, 9 insertions(+), 1 deletion(-)
+
+diff --git a/THANKS b/THANKS
+index 0ab162d..aa7aa8c 100644
+--- a/THANKS
++++ b/THANKS
+@@ -258,6 +258,7 @@ Robert Garron                       [email protected]
+ Robert Millan                       [email protected]
+ Robert Ögren                        [email protected]
+ Roberto Bagnara                     [email protected]
++Robert Yang                         [email protected]
+ Roger Cornelius                     [email protected]
+ Roland Mainz                        [email protected]
+ Roumen Petrov                       [email protected]
+diff --git a/build-aux/ltmain.in b/build-aux/ltmain.in
+index 46a0bb5..d5cf07a 100644
+--- a/build-aux/ltmain.in
++++ b/build-aux/ltmain.in
+@@ -127,7 +127,12 @@ usage_message="Options:
+ "
+
+ # Additional text appended to 'usage_message' in response to '--help'.
+-long_help_message=$long_help_message"
++func_help ()
++{
++    $debug_cmd
++
++    func_usage_message
++    $ECHO "$long_help_message
+
+ MODE must be one of the following:

meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch line 68

Quoted 10 lines
meta/recipes-devtools/libtool/libtool/libtool-don-t-execute-automake-and-autoconf-on-every.patch new file +10 -0
+
+@@ -158,6 +163,8 @@ include the following information:
+ Report bugs to <@PACKAGE_BUGREPORT@>.
+ GNU @PACKAGE@ home page: <@PACKAGE_URL@>.
+ General help using GNU software: <http://www.gnu.org/gethelp/>."
++    exit 0
++}
+
+
+ # func_lo2o OBJECT-NAME

Bye Henning

#8 lore raw

Re: [PATCH 5/7] btrfs-tools: fix for parallel build

In reply to Robert Yang
Quoted 7 lines · Robert Yang

Fixed:
mkfs.c:300:46: error: 'BTRFS_BUILD_VERSION' undeclared (first use in this function)
fprintf(stderr, "mkfs.btrfs, part of %s\n", BTRFS_BUILD_VERSION);

In mut (about to be merged to master) there's a btrfs upgrade, can you rebase this?

Cheers,
Ross