various fixes mainly for pxa and colibri_pxa270

PATCH RESEND Superseded Marcel Ziswiler 4 participants 18 messages Feb 16, 2015 – Mar 2, 2015 Arm/versatile express platform

lore

Share & tools

lore

Stefano Babic

2015-02-16 12:33 UTC #3 lore raw

PATCH 2/12 remove nowhere used symbol CONFIG_SYS_CLKS_IN_HZ

In reply to Marcel Ziswiler

Hi Marcel,

include/configs/balloon3.h

Quoted 22 lines · Marcel Ziswiler

Basically finish what the following commit started a long time ago:

488f5d8790c451fc527fe5d2ef218f2a5e40ea17

Signed-off-by Marcel Ziswiler <[email protected]>

---
 include/configs/balloon3.h        | 1 -
 include/configs/flea3.h           | 2 --
 include/configs/mx35pdk.h         | 2 --
 include/configs/palmld.h          | 1 -
 include/configs/palmtc.h          | 1 -
 include/configs/palmtreo680.h     | 1 -
 include/configs/snowball.h        | 1 -
 include/configs/ti816x_evm.h      | 1 -
 include/configs/u8500_href.h      | 1 -
 include/configs/vexpress_common.h | 1 -
 include/configs/woodburn_common.h | 2 --
 include/configs/zipitz2.h         | 1 -
 12 files changed, 15 deletions(-)

include/configs/balloon3.h +0 -0

index 2f5a660..8dabc80 100644

For mx35pdk/woodburn:

Acked-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Simon Glass

2015-02-18 04:19 UTC #8 lore raw

PATCH 6/12 pxa: colibri_pxa270: migrate to generic board

In reply to Marcel Ziswiler

Quoted 6 lines · Marcel Ziswiler

Migrate Toradex Colibri PXA270 to use CONFIG_SYS_GENERIC_BOARD.
Signed-off-by Marcel Ziswiler <[email protected]>
---
 include/configs/colibri_pxa270.h | 2 ++
 1 file changed, 2 insertions(+)

Reviewed-by Simon Glass <[email protected]>

Marcel Ziswiler

author

2015-02-28 23:53 UTC #0 lore raw

cover various fixes mainly for pxa and colibri_pxa270

The following is a set of various fixes mainly for PXA and the Toradex Colibri PXA270 introducing it to generic board to save it from becoming obsolete as those modules are still on sale for another 3 to 4 years.

If I again do not get any feedback from Marek the current PXA CPU and Colibri PXA270 board maintainer may I ask Tom for help in getting this resolved?

Marcel Ziswiler (12):
pxa: fix wrong comment about vpac270 being the arch number remove nowhere used symbol CONFIG_SYS_CLKS_IN_HZ
pxa: balloon3: remove nowhere used symbol CONFIG_SYS_MEM_BUF_IMP
pxa: balloon3: fix comment about sdram banks
pxa: balloon3/colibri_pxa270: fix environment optionally being nowhere
pxa: colibri_pxa270: migrate to generic board
pxa: colibri_pxa270: disable loadb/s commands and long help
pxa: colibri_pxa270: avoid overwriting factory configuration block
pxa: colibri_pax270: fix CONFIG_BOOTCOMMAND
pxa: colibri_pxa270: fix wrong comment about voipac ethernet chip
pxa: colibri_pxa270: remove CONFIG_ENV_ADDR_REDUND
pxa: colibri_pxa270: integrate latest validated register settings

 board/balloon3/balloon3.c                     |  2 +-
 board/toradex/colibri_pxa270/colibri_pxa270.c |  2 +-
 include/configs/balloon3.h                    | 10 ++--
 include/configs/colibri_pxa270.h              | 77 ++++++++++++++-------------
 include/configs/flea3.h                       |  2 -
 include/configs/mx35pdk.h                     |  2 -
 include/configs/palmld.h                      |  1 -
 include/configs/palmtc.h                      |  1 -
 include/configs/palmtreo680.h                 |  1 -
 include/configs/snowball.h                    |  1 -
 include/configs/ti816x_evm.h                  |  1 -
 include/configs/u8500_href.h                  |  1 -
 include/configs/vexpress_common.h             |  1 -
 include/configs/vpac270.h                     |  3 +-
 include/configs/woodburn_common.h             |  2 -
 include/configs/zipitz2.h                     |  1 -
 16 files changed, 47 insertions(+), 61 deletions(-)

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #1 lore raw

PATCH RESEND 1/12 pxa: fix wrong comment about vpac270 being the arch number

Signed-off-by Marcel Ziswiler <[email protected]>

---
 board/balloon3/balloon3.c                     | 2 +-
 board/toradex/colibri_pxa270/colibri_pxa270.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

board/balloon3/balloon3.c +1 -1

index aa108ca..458d90c 100644
@@ -29,7 +29,7 @@ int board_init(void)
 	dcache_disable();
 	icache_disable();
 
-	/* arch number of vpac270 */
+	/* arch number of balloon3 */
 	gd->bd->bi_arch_number = MACH_TYPE_BALLOON3;
 
 	/* adress of boot parameters */

board/toradex/colibri_pxa270/colibri_pxa270.c +1 -1

index 8d95e4d..3def0a6 100644
@@ -23,7 +23,7 @@ int board_init(void)
 	dcache_disable();
 	icache_disable();
 
-	/* arch number of vpac270 */
+	/* arch number of Toradex Colibri PXA270 */
 	gd->bd->bi_arch_number = MACH_TYPE_COLIBRI;
 
 	/* adress of boot parameters */

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #2 lore raw

PATCH RESEND 2/12 remove nowhere used symbol CONFIG_SYS_CLKS_IN_HZ

In reply to Marcel Ziswiler

Basically finish what the following commit started a long time ago:

488f5d8790c451fc527fe5d2ef218f2a5e40ea17

Signed-off-by Marcel Ziswiler <[email protected]>

For mx35pdk/woodburn:

Acked-by Stefano Babic <[email protected]>

---
 include/configs/balloon3.h        | 1 -
 include/configs/flea3.h           | 2 --
 include/configs/mx35pdk.h         | 2 --
 include/configs/palmld.h          | 1 -
 include/configs/palmtc.h          | 1 -
 include/configs/palmtreo680.h     | 1 -
 include/configs/snowball.h        | 1 -
 include/configs/ti816x_evm.h      | 1 -
 include/configs/u8500_href.h      | 1 -
 include/configs/vexpress_common.h | 1 -
 include/configs/woodburn_common.h | 2 --
 include/configs/zipitz2.h         | 1 -
 12 files changed, 15 deletions(-)

include/configs/balloon3.h +0 -1

index 2f5a660..8dabc80 100644
@@ -84,7 +84,6 @@
 /*
  * Clock Configuration
  */
-#undef	CONFIG_SYS_CLKS_IN_HZ
 #define	CONFIG_SYS_CPUSPEED		0x290		/* 520MHz */
 
 /*

include/configs/flea3.h +0 -2

index bf02829..edff0f5 100644
@@ -124,8 +124,6 @@
 #define CONFIG_SYS_MEMTEST_START	0	/* memtest works on */
 #define CONFIG_SYS_MEMTEST_END		0x10000
 
-#undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */
-
 #define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
 
 /*

include/configs/mx35pdk.h +0 -2

index a145f08..603d17c 100644
@@ -146,8 +146,6 @@
 #define CONFIG_SYS_MEMTEST_START	0	/* memtest works on */
 #define CONFIG_SYS_MEMTEST_END		0x10000
 
-#undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */
-
 #define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
 
 /*

include/configs/palmld.h +0 -1

index 9480d8d..7dbc9ae 100644
@@ -114,7 +114,6 @@
 /*
  * Clock Configuration
  */
-#undef	CONFIG_SYS_CLKS_IN_HZ
 #define	CONFIG_SYS_CPUSPEED		0x210		/* 416MHz ; N=2,L=16 */
 
 /*

include/configs/palmtc.h +0 -1

index 8abce1b..75506b2 100644
@@ -116,7 +116,6 @@
 /*
  * Clock Configuration
  */
-#undef	CONFIG_SYS_CLKS_IN_HZ
 #define	CONFIG_SYS_CPUSPEED		0x161		/* 400MHz;L=1 M=3 T=1 */
 
 /*

include/configs/palmtreo680.h +0 -1

index 6490be5..bd0f44b 100644
@@ -117,7 +117,6 @@
 /*
  * Clock Configuration
  */
-#undef  CONFIG_SYS_CLKS_IN_HZ
 #define CONFIG_SYS_CPUSPEED             0x210           /* 416MHz ; N=2,L=16 */
 
 /*

include/configs/snowball.h +0 -1

index dacb560..126201c 100644
@@ -175,7 +175,6 @@
 #define CONFIG_SYS_MAXARGS	32	/* max number of command args */
 #define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE /* Boot Arg Buffer Size */
 
-#undef	CONFIG_SYS_CLKS_IN_HZ		/* everything, incl board info, in Hz */
 #define CONFIG_SYS_LOAD_ADDR		0x00100000 /* default load address */
 #define CONFIG_SYS_LOADS_BAUD_CHANGE	1

include/configs/ti816x_evm.h +0 -1

index 87a4efc..f69a559 100644
@@ -58,7 +58,6 @@
 		+ sizeof(CONFIG_SYS_PROMPT) + 16) /* print buffer size */
 #define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE /* boot arg buffer size */
 
-#undef  CONFIG_SYS_CLKS_IN_HZ
 #define CONFIG_SYS_LOAD_ADDR		0x81000000 /* Default load address */
 
 #define CONFIG_CMD_ASKEN

include/configs/u8500_href.h +0 -1

index 8d7970a..5302b1f 100644
@@ -131,7 +131,6 @@
 #define CONFIG_SYS_MAXARGS	32	/* max number of command args */
 #define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE /* Boot Arg Buffer Size */
 
-#undef	CONFIG_SYS_CLKS_IN_HZ		/* everything, incl board info, in Hz */
 #define CONFIG_SYS_LOAD_ADDR		0x00100000 /* default load address */
 #define CONFIG_SYS_LOADS_BAUD_CHANGE

include/configs/vexpress_common.h +0 -1

index 2dea921..989e755 100644
@@ -188,7 +188,6 @@
 #define CONFIG_BOOTP_PXE_CLIENTARCH	0x100
 
 /* Miscellaneous configurable options */
-#undef	CONFIG_SYS_CLKS_IN_HZ
 #define CONFIG_SYS_LOAD_ADDR		(V2M_BASE + 0x8000)
 #define LINUX_BOOT_PARAM_ADDR		(V2M_BASE + 0x2000)
 #define CONFIG_BOOTDELAY		2

include/configs/woodburn_common.h +0 -2

index c7a17f7..8e1c7a4 100644
@@ -146,8 +146,6 @@
 #define CONFIG_SYS_MEMTEST_START	0	/* memtest works on */
 #define CONFIG_SYS_MEMTEST_END		0x10000
 
-#undef	CONFIG_SYS_CLKS_IN_HZ	/* everything, incl board info, in Hz */
-
 #define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
 
 /*

include/configs/zipitz2.h +0 -1

index fe331bc..1dbbc15 100644
@@ -136,7 +136,6 @@ unsigned char zipitz2_spi_read(void);
 /*
  * Clock Configuration
  */
-#undef	CONFIG_SYS_CLKS_IN_HZ
 #define CONFIG_SYS_CPUSPEED		0x190		/* standard setting for 312MHz; L=16, N=1.5, A=0, SDCLK!=SystemBus */
 
 /*

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #4 lore raw

PATCH RESEND 3/12 pxa: balloon3: remove nowhere used symbol CONFIG_SYS_MEM_BUF_IMP

In reply to Marcel Ziswiler

Signed-off-by Marcel Ziswiler <[email protected]>

---
 include/configs/balloon3.h | 1 -
 include/configs/vpac270.h  | 1 -
 2 files changed, 2 deletions(-)

include/configs/balloon3.h +0 -1

index 8dabc80..f20a631 100644
@@ -190,7 +190,6 @@
 #define	CONFIG_SYS_MDMRS_VAL	0x00220022
 #define	CONFIG_SYS_FLYCNFG_VAL	0x00000000
 #define	CONFIG_SYS_SXCNFG_VAL	0x00000000
-#define	CONFIG_SYS_MEM_BUF_IMP	0x0f
 
 /*
  * PCMCIA and CF Interfaces

include/configs/vpac270.h +0 -1

index 2fb91a8..e54601d 100644
@@ -297,7 +297,6 @@
 #define	CONFIG_SYS_MDMRS_VAL	0x00000000
 #define	CONFIG_SYS_FLYCNFG_VAL	0x00000000
 #define	CONFIG_SYS_SXCNFG_VAL	0x40044004
-#define	CONFIG_SYS_MEM_BUF_IMP	0x0f
 
 /*
  * PCMCIA and CF Interfaces

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #5 lore raw

PATCH RESEND 4/12 pxa: balloon3: fix comment about sdram banks

In reply to Marcel Ziswiler

Signed-off-by Marcel Ziswiler <[email protected]>

---
 include/configs/balloon3.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

include/configs/balloon3.h +3 -3

index f20a631..e7f0345 100644
@@ -13,7 +13,7 @@
  * High Level Board Configuration Options
  */
 #define	CONFIG_CPU_PXA27X		1	/* Marvell PXA270 CPU */
-#define	CONFIG_BALLOON3		1	/* Balloon3 board */
+#define	CONFIG_BALLOON3			1	/* Balloon3 board */
 
 /*
  * Environment settings

@@ -89,12 +89,12 @@
 /*
  * DRAM Map
  */
-#define	CONFIG_NR_DRAM_BANKS		3		/* 2 banks of DRAM */
+#define	CONFIG_NR_DRAM_BANKS		3		/* 3 banks of DRAM */
 #define	PHYS_SDRAM_1			0xa0000000	/* SDRAM Bank #1 */
 #define	PHYS_SDRAM_1_SIZE		0x08000000	/* 128 MB */
 #define	PHYS_SDRAM_2			0xb0000000	/* SDRAM Bank #2 */
 #define	PHYS_SDRAM_2_SIZE		0x08000000	/* 128 MB */
-#define	PHYS_SDRAM_3			0x80000000	/* SDRAM Bank #2 */
+#define	PHYS_SDRAM_3			0x80000000	/* SDRAM Bank #3 */
 #define	PHYS_SDRAM_3_SIZE		0x08000000	/* 128 MB */
 
 #define	CONFIG_SYS_DRAM_BASE		0xa0000000	/* CS0 */

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #6 lore raw

PATCH RESEND 5/12 pxa: balloon3/colibri_pxa270: fix environment optionally being nowhere

In reply to Marcel Ziswiler

I couldn't quite figure out whether or not CONFIG_SYS_ENV_IS_NOWHERE actually ever worked but nowadays this is called CONFIG_ENV_IS_NOWHERE.

Signed-off-by Marcel Ziswiler <[email protected]>

---
 include/configs/balloon3.h       | 2 +-
 include/configs/colibri_pxa270.h | 2 +-
 include/configs/vpac270.h        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

include/configs/balloon3.h +1 -1

index e7f0345..848a158 100644
@@ -134,7 +134,7 @@
 #define	CONFIG_ENV_IS_IN_FLASH
 #else
 #define	CONFIG_SYS_NO_FLASH
-#define	CONFIG_SYS_ENV_IS_NOWHERE
+#define	CONFIG_ENV_IS_NOWHERE
 #endif
 
 #define	CONFIG_SYS_MONITOR_BASE		0x000000

include/configs/colibri_pxa270.h +1 -1

index 08bd276..b8df89c 100644
@@ -142,7 +142,7 @@
 
 #else	/* No flash */
 #define	CONFIG_SYS_NO_FLASH
-#define	CONFIG_SYS_ENV_IS_NOWHERE
+#define	CONFIG_ENV_IS_NOWHERE
 #endif
 
 #define	CONFIG_SYS_MONITOR_BASE		0x0

include/configs/vpac270.h +1 -1

index e54601d..887433b 100644
@@ -221,7 +221,7 @@
 
 #else	/* No flash */
 #define	CONFIG_SYS_NO_FLASH
-#define	CONFIG_SYS_ENV_IS_NOWHERE
+#define	CONFIG_ENV_IS_NOWHERE
 #endif
 
 /*

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #7 lore raw

PATCH RESEND 6/12 pxa: colibri_pxa270: migrate to generic board

In reply to Marcel Ziswiler

Migrate Toradex Colibri PXA270 to use CONFIG_SYS_GENERIC_BOARD.

Signed-off-by Marcel Ziswiler <[email protected]>

Reviewed-by Simon Glass <[email protected]>

---
 include/configs/colibri_pxa270.h | 2 ++
 1 file changed, 2 insertions(+)

include/configs/colibri_pxa270.h +2 -0

index b8df89c..bb48419 100644
@@ -2,6 +2,7 @@
  * Toradex Colibri PXA270 configuration file
  *
  * Copyright (C) 2010 Marek Vasut <[email protected]>
+ * Copyright (C) 2015 Marcel Ziswiler <[email protected]>
  *
  * SPDX-License-Identifier:	GPL-2.0+
  */

@@ -13,6 +14,7 @@
  * High Level Board Configuration Options
  */
 #define	CONFIG_CPU_PXA27X		1	/* Marvell PXA270 CPU */
+#define CONFIG_SYS_GENERIC_BOARD
 #define	CONFIG_SYS_TEXT_BASE		0x0
 
 /*

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #9 lore raw

PATCH RESEND 7/12 pxa: colibri_pxa270: disable loadb/s commands and long help

In reply to Marcel Ziswiler

To save more than 20 KB of precious space in NOR flash get rid of the following configuration options:

CONFIG_CMD_LOADB
CONFIG_CMD_LOADS
CONFIG_SYS_LONGHELP

Signed-off-by Marcel Ziswiler <[email protected]>

---
 include/configs/colibri_pxa270.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

include/configs/colibri_pxa270.h +3 -1

index bb48419..c2714f7 100644
@@ -52,6 +52,8 @@
  */
 #include <config_cmd_default.h>
 
+#undef CONFIG_CMD_LOADB			/* Both together */
+#undef CONFIG_CMD_LOADS			/* saves 10 KB */
 #define	CONFIG_CMD_NET
 #define	CONFIG_CMD_ENV
 #undef	CONFIG_CMD_IMLS

@@ -84,7 +86,7 @@
  */
 #define	CONFIG_SYS_HUSH_PARSER		1
 
-#define	CONFIG_SYS_LONGHELP
+#undef	CONFIG_SYS_LONGHELP		/* Saves 10 KB */
 #ifdef	CONFIG_SYS_HUSH_PARSER
 #define	CONFIG_SYS_PROMPT		"$ "
 #else

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #10 lore raw

PATCH RESEND 8/12 pxa: colibri_pxa270: avoid overwriting factory configuration block

In reply to Marcel Ziswiler

Specify a CONFIG_BOARD_SIZE_LIMIT of 256 KB in order to avoid overwriting the factory configuration block located at offset 0x40000 in NOR flash.

Signed-off-by Marcel Ziswiler <[email protected]>

---
 include/configs/colibri_pxa270.h | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

include/configs/colibri_pxa270.h +8 -6

index c2714f7..1b1816a 100644
@@ -7,8 +7,8 @@
  * SPDX-License-Identifier:	GPL-2.0+
  */
 
-#ifndef __CONFIG_H
-#define __CONFIG_H
+#ifndef	__CONFIG_H
+#define	__CONFIG_H
 
 /*
  * High Level Board Configuration Options

@@ -16,6 +16,8 @@
 #define	CONFIG_CPU_PXA27X		1	/* Marvell PXA270 CPU */
 #define CONFIG_SYS_GENERIC_BOARD
 #define	CONFIG_SYS_TEXT_BASE		0x0
+/* Avoid overwriting factory configuration block */
+#define CONFIG_BOARD_SIZE_LIMIT		0x40000
 
 /*
  * Environment settings

@@ -100,7 +102,6 @@
 #define	CONFIG_CMDLINE_EDITING		1
 #define	CONFIG_AUTO_COMPLETE		1
 
-
 /*
  * Clock Configuration
  */

@@ -150,10 +151,11 @@
 #endif
 
 #define	CONFIG_SYS_MONITOR_BASE		0x0
-#define	CONFIG_SYS_MONITOR_LEN		0x80000
+#define	CONFIG_SYS_MONITOR_LEN		0x40000
 
+/* Skip factory configuration block */
 #define	CONFIG_ENV_ADDR			\
-			(CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN)
+			(CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN + 0x40000)
 #define	CONFIG_ENV_SIZE			0x40000
 #define	CONFIG_ENV_SECT_SIZE		0x40000
 #define CONFIG_ENV_ADDR_REDUND		(CONFIG_ENV_ADDR + CONFIG_ENV_SECT_SIZE)

@@ -219,4 +221,4 @@
 
 #include "pxa-common.h"
 
-#endif	/* __CONFIG_H */
+#endif /* __CONFIG_H */

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #11 lore raw

PATCH RESEND 9/12 pxa: colibri_pax270: fix CONFIG_BOOTCOMMAND

In reply to Marcel Ziswiler

While 'mmc init' is no longer required the address to bootm the kernel from NOR flash was wrong.

Signed-off-by Marcel Ziswiler <[email protected]>

---
 include/configs/colibri_pxa270.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

include/configs/colibri_pxa270.h +2 -2

index 1b1816a..07426d1 100644
@@ -26,13 +26,13 @@
 #define	CONFIG_SYS_MALLOC_LEN		(128 * 1024)
 #define	CONFIG_ARCH_CPU_INIT
 #define	CONFIG_BOOTCOMMAND						\
-	"if mmc init && fatload mmc 0 0xa0000000 uImage; then "		\
+	"if fatload mmc 0 0xa0000000 uImage; then "			\
 		"bootm 0xa0000000; "					\
 	"fi; "								\
 	"if usb reset && fatload usb 0 0xa0000000 uImage; then "	\
 		"bootm 0xa0000000; "					\
 	"fi; "								\
-	"bootm 0x80000;"
+	"bootm 0xc0000;"
 #define	CONFIG_BOOTARGS			"console=tty0 console=ttyS0,115200"
 #define	CONFIG_TIMESTAMP
 #define	CONFIG_BOOTDELAY		2	/* Autoboot delay */

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #12 lore raw

PATCH RESEND 10/12 pxa: colibri_pxa270: fix wrong comment about voipac ethernet chip

In reply to Marcel Ziswiler

Signed-off-by Marcel Ziswiler <[email protected]>

---
 include/configs/colibri_pxa270.h | 1 -
 1 file changed, 1 deletion(-)

include/configs/colibri_pxa270.h +0 -1

index 07426d1..28e57b5 100644
@@ -65,7 +65,6 @@
 
 /*
  * Networking Configuration
- *  chip on the Voipac PXA270 board
  */
 #ifdef	CONFIG_CMD_NET
 #define	CONFIG_CMD_PING

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #13 lore raw

PATCH RESEND 11/12 pxa: colibri_pxa270: remove CONFIG_ENV_ADDR_REDUND

In reply to Marcel Ziswiler

Usually not required for NOR flash.

Signed-off-by Marcel Ziswiler <[email protected]>

---
 include/configs/colibri_pxa270.h | 2 --
 1 file changed, 2 deletions(-)

include/configs/colibri_pxa270.h +0 -2

index 28e57b5..ed0589a 100644
@@ -157,8 +157,6 @@
 			(CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN + 0x40000)
 #define	CONFIG_ENV_SIZE			0x40000
 #define	CONFIG_ENV_SECT_SIZE		0x40000
-#define CONFIG_ENV_ADDR_REDUND		(CONFIG_ENV_ADDR + CONFIG_ENV_SECT_SIZE)
-#define CONFIG_ENV_SIZE_REDUND		(CONFIG_ENV_SIZE)
 
 /*
  * GPIO settings

Signature · 1 line

1.9.3

Marcel Ziswiler

author

2015-02-28 23:53 UTC #14 lore raw

PATCH RESEND 12/12 pxa: colibri_pxa270: integrate latest validated register settings

In reply to Marcel Ziswiler

Integrate latest validated register settings from Toradex WinCE BSP 4.2 working accross all module versions from early V1.x, V1.2D, V2.2B to V2.4A.

Signed-off-by Marcel Ziswiler <[email protected]>

---
 include/configs/colibri_pxa270.h | 48 ++++++++++++++++++++--------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

include/configs/colibri_pxa270.h +24 ~~-24~~

index ed0589a..7fc364e 100644
@@ -163,7 +163,7 @@
  */
 #define	CONFIG_SYS_GPSR0_VAL	0x00000000
 #define	CONFIG_SYS_GPSR1_VAL	0x00020000
-#define	CONFIG_SYS_GPSR2_VAL	0x0002C000
+#define	CONFIG_SYS_GPSR2_VAL	0x0002c000
 #define	CONFIG_SYS_GPSR3_VAL	0x00000000
 
 #define	CONFIG_SYS_GPCR0_VAL	0x00000000

@@ -171,19 +171,19 @@
 #define	CONFIG_SYS_GPCR2_VAL	0x00000000
 #define	CONFIG_SYS_GPCR3_VAL	0x00000000
 
-#define	CONFIG_SYS_GPDR0_VAL	0x08000000
-#define	CONFIG_SYS_GPDR1_VAL	0x0002A981
-#define	CONFIG_SYS_GPDR2_VAL	0x0202FC00
-#define	CONFIG_SYS_GPDR3_VAL	0x00000000
+#define	CONFIG_SYS_GPDR0_VAL	0xc8008000
+#define	CONFIG_SYS_GPDR1_VAL	0xfc02a981
+#define	CONFIG_SYS_GPDR2_VAL	0x92c3ffff
+#define	CONFIG_SYS_GPDR3_VAL	0x0061e804
 
-#define	CONFIG_SYS_GAFR0_L_VAL	0x00100000
-#define	CONFIG_SYS_GAFR0_U_VAL	0x00C00010
-#define	CONFIG_SYS_GAFR1_L_VAL	0x999A901A
-#define	CONFIG_SYS_GAFR1_U_VAL	0xAAA00008
-#define	CONFIG_SYS_GAFR2_L_VAL	0xAAAAAAAA
-#define	CONFIG_SYS_GAFR2_U_VAL	0x0109A000
-#define	CONFIG_SYS_GAFR3_L_VAL	0x54000300
-#define	CONFIG_SYS_GAFR3_U_VAL	0x00024001
+#define	CONFIG_SYS_GAFR0_L_VAL	0x80100000
+#define	CONFIG_SYS_GAFR0_U_VAL	0xa5c00010
+#define	CONFIG_SYS_GAFR1_L_VAL	0x6992901a
+#define	CONFIG_SYS_GAFR1_U_VAL	0xaaa50008
+#define	CONFIG_SYS_GAFR2_L_VAL	0xaaaaaaaa
+#define	CONFIG_SYS_GAFR2_U_VAL	0x4109a002
+#define	CONFIG_SYS_GAFR3_L_VAL	0x54000310
+#define	CONFIG_SYS_GAFR3_U_VAL	0x00005401
 
 #define	CONFIG_SYS_PSSR_VAL	0x30

@@ -196,24 +196,24 @@
 /*
  * Memory settings
  */
-#define	CONFIG_SYS_MSC0_VAL	0x000095f2
-#define	CONFIG_SYS_MSC1_VAL	0x00007ff4
-#define	CONFIG_SYS_MSC2_VAL	0x00000000
-#define	CONFIG_SYS_MDCNFG_VAL	0x08000ac9
-#define	CONFIG_SYS_MDREFR_VAL	0x2013e01e
-#define	CONFIG_SYS_MDMRS_VAL	0x00320032
-#define	CONFIG_SYS_FLYCNFG_VAL	0x00000000
+#define	CONFIG_SYS_MSC0_VAL	0x9ee1c5f2
+#define	CONFIG_SYS_MSC1_VAL	0x9ee1f994
+#define	CONFIG_SYS_MSC2_VAL	0x9ee19ee1
+#define	CONFIG_SYS_MDCNFG_VAL	0x090009c9
+#define	CONFIG_SYS_MDREFR_VAL	0x2003a031
+#define	CONFIG_SYS_MDMRS_VAL	0x00220022
+#define	CONFIG_SYS_FLYCNFG_VAL	0x00010001
 #define	CONFIG_SYS_SXCNFG_VAL	0x40044004
 
 /*
  * PCMCIA and CF Interfaces
  */
-#define	CONFIG_SYS_MECR_VAL	0x00000001
-#define	CONFIG_SYS_MCMEM0_VAL	0x00014307
+#define	CONFIG_SYS_MECR_VAL	0x00000000
+#define	CONFIG_SYS_MCMEM0_VAL	0x00028307
 #define	CONFIG_SYS_MCMEM1_VAL	0x00014307
-#define	CONFIG_SYS_MCATT0_VAL	0x0001c787
+#define	CONFIG_SYS_MCATT0_VAL	0x00038787
 #define	CONFIG_SYS_MCATT1_VAL	0x0001c787
-#define	CONFIG_SYS_MCIO0_VAL	0x0001430f
+#define	CONFIG_SYS_MCIO0_VAL	0x0002830f
 #define	CONFIG_SYS_MCIO1_VAL	0x0001430f
 
 #include "pxa-common.h"

Signature · 1 line

1.9.3

Marek Vasut

Applied

2015-03-02 10:01 UTC #15 lore raw

cover various fixes mainly for pxa and colibri_pxa270

In reply to Marcel Ziswiler

Quoted 7 lines · Marcel Ziswiler

The following is a set of various fixes mainly for PXA and the Toradex Colibri PXA270 introducing it to generic board to save it from becoming obsolete as those modules are still on sale for another 3 to 4 years.
If I again do not get any feedback from Marek the current PXA CPU and Colibri PXA270 board maintainer may I ask Tom for help in getting this resolved?

Uh, sorry about that. Next time, please just poke me in case you don't get reply in a reasonable amount of time.

Applied all, thanks!

Best regards,
Marek Vasut

Marcel Ziswiler

author

2015-03-02 12:15 UTC #16 lore raw

cover various fixes mainly for pxa and colibri_pxa270

Quoted 4 lines · Marek Vasut

Uh, sorry about that. Next time, please just poke me in case you don't get reply in a reasonable amount of time.
Applied all, thanks!

No problem, I guess that's what RESENDs are for (;-p). Maybe it also had to do with me initially using your gmail rather than denx email address.

BTW: I noticed PXA3xx support having been removed a while back which is kind of sad considering our still shipping Colibri PXA3xx product line. Do you know whether there are any plans to ever revive any of that? I did notice that in Linux there is lately a push to migrating the PXAs to using device-tree as well wondering what boot loader those folks are using.

Marek Vasut

2015-03-02 12:30 UTC #17 lore raw

cover various fixes mainly for pxa and colibri_pxa270

Quoted 5 lines · Marcel Ziswiler

Quoted 4 lines · Marek Vasut
Uh, sorry about that. Next time, please just poke me in case you don't get reply in a reasonable amount of time.
Applied all, thanks!

Hi!

Quoted 2 lines

No problem, I guess that's what RESENDs are for (;-p). Maybe it also had to do with me initially using your gmail rather than denx email address.

Oh. You could have just sent an reply to the previous patches, no need to explicitly repost them :)

Quoted 3 lines

BTW: I noticed PXA3xx support having been removed a while back which is kind of sad considering our still shipping Colibri PXA3xx product line. Do you know whether there are any plans to ever revive any of that?

Yeah, I have a whole collection of those PXA3xx Colibris myself. I don't plan to dig in the PXA3xx support though. In case you want to revive it, please feel free to submit patches. I might also be able to give you some pointers on how to implement the support, so feel free to ask.

Quoted 3 lines

I did notice that in Linux there is lately a push to migrating the PXAs to using device-tree as well wondering what boot loader those folks are using.

Possibly an old version of U-Boot, which was hacked to support PXA3xx, the one from openpxa ?

Best regards,
Marek Vasut