Improve code, codestyle in usb_ops_linux.c
cover Improve code, codestyle in usb_ops_linux.c
This patchset improves the code in usb_ops_linux by removing the use of a variable, adds a blank line after declarations to improve code readability.
Navya Sri Nizamkari (2):
staging: rtl8188eu: Compress two statements into one.
staging: rtl8188eu: Add blank line after declarations
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)
Signature · 1 line
1.9.1
PATCH 1/2 staging: rtl8188eu: Compress two statements into one.
This patch removes the use of a variable used only for returning a value. The following coccinelle script was used to discover it:
@@
expression ret;
identifier f;
@@
-ret =
+return
f(...);
-return ret;--- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c +3 -9
@@ -552,7 +552,6 @@ int usb_write8(struct adapter *adapter, u32 addr, u8 val)u16 index;u16 len;u8 data; -int ret; request =0x05 ; requesttype =0x00 ;/* write_out */
@@ -560,8 +559,7 @@ int usb_write8(struct adapter *adapter, u32 addr, u8 val) wvalue = (u16)(addr&0x0000ffff ); len =1 ; data = val; - ret =usbctrl_vendorreq (adapter, request, wvalue, index, &data, len, requesttype); -return ret; +return usbctrl_vendorreq (adapter, request, wvalue, index, &data, len, requesttype); }int usb_write16 (struct adapter *adapter,u32 addr,u16 val)
@@ -572,7 +570,6 @@ int usb_write16(struct adapter *adapter, u32 addr, u16 val)u16 index;u16 len;__le32 data; -int ret; request =0x05 ;
@@ -584,10 +581,9 @@ int usb_write16(struct adapter *adapter, u32 addr, u16 val) data =cpu_to_le32 (val &0x0000ffff ); - ret =usbctrl_vendorreq (adapter, request, wvalue, index, &data, len, requesttype); +return usbctrl_vendorreq (adapter, request, wvalue, index, &data, len, requesttype); -return ret; }int usb_write32 (struct adapter *adapter,u32 addr,u32 val)
@@ -598,7 +594,6 @@ int usb_write32(struct adapter *adapter, u32 addr, u32 val)u16 index;u16 len;__le32 data; -int ret; request =0x05 ;
@@ -609,10 +604,9 @@ int usb_write32(struct adapter *adapter, u32 addr, u32 val) len =4 ; data =cpu_to_le32 (val); - ret =usbctrl_vendorreq (adapter, request, wvalue, index, &data, len, requesttype); +return usbctrl_vendorreq (adapter, request, wvalue, index, &data, len, requesttype); -return ret; }static void usb_write_port_complete (struct urb *purb,struct pt_regs *regs)
Signature · 1 line
1.9.1
PATCH 2/2 staging: rtl8188eu: Add blank line after declarations
In reply to Navya Sri NizamkariThis patch removes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations
--- drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c +1 -0
@@ -530,6 +530,7 @@ void usb_read_port_cancel(struct adapter *padapter) {int i;struct recv_buf *precvbuf; + precvbuf = (struct recv_buf *)padapter->recvpriv.precv_buf;DBG_88E ("%s\n" , __func__);
Signature · 1 line
1.9.1
Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8188eu: Compress two statements into one.
In reply to Navya Sri Nizamkaridrivers/staging/rtl8188eu/os_dep/usb_ops_linux.c int usb_write8(struct adapter *adapter, u32 addr, u8 val) · line 562
Quoted 3 lines
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c +1
-2- ret =usbctrl_vendorreq (adapter, request, wvalue, index, &data, len, requesttype); -return ret; +return usbctrl_vendorreq (adapter, request, wvalue, index, &data, len, requesttype);
Consider fixing the 80 character problem at the same time.
julia