Skip to contentSkip to conversation

staging: remove break after return

PATCH New Supriya Karanth 1 participant 4 messages Mar 13, 2015 Staging

lore
Share & tools
lore
#0 lore raw

cover staging: remove break after return

This patchset removes the "break" statement after a "return" statement as it will not get executed.

Found by checkpatch.pl - break is not useful after a goto or return

Supriya Karanth (3):
staging: rtl8188eu: remove break after return
staging: rtl8192e: remove break after return
staging: rtl8192u: remove break after return

 drivers/staging/rtl8188eu/hal/pwrseqcmd.c              | 1 -
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c         | 1 -
 drivers/staging/rtl8192e/rtllib_softmac.c              | 1 -
 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 1 -
 4 files changed, 4 deletions(-)
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/3 staging: rtl8188eu: remove break after return

Remove "break" statement after a "return" statement as it does not get executed.

Found by checkpatch.pl - break is not useful after a goto or return

---
 drivers/staging/rtl8188eu/hal/pwrseqcmd.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8188eu/hal/pwrseqcmd.c +0 -1
index be0663e..73e1f8b 100644
@@ -109,7 +109,6 @@ u8 rtl88eu_pwrseqcmdparsing(struct adapter *padapter, u8 cut_vers, u8 fab_vers,
 				RT_TRACE(_module_hal_init_c_, _drv_info_,
 					 ("rtl88eu_pwrseqcmdparsing: PWR_CMD_END\n"));
 				return true;
-				break;
 			default:
 				RT_TRACE(_module_hal_init_c_, _drv_err_,
 					 ("rtl88eu_pwrseqcmdparsing: Unknown CMD!!\n"));
Signature · 1 line
2.1.0
#2 lore raw

PATCH 2/3 staging: rtl8192e: remove break after return

In reply to Supriya Karanth

Remove "break" statement after a "return" statement as it does not get executed.

Found by checkpatch.pl - break is not useful after a goto or return

---
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 1 -
 drivers/staging/rtl8192e/rtllib_softmac.c      | 1 -
 2 files changed, 2 deletions(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +0 -1
index cd3c662..a369a1f 100644
@@ -920,7 +920,6 @@ static u8 rtl8192_phy_SwChnlStepByStep(struct net_device *dev, u8 channel,
 			RT_TRACE(COMP_ERR, "Unknown RFChipID: %d\n",
 				 priv->rf_chip);
 			return false;
-			break;
 		}
 
 
drivers/staging/rtl8192e/rtllib_softmac.c +0 -1
index 16aef7c..2e730b5 100644
@@ -2450,7 +2450,6 @@ inline int rtllib_rx_frame_softmac(struct rtllib_device *ieee,
 		break;
 	default:
 		return -1;
-		break;
 	}
 	return 0;
 }
Signature · 1 line
2.1.0
#3 lore raw

PATCH 3/3 staging: rtl8192u: remove break after return

In reply to Supriya Karanth

Remove "break" statement after a "return" statement as it does not get executed.

Found by checkpatch.pl - break is not useful after a goto or return

---
 drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c +0 -1
index 878086a..5106b60 100644
@@ -2110,7 +2110,6 @@ ieee80211_rx_frame_softmac(struct ieee80211_device *ieee, struct sk_buff *skb,
 		break;
 	default:
 		return -1;
-		break;
 	}
 
 	//dev_kfree_skb_any(skb);
Signature · 1 line
2.1.0