Skip to contentSkip to conversation

staging: lustre: Fix checkpatch.pl warnings.

PATCH New Alberto Pires de Oliveira Neto 1 participant 4 messages Mar 17, 2015 Staging

lore
Share & tools
lore
#0 lore raw

v2 cover staging: lustre: Fix checkpatch.pl warnings.

Changes since v1:
- Put '}' in the next line instead of just insert a space for lproc_fld.c.

Alberto Pires de Oliveira Neto (3):
staging: lustre: space prohibited between function name and open parenthesis '('
staging: lustre: void function return statements are not generally useful.
staging: lustre: space required after that close brace '}'

 drivers/staging/lustre/lustre/fld/fld_internal.h | 2 +-
 drivers/staging/lustre/lustre/fld/fld_request.c  | 1 -
 drivers/staging/lustre/lustre/fld/lproc_fld.c    | 3 ++-
 3 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
1.9.1
#3 lore raw

PATCH v2 3/3 staging: lustre: space required after that close brace '}'

This patch fixes checkpatch.pl warning.
WARNING: space required after that close brace '}'

---
 drivers/staging/lustre/lustre/fld/lproc_fld.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/lustre/lustre/fld/lproc_fld.c +2 -1
index 8c5a657..f53fdcf 100644
@@ -168,4 +168,5 @@ struct lprocfs_vars fld_client_proc_list[] = {
 	{ "targets", &fld_proc_targets_fops },
 	{ "hash", &fld_proc_hash_fops },
 	{ "cache_flush", &fld_proc_cache_flush_fops },
-	{ NULL }};
+	{ NULL }
+};
Signature · 1 line
1.9.1
#2 lore raw

PATCH v2 2/3 staging: lustre: void function return statements are not generally useful.

In reply to Alberto Pires de Oliveira Neto

This patch fixes checkpatch.pl warning.
WARNING: void function return statements are not generally useful

---
 drivers/staging/lustre/lustre/fld/fld_request.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/lustre/lustre/fld/fld_request.c +0 -1
index 22e0d94..6ac225e 100644
@@ -326,7 +326,6 @@ static int fld_client_proc_init(struct lu_client_fld *fld)
 
 void fld_client_proc_fini(struct lu_client_fld *fld)
 {
-	return;
 }
 #endif
 EXPORT_SYMBOL(fld_client_proc_fini);
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/3 staging: lustre: space prohibited between function name and open parenthesis '('

In reply to Alberto Pires de Oliveira Neto

This patch fixes checkpatch.pl warning.
WARNING: space prohibited between function name and open parenthesis '('

---
 drivers/staging/lustre/lustre/fld/fld_internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/fld/fld_internal.h +1 -1
index 6125bbe..68bec765 100644
@@ -142,7 +142,7 @@ extern struct lu_fld_hash fld_hash[];
 int fld_client_rpc(struct obd_export *exp,
 		   struct lu_seq_range *range, __u32 fld_op);
 
-#if defined (CONFIG_PROC_FS)
+#if defined(CONFIG_PROC_FS)
 extern struct lprocfs_vars fld_client_proc_list[];
 #endif
 
Signature · 1 line
1.9.1