Skip to contentSkip to conversation

meta: 3 fixes

PATCH In review Robert Yang 4 participants 13 messages Apr 1, 2015 – Apr 4, 2015

lore
Share & tools
lore

Robert Yang

author
#0 lore raw

cover meta: 3 fixes

The following changes since commit e6aab245623b6ba1ca5f06632d1028c863cef737:

image_types: Add missing ext4 support (2015-03-31 22:38:50 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/3fixes
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/3fixes

Robert Yang (3):
piglit: add PACKAGECONFIG for freeglut
db: fix parallel issue
glibc: fix a tpo

 .../glibc/glibc/elf-Makefile-fix-a-typo.patch      |   36 ++++++++++++++++++++
 meta/recipes-core/glibc/glibc_2.21.bb              |    1 +
 meta/recipes-graphics/piglit/piglit_git.bb         |    3 ++
 ...akefile-let-libso_target-depend-on-bt_rec.patch |   30 ++++++++++++++++
 meta/recipes-support/db/db_6.0.30.bb               |    1 +
 5 files changed, 71 insertions(+)
 create mode 100644 meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch
 create mode 100644 meta/recipes-support/db/db/Makefile-let-libso_target-depend-on-bt_rec.patch
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/3 piglit: add PACKAGECONFIG for freeglut

Signed-off-by Robert Yang <[email protected]>
---
 meta/recipes-graphics/piglit/piglit_git.bb |    3 +++
 1 file changed, 3 insertions(+)
meta/recipes-graphics/piglit/piglit_git.bb +3 -0
index 68ac7e7..e33e4a7 100644
@@ -21,6 +21,9 @@ REQUIRED_DISTRO_FEATURES = "x11"
 # contents out of $S and $B.
 B="${S}"
 
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[freeglut] = "-DPIGLIT_USE_GLUT=1,-DPIGLIT_USE_GLUT=0,freeglut,"
+
 # CMake sets the rpath at build time with the source tree, and will reset it at
 # install time. As we don't install this doesn't happen, so force the rpath to
 # what we need.
Signature · 1 line
1.7.9.5
#2 lore raw

Re: [PATCH 1/3] piglit: add PACKAGECONFIG for freeglut

meta/recipes-graphics/piglit/piglit_git.bb REQUIRED_DISTRO_FEATURES = "x11"

Quoted 10 lines · Robert Yang
Signed-off-by Robert Yang <[email protected]>
---
 meta/recipes-graphics/piglit/piglit_git.bb |    3 +++
 1 file changed, 3 insertions(+)
meta/recipes-graphics/piglit/piglit_git.bb +0 -0
index 68ac7e7..e33e4a7 100644
@@ -21,6 +21,9 @@ REQUIRED_DISTRO_FEATURES = "x11"

Does this change resolve:
REQUIRED_DISTRO_FEATURES = "x11"
?

If yes, then you should remove it.

Quoted 17 lines
meta/recipes-graphics/piglit/piglit_git.bb +3 -0
 # contents out of $S and $B.
 B="${S}"
 
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[freeglut] = "-DPIGLIT_USE_GLUT=1,-DPIGLIT_USE_GLUT=0,freeglut,"
+
 # CMake sets the rpath at build time with the source tree, and will reset it at
 # install time. As we don't install this doesn't happen, so force the rpath to
 # what we need.
Signature · 7 lines
1.7.9.5

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
author
#3 lore raw

Re: [PATCH 1/3] piglit: add PACKAGECONFIG for freeglut

Quoted 16 lines · Martin Jansa

meta/recipes-graphics/piglit/piglit_git.bb REQUIRED_DISTRO_FEATURES = "x11"

Quoted 10 lines · Robert Yang
Signed-off-by Robert Yang <[email protected]>
---
  meta/recipes-graphics/piglit/piglit_git.bb |    3 +++
  1 file changed, 3 insertions(+)
meta/recipes-graphics/piglit/piglit_git.bb +0 -0
index 68ac7e7..e33e4a7 100644
@@ -21,6 +21,9 @@ REQUIRED_DISTRO_FEATURES = "x11"

Does this change resolve:
REQUIRED_DISTRO_FEATURES = "x11"
?

Quoted 1 line

If yes, then you should remove it.

I'm afraid not since it depends on virtual/libx11.

// Robert

Quoted 19 lines
Quoted 18 lines
meta/recipes-graphics/piglit/piglit_git.bb +3 -1
  # contents out of $S and $B.
  B="${S}"
 
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[freeglut] = "-DPIGLIT_USE_GLUT=1,-DPIGLIT_USE_GLUT=0,freeglut,"
+
  # CMake sets the rpath at build time with the source tree, and will reset it at
  # install time. As we don't install this doesn't happen, so force the rpath to
  # what we need.
--

1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw

Re: [PATCH 1/3] piglit: add PACKAGECONFIG for freeglut

Quoted 2 lines · Robert Yang

I'm afraid not since it depends on virtual/libx11.

So what's gained by disabling freeglut? Shouldn't we be enabling it if possible?

Ross

author
#5 lore raw

Re: [PATCH 1/3] piglit: add PACKAGECONFIG for freeglut

Quoted 8 lines · Ross

On 2 April 2015 at 04:24, Robert Yang <[email protected] <mailto:[email protected]>> wrote:

I'm afraid not since it depends on virtual/libx11.

So what's gained by disabling freeglut? Shouldn't we be enabling it if possible?

There is no freeglut in oe-core, so I think that we need disable it by default.

// Robert

Quoted 2 lines

Ross

author
#6 lore raw

PATCH 2/3 db: fix parallel issue

In reply to Robert Yang

Fixed parallel issue:
libtool: link: `bt_rec.lo' is not a valid libtool object Makefile:867: recipe for target 'libdb-6.0.la' failed
make: *** [libdb-6.0.la] Error 1

Signed-off-by Robert Yang <[email protected]>
---
 ...akefile-let-libso_target-depend-on-bt_rec.patch |   30 ++++++++++++++++++++
 meta/recipes-support/db/db_6.0.30.bb               |    1 +
 2 files changed, 31 insertions(+)
 create mode 100644 meta/recipes-support/db/db/Makefile-let-libso_target-depend-on-bt_rec.patch
meta/recipes-support/db/db/Makefile-let-libso_target-depend-on-bt_rec.patch new file +30 -0
new file mode 100644
index 0000000..329bff5
@@ -0,0 +1,30 @@
+From c640ff9340f358a00835816d0fea03d27a7be978 Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Tue, 31 Mar 2015 00:56:44 -0700
+Subject: [PATCH] Makefile: let libso_target depend on bt_rec
+
+Fixed parallel issue:
+libtool: link: `bt_rec.lo' is not a valid libtool object
+Makefile:867: recipe for target 'libdb-6.0.la' failed
+make: *** [libdb-6.0.la] Error 1
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ Makefile.in |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.in b/Makefile.in
+index e451f70..0a42375 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -863,7 +863,7 @@ $(libdb_version): $(C_OBJS)
+ 	$(LN) -s $(libdb_version) $(libdb)
+ 
+ # Shared C library.
+-$(libso_target): $(C_OBJS)
++$(libso_target): $(C_OBJS) bt_rec@o@
+ 	$(SOLINK) $(SOFLAGS) $(LDFLAGS) -o $@ $(C_OBJS) \
+ 		$(LIBCSO_LIBS)
+ 	$(RM) $(libdb)
meta/recipes-support/db/db_6.0.30.bb +1 -0
index 47fb296..9eae5c7 100644
@@ -18,6 +18,7 @@ RCONFLICTS_${PN} = "db3"
 SRC_URI = "http://download.oracle.com/berkeley-db/db-${PV}.tar.gz"
 SRC_URI += "file://arm-thumb-mutex_db5.patch;patchdir=.. \
             file://fix-parallel-build.patch \
+            file://Makefile-let-libso_target-depend-on-bt_rec.patch \
            "
 
 SRC_URI[md5sum] = "ad28eb86ad3203b5422844db179c585b"
Signature · 1 line
1.7.9.5
author
#7 lore raw

PATCH 3/3 glibc: fix a tpo

In reply to Robert Yang

Fixed a typo:
name-target-directory -> make-target-directory

There is no name-target-directory, it should be make-target-directory, this fixed the error:
/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed

Signed-off-by Robert Yang <[email protected]>
---
 .../glibc/glibc/elf-Makefile-fix-a-typo.patch      |   36 ++++++++++++++++++++
 meta/recipes-core/glibc/glibc_2.21.bb              |    1 +
 2 files changed, 37 insertions(+)
 create mode 100644 meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch
meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch new file +36 -0
new file mode 100644
index 0000000..ec48006
@@ -0,0 +1,36 @@
+From 6207fb45553ee98f2f326883b7c21b76c8267343 Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Tue, 31 Mar 2015 02:31:25 -0700
+Subject: [PATCH] elf/Makefile: fix a typo
+
+Fixed a typo:
+name-target-directory -> make-target-directory
+
+There is no name-target-directory, it should be make-target-directory,
+this fixed the error:
+/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory
+Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ elf/Makefile |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/elf/Makefile b/elf/Makefile
+index e5b142c..62fe245 100644
+--- a/elf/Makefile
++++ b/elf/Makefile
+@@ -358,7 +358,7 @@ $(objpfx)interp.os: $(elf-objpfx)runtime-linker.h
+ 
+ $(elf-objpfx)runtime-linker.h: $(elf-objpfx)runtime-linker.st; @:
+ $(elf-objpfx)runtime-linker.st: $(common-objpfx)config.make
+-	$(name-target-directory)
++	$(make-target-directory)
+ 	echo '#define RUNTIME_LINKER "$(rtlddir)/$(rtld-installed-name)"' \
+ 		> ${@:st=T}
+ 	$(move-if-change) ${@:st=T} ${@:st=h}
+-- 
+1.7.9.5
+
meta/recipes-core/glibc/glibc_2.21.bb +1 -0
index 91feff5..fcef4ff 100644
@@ -25,6 +25,7 @@ SRC_URI = "git://sourceware.org/git/glibc.git;branch=${BRANCH} \
            file://0001-Add-unused-attribute.patch \
            file://0001-When-disabling-SSE-also-make-sure-that-fpmath-is-not.patch \
            file://0001-yes-within-the-path-sets-wrong-config-variables.patch \
+           file://elf-Makefile-fix-a-typo.patch \
            ${EGLIBCPATCHES} \
           "
 EGLIBCPATCHES = "\
Signature · 1 line
1.7.9.5
#8 lore raw

Re: [PATCH 3/3] glibc: fix a tpo

Quoted 2 lines · Robert Yang

Fixed a typo:
name-target-directory -> make-target-directory

You have another typo in commit message.

Quoted 74 lines

There is no name-target-directory, it should be make-target-directory, this fixed the error:
/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed

Signed-off-by Robert Yang <[email protected]>
---
 .../glibc/glibc/elf-Makefile-fix-a-typo.patch      |   36 ++++++++++++++++++++
 meta/recipes-core/glibc/glibc_2.21.bb              |    1 +
 2 files changed, 37 insertions(+)
 create mode 100644 meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch
meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch new file +36 -0
new file mode 100644
index 0000000..ec48006
@@ -0,0 +1,36 @@
+From 6207fb45553ee98f2f326883b7c21b76c8267343 Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Tue, 31 Mar 2015 02:31:25 -0700
+Subject: [PATCH] elf/Makefile: fix a typo
+
+Fixed a typo:
+name-target-directory -> make-target-directory
+
+There is no name-target-directory, it should be make-target-directory,
+this fixed the error:
+/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory
+Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ elf/Makefile |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/elf/Makefile b/elf/Makefile
+index e5b142c..62fe245 100644
+--- a/elf/Makefile
++++ b/elf/Makefile
+@@ -358,7 +358,7 @@ $(objpfx)interp.os: $(elf-objpfx)runtime-linker.h
+ 
+ $(elf-objpfx)runtime-linker.h: $(elf-objpfx)runtime-linker.st; @:
+ $(elf-objpfx)runtime-linker.st: $(common-objpfx)config.make
+-	$(name-target-directory)
++	$(make-target-directory)
+ 	echo '#define RUNTIME_LINKER "$(rtlddir)/$(rtld-installed-name)"' \
+ 		> ${@:st=T}
+ 	$(move-if-change) ${@:st=T} ${@:st=h}
+-- 
+1.7.9.5
+
meta/recipes-core/glibc/glibc_2.21.bb +1 -0
index 91feff5..fcef4ff 100644
@@ -25,6 +25,7 @@ SRC_URI = "git://sourceware.org/git/glibc.git;branch=${BRANCH} \
            file://0001-Add-unused-attribute.patch \
            file://0001-When-disabling-SSE-also-make-sure-that-fpmath-is-not.patch \
            file://0001-yes-within-the-path-sets-wrong-config-variables.patch \
+           file://elf-Makefile-fix-a-typo.patch \
            ${EGLIBCPATCHES} \
           "
 EGLIBCPATCHES = "\
Signature · 7 lines
1.7.9.5

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
author
#9 lore raw

Re: [PATCH 3/3] glibc: fix a tpo

Quoted 5 lines · Martin Jansa
Quoted 2 lines · Robert Yang

Fixed a typo:
name-target-directory -> make-target-directory

You have another typo in commit message.

Sorry, I checked again, which typo, please ?

// Robert

Quoted 76 lines
Quoted 75 lines

There is no name-target-directory, it should be make-target-directory, this fixed the error:
/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed

Signed-off-by Robert Yang <[email protected]>
---
  .../glibc/glibc/elf-Makefile-fix-a-typo.patch      |   36 ++++++++++++++++++++
  meta/recipes-core/glibc/glibc_2.21.bb              |    1 +
  2 files changed, 37 insertions(+)

create mode 100644 meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch

meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch new file +36 -0
new file mode 100644
index 0000000..ec48006
@@ -0,0 +1,36 @@
+From 6207fb45553ee98f2f326883b7c21b76c8267343 Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Tue, 31 Mar 2015 02:31:25 -0700
+Subject: [PATCH] elf/Makefile: fix a typo
+
+Fixed a typo:
+name-target-directory -> make-target-directory
+
+There is no name-target-directory, it should be make-target-directory,
+this fixed the error:
+/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory
+Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ elf/Makefile |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/elf/Makefile b/elf/Makefile
+index e5b142c..62fe245 100644
+--- a/elf/Makefile
++++ b/elf/Makefile
+@@ -358,7 +358,7 @@ $(objpfx)interp.os: $(elf-objpfx)runtime-linker.h
+
+ $(elf-objpfx)runtime-linker.h: $(elf-objpfx)runtime-linker.st; @:
+ $(elf-objpfx)runtime-linker.st: $(common-objpfx)config.make
+-	$(name-target-directory)
++	$(make-target-directory)
+ 	echo '#define RUNTIME_LINKER "$(rtlddir)/$(rtld-installed-name)"' \
+ 		> ${@:st=T}
+ 	$(move-if-change) ${@:st=T} ${@:st=h}
+--
+1.7.9.5
+
meta/recipes-core/glibc/glibc_2.21.bb +1 -1
index 91feff5..fcef4ff 100644
@@ -25,6 +25,7 @@ SRC_URI = "git://sourceware.org/git/glibc.git;branch=${BRANCH} \
             file://0001-Add-unused-attribute.patch \
             file://0001-When-disabling-SSE-also-make-sure-that-fpmath-is-not.patch \
             file://0001-yes-within-the-path-sets-wrong-config-variables.patch \
+           file://elf-Makefile-fix-a-typo.patch \
             ${EGLIBCPATCHES} \
            "
  EGLIBCPATCHES = "\
--

1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#10 lore raw

Re: [PATCH 3/3] glibc: fix a tpo

Quoted 10 lines · Robert Yang
Quoted 5 lines · Martin Jansa
Quoted 2 lines · Robert Yang

Fixed a typo:
name-target-directory -> make-target-directory

You have another typo in commit message.

Sorry, I checked again, which typo, please ?

"fix a TPO"

Quoted 78 lines

// Robert

Quoted 76 lines
Quoted 75 lines

There is no name-target-directory, it should be make-target-directory, this fixed the error:
/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed

Signed-off-by Robert Yang <[email protected]>
---
  .../glibc/glibc/elf-Makefile-fix-a-typo.patch      |   36 ++++++++++++++++++++
  meta/recipes-core/glibc/glibc_2.21.bb              |    1 +
  2 files changed, 37 insertions(+)

create mode 100644 meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch

meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch new file +36 -0
new file mode 100644
index 0000000..ec48006
@@ -0,0 +1,36 @@
+From 6207fb45553ee98f2f326883b7c21b76c8267343 Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Tue, 31 Mar 2015 02:31:25 -0700
+Subject: [PATCH] elf/Makefile: fix a typo
+
+Fixed a typo:
+name-target-directory -> make-target-directory
+
+There is no name-target-directory, it should be make-target-directory,
+this fixed the error:
+/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory
+Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ elf/Makefile |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/elf/Makefile b/elf/Makefile
+index e5b142c..62fe245 100644
+--- a/elf/Makefile
++++ b/elf/Makefile
+@@ -358,7 +358,7 @@ $(objpfx)interp.os: $(elf-objpfx)runtime-linker.h
+
+ $(elf-objpfx)runtime-linker.h: $(elf-objpfx)runtime-linker.st; @:
+ $(elf-objpfx)runtime-linker.st: $(common-objpfx)config.make
+-	$(name-target-directory)
++	$(make-target-directory)
+ 	echo '#define RUNTIME_LINKER "$(rtlddir)/$(rtld-installed-name)"' \
+ 		> ${@:st=T}
+ 	$(move-if-change) ${@:st=T} ${@:st=h}
+--
+1.7.9.5
+
meta/recipes-core/glibc/glibc_2.21.bb +1 -1
index 91feff5..fcef4ff 100644
@@ -25,6 +25,7 @@ SRC_URI = "git://sourceware.org/git/glibc.git;branch=${BRANCH} \
             file://0001-Add-unused-attribute.patch \
             file://0001-When-disabling-SSE-also-make-sure-that-fpmath-is-not.patch \
             file://0001-yes-within-the-path-sets-wrong-config-variables.patch \
+           file://elf-Makefile-fix-a-typo.patch \
             ${EGLIBCPATCHES} \
            "
  EGLIBCPATCHES = "\
--

1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
author
#11 lore raw

Re: [PATCH 3/3] glibc: fix a tpo

Quoted 5 lines · Martin Jansa
Quoted 4 lines · Robert Yang
Quoted 1 line · Martin Jansa

On Wed, Apr 01, 2015 at 12:53:02AM -0700, Robert Yang wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Fixed a typo:
name-target-directory -> make-target-directory

You have another typo in commit message.

Sorry, I checked again, which typo, please ?

"fix a TPO"

Ah, yes, thanks, I updated it in the repo.

git://git.openembedded.org/openembedded-core-contrib rbt/3fixes

// Robert

Quoted 80 lines
Quoted 79 lines

// Robert

Quoted 76 lines
Quoted 75 lines

There is no name-target-directory, it should be make-target-directory, this fixed the error:
/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed

Signed-off-by Robert Yang <[email protected]>
---
   .../glibc/glibc/elf-Makefile-fix-a-typo.patch      |   36 ++++++++++++++++++++
   meta/recipes-core/glibc/glibc_2.21.bb              |    1 +
   2 files changed, 37 insertions(+)

create mode 100644 meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch

meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch new file +36 -0
new file mode 100644
index 0000000..ec48006
@@ -0,0 +1,36 @@
+From 6207fb45553ee98f2f326883b7c21b76c8267343 Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Tue, 31 Mar 2015 02:31:25 -0700
+Subject: [PATCH] elf/Makefile: fix a typo
+
+Fixed a typo:
+name-target-directory -> make-target-directory
+
+There is no name-target-directory, it should be make-target-directory,
+this fixed the error:
+/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory
+Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed
+
+Upstream-Status: Pending
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ elf/Makefile |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/elf/Makefile b/elf/Makefile
+index e5b142c..62fe245 100644
+--- a/elf/Makefile
++++ b/elf/Makefile
+@@ -358,7 +358,7 @@ $(objpfx)interp.os: $(elf-objpfx)runtime-linker.h
+
+ $(elf-objpfx)runtime-linker.h: $(elf-objpfx)runtime-linker.st; @:
+ $(elf-objpfx)runtime-linker.st: $(common-objpfx)config.make
+-	$(name-target-directory)
++	$(make-target-directory)
+ 	echo '#define RUNTIME_LINKER "$(rtlddir)/$(rtld-installed-name)"' \
+ 		> ${@:st=T}
+ 	$(move-if-change) ${@:st=T} ${@:st=h}
+--
+1.7.9.5
+
meta/recipes-core/glibc/glibc_2.21.bb +1 -1
index 91feff5..fcef4ff 100644
@@ -25,6 +25,7 @@ SRC_URI = "git://sourceware.org/git/glibc.git;branch=${BRANCH} \
              file://0001-Add-unused-attribute.patch \
              file://0001-When-disabling-SSE-also-make-sure-that-fpmath-is-not.patch \
              file://0001-yes-within-the-path-sets-wrong-config-variables.patch \
+           file://elf-Makefile-fix-a-typo.patch \
              ${EGLIBCPATCHES} \
             "
   EGLIBCPATCHES = "\
--

1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#12 lore raw

Re: [PATCH 3/3] glibc: fix a tpo

In reply to Robert Yang
Quoted 28 lines · Robert Yang

Fixed a typo:
name-target-directory -> make-target-directory

There is no name-target-directory, it should be make-target-directory, this fixed the error:
/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed

Signed-off-by Robert Yang <[email protected]>

---
.../glibc/glibc/elf-Makefile-fix-a-typo.patch | 36 ++++++++++++++++++++
meta/recipes-core/glibc/glibc_2.21.bb | 1 +

2 files changed, 37 insertions(+)

create mode 100644 meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch

meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch new file +4 -0
new file mode 100644
index 0000000..ec48006
@@ -0,0 +1,36 @@
+From 6207fb45553ee98f2f326883b7c21b76c8267343 Mon Sep 17 00:00:00 2001
+From: Robert Yang <[email protected]>
+Date: Tue, 31 Mar 2015 02:31:25 -0700
+Subject: [PATCH] elf/Makefile: fix a typo

meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch line 14

Quoted 10 lines
meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch new file +10 -0
+
+Fixed a typo:
+name-target-directory -> make-target-directory
+
+There is no name-target-directory, it should be make-target-directory,
+this fixed the error:
+/bin/bash: /path/to/elf/runtime-linker.T: No such file or directory
+Makefile:361: recipe for target '/path/to/elf/runtime-linker.st' failed
+
+Upstream-Status: Pending

This is already fixed upstream so please mark it appropriately.

commit e8b6be0016f131c2ac72bf3213eabdb59800e63b

Author: Andreas Schwab <[email protected]>
Date:   Mon Mar 2 15:47:56 2015 +0100

Fix parallel build error

Quoted 42 lines
meta/recipes-core/glibc/glibc/elf-Makefile-fix-a-typo.patch new file +22 -0
+
+Signed-off-by: Robert Yang <[email protected]>
+---
+ elf/Makefile |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/elf/Makefile b/elf/Makefile
+index e5b142c..62fe245 100644
+--- a/elf/Makefile
++++ b/elf/Makefile
+@@ -358,7 +358,7 @@ $(objpfx)interp.os: $(elf-objpfx)runtime-linker.h
+ 
+ $(elf-objpfx)runtime-linker.h: $(elf-objpfx)runtime-linker.st; @:
+ $(elf-objpfx)runtime-linker.st: $(common-objpfx)config.make
+-	$(name-target-directory)
++	$(make-target-directory)
+ 	echo '#define RUNTIME_LINKER "$(rtlddir)/$(rtld-installed-name)"' \
+ 		> ${@:st=T}
+ 	$(move-if-change) ${@:st=T} ${@:st=h}
+-- 
+1.7.9.5
+
meta/recipes-core/glibc/glibc_2.21.bb +1 -0
index 91feff5..fcef4ff 100644
@@ -25,6 +25,7 @@ SRC_URI = "git://sourceware.org/git/glibc.git;branch=${BRANCH} \
           file://0001-Add-unused-attribute.patch \
           file://0001-When-disabling-SSE-also-make-sure-that-fpmath-is-not.patch \
           file://0001-yes-within-the-path-sets-wrong-config-variables.patch \
+           file://elf-Makefile-fix-a-typo.patch \
           ${EGLIBCPATCHES} \
          "
 EGLIBCPATCHES = "\
Signature · 7 lines
1.7.9.5

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core