Add support for Colibri Vybrid Modules

Hello,

This is the second version of the patchset which adds support for the Toradex Colibri Vybrid VF50 and VF61 modules. Boot up has been tested using the serial loader over UART.

Quoted 5 lines · Sanchayan Maity

Hello,

This is the second version of the patchset which adds support for the Toradex Colibri Vybrid VF50 and VF61 modules. Boot up has been tested using the serial loader over UART.

Hi!

Stefano, maybe you can pick 1,2,3,4,6 right away for next? This way, we can solve 5/6 separately, since it might need some further dicussion. I don't want that patch to block the rest of the series though.

Best regards,
Marek Vasut

Hi,

Quoted 7 lines · Marek Vasut

Quoted 5 lines · Sanchayan Maity

Hello,

This is the second version of the patchset which adds support for the Toradex Colibri Vybrid VF50 and VF61 modules. Boot up has been tested using the serial loader over UART.

Quoted 5 lines

Hi!

Stefano, maybe you can pick 1,2,3,4,6 right away for next? This way, we can solve 5/6 separately, since it might need some further dicussion. I don't want that patch to block the rest of the series though.

The sixth patch has some minor dependencies on the fifth patch like some #defines and configuration we enable for Colibri. In case the fifth patch will require some more discussion and time, then I guess I will need to rework the sixth patch and then everything related to USB can go in a later patch. The rework will be minor. So the v3 will be without USB support

and USB will go in later once this gets applied. Perhaps we will send the USB along with some more other featureset addition like gpio support for Vybrid which my colleague did recently along with some driver model/dt stuff.

By the way, where the fifth patch is concerned, is it related to the discussion Fabio pointed out in the discussion on first version of the patch? uboot trying to get rid of the 'no register access via offset' rule? Anything required I can rework accordingly.

This driver adds support for the USB peripheral on Freescale Vybrid SoC's.

Signed-off-by Sanchayan Maity <[email protected]>

---
 arch/arm/include/asm/arch-vf610/crm_regs.h    |  10 ++
 arch/arm/include/asm/arch-vf610/imx-regs.h    |   4 +
 arch/arm/include/asm/arch-vf610/regs-usbphy.h |  31 ++++
 drivers/usb/host/Makefile                     |   1 +
 drivers/usb/host/ehci-vf.c                    | 196
++++++++++++++++++++++++++ 5 files changed, 242 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-vf610/regs-usbphy.h
 create mode 100644 drivers/usb/host/ehci-vf.c

I was concerned about the placement of the PHY reg definition. I didn't hear from Fabio on the result of this decision and I don't really mind that either way.

Hi Marek,

Quoted 3 lines · Marek Vasut

I was concerned about the placement of the PHY reg definition. I didn't hear from Fabio on the result of this decision and I don't really mind that either way.

I thought that maybe we should relax about the 'register access via offset is forbidden' rule for new code submission, as according to Tom he would like to see this going away in the future:
https://www.marc.info/?l=u-boot&m=142609602127309&w=2

Quoted 4 lines · Sanchayan Maity

This driver adds support for the USB peripheral on Freescale Vybrid SoC's.

Signed-off-by Sanchayan Maity <[email protected]>

Quoted 9 lines

---
 arch/arm/include/asm/arch-vf610/crm_regs.h    |  10 ++
 arch/arm/include/asm/arch-vf610/imx-regs.h    |   4 +
 arch/arm/include/asm/arch-vf610/regs-usbphy.h |  31 ++++
 drivers/usb/host/Makefile                     |   1 +
 drivers/usb/host/ehci-vf.c                    | 196
++++++++++++++++++++++++++ 5 files changed, 242 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-vf610/regs-usbphy.h
 create mode 100644 drivers/usb/host/ehci-vf.c

A general hint, you can replace sequences of code like this:

var = readl(foo);
var |= BIT_BAR;
writel(var, addr);

with

setbits_le32(var, BIT_BAR);

Same applies for clearing -- clrbits_le32() and both setting and clearing -- clrsetbits_le32().

Thanks!

Best regards,
Marek Vasut

Hello,

Quoted 28 lines · Marek Vasut

Quoted 12 lines · Sanchayan Maity

This driver adds support for the USB peripheral on Freescale Vybrid SoC's.

Signed-off-by Sanchayan Maity <[email protected]>

---

 arch/arm/include/asm/arch-vf610/crm_regs.h    |  10 ++
 arch/arm/include/asm/arch-vf610/imx-regs.h    |   4 +
 arch/arm/include/asm/arch-vf610/regs-usbphy.h |  31 ++++
 drivers/usb/host/Makefile                     |   1 +
 drivers/usb/host/ehci-vf.c                    | 196

Quoted 4 lines

++++++++++++++++++++++++++ 5 files changed, 242 insertions(+)

 create mode 100644 arch/arm/include/asm/arch-vf610/regs-usbphy.h
 create mode 100644 drivers/usb/host/ehci-vf.c

A general hint, you can replace sequences of code like this:

var = readl(foo);
var |= BIT_BAR;
writel(var, addr);

with

setbits_le32(var, BIT_BAR);

Quoted 2 lines

Same applies for clearing -- clrbits_le32() and both setting and clearing -- clrsetbits_le32().

Sorry about that. It is something which I use in the sixth patch as well in the board files but it skipped my mind while doing this driver. Will take care of it in v3 which seems imminent.

Noted, thanks :).

Quoted 16 lines · maitysanchayan at gmail.com

Hi,

Quoted 12 lines · Marek Vasut

Quoted 5 lines · Sanchayan Maity

Hello,

This is the second version of the patchset which adds support for the Toradex Colibri Vybrid VF50 and VF61 modules. Boot up has been tested using the serial loader over UART.

Hi!

Stefano, maybe you can pick 1,2,3,4,6 right away for next? This way, we can solve 5/6 separately, since it might need some further dicussion. I don't want that patch to block the rest of the series though.

Quoted 6 lines

The sixth patch has some minor dependencies on the fifth patch like some #defines and configuration we enable for Colibri. In case the fifth patch will require some more discussion and time, then I guess I will need to rework the sixth patch and then everything related to USB can go in a later patch. The rework will be minor. So the v3 will be without USB support

Well, if you want to rework the 6th patch, that'd be very nice of you :)

Quoted 5 lines

and USB will go in later once this gets applied. Perhaps we will send the USB along with some more other featureset addition like gpio support for Vybrid which my colleague did recently along with some driver model/dt stuff.

My impression is that the USB is just a matter of figuring out where the PHY registers go -- whether in arch/arm/include/imx-common or into include/usb/ . I'd be more inclined for the later, since the PHY regs looks like chipidea IP specific thing, but I might be wrong.

Quoted 5 lines

By the way, where the fifth patch is concerned, is it related to the discussion Fabio pointed out in the discussion on first version of the patch? uboot trying to get rid of the 'no register access via offset' rule? Anything required I can rework accordingly.

I was concerned about the placement of the PHY reg definition. I didn't hear from Fabio on the result of this decision and I don't really mind that either way.

Best regards,
Marek Vasut

Hello,

Quoted 18 lines · Marek Vasut

Quoted 17 lines · maitysanchayan at gmail.com

Hi,

Quoted 13 lines · Marek Vasut

Quoted 5 lines · Sanchayan Maity

Hello,

This is the second version of the patchset which adds support for the Toradex Colibri Vybrid VF50 and VF61 modules. Boot up has been tested using the serial loader over UART.

Hi!

Stefano, maybe you can pick 1,2,3,4,6 right away for next? This way, we can solve 5/6 separately, since it might need some further dicussion. I don't want that patch to block the rest of the series though.

Quoted 8 lines

Quoted 6 lines

The sixth patch has some minor dependencies on the fifth patch like some #defines and configuration we enable for Colibri. In case the fifth patch will require some more discussion and time, then I guess I will need to rework the sixth patch and then everything related to USB can go in a later patch. The rework will be minor. So the v3 will be without USB support

Well, if you want to rework the 6th patch, that'd be very nice of you :)

Yes sure. Will put the USB support in the end or not, the first patches can go in atleast since there seem to be no complaints on them so far.

Quoted 5 lines

Quoted 4 lines

and USB will go in later once this gets applied. Perhaps we will send the USB along with some more other featureset addition like gpio support for Vybrid which my colleague did recently along with some driver model/dt stuff.

Quoted 4 lines

My impression is that the USB is just a matter of figuring out where the PHY registers go -- whether in arch/arm/include/imx-common or into include/usb/ . I'd be more inclined for the later, since the PHY regs looks like chipidea IP specific thing, but I might be wrong.

I would say it looks like chipidea specific but I have not looked at IPs other than Freescale controllers to be sure.

Quoted 8 lines

Quoted 4 lines

By the way, where the fifth patch is concerned, is it related to the discussion Fabio pointed out in the discussion on first version of the patch? uboot trying to get rid of the 'no register access via offset' rule? Anything required I can rework accordingly.

I was concerned about the placement of the PHY reg definition. I didn't hear from Fabio on the result of this decision and I don't really mind that either way.

Ok. So I assume the driver can resort to the way it was in the first version while being changed with regards to three points 1. Use of clrsetbits_ related functions 2. Register phy definitions going in either of imx-common/ or include/usb/ with chipidea name. 3. No need to use offset accesses with the struct{} in light of the discussion Fabio pointed out.

Quoted 5 lines · Marek Vasut

Quoted 1 line

On Sunday, April 12, 2015 at 07:33:41 AM, maitysanchayan at gmail.com

Quoted 40 lines · wrote:

Quoted 24 lines

Quoted 17 lines

Hi,

Quoted 7 lines · Marek Vasut

Quoted 5 lines · Sanchayan Maity

Hello,

This is the second version of the patchset which adds support for the Toradex Colibri Vybrid VF50 and VF61 modules. Boot up has been tested using the serial loader over UART.

Quoted 6 lines

Hi!

Stefano, maybe you can pick 1,2,3,4,6 right away for next? This way, we can solve 5/6 separately, since it might need some further dicussion. I don't want that patch to block the rest of the series though.

Quoted 6 lines

The sixth patch has some minor dependencies on the fifth patch like some #defines and configuration we enable for Colibri. In case the fifth patch will require some more discussion and time, then I guess I will need to rework the sixth patch and then everything related to USB can go in a later patch. The rework will be minor. So the v3 will be without USB support

Quoted 2 lines

Well, if you want to rework the 6th patch, that'd be very nice of you :)

Yes sure. Will put the USB support in the end or not, the first patches can go in atleast since there seem to be no complaints on them so far.

Quoted 9 lines

Quoted 4 lines

and USB will go in later once this gets applied. Perhaps we will send the USB along with some more other featureset addition like gpio support for Vybrid which my colleague did recently along with some driver model/dt stuff.

My impression is that the USB is just a matter of figuring out where the PHY registers go -- whether in arch/arm/include/imx-common or into include/usb/ . I'd be more inclined for the later, since the PHY regs looks like chipidea IP specific thing, but I might be wrong.

Quoted 2 lines

I would say it looks like chipidea specific but I have not looked at IPs other than Freescale controllers to be sure.

I think it's CI-specific indeed, thus include/usb/ . +CC Peter, who might chime in whether the PHY is CI-specific or IMX-specific.

Quoted 45 lines

Quoted 2 lines · Marek Vasut

Quoted 1 line

On Sunday, April 12, 2015 at 07:33:41 AM, maitysanchayan at gmail.com

Quoted 41 lines · wrote:

Quoted 24 lines

Quoted 17 lines

Hi,

Quoted 7 lines · Marek Vasut

Quoted 5 lines · Sanchayan Maity

Hello,

This is the second version of the patchset which adds support for the Toradex Colibri Vybrid VF50 and VF61 modules. Boot up has been tested using the serial loader over UART.

Quoted 6 lines

Hi!

Stefano, maybe you can pick 1,2,3,4,6 right away for next? This way, we can solve 5/6 separately, since it might need some further dicussion. I don't want that patch to block the rest of the series though.

Quoted 6 lines

The sixth patch has some minor dependencies on the fifth patch like some #defines and configuration we enable for Colibri. In case the fifth patch will require some more discussion and time, then I guess I will need to rework the sixth patch and then everything related to USB can go in a later patch. The rework will be minor. So the v3 will be without USB support

Quoted 2 lines

Well, if you want to rework the 6th patch, that'd be very nice of you :)

Yes sure. Will put the USB support in the end or not, the first patches can go in atleast since there seem to be no complaints on them so far.

Quoted 9 lines

Quoted 4 lines

and USB will go in later once this gets applied. Perhaps we will send the USB along with some more other featureset addition like gpio support for Vybrid which my colleague did recently along with some driver model/dt stuff.

My impression is that the USB is just a matter of figuring out where the PHY registers go -- whether in arch/arm/include/imx-common or into include/usb/ . I'd be more inclined for the later, since the PHY regs looks like chipidea IP specific thing, but I might be wrong.

Quoted 5 lines

Quoted 2 lines

I would say it looks like chipidea specific but I have not looked at IPs other than Freescale controllers to be sure.

I think it's CI-specific indeed, thus include/usb/ . +CC Peter, who might chime in whether the PHY is CI-specific or IMX-specific.

Which PHY? Vybrid? In Linux kernel, it belongs to mxs PHY. The same controller can integrate different PHYs.

Quoted 29 lines

Quoted 29 lines

Quoted 29 lines

Quoted 17 lines

Quoted 10 lines

Quoted 9 lines

Hi!

Stefano, maybe you can pick 1,2,3,4,6 right away for next? This way, we can solve 5/6 separately, since it might need some further dicussion. I don't want that patch to block the rest of the series though.

Quoted 6 lines

The sixth patch has some minor dependencies on the fifth patch like some #defines and configuration we enable for Colibri. In case the fifth patch will require some more discussion and time, then I guess I will need to rework the sixth patch and then everything related to USB can go in a later patch. The rework will be minor. So the v3 will be without USB support

Quoted 2 lines

Well, if you want to rework the 6th patch, that'd be very nice of you :)

Yes sure. Will put the USB support in the end or not, the first patches can go in atleast since there seem to be no complaints on them so far.

Quoted 5 lines

Quoted 4 lines

and USB will go in later once this gets applied. Perhaps we will send the USB along with some more other featureset addition like gpio support for Vybrid which my colleague did recently along with some driver model/dt stuff.

Quoted 4 lines

Quoted 4 lines

Quoted 4 lines

Quoted 4 lines

My impression is that the USB is just a matter of figuring out where the PHY registers go -- whether in arch/arm/include/imx-common or into include/usb/ . I'd be more inclined for the later, since the PHY regs looks like chipidea IP specific

thing, but I might be wrong.

Quoted 4 lines

Quoted 4 lines

Quoted 3 lines

I would say it looks like chipidea specific but I have not looked at IPs other than Freescale controllers to be sure.

Quoted 5 lines

Quoted 2 lines

I think it's CI-specific indeed, thus include/usb/ . +CC Peter, who might chime in whether the PHY is CI-specific or IMX-specific.

Which PHY? Vybrid? In Linux kernel, it belongs to mxs PHY. The same controller can integrate different PHYs.

Yeah. Is the PHY MXS/IMX/VF specific or can that PHY be found even on other SoCs not manufactured by Freescale ?

Quoted 44 lines

Quoted 29 lines

Quoted 29 lines

Quoted 29 lines

Quoted 17 lines

Quoted 10 lines

Quoted 9 lines

Hi!

Stefano, maybe you can pick 1,2,3,4,6 right away for next? This way, we can solve 5/6 separately, since it might need some further dicussion. I don't want that patch to block the rest of the series though.

Quoted 6 lines

The sixth patch has some minor dependencies on the fifth patch like some #defines and configuration we enable for Colibri. In case the fifth patch will require some more discussion and time, then I guess I will need to rework the sixth patch and then everything related to USB can go in a later patch. The rework will be minor. So the v3 will be without USB support

Quoted 2 lines

Well, if you want to rework the 6th patch, that'd be very nice of you :)

Yes sure. Will put the USB support in the end or not, the first patches can go in atleast since there seem to be no complaints on them so far.

Quoted 5 lines

Quoted 4 lines

and USB will go in later once this gets applied. Perhaps we will send the USB along with some more other featureset addition like gpio support for Vybrid which my colleague did recently along with some driver model/dt stuff.

Quoted 4 lines

Quoted 4 lines

Quoted 4 lines

Quoted 4 lines

My impression is that the USB is just a matter of figuring out where the PHY registers go -- whether in arch/arm/include/imx-common or into include/usb/ . I'd be more inclined for the later, since the PHY regs looks like chipidea IP specific

thing, but I might be wrong.

Quoted 9 lines

Quoted 6 lines

Quoted 3 lines

I would say it looks like chipidea specific but I have not looked at IPs other than Freescale controllers to be sure.

I think it's CI-specific indeed, thus include/usb/ . +CC Peter, who might chime in whether the PHY is CI-specific or IMX-specific.

Which PHY? Vybrid? In Linux kernel, it belongs to mxs PHY. The same controller can integrate different PHYs.

Quoted 3 lines

Yeah. Is the PHY MXS/IMX/VF specific or can that PHY be found even on other SoCs not manufactured by Freescale ?

This mxs PHY is from SigmaTel, I only see this PHY is used at FSL SoCs, but not sure if others use it.

Peter

Hello,

Quoted 5 lines

Quoted 2 lines

Yeah. Is the PHY MXS/IMX/VF specific or can that PHY be found even on other SoCs not manufactured by Freescale ?

This mxs PHY is from SigmaTel, I only see this PHY is used at FSL SoCs, but not sure if others use it.

So Chipidea IP with the SigmaTel phy. It might be better to have the regs-usbphy.h viz. register phy definitions in imx-common then since it is not clear if SoC's other than Freescale's use the same phy.

Marek, what do you think?