Skip to contentSkip to conversation

buildstats-summary: add eventmask

PATCH Superseded Chen Qi 3 participants 5 messages May 19, 2015 – May 20, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

cover buildstats-summary: add eventmask

The following changes since commit 7ffe10df73cc20d10fcd41b121074445273bd60e:

license_class: license_create_manifest improvment (2015-05-09 22:26:02 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib ChenQi/buildstats-summary
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/buildstats-summary

Chen Qi (1):
buildstats-summary: add eventmask

 meta/classes/buildstats-summary.bbclass | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 buildstats-summary: add eventmask

Add eventmask for buildstats_summary handler.

---
 meta/classes/buildstats-summary.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/buildstats-summary.bbclass +1 -0
index c8fbb2f..7bd528e 100644
@@ -37,3 +37,4 @@ python buildstats_summary () {
             bb.note("  {0}: {1}% sstate reuse ({2} setscene, {3} scratch)".format(t, 100*len(sstate)/(len(sstate)+len(no_sstate)), len(sstate), len(no_sstate)))
 }
 addhandler buildstats_summary
+buildstats_summary[eventmask] = "bb.event.BuildCompleted"
Signature · 1 line
1.9.1
#2 lore raw
Quoted 1 line · Chen Qi

Add eventmask for buildstats_summary handler.

Why?

This says what you've done but not why we need this...

Cheers,

Richard

#3 lore raw
Quoted 10 lines · Richard Purdie
Quoted 1 line · Chen Qi

Add eventmask for buildstats_summary handler.

Why?

This says what you've done but not why we need this...

Cheers,

Richard

Also, this adds the eventmask, but doesn’t remove the then-redundant isinstance() on the event object.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
author
#4 lore raw
Quoted 8 lines · Christopher Larson

On Tue, May 19, 2015 at 3:47 AM, Richard Purdie <[email protected] <mailto:[email protected]>> wrote:

On Tue, 2015-05-19 at 16:29 +0800, Chen Qi wrote:
> Add eventmask for buildstats_summary handler.

Why?

Quoted 8 lines

This says what you've done but not why we need this...

Cheers,

Richard

Also, this adds the eventmask, but doesn’t remove the then-redundant isinstance() on the event object.

Hi Richard and Christopher,

Thanks for you advice.
I'll send out V2.

Regards,
Chen Qi

Quoted 6 lines
Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics