Skip to contentSkip to conversation

xserver-xorg upgrade

PATCH In review Jussi Kukkonen 2 participants 4 messages May 20, 2015

lore
Share & tools
lore
#0 lore raw

cover xserver-xorg upgrade

The last commit does three things:
* removes xf86-video-modesetting recipe
* upgrades xserver-xorg (which now includes modesetting driver)
* updates OELAYOUT_ABI (to avoid sanity check freaking out from the previous two)
The combination seems logically atomic to me but let me know if I should divide it into separate commits instead.

Also, I'm not totally familiar with the tmp/sysroots/ layout so would appreciate advice on the sanity.bbclass changes.

First commit fixes a sanity.bbclass bug that would be triggered by the actual patch.

I've tested the ABI upgrade to the best of my ability (including wiping tmp/, building an image from master, then building this branch).

The following changes since commit 16caaabfcc678b03a0cd88aaeac15f9b8d1c3dad:

bitbake: bitbake-user-manual-customization.xsl: Pointing to mirrors for XSL files. (2015-05-19 22:09:36 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib jku/xorg
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/xorg

Jussi Kukkonen (2):
sanity.bbclass: import subprocess in correct function
xserver-xorg: Upgrade 1.16.3 -> 1.17.1 (OELAYOUT_ABI change)

 meta-yocto/conf/distro/poky.conf                   |   2 +-
 meta/classes/sanity.bbclass                        |  10 +-
 meta/conf/abi_version.conf                         |   2 +-
 .../xorg-driver/xf86-video-modesetting_0.9.0.bb    |   8 --
 .../recipes-graphics/xorg-xserver/xserver-xorg.inc |   9 +-
 ...Check-strings-length-against-request-size.patch | 145 ---------------------
 ...wap-XkbSetGeometry-data-in-the-input-buff.patch | 109 ----------------
 .../Fix-subwindow-in-Xi-emulated-events.patch      |  41 ------
 .../xserver-xorg/xshmfence-option.patch            |  57 --------
 ...erver-xorg_1.16.3.bb => xserver-xorg_1.17.1.bb} |   8 +-
 10 files changed, 19 insertions(+), 372 deletions(-)
 delete mode 100644 meta/recipes-graphics/xorg-driver/xf86-video-modesetting_0.9.0.bb
 delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-xkb-Check-strings-length-against-request-size.patch
 delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-xkb-Don-t-swap-XkbSetGeometry-data-in-the-input-buff.patch
 delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/Fix-subwindow-in-Xi-emulated-events.patch
 delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/xshmfence-option.patch
 rename meta/recipes-graphics/xorg-xserver/{xserver-xorg_1.16.3.bb => xserver-xorg_1.17.1.bb} (74%)
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/2 sanity.bbclass: import subprocess in correct function

check_sanity() no longer needs the subprocess module but sanity_handle_abichanges() does use subprocess.call().

---
 meta/classes/sanity.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/classes/sanity.bbclass +2 -2
index fc8c980..839f7ce 100644
@@ -491,6 +491,8 @@ def sanity_handle_abichanges(status, d):
     #
     # Check the 'ABI' of TMPDIR
     #
+    import subprocess
+
     current_abi = d.getVar('OELAYOUT_ABI', True)
     abifile = d.getVar('SANITY_ABIFILE', True)
     if os.path.exists(abifile):
@@ -824,8 +826,6 @@ def check_sanity_everybuild(status, d):
         status.addresult("Error, IMAGE_FSTYPES vmdk and live can't be built together\n")
 
 def check_sanity(sanity_data):
-    import subprocess
-
     class SanityStatus(object):
         def __init__(self):
             self.messages = ""
Signature · 1 line
2.1.4
#2 lore raw

PATCH 2/2 xserver-xorg: Upgrade 1.16.3 -> 1.17.1 (OELAYOUT_ABI change)

* Increase OELAYOUT_ABI: this is required because the xf86-video-modesetting package moves from its own recipe to xserver-xorg and sanity check cannot handle that currently. The upgrade will delete old xf86-video-modesetting files from sysroots.
* Remove upstreamed xserver-xorg patches
* Remove xf86-video-modesetting recipe: the driver is now included in xserver-xorg recipe, which now produces the xf86-video-modesetting package. The package version changes from 0.9 to 1.17.1
* Update xserver-xorg license checksum: modesetting license info (another MIT one) has been added to the file

---
 meta-yocto/conf/distro/poky.conf                   |   2 +-
 meta/classes/sanity.bbclass                        |   6 +
 meta/conf/abi_version.conf                         |   2 +-
 .../xorg-driver/xf86-video-modesetting_0.9.0.bb    |   8 --
 .../recipes-graphics/xorg-xserver/xserver-xorg.inc |   9 +-
 ...Check-strings-length-against-request-size.patch | 145 ---------------------
 ...wap-XkbSetGeometry-data-in-the-input-buff.patch | 109 ----------------
 .../Fix-subwindow-in-Xi-emulated-events.patch      |  41 ------
 .../xserver-xorg/xshmfence-option.patch            |  57 --------
 ...erver-xorg_1.16.3.bb => xserver-xorg_1.17.1.bb} |   8 +-
 10 files changed, 17 insertions(+), 370 deletions(-)
 delete mode 100644 meta/recipes-graphics/xorg-driver/xf86-video-modesetting_0.9.0.bb
 delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-xkb-Check-strings-length-against-request-size.patch
 delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-xkb-Don-t-swap-XkbSetGeometry-data-in-the-input-buff.patch
 delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/Fix-subwindow-in-Xi-emulated-events.patch
 delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/xshmfence-option.patch
 rename meta/recipes-graphics/xorg-xserver/{xserver-xorg_1.16.3.bb => xserver-xorg_1.17.1.bb} (74%)
meta-yocto/conf/distro/poky.conf +1 -1
index 94de6e8..b47325d 100644
@@ -91,7 +91,7 @@ BB_SIGNATURE_HANDLER ?= 'OEBasicHash'
 # that breaks the format and have been previously discussed on the mailing list 
 # with general agreement from the core team.
 #
-OELAYOUT_ABI = "10"
+OELAYOUT_ABI = "11"
 
 # add poky sanity bbclass
 INHERIT += "poky-sanity"
meta/classes/sanity.bbclass +6 -0
index 839f7ce..c46a073 100644
@@ -536,6 +536,12 @@ def sanity_handle_abichanges(status, d):
                 sstate_clean_manifest(f, d)
             with open(abifile, "w") as f:
                 f.write(current_abi)
+        elif abi == "10" and current_abi == "11":
+            bb.note("Converting staging layout from version 10 to layout version 11")
+            # Files in xf86-video-modesetting moved to xserver-xorg and bitbake can't currently handle that:
+            subprocess.call(d.expand("rm ${TMPDIR}/sysroots/*/usr/lib/xorg/modules/drivers/modesetting_drv.so ${TMPDIR}/sysroots/*/pkgdata/runtime/xf86-video-modesetting* ${TMPDIR}/sysroots/*/pkgdata/runtime-reverse/xf86-video-modesetting* ${TMPDIR}/sysroots/*/pkgdata/shlibs2/xf86-video-modesetting*"), shell=True)
+            with open(abifile, "w") as f:
+                f.write(current_abi)
         elif (abi != current_abi):
             # Code to convert from one ABI to another could go here if possible.
             status.addresult("Error, TMPDIR has changed its layout version number (%s to %s) and you need to either rebuild, revert or adjust it at your own risk.\n" % (abi, current_abi))
meta/conf/abi_version.conf +1 -1
index 2867850..a829687 100644
@@ -4,4 +4,4 @@
 # that breaks the format and have been previously discussed on the mailing list 
 # with general agreement from the core team.
 #
-OELAYOUT_ABI = "10"
+OELAYOUT_ABI = "11"
meta/recipes-graphics/xorg-driver/xf86-video-modesetting_0.9.0.bb deleted +0 -8
deleted file mode 100644
index b220787..0000000
@@ -1,8 +0,0 @@
-require xorg-driver-video.inc
-LIC_FILES_CHKSUM = "file://COPYING;md5=5e53d3fcadb1c23d122ad63cb099a918"
-
-SUMMARY = "X.Org X server -- modesetting display driver"
-DESCRIPTION = "Provides a generic kernel modesetting display driver for the X.Org X server."
-
-SRC_URI[md5sum] = "da588d4f54111c2deae035998058ce10"
-SRC_URI[sha256sum] = "90cf085573203dfadd48ea69bd694c4d04ccbe088b6855e9c85c34bb8a95d75c"
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +7 -2
index cc95da6..04289f8 100644
@@ -2,7 +2,7 @@ SUMMARY = "The X.Org X server"
 HOMEPAGE = "http://www.x.org"
 SECTION = "x11/base"
 LICENSE = "MIT-X"
-LIC_FILES_CHKSUM = "file://COPYING;md5=15b5bf9327341c81089137aec4830bfd"
+LIC_FILES_CHKSUM = "file://COPYING;md5=5df87950af51ac2c5822094553ea1880"
 
 # xf86-*-* packages depend on an X server built with the xfree86 DDX
 # so we have a virtual to represent that:
@@ -63,7 +63,11 @@ PACKAGES =+ "${PN}-security-policy \
              ${PN}-module-exa \
              ${PN}-module-xaa \
              ${PN}-module-libxf1bpp \
-             ${PN}-module-libxf4bpp"
+             ${PN}-module-libxf4bpp \
+             xf86-video-modesetting"
+
+SUMMARY_xf86-video-modesetting = "X.Org X server -- modesetting display driver"
+INSANE_SKIP_xf86-video-modesetting = "xorg-driver-abi"
 
 RRECOMMENDS_${PN} += "${PN}-security-policy xkeyboard-config rgb xserver-xf86-config xkbcomp"
 RDEPENDS_${PN}-xvfb += "xkeyboard-config"
@@ -99,6 +103,7 @@ FILES_${PN}-module-exa = "${libdir}/xorg/modules/libexa.so"
 FILES_${PN}-module-xaa = "${libdir}/xorg/modules/libxaa.so"
 FILES_${PN}-module-libxf1bpp = "${libdir}/xorg/modules/libxf1bpp.so"
 FILES_${PN}-module-libxf4bpp = "${libdir}/xorg/modules/libxf4bpp.so"
+FILES_xf86-video-modesetting = "${libdir}/xorg/modules/drivers/modesetting_drv.so"
 
 EXTRA_OECONF += "--with-fop=no \
                  --with-pic \
meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-xkb-Check-strings-length-against-request-size.patch deleted +0 -145

145 lines not on this page · raw message

meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-xkb-Don-t-swap-XkbSetGeometry-data-in-the-input-buff.patch deleted +0 -109

109 lines not on this page · raw message

meta/recipes-graphics/xorg-xserver/xserver-xorg/Fix-subwindow-in-Xi-emulated-events.patch deleted +0 -41

41 lines not on this page · raw message

meta/recipes-graphics/xorg-xserver/xserver-xorg/xshmfence-option.patch deleted +0 -57

57 lines not on this page · raw message

meta/recipes-graphics/xorg-xserver/xserver-xorg_1.17.1.bb renamed from meta/recipes-graphics/xorg-xserver/xserver-xorg_1.16.3.bb +2 -6
similarity index 74%
rename from meta/recipes-graphics/xorg-xserver/xserver-xorg_1.16.3.bb
rename to meta/recipes-graphics/xorg-xserver/xserver-xorg_1.17.1.bb
index 780ece0..82051b3 100644
@@ -3,17 +3,13 @@ require xserver-xorg.inc
 # Misc build failure for master HEAD
 SRC_URI += "file://fix_open_max_preprocessor_error.patch \
             file://xorg-CVE-2013-6424.patch \
-            file://xshmfence-option.patch \
-            file://Fix-subwindow-in-Xi-emulated-events.patch \
             file://xtrans.patch \
-            file://0001-xkb-Don-t-swap-XkbSetGeometry-data-in-the-input-buff.patch \
-            file://0001-xkb-Check-strings-length-against-request-size.patch \
             file://0001-use-__GLIBC__-guard-for-glibc-specific-code.patch \
 	    file://0001-sdksyms.sh-Make-sdksyms.sh-work-with-gcc5.patch \
            "
 
-SRC_URI[md5sum] = "afd93977235584a9caa7528a737c1b52"
-SRC_URI[sha256sum] = "5e0f443238af1078b48f6eea98a382861b59187da221c2cf714d31c1d560b0fb"
+SRC_URI[md5sum] = "5986510d59e394a50126a8e2833e79d3"
+SRC_URI[sha256sum] = "2bf8e9f6f0a710dec1d2472467bff1f4e247cb6dcd76eb469aafdc8a2d7db2ab"
 
 # These extensions are now integrated into the server, so declare the migration
 # path for in-place upgrades.
Signature · 1 line
2.1.4
#3 lore raw

Re: [PATCH 2/2] xserver-xorg: Upgrade 1.16.3 -> 1.17.1 (OELAYOUT_ABI change)

Review

Quoted 3 lines · Jussi Kukkonen
(quoted diff) +1 -1
-LIC_FILES_CHKSUM = "file://COPYING;md5=15b5bf9327341c81089137aec4830bfd"
+LIC_FILES_CHKSUM = "file://COPYING;md5=5df87950af51ac2c5822094553ea1880

When this happens please explain what the change was, to demonstrate that you've verified that xserver wasn't relicensed to GPLv3. :)

I'll look at the rest in a minute...

Ross