misc: mic: bug fixes
cover misc: mic: bug fixes
This patch series fixes reported issues including a randconfig build error and a warning from a static checker.
Sudeep Dutt (2):
misc: mic: Fix randconfig build error by including errno.h
misc: mic: Fix reported static checker warning
drivers/misc/mic/scif/scif_main.c | 4 ---- drivers/misc/mic/scif/scif_rb.c | 1 + 2 files changed, 1 insertion(+), 4 deletions(-)
Signature · 1 line
1.8.2.1
PATCH 1/2 misc: mic: Fix randconfig build error by including errno.h
This issue was reported @ https://lkml.org/lkml/2015/6/9/731
Reported-by Jim Davis <[email protected]>
Reviewed-by Ashutosh Dixit <[email protected]>
Signed-off-by Sudeep Dutt <[email protected]>
--- drivers/misc/mic/scif/scif_rb.c | 1 + 1 file changed, 1 insertion(+)
drivers/misc/mic/scif/scif_rb.c +1 -0
@@ -18,6 +18,7 @@#include <linux/circ_buf.h> #include <linux/types.h> #include <linux/io.h> +#include <linux/errno.h> #include "scif_rb.h"
Signature · 1 line
1.8.2.1
PATCH 2/2 misc: mic: Fix reported static checker warning
In reply to Sudeep DuttDelete unnecessary prints resulting in an "spdev could be null" warning from a static checker in scif_peer_remove(..).
Reported-by Dan Carpenter <[email protected]>
Reviewed-by Ashutosh Dixit <[email protected]>
Signed-off-by Sudeep Dutt <[email protected]>
--- drivers/misc/mic/scif/scif_main.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/misc/mic/scif/scif_main.c +0 -4
@@ -91,8 +91,6 @@ static int scif_peer_probe(struct scif_peer_dev *spdev)rcu_assign_pointer (scifdev->spdev, spdev);/* In the future SCIF kernel client devices will be added here */ -dev_info (&spdev->dev,"Peer added dnode %d\n" , - spdev->dnode);return 0 ; }
@@ -109,8 +107,6 @@ static void scif_peer_remove(struct scif_peer_dev *spdev)mutex_lock (&scif_info.conflock); scif_info.total--;mutex_unlock (&scif_info.conflock); -dev_info (&spdev->dev,"Peer removed dnode %d\n" , - spdev->dnode); }static void scif_qp_setup_handler (struct work_struct *work)
Signature · 1 line
1.8.2.1