Skip to contentSkip to conversation

meta: 3 fixes

PATCH In review Robert Yang 3 participants 9 messages Jul 13, 2015 – Aug 19, 2015

lore
Share & tools
lore
#0 lore raw

cover meta: 3 fixes

The following changes since commit e6f66370c6ce15aca18ef64491bab3dc92b80c57:

classes/sstate.bbclass: Improve checkstatus using connection cache. (2015-07-12 22:53:22 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/3fixes
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/3fixes

Robert Yang (3):
glibc: print PN when bbwarn
dbus-ptest: set INSANE_SKIP for build-deps
gnu-config: set noexec for do_compile

 meta/recipes-core/dbus/dbus.inc                    |    2 ++
 meta/recipes-core/glibc/glibc_2.21.bb              |    3 ++-
 .../gnu-config/gnu-config_20120814.bb              |    4 +---
 3 files changed, 5 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/3 glibc: print PN when bbwarn

The current warning is:
WARNING: glibc: unable to generate header for spray.x

Which is easier to debug than:
WARNING: unable to generate header for spray.x

And remove the file before generate it again to fix the warning when recompile:
file `bootparam_prot.h' already exists and may be overwritten
WARNING: unable to generate header for bootparam_prot.x file `nlm_prot.h' already exists and may be overwritten
WARNING: unable to generate header for nlm_prot.x
[snip]

---
 meta/recipes-core/glibc/glibc_2.21.bb |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.21.bb +2 -1
index 8197c29..30f1937 100644
@@ -135,7 +135,8 @@ do_compile () {
 		cd ${S}/sunrpc/rpcsvc
 		for r in ${rpcsvc}; do
 			h=`echo $r|sed -e's,\.x$,.h,'`
-			rpcgen -h $r -o $h || bbwarn "unable to generate header for $r"
+			rm -f $h
+			rpcgen -h $r -o $h || bbwarn "${PN}: unable to generate header for $r"
 		done
 	)
 	echo "Adjust ldd script"
Signature · 1 line
1.7.9.5
#2 lore raw

Re: [PATCH 1/3] glibc: print PN when bbwarn

Quoted 24 lines · Robert Yang

The current warning is:
WARNING: glibc: unable to generate header for spray.x

Which is easier to debug than:
WARNING: unable to generate header for spray.x

And remove the file before generate it again to fix the warning when recompile:
file `bootparam_prot.h' already exists and may be overwritten
WARNING: unable to generate header for bootparam_prot.x file `nlm_prot.h' already exists and may be overwritten
WARNING: unable to generate header for nlm_prot.x
[snip]

---
 meta/recipes-core/glibc/glibc_2.21.bb |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/glibc/glibc_2.21.bb +0 -0
index 8197c29..30f1937 100644

meta/recipes-core/glibc/glibc_2.21.bb do_compile () { · line 138

Quoted 5 lines
meta/recipes-core/glibc/glibc_2.21.bb +1 -1
@@ -135,7 +135,8 @@ do_compile () {
                cd ${S}/sunrpc/rpcsvc
                for r in ${rpcsvc}; do
                        h=`echo $r|sed -e's,\.x$,.h,'`
-                       rpcgen -h $r -o $h || bbwarn "unable to generate header for $r"
+                       rm -f $h

it quashes the warning but doesnt fix underlying problem. this doesnt seem to be right thing to do in cross builds. We use cross-rpcgen to generate these files so this whole rpcgen run should be removed instead. Please test such a patch and correct it.

Quoted 12 lines
meta/recipes-core/glibc/glibc_2.21.bb +1 -1
+                       rpcgen -h $r -o $h || bbwarn "${PN}: unable to generate header for $r"
                done
        )
        echo "Adjust ldd script"
--

1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw

Re: [PATCH 1/3] glibc: print PN when bbwarn

Quoted 20 lines · Khem Raj
Quoted 19 lines · Robert Yang

The current warning is:
WARNING: glibc: unable to generate header for spray.x

Which is easier to debug than:
WARNING: unable to generate header for spray.x

And remove the file before generate it again to fix the warning when recompile:
file `bootparam_prot.h' already exists and may be overwritten
WARNING: unable to generate header for bootparam_prot.x file `nlm_prot.h' already exists and may be overwritten
WARNING: unable to generate header for nlm_prot.x
[snip]

---
  meta/recipes-core/glibc/glibc_2.21.bb |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 16 lines

meta/recipes-core/glibc/glibc_2.21.bb do_compile () { · line 138

Quoted 10 lines
meta/recipes-core/glibc/glibc_2.21.bb +1 -1
index 8197c29..30f1937 100644
@@ -135,7 +135,8 @@ do_compile () {
                 cd ${S}/sunrpc/rpcsvc
                 for r in ${rpcsvc}; do
                         h=`echo $r|sed -e's,\.x$,.h,'`
-                       rpcgen -h $r -o $h || bbwarn "unable to generate header for $r"
+                       rm -f $h

it quashes the warning but doesnt fix underlying problem. this doesnt seem to be right thing to do in cross builds. We use cross-rpcgen to generate these files so this whole rpcgen run should be removed instead. Please test such a patch and correct it.

Hi Khem,

I will be on vacation the whole next week, will do when I come back.

// Robert

Quoted 14 lines
Quoted 12 lines
meta/recipes-core/glibc/glibc_2.21.bb +1 -1
+                       rpcgen -h $r -o $h || bbwarn "${PN}: unable to generate header for $r"
                 done
         )
         echo "Adjust ldd script"
--

1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#4 lore raw

Re: [PATCH 1/3] glibc: print PN when bbwarn

In reply to Khem Raj
Quoted 5 lines · Khem Raj

it quashes the warning but doesnt fix underlying problem. this doesnt seem to be right thing to do in cross builds. We use cross-rpcgen to generate these files so this whole rpcgen run should be removed instead. Please test such a patch and correct it.

There's been a related report on the yocto@ list where it was noticed that we're executing the host rpcgen during glibc builds, so consider this is a ping. :)

Ross

#5 lore raw

Re: [PATCH 1/3] glibc: print PN when bbwarn

Quoted 4 lines · Ross

There's been a related report on the yocto@ list where it was noticed that we're executing the host rpcgen during glibc builds, so consider this is a ping. :)

Filed #8181 so this doesn't get lost.

Ross

#6 lore raw

Re: [PATCH 1/3] glibc: print PN when bbwarn

Thanks, I will work on it.

// Robert

Quoted 12 lines · Ross

On 17 August 2015 at 13:33, Burton, Ross <[email protected] <mailto:[email protected]>> wrote:

There's been a related report on the yocto@ list where it was noticed that we're executing the host rpcgen during glibc builds, so consider this is a ping. :)

Filed #8181 so this doesn't get lost.

Ross

#7 lore raw

PATCH 2/3 dbus-ptest: set INSANE_SKIP for build-deps

In reply to Robert Yang

Skip the warning for dbus-ptest:
dbus-1.8.18: dbus-ptest rdepends on dbus-test-ptest, but it isn't a build dependency? [build-deps]

We add dbus-test to dbus' DEPENDS to fix the problem usually, but dbus-test DEPENDS on dbus, so we can't do that, use INSANE_SKIP to fix the problem.

---
 meta/recipes-core/dbus/dbus.inc |    2 ++
 1 file changed, 2 insertions(+)
meta/recipes-core/dbus/dbus.inc +2 -0
index 01066cb..3971081 100644
@@ -166,3 +166,5 @@ do_install_class-nativesdk() {
 	rm -rf ${D}${localstatedir}/run
 }
 BBCLASSEXTEND = "native nativesdk"
+
+INSANE_SKIP_${PN}-ptest += "build-deps"
Signature · 1 line
1.7.9.5
#8 lore raw

PATCH 3/3 gnu-config: set noexec for do_compile

In reply to Robert Yang
---
 .../gnu-config/gnu-config_20120814.bb              |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
meta/recipes-devtools/gnu-config/gnu-config_20120814.bb +1 -3
index f5fce6f..eb7e420 100644
@@ -19,9 +19,7 @@ SRC_URI[sha256sum] = "44f99a8e76f3e8e4fec0bb5ad4762f8e44366168554ce66cb85afbe2ed
 
 CLEANBROKEN = "1"
 
-do_compile() {
-	:
-}
+do_compile[noexec] = "1"
 
 do_install () {
 	install -d ${D}${datadir}/gnu-config \
Signature · 1 line
1.7.9.5