Skip to contentSkip to conversation

Fixes for qemu and mc

PATCH In review Robert Yang 4 participants 11 messages Jul 28, 2015 – Jul 29, 2015

lore
Share & tools
lore
#0 lore raw

cover Fixes for qemu and mc

The following changes since commit 27d068d05239c26a3848eb101571acab54635e37:

harfbuzz: upgrade to 1.0.1 (2015-07-27 23:28:23 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/qemu
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/qemu

Robert Yang (3):
mc: add PACKAGECONFIG for util-linux
qemu: add PACKAGECONFIG for gnutls
qemu_git.bb: remove it

 meta/recipes-devtools/qemu/qemu.inc                |    1 +
 ...-Arm-versatilepb-Add-memory-size-checking.patch |    0
 .../exclude-some-arm-EABI-obsolete-syscalls.patch  |    0
 .../qemu-enlarge-env-entry-size.patch              |    0
 meta/recipes-devtools/qemu/qemu_git.bb             |   15 ---------------
 meta/recipes-extended/mc/mc_4.8.14.bb              |    1 +
 6 files changed, 2 insertions(+), 15 deletions(-)
 rename meta/recipes-devtools/qemu/{files => qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%)
 rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%)
 rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%)
 delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/3 mc: add PACKAGECONFIG for util-linux

Fixed:
mc-4.8.14: mc rdepends on util-linux-libmount, but it isn't a build dependency? [build-deps]

---
 meta/recipes-extended/mc/mc_4.8.14.bb |    1 +
 1 file changed, 1 insertion(+)
meta/recipes-extended/mc/mc_4.8.14.bb +1 -0
index 8fec0b3..81a8ad9 100644
@@ -20,6 +20,7 @@ inherit autotools gettext pkgconfig
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[smb] = "--enable-vfs-smb,--disable-vfs-smb,samba,"
 PACKAGECONFIG[sftp] = "--enable-vfs-sftp,--disable-vfs-sftp,libssh2,"
+PACKAGECONFIG[util-linux] = "ac_cv_lib_mount_mnt_new_table_from_file=yes,ac_cv_lib_mount_mnt_new_table_from_file=no,util-linux,"
 
 EXTRA_OECONF = "--with-screen=ncurses --without-gpm-mouse --without-x"
 
Signature · 1 line
1.7.9.5
#2 lore raw

Re: [PATCH 1/3] mc: add PACKAGECONFIG for util-linux

Quoted 3 lines · Robert Yang

+PACKAGECONFIG[util-linux] = "ac_cv_lib_mount_mnt_new_table_from_file=yes,ac_cv_lib_mount_mnt_new_table_from_file=no,util-linux,"

For mc this might be something we want to enable by default.

Ross

#3 lore raw

Re: [PATCH 1/3] mc: add PACKAGECONFIG for util-linux

Quoted 9 lines · Ross

On 28 July 2015 at 10:05, Robert Yang <[email protected] <mailto:[email protected]>> wrote:

+PACKAGECONFIG[util-linux] = "ac_cv_lib_mount_mnt_new_table_from_file=yes,ac_cv_lib_mount_mnt_new_table_from_file=no,util-linux,"

For mc this might be something we want to enable by default.

Thanks, I will update it.

// Robert

Quoted 2 lines

Ross

#4 lore raw

PATCH 2/3 qemu: add PACKAGECONFIG for gnutls

In reply to Robert Yang

Fixed:
qemu-2.3.99+2.4.0-rc2: qemu rdepends on nettle, but it isn't a build dependency? [build-deps] qemu-2.3.99+2.4.0-rc2: qemu rdepends on gnutls, but it isn't a build dependency? [build-deps]

---
 meta/recipes-devtools/qemu/qemu.inc |    1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/qemu/qemu.inc +1 -0
index eba7d3d..6a744c3 100644
@@ -105,6 +105,7 @@ PACKAGECONFIG[alsa] = ",,alsa-lib"
 PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,mesa"
 PACKAGECONFIG[lzo] = "--enable-lzo,--disable-lzo,lzo"
 PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl"
+PACKAGECONFIG[gnutls] = "--enable-gnutls,--disable-gnutls,gnutls"
 
 EXTRA_OECONF += "${@bb.utils.contains('PACKAGECONFIG', 'alsa', '--audio-drv-list=oss,alsa', '', d)}"
 
Signature · 1 line
1.7.9.5
#5 lore raw

PATCH 3/3 qemu_git.bb: remove it

In reply to Robert Yang

Remove it since we have 2.4.0, the git version is 1.3 can't be built by
deafult:
ERROR: Fetcher failure: Unable to find revision 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from upstream

We can fix it, but seems that no one uses it any more.

And move patches from "files" dir to "qemu" dir.

---
 ...-Arm-versatilepb-Add-memory-size-checking.patch |    0
 .../exclude-some-arm-EABI-obsolete-syscalls.patch  |    0
 .../qemu-enlarge-env-entry-size.patch              |    0
 meta/recipes-devtools/qemu/qemu_git.bb             |   15 ---------------
 4 files changed, 15 deletions(-)
 rename meta/recipes-devtools/qemu/{files => qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%)
 rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%)
 rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%)
 delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb
meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch renamed from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch +0 -0
similarity index 100%
rename from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch
rename to meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch
meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch renamed from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch +0 -0
similarity index 100%
rename from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch
rename to meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch
meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch renamed from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch +0 -0
similarity index 100%
rename from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch
rename to meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch
meta/recipes-devtools/qemu/qemu_git.bb deleted +0 -15
deleted file mode 100644
index a30932a..0000000
@@ -1,15 +0,0 @@
-require qemu.inc
-
-SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8"
-
-LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \
-                    file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913"
-
-PV = "1.3.0+git${SRCPV}"
-
-SRC_URI_prepend = "git://git.qemu.org/qemu.git"
-S = "${WORKDIR}/git"
-
-DEFAULT_PREFERENCE = "-1"
-
-COMPATIBLE_HOST_class-target_mips64 = "null"
Signature · 1 line
1.7.9.5
#6 lore raw

Re: [PATCH 3/3] qemu_git.bb: remove it

Hi Robert,

Hmm,
Qemu git recipe is useful, and is close to being up to date, why to remove it??
Qemu brakes quite often, as seen recently on autobuilders, building from git allowed us to move forward (although it is true that the git upgrade was not integrated into master.) I vote against this patch.

Thanks,
Cristian

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Robert Yang
Sent: Tuesday, July 28, 2015 12:05 PM
To: [email protected]
Subject: [OE-core] [PATCH 3/3] qemu_git.bb: remove it

Remove it since we have 2.4.0, the git version is 1.3 can't be built by
deafult:
ERROR: Fetcher failure: Unable to find revision 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from upstream

We can fix it, but seems that no one uses it any more.

And move patches from "files" dir to "qemu" dir.

---
 ...-Arm-versatilepb-Add-memory-size-checking.patch |    0
 .../exclude-some-arm-EABI-obsolete-syscalls.patch  |    0
 .../qemu-enlarge-env-entry-size.patch              |    0
 meta/recipes-devtools/qemu/qemu_git.bb             |   15 ---------------
 4 files changed, 15 deletions(-)
 rename meta/recipes-devtools/qemu/{files => qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%)  rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%)  rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%)  delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb
meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch renamed from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch +0 -0
similarity index 100%
rename from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch
rename to meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch
meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch renamed from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch +0 -0
similarity index 100%
rename from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch
rename to meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch
meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch renamed from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch +0 -0
similarity index 100%
rename from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch
rename to meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch
meta/recipes-devtools/qemu/qemu_git.bb deleted +0 -15
deleted file mode 100644
index a30932a..0000000
@@ -1,15 +0,0 @@
-require qemu.inc
-
-SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8"
-
-LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \
-                    file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913"
-
-PV = "1.3.0+git${SRCPV}"
-
-SRC_URI_prepend = "git://git.qemu.org/qemu.git"
-S = "${WORKDIR}/git"
-
-DEFAULT_PREFERENCE = "-1"
-
-COMPATIBLE_HOST_class-target_mips64 = "null"

--
1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#7 lore raw

Re: [PATCH 3/3] qemu_git.bb: remove it

Quoted 4 lines · Cristian

Hi Robert,

Hmm,
Qemu git recipe is useful, and is close to being up to date, why to remove it??

Close to being up to date? Aren't you talking about ./meta/recipes-devtools/qemu/qemu_2.4.0-rc2.bb?

bitbake@jama:/OE/webos/ow/oe-core$ find . -name qemu\*bb -exec grep
PV.*= {} \;
REALPV = "2.4.0-rc2"
PV = "2.3.99+${REALPV}"
PV = "1.3.0+git${SRCPV}"

As Robert said, 1.3 version is old and current qemu_git recipe broken, because 04024dea2674861fcf13582a77b58130c67fccd8 isn't in master branch anymore after it was moved to stable-1.3 branch:

bitbake@jama:/OE/projects/qemu$ git branch -a --contains 04024dea2674861fcf13582a77b58130c67fccd8
  remotes/origin/stable-1.3
Quoted 2 lines

Qemu brakes quite often, as seen recently on autobuilders, building from git allowed us to move forward (although it is true that the git upgrade was not integrated into master.) I vote against this patch.

Regards,

Quoted 73 lines

Thanks,
Cristian

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Robert Yang
Sent: Tuesday, July 28, 2015 12:05 PM
To: [email protected]
Subject: [OE-core] [PATCH 3/3] qemu_git.bb: remove it

Remove it since we have 2.4.0, the git version is 1.3 can't be built by
deafult:
ERROR: Fetcher failure: Unable to find revision 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from upstream

We can fix it, but seems that no one uses it any more.

And move patches from "files" dir to "qemu" dir.

---
 ...-Arm-versatilepb-Add-memory-size-checking.patch |    0
 .../exclude-some-arm-EABI-obsolete-syscalls.patch  |    0
 .../qemu-enlarge-env-entry-size.patch              |    0
 meta/recipes-devtools/qemu/qemu_git.bb             |   15 ---------------
 4 files changed, 15 deletions(-)
 rename meta/recipes-devtools/qemu/{files => qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%)  rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%)  rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%)  delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb
meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch renamed from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch +0 -0
similarity index 100%
rename from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch
rename to meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch
meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch renamed from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch +0 -0
similarity index 100%
rename from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch
rename to meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch
meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch renamed from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch +0 -0
similarity index 100%
rename from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch
rename to meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch
meta/recipes-devtools/qemu/qemu_git.bb deleted +0 -16
deleted file mode 100644
index a30932a..0000000
@@ -1,15 +0,0 @@
-require qemu.inc
-
-SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8"
-
-LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \
-                    file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913"
-
-PV = "1.3.0+git${SRCPV}"
-
-SRC_URI_prepend = "git://git.qemu.org/qemu.git"
-S = "${WORKDIR}/git"
-
-DEFAULT_PREFERENCE = "-1"
-
-COMPATIBLE_HOST_class-target_mips64 = "null"
--

1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 4 lines
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#8 lore raw

Re: [PATCH 3/3] qemu_git.bb: remove it

Quoted 9 lines · Martin Jansa

Close to being up to date? Aren't you talking about ./meta/recipes-devtools/qemu/qemu_2.4.0-rc2.bb?

bitbake@jama:/OE/webos/ow/oe-core$ find . -name qemu\*bb -exec grep
PV.*= {} \;
REALPV = "2.4.0-rc2"
PV = "2.3.99+${REALPV}"
PV = "1.3.0+git${SRCPV}"
Quoted 4 lines

As Robert said, 1.3 version is old and current qemu_git recipe broken, because 04024dea2674861fcf13582a77b58130c67fccd8 isn't in master branch anymore after it was moved to stable-1.3 branch:

For local testing it's not exactly rocket science to set SRC_URI and S in a bbappend. _git recipes are fine *if they're actively used* but when they sit around and bitrot, what's the point?

Ross

#9 lore raw

Re: [PATCH 3/3] qemu_git.bb: remove it

In reply to Martin Jansa

I am not in the habit of talking without knowing. Usually.
There might be exceptions. This is not one.
That being said, I was able to switch to qemu git recipe (instead of the tarball releases) and make it work for a git head just before 2.4.0RC0 in under 20 minutes. The patch was not submitted for inclusion into master however.
I am not sure why the git recipe bothers everyone that much in this specific case, when I just explained that it was quite useful for me (and by extension, to the project). Thanks,
Cristian

-----Original Message-----
From: Martin Jansa [mailto:[email protected]]
Sent: Tuesday, July 28, 2015 5:16 PM
To: Iorga, Cristian
Cc: Yang, Liezhi (Wind River); [email protected]
Subject: Re: [OE-core] [PATCH 3/3] qemu_git.bb: remove it

Quoted 4 lines · Cristian

Hi Robert,

Hmm,
Qemu git recipe is useful, and is close to being up to date, why to remove it??

Close to being up to date? Aren't you talking about ./meta/recipes-devtools/qemu/qemu_2.4.0-rc2.bb?

bitbake@jama:/OE/webos/ow/oe-core$ find . -name qemu\*bb -exec grep PV.*= {} \; REALPV = "2.4.0-rc2"
PV = "2.3.99+${REALPV}"
PV = "1.3.0+git${SRCPV}"

As Robert said, 1.3 version is old and current qemu_git recipe broken, because 04024dea2674861fcf13582a77b58130c67fccd8 isn't in master branch anymore after it was moved to stable-1.3 branch:

bitbake@jama:/OE/projects/qemu$ git branch -a --contains 04024dea2674861fcf13582a77b58130c67fccd8
  remotes/origin/stable-1.3
Quoted 2 lines

Qemu brakes quite often, as seen recently on autobuilders, building
from git allowed us to move forward (although it is true that the git upgrade was not integrated into master.) I vote against this patch.

Regards,

Quoted 101 lines

Thanks,
Cristian

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Robert Yang
Sent: Tuesday, July 28, 2015 12:05 PM
To: [email protected]
Subject: [OE-core] [PATCH 3/3] qemu_git.bb: remove it

Remove it since we have 2.4.0, the git version is 1.3 can't be built by
deafult:
ERROR: Fetcher failure: Unable to find revision 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from upstream

We can fix it, but seems that no one uses it any more.

And move patches from "files" dir to "qemu" dir.

---
 ...-Arm-versatilepb-Add-memory-size-checking.patch |    0
 .../exclude-some-arm-EABI-obsolete-syscalls.patch  |    0
 .../qemu-enlarge-env-entry-size.patch              |    0
 meta/recipes-devtools/qemu/qemu_git.bb             |   15 ---------------
 4 files changed, 15 deletions(-)
 rename meta/recipes-devtools/qemu/{files => 

qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%) rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%) rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%) delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb

(quoted diff) +0 -0

a/meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-siz e-checking.patch b/meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size -checking.patch
similarity index 100%
rename from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size- checking.patch rename to meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-c hecking.patch diff --git a/meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-sysc alls.patch b/meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-sysca lls.patch
similarity index 100%
rename from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscal ls.patch rename to meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscall s.patch diff --git a/meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch b/meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch similarity index 100%
rename from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch rename to meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch

meta/recipes-devtools/qemu/qemu_git.bb deleted +0 -16
deleted file mode 100644
index a30932a..0000000
@@ -1,15 +0,0 @@
-require qemu.inc
-
-SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8"
-
-LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \
-                    file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913"
-
-PV = "1.3.0+git${SRCPV}"
-
-SRC_URI_prepend = "git://git.qemu.org/qemu.git"
-S = "${WORKDIR}/git"
-
-DEFAULT_PREFERENCE = "-1"
-
-COMPATIBLE_HOST_class-target_mips64 = "null"
--

1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#10 lore raw

Re: [PATCH 3/3] qemu_git.bb: remove it

Quoted 5 lines · Cristian

I am not in the habit of talking without knowing. Usually.
There might be exceptions. This is not one.
That being said, I was able to switch to qemu git recipe (instead of the tarball releases) and make it work for a git head just before 2.4.0RC0 in under 20 minutes. The patch was not submitted for inclusion into master however.
I am not sure why the git recipe bothers everyone that much in this specific case, when I just explained that it was quite useful for me (and by extension, to the project).

Hi Cristian,

The problem is that it is broken, we need try to avoid shipping broken recipes to confuse the end user, you can fix it to make it work, but qemu 1.3 and 2.4 have different configure options, you will get warnings about unknown configure options, so you need move a few PACKAGECONFIGs from qemu.inc to qemu_2.4.bb to fix the warnings, that seems not worth, so I removed it, if you do like qemu_git.bb recipes, I think that you can upgrade it to 2.4.0-rc2 and replace qemu_2.4.0-rc2.bb.

// Robert

Quoted 137 lines

Thanks,
Cristian

-----Original Message-----
From: Martin Jansa [mailto:[email protected]]
Sent: Tuesday, July 28, 2015 5:16 PM
To: Iorga, Cristian
Cc: Yang, Liezhi (Wind River); [email protected]
Subject: Re: [OE-core] [PATCH 3/3] qemu_git.bb: remove it

Quoted 4 lines · Cristian

Hi Robert,

Hmm,
Qemu git recipe is useful, and is close to being up to date, why to remove it??

Close to being up to date? Aren't you talking about ./meta/recipes-devtools/qemu/qemu_2.4.0-rc2.bb?

bitbake@jama:/OE/webos/ow/oe-core$ find . -name qemu\*bb -exec grep PV.*= {} \; REALPV = "2.4.0-rc2"
PV = "2.3.99+${REALPV}"
PV = "1.3.0+git${SRCPV}"

As Robert said, 1.3 version is old and current qemu_git recipe broken, because 04024dea2674861fcf13582a77b58130c67fccd8 isn't in master branch anymore after it was moved to stable-1.3 branch:

bitbake@jama:/OE/projects/qemu$ git branch -a --contains 04024dea2674861fcf13582a77b58130c67fccd8
   remotes/origin/stable-1.3
Quoted 2 lines

Qemu brakes quite often, as seen recently on autobuilders, building
from git allowed us to move forward (although it is true that the git upgrade was not integrated into master.) I vote against this patch.

Regards,

Quoted 91 lines

Thanks,
Cristian

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Robert Yang
Sent: Tuesday, July 28, 2015 12:05 PM
To: [email protected]
Subject: [OE-core] [PATCH 3/3] qemu_git.bb: remove it

Remove it since we have 2.4.0, the git version is 1.3 can't be built by
deafult:
ERROR: Fetcher failure: Unable to find revision 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from upstream

We can fix it, but seems that no one uses it any more.

And move patches from "files" dir to "qemu" dir.

---
  ...-Arm-versatilepb-Add-memory-size-checking.patch |    0
  .../exclude-some-arm-EABI-obsolete-syscalls.patch  |    0
  .../qemu-enlarge-env-entry-size.patch              |    0
  meta/recipes-devtools/qemu/qemu_git.bb             |   15 ---------------
  4 files changed, 15 deletions(-)

rename meta/recipes-devtools/qemu/{files =>
qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%) rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%) rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%) delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb

diff --git a/meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-siz e-checking.patch b/meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size -checking.patch
similarity index 100%
rename from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size- checking.patch rename to meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-c hecking.patch diff --git a/meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-sysc alls.patch b/meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-sysca lls.patch
similarity index 100%
rename from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscal ls.patch rename to meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscall s.patch diff --git a/meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch b/meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch similarity index 100%
rename from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch rename to meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch

meta/recipes-devtools/qemu/qemu_git.bb deleted +0 -16
deleted file mode 100644
index a30932a..0000000
@@ -1,15 +0,0 @@
-require qemu.inc
-
-SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8"
-
-LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \
-                    file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913"
-
-PV = "1.3.0+git${SRCPV}"
-
-SRC_URI_prepend = "git://git.qemu.org/qemu.git"
-S = "${WORKDIR}/git"
-
-DEFAULT_PREFERENCE = "-1"
-
-COMPATIBLE_HOST_class-target_mips64 = "null"
--

1.7.9.5

Quoted 10 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
Martin 'JaMa' Jansa jabber: [email protected]