Skip to contentSkip to conversation

glibc: use cross-rpcgen to replace host's rpcgen

PATCH In review Robert Yang 2 participants 3 messages Aug 19, 2015

lore
Share & tools
lore
#0 lore raw

cover glibc: use cross-rpcgen to replace host's rpcgen

The following changes since commit 059db140885bad379534e6ec713f3ceb4e18faea:

adt-installer: use DEPLOY_DIR in ANT_DEPLOY expansion (2015-08-16 17:28:14 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/glibc
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/glibc

Robert Yang (1):
glibc: use cross-rpcgen to replace host's rpcgen

 meta/recipes-core/glibc/glibc_2.22.bb |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 glibc: use cross-rpcgen to replace host's rpcgen

There might be unexpected errors when use host's rpcgen.

[YOCTO #8181]

---
 meta/recipes-core/glibc/glibc_2.22.bb |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
meta/recipes-core/glibc/glibc_2.22.bb +1 -5
index 6aaf722..f0e1fad 100644
@@ -97,10 +97,6 @@ do_configure () {
 # calls for now
 # don't pass CPPFLAGS into configure, since it upsets the kernel-headers
 # version check and doesn't really help with anything
-        if [ -z "`which rpcgen`" ]; then
-                echo "rpcgen not found.  Install glibc-devel."
-                exit 1
-        fi
         (cd ${S} && gnu-configize) || die "failure in running gnu-configize"
         find ${S} -name "configure" | xargs touch
         CPPFLAGS="" oe_runconf
@@ -119,7 +115,7 @@ do_compile () {
 		for r in ${rpcsvc}; do
 			h=`echo $r|sed -e's,\.x$,.h,'`
 			rm -f $h
-			rpcgen -h $r -o $h || bbwarn "${PN}: unable to generate header for $r"
+			${B}/sunrpc/cross-rpcgen -h $r -o $h || bbwarn "${PN}: unable to generate header for $r"
 		done
 	)
 	echo "Adjust ldd script"
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 4 lines · Robert Yang

There might be unexpected errors when use host's rpcgen.

[YOCTO #8181]

This is fine

Review

Quoted 7 lines
---
 meta/recipes-core/glibc/glibc_2.22.bb |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
(quoted diff) +0 -0

b/meta/recipes-core/glibc/glibc_2.22.bb

meta/recipes-core/glibc/glibc_2.22.bb do_configure () { · line 100

Quoted 12 lines

index 6aaf722..f0e1fad 100644

meta/recipes-core/glibc/glibc_2.22.bb +0 -4
@@ -97,10 +97,6 @@ do_configure () {
 # calls for now
 # don't pass CPPFLAGS into configure, since it upsets the kernel-headers
 # version check and doesn't really help with anything
-        if [ -z "`which rpcgen`" ]; then
-                echo "rpcgen not found.  Install glibc-devel."
-                exit 1
-        fi
         (cd ${S} && gnu-configize) || die "failure in running

gnu-configize"

meta/recipes-core/glibc/glibc_2.22.bb do_compile () { · line 122

Quoted 7 lines
meta/recipes-core/glibc/glibc_2.22.bb +0 -1
         find ${S} -name "configure" | xargs touch
         CPPFLAGS="" oe_runconf
@@ -119,7 +115,7 @@ do_compile () {
                for r in ${rpcsvc}; do
                        h=`echo $r|sed -e's,\.x$,.h,'`
                        rm -f $h
-                       rpcgen -h $r -o $h || bbwarn "${PN}: unable to

generate header for $r"

meta/recipes-core/glibc/glibc_2.22.bb do_compile () { · line 118

Quoted 1 line
meta/recipes-core/glibc/glibc_2.22.bb +1 -0
+                       ${B}/sunrpc/cross-rpcgen -h $r -o $h || bbwarn

"${PN}: unable to generate header for $r"

Quoted 11 lines
meta/recipes-core/glibc/glibc_2.22.bb +0 -1
                done
        )
        echo "Adjust ldd script"
--

1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core