Skip to contentSkip to conversation

Fix for issue thrown up by devtool QA test

PATCH New Paul Eggleton 1 participant 2 messages Aug 28, 2015

lore
Share & tools
lore
#0 lore raw

cover Fix for issue thrown up by devtool QA test

The following changes since commit f07045fcae859c902434062d1725f1348f42d1dd:

oeqa/oetest.py: add better package search for hasPackage() (2015-08-26 08:26:37 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib paule/patchfix
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/patchfix

Paul Eggleton (1):
lib/oe/patch: handle patches that delete files with older git

 meta/lib/oe/patch.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 lib/oe/patch: handle patches that delete files with older git

When running "git add" on a directory with older git versions, deleted files aren't added to what is to be committed unless you explicitly specify the -A option. The result of this is that when applying a patch from a recipe which doesn't apply with "git am" (and we fall back to applying the patch through other means then "git add" following by a "git commit") these deletes weren't committed with the patch, leaving them sitting deleted but not committed at the end.

This should fix test_devtool_modify_native (which unwittingly exercises this scenario by attempting to run "devtool modify" on apt-native) on machines with older git versions.

---
 meta/lib/oe/patch.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/patch.py +1 -1
index c4f042d..108bf1d 100644
@@ -415,7 +415,7 @@ class GitApplyTree(PatchTree):
                     # Fall back to patch
                     output = PatchTree._applypatch(self, patch, force, reverse, run)
                 # Add all files
-                shellcmd = ["git", "add", "-f", "."]
+                shellcmd = ["git", "add", "-f", "-A", "."]
                 output += runcmd(["sh", "-c", " ".join(shellcmd)], self.dir)
                 # Exclude the patches directory
                 shellcmd = ["git", "reset", "HEAD", self.patchdir]
Signature · 1 line
2.1.0