Skip to contentSkip to conversation

any day now: pseudo 1.7, really

PATCH In review Peter Seebach 2 participants 3 messages Sep 4, 2015 – Sep 7, 2015

lore
Share & tools
lore
#0 lore raw

cover any day now: pseudo 1.7, really

So there was a bogus argument on an fchmodat(), which resulted in mkdirat() being able to set errno on success, and glibc's localedef errors out if errno is set even if it has already confirmed that the operation was successful. But it is not *intended* that I set errno even on success, so that's fixed now.

Tarball sent to RP/halstead, may not be on server yet. I left the branch name alone because I am gradually slipping into despair and anguish and updating branch names no longer seems like it will help slow down the universe's gradual decline into entropy.

The following changes since commit aba3ef50d65e0dc8659a48bf98d0fb00dd44a6fc:

debianutils: create package for run-parts (2015-09-02 23:51:16 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib seebs/pseudo172
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/pseudo172

Peter Seebach (1):
pseudo_1.7.3.bb: New version of pseudo

 meta/recipes-devtools/pseudo/pseudo_1.7.3.bb | 19 +++++++++++++++++++
 meta/recipes-devtools/pseudo/pseudo_git.bb   |  4 ++--
 2 files changed, 21 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-devtools/pseudo/pseudo_1.7.3.bb
Signature · 1 line
2.3.1
#1 lore raw

PATCH 1/1 pseudo_1.7.3.bb: New version of pseudo

Pseudo 1.7 adds an experimental feature (which I think needs more testing before it becomes the default) allowing the pseudo client to store modes and uid/gid values in extended attributes rather than using the sqlite database. On most Linux-like systems, this works only if the underlying file is a plain file or a directory.

Also added is a profiling feature to allow some amount of reporting on the wall-clock time the client spends in wrappers, processing operations, or in IPC. This feature is not intendeded to be precisely accurate, but gives a good overview of where time is going.

Based on the results from the profiling feature, the client now suppresses OP_OPEN and OP_EXEC messages if the server is not logging messages, and no longer uses constant dynamic allocation and free cycles for canonicalized paths.

There's a few other likely-looking optimizations being considered, but this seemed like a good cutoff for now.

1.7.1 fixes two bugs, one affecting mostly XFS systems with 64-bit inode values, and one affecting code that called realpath(x, NULL), such as the RPM backend.

1.7.2 fixes an indirect side-effect of the chmod fixes to deal with umask 0700, which had no effect with opkg 0.2.4 but appears to cause failures with 0.3.0.

1.7.3 prevents mkdirat() (and mkfifoat()) from setting errno on success, because glibc's localedef inexplicably errors out if errno was set, even if the operation's actual return code (which it tests) indicated success.

---
 meta/recipes-devtools/pseudo/pseudo_1.7.3.bb | 19 +++++++++++++++++++
 meta/recipes-devtools/pseudo/pseudo_git.bb   |  4 ++--
 2 files changed, 21 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-devtools/pseudo/pseudo_1.7.3.bb
meta/recipes-devtools/pseudo/pseudo_1.7.3.bb new file +19 -0
new file mode 100644
index 0000000..1e9ef3b
@@ -0,0 +1,19 @@
+require pseudo.inc
+
+SRC_URI = " \
+    http://downloads.yoctoproject.org/releases/pseudo/${BPN}-${PV}.tar.bz2 \
+    file://fallback-passwd \
+    file://fallback-group \
+"
+
+SRC_URI[md5sum] = "2bd0a44eadd4713e90ad8c152eea77aa"
+SRC_URI[sha256sum] = "e9fc3922f8feb97839b50d14eb1987afdc8f22cdcac93119323cccd5f8444652"
+
+PSEUDO_EXTRA_OPTS ?= "--enable-force-async --without-passwd-fallback"
+
+do_install_append_class-native () {
+	install -d ${D}${sysconfdir}
+	# The fallback files should never be modified
+	install -m 444 ${WORKDIR}/fallback-passwd ${D}${sysconfdir}/passwd
+	install -m 444 ${WORKDIR}/fallback-group ${D}${sysconfdir}/group
+}
meta/recipes-devtools/pseudo/pseudo_git.bb +2 -2
index aa315d3..31e1223 100644
@@ -1,7 +1,7 @@
 require pseudo.inc
 
-SRCREV = "db758fb11167c79d9682a17d359568e2a3c4acd5"
-PV = "1.6.5+git${SRCPV}"
+SRCREV = "e795df44a90a426a76b790f1b2774f3046a8fc31"
+PV = "1.7.2+git${SRCPV}"
 
 DEFAULT_PREFERENCE = "-1"
 
Signature · 1 line
2.3.1
#2 lore raw

Re: [PATCH 1/1] pseudo_1.7.3.bb: New version of pseudo

Quoted 23 lines · Peter Seebach

Pseudo 1.7 adds an experimental feature (which I think needs more testing before it becomes the default) allowing the pseudo client to store modes and uid/gid values in extended attributes rather than using the sqlite database. On most Linux-like systems, this works only if the underlying file is a plain file or a directory.

Also added is a profiling feature to allow some amount of reporting on the wall-clock time the client spends in wrappers, processing operations, or in IPC. This feature is not intendeded to be precisely accurate, but gives a good overview of where time is going.

Based on the results from the profiling feature, the client now suppresses OP_OPEN and OP_EXEC messages if the server is not logging messages, and no longer uses constant dynamic allocation and free cycles for canonicalized paths.

There's a few other likely-looking optimizations being considered, but this seemed like a good cutoff for now.

1.7.1 fixes two bugs, one affecting mostly XFS systems with 64-bit inode values, and one affecting code that called realpath(x, NULL), such as the RPM backend.

Quoted 8 lines

1.7.2 fixes an indirect side-effect of the chmod fixes to deal with umask 0700, which had no effect with opkg 0.2.4 but appears to cause failures with 0.3.0.

1.7.3 prevents mkdirat() (and mkfifoat()) from setting errno on success, because glibc's localedef inexplicably errors out if errno was set, even if the operation's actual return code (which it tests) indicated success.

We finally got there, I merged this one after it passed the tests!

Cheers,

Richard