Upgrade gdk-pixbuf from 2.30.8 to 2.31.7
cover Upgrade gdk-pixbuf from 2.30.8 to 2.31.7
From: Kai Kang <[email protected]>
The following changes since commit c1df471feacaf2590216aa476ce242908dac38cf:
pseudo_1.7.3.bb: New version of pseudo (2015-09-06 15:26:27 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib kangkai/gdk-pixbuf
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/gdk-pixbuf
Kai Kang (1):
gdk-pixbuf: 2.30.8 -> 2.31.7
...ps-Be-more-careful-about-integer-overflow.patch | 89 ----------------------
.../{gdk-pixbuf_2.30.8.bb => gdk-pixbuf_2.31.7.bb} | 5 +-
2 files changed, 2 insertions(+), 92 deletions(-)
delete mode 100644 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf/0001-pixops-Be-more-careful-about-integer-overflow.patch
rename meta/recipes-gnome/gdk-pixbuf/{gdk-pixbuf_2.30.8.bb => gdk-pixbuf_2.31.7.bb} (93%)Signature · 1 line
1.9.1
PATCH 1/1 gdk-pixbuf: 2.30.8 -> 2.31.7
From: Kai Kang <[email protected]>
* drop backport patch
---
...ps-Be-more-careful-about-integer-overflow.patch | 89 ----------------------
.../{gdk-pixbuf_2.30.8.bb => gdk-pixbuf_2.31.7.bb} | 5 +-
2 files changed, 2 insertions(+), 92 deletions(-)
delete mode 100644 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf/0001-pixops-Be-more-careful-about-integer-overflow.patch
rename meta/recipes-gnome/gdk-pixbuf/{gdk-pixbuf_2.30.8.bb => gdk-pixbuf_2.31.7.bb} (93%)meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf/0001-pixops-Be-more-careful-about-integer-overflow.patch deleted +0 -89
@@ -1,89 +0,0 @@ -From ffec86ed5010c5a2be14f47b33bcf4ed3169a199 Mon Sep 17 00:00:00 2001 -From: Matthias Clasen <[email protected]> -Date: Mon, 13 Jul 2015 00:33:40 -0400 -Subject: [PATCH] pixops: Be more careful about integer overflow - -Our loader code is supposed to handle out-of-memory and overflow -situations gracefully, reporting errors instead of aborting. But -if you load an image at a specific size, we also execute our -scaling code, which was not careful enough about overflow in some -places. - -This commit makes the scaling code silently return if it fails to -allocate filter tables. This is the best we can do, since -gdk_pixbuf_scale() is not taking a GError. - -https://bugzilla.gnome.org/show_bug.cgi?id=752297 - -Upstream-Status: backport - -Signed-off-by: Li Zhou <[email protected]> ---- - gdk-pixbuf/pixops/pixops.c | 22 +++++++++++++++++----- - 1 file changed, 17 insertions(+), 5 deletions(-) - -diff --git a/gdk-pixbuf/pixops/pixops.c b/gdk-pixbuf/pixops/pixops.c -index 29a1c14..ce51745 100644 ---- a/gdk-pixbuf/pixops/pixops.c -+++ b/gdk-pixbuf/pixops/pixops.c -@@ -1272,7 +1272,16 @@ make_filter_table (PixopsFilter *filter) - int i_offset, j_offset; - int n_x = filter->x.n; - int n_y = filter->y.n; -- int *weights = g_new (int, SUBSAMPLE * SUBSAMPLE * n_x * n_y); -+ gsize n_weights; -+ int *weights; -+ -+ n_weights = SUBSAMPLE * SUBSAMPLE * n_x * n_y; -+ if (n_weights / (SUBSAMPLE * SUBSAMPLE * n_x) != n_y) -+ return NULL; /* overflow, bail */ -+ -+ weights = g_try_new (int, n_weights); -+ if (!weights) -+ return NULL; /* overflow, bail */ - - for (i_offset=0; i_offset < SUBSAMPLE; i_offset++) - for (j_offset=0; j_offset < SUBSAMPLE; j_offset++) -@@ -1347,8 +1356,11 @@ pixops_process (guchar *dest_buf, - if (x_step == 0 || y_step == 0) - return; /* overflow, bail out */ - -- line_bufs = g_new (guchar *, filter->y.n); - filter_weights = make_filter_table (filter); -+ if (!filter_weights) -+ return; /* overflow, bail out */ -+ -+ line_bufs = g_new (guchar *, filter->y.n); - - check_shift = check_size ? get_check_shift (check_size) : 0; - -@@ -1468,7 +1480,7 @@ tile_make_weights (PixopsFilterDimension *dim, - double scale) - { - int n = ceil (1 / scale + 1); -- double *pixel_weights = g_new (double, SUBSAMPLE * n); -+ double *pixel_weights = g_malloc_n (sizeof (double) * SUBSAMPLE, n); - int offset; - int i; - -@@ -1526,7 +1538,7 @@ bilinear_magnify_make_weights (PixopsFilterDimension *dim, - } - - dim->n = n; -- dim->weights = g_new (double, SUBSAMPLE * n); -+ dim->weights = g_malloc_n (sizeof (double) * SUBSAMPLE, n); - - pixel_weights = dim->weights; - -@@ -1617,7 +1629,7 @@ bilinear_box_make_weights (PixopsFilterDimension *dim, - double scale) - { - int n = ceil (1/scale + 3.0); -- double *pixel_weights = g_new (double, SUBSAMPLE * n); -+ double *pixel_weights = g_malloc_n (sizeof (double) * SUBSAMPLE, n); - double w; - int offset, i; - --- -1.7.9.5 -
meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.31.7.bb renamed from meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.30.8.bb +2 -3
@@ -18,11 +18,10 @@ SRC_URI = "${GNOME_MIRROR}/${BPN}/${MAJ_VER}/${BPN}-${PV}.tar.xz \ file://extending-libinstall-dependencies.patch \ file://run-ptest \ file://fatal-loader.patch \ - file://0001-pixops-Be-more-careful-about-integer-overflow.patch \ " -SRC_URI[md5sum] = "4fed0d54432f1b69fc6e66e608bd5542" -SRC_URI[sha256sum] = "4853830616113db4435837992c0aebd94cbb993c44dc55063cee7f72a7bef8be" +SRC_URI[md5sum] = "8a42218ed76a75e38dc737c0c5d30190" +SRC_URI[sha256sum] = "4736e009168857ce8bb19291f0887c1dc6551cbc3c46d5ffcd034e133e4fd610" inherit autotools pkgconfig gettext pixbufcache ptest-gnome
Signature · 1 line
1.9.1
Re: [PATCH 1/1] gdk-pixbuf: 2.30.8 -> 2.31.7
Quoted 4 lines · On 8 September 2015 at 11:05, <[email protected]> wrote:
From: Kai Kang <[email protected]>
* drop backport patch
gdk-pixbuf is a GNOME project, so odd-minor-versions are development releases and we won't be merging this. If there's a particular fix you want integrated, please backport it.
Ross
Re: [PATCH 1/1] gdk-pixbuf: 2.30.8 -> 2.31.7
Quoted 10 lines · Ross
On 8 September 2015 at 11:05, <[email protected] <mailto:[email protected]>> wrote:
From: Kai Kang <[email protected]
<mailto:[email protected]>>* drop backport patch
gdk-pixbuf is a GNOME project, so odd-minor-versions are development releases and we won't be merging this. If there's a particular fix you want integrated, please backport it.
OK. Thanks.
--Kai
Quoted 2 lines
Ross
Signature · 2 lines
Regards, Neil | Kai Kang