Skip to contentSkip to conversation

toaster:cleanup buildelete command

PATCH In review brian avery 2 participants 3 messages Sep 10, 2015 – Sep 14, 2015

lore
Share & tools
lore
#0 lore raw

cover toaster:cleanup buildelete command

This patch cleans up the multiple build delete. It:
1) skips build id's that don't exist rather than giving a traceback.
2) let you pass in the ids as a space separated list
3) fixes the usage to match the space separated list format

this comand is accessed by doing something like:
poky/bitbake/lib/toaster/manage.py builddelete 1 99 2

[YOCTO #7726]

The following changes since commit d4585fa23d56a58c583ee33db067a23177a936b1:

bsps: update 3.14 SRCREVs (2015-09-09 14:27:57 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib bavery/cleanup-builddelete
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=bavery/cleanup-builddelete

brian avery (1):
bitbake: toaster: delete multiple builds cleanup

 .../toaster/toastermain/management/commands/builddelete.py  | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 bitbake: toaster: delete multiple builds cleanup

This patch cleans up the multiple delete. It:
1) skips build id's that don't exist rather than giving a traceback.
2) let you pass in the ids as a space separated list
3) fixes the usage to match the space separated list format

[YOCTO #7726]

---
 .../toaster/toastermain/management/commands/builddelete.py  | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)
bitbake/lib/toaster/toastermain/management/commands/builddelete.py +9 -4
index 343d311..ff93e54 100644
@@ -1,4 +1,5 @@
 from django.core.management.base import BaseCommand, CommandError
+from django.core.exceptions import ObjectDoesNotExist
 from orm.models import Build
 from django.db import OperationalError
 import os
@@ -6,12 +7,16 @@ import os
 
 
 class Command(BaseCommand):
-    args    = "buildId"
+    args    = '<buildID1 buildID2 .....>'
     help    = "Deletes selected build(s)"
 
-    def handle(self, buildId, *args, **options):
-        for bid in buildId.split(","):
-            b = Build.objects.get(pk = bid)
+    def handle(self, *args, **options):
+        for bid in args:
+            try:
+                b = Build.objects.get(pk = bid)
+            except ObjectDoesNotExist:
+                print 'build %s does not exist, skipping...' %(bid)
+                continue
             # theoretically, just b.delete() would suffice
             # however SQLite runs into problems when you try to
             # delete too many rows at once, so we delete some direct
Signature · 1 line
1.9.1
#2 lore raw

Re: [PATCH 1/1] bitbake: toaster: delete multiple builds cleanup

Looks OK to me, I'll submit it.

Elliot

Quoted 55 lines · brian avery

This patch cleans up the multiple delete. It:
1) skips build id's that don't exist rather than giving a traceback.
2) let you pass in the ids as a space separated list
3) fixes the usage to match the space separated list format

[YOCTO #7726]

---
 .../toaster/toastermain/management/commands/builddelete.py  | 13
+++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/bitbake/lib/toaster/toastermain/management/commands/builddelete.py b/bitbake/lib/toaster/toastermain/management/commands/builddelete.py index 343d311..ff93e54 100644

bitbake/lib/toaster/toastermain/management/commands/builddelete.py +9 -5
@@ -1,4 +1,5 @@
 from django.core.management.base import BaseCommand, CommandError
+from django.core.exceptions import ObjectDoesNotExist
 from orm.models import Build
 from django.db import OperationalError
 import os
@@ -6,12 +7,16 @@ import os
 
 
 class Command(BaseCommand):
-    args    = "buildId"
+    args    = '<buildID1 buildID2 .....>'
     help    = "Deletes selected build(s)"
 
-    def handle(self, buildId, *args, **options):
-        for bid in buildId.split(","):
-            b = Build.objects.get(pk = bid)
+    def handle(self, *args, **options):
+        for bid in args:
+            try:
+                b = Build.objects.get(pk = bid)
+            except ObjectDoesNotExist:
+                print 'build %s does not exist, skipping...' %(bid)
+                continue
             # theoretically, just b.delete() would suffice
             # however SQLite runs into problems when you try to
             # delete too many rows at once, so we delete some direct
--

1.9.1

--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Signature · 3 lines
Elliot Smith
Software Engineer
Intel Open Source Technology Centre