Skip to contentSkip to conversation

Add a dummy pointercal calibration for qemu

PATCH NAK Jussi Kukkonen 3 participants 6 messages Sep 17, 2015

lore
Share & tools
lore
#0 lore raw

cover Add a dummy pointercal calibration for qemu

xinput_calibrator keeps popping up on every boot (or session start) when testing Sato image on qemu: This seems to be because qemu emulates a tablet and is made worse by xinput_calibrator not actually being able to write xinput files for xorg drivers, so the problem persists on following boots.

The patch adds a dummy calibration file for "qemuall". I wasn't sure how this should be done so let me know if there's a better solution.

- Jussi

The following changes since commit ea562de57590c966cd5a75fda8defecd397e6436:

qemu: Update to upstream patches (2015-09-14 20:46:40 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib jku/pointercal-xinput
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/pointercal-xinput

Jussi Kukkonen (1):
xinput-calibrator: Add a dummy calibration file for qemu

 .../xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput      | 2 ++
 meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb    | 6 ++++++
 2 files changed, 8 insertions(+)
 create mode 100644 meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 xinput-calibrator: Add a dummy calibration file for qemu

This prevents xinput_calibrator from popping up on every boot in qemu.

---
 .../xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput      | 2 ++
 meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb    | 6 ++++++
 2 files changed, 8 insertions(+)
 create mode 100644 meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput
meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput new file +2 -0
new file mode 100644
index 0000000..a816d6d
@@ -0,0 +1,2 @@
+# Dummy pointercal.xinput file to prevent xinput_calibrator
+# from running on qemu startup
meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb +6 -0
index 65348c3..cab3d14 100644
@@ -5,8 +5,14 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384
 PR = "r7"
 
 SRC_URI = "file://pointercal.xinput"
+SRC_URI_append_qemuall = " file://pointercal-qemu.xinput"
 S = "${WORKDIR}"
 
+do_install_prepend_qemuall () {
+    install -d ${D}${sysconfdir}/
+    install -m 0644 ${S}/pointercal-qemu.xinput ${D}${sysconfdir}/pointercal.xinput
+}
+
 do_install() {
     # Only install file if it has a contents
     if [ -s ${S}/pointercal.xinput ] &&\
Signature · 1 line
2.1.4
#2 lore raw

Re: [PATCH 1/1] xinput-calibrator: Add a dummy calibration file for qemu

Quoted 3 lines · Jussi Kukkonen

This prevents xinput_calibrator from popping up on every boot in qemu.

Why you don't provide a valid calibration for it instead?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw

Re: [PATCH 1/1] xinput-calibrator: Add a dummy calibration file for qemu

Quoted 8 lines · Otavio Salvador
Quoted 3 lines · Jussi Kukkonen

This prevents xinput_calibrator from popping up on every boot in qemu.

Why you don't provide a valid calibration for it instead?

xinput_calibrator does not actually work for xorg drivers: it fails to write the values in xinput format for xorg devices. I was planning on looking at that as well but since I know very little about these drivers I was going for the low hanging fruit first...

Also, Ross pointed out that I should just add the file into meta/recipes-graphics/xinput-calibrator/pointercal-xinput/qemuall/pointercal.xinput and then the recipe changes become unneeded.

Jussi

#4 lore raw

Re: [PATCH 1/1] xinput-calibrator: Add a dummy calibration file for qemu

Quoted 11 lines · Jussi Kukkonen
Quoted 8 lines · Otavio Salvador
Quoted 3 lines · Jussi Kukkonen

This prevents xinput_calibrator from popping up on every boot in qemu.

Why you don't provide a valid calibration for it instead?

Quoted 8 lines

xinput_calibrator does not actually work for xorg drivers: it fails to write the values in xinput format for xorg devices. I was planning on looking at that as well but since I know very little about these drivers I was going for the low hanging fruit first...

Also, Ross pointed out that I should just add the file into meta/recipes-graphics/xinput-calibrator/pointercal-xinput/qemuall/pointercal.xinput and then the recipe changes become unneeded.

This is a workaround, not a fix.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#5 lore raw

Re: [PATCH 1/1] xinput-calibrator: Add a dummy calibration file for qemu

In reply to Jussi Kukkonen
Quoted 15 lines · Jussi Kukkonen

This prevents xinput_calibrator from popping up on every boot in qemu.

---
 .../xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput      | 2 ++
 meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb    | 6 ++++++
 2 files changed, 8 insertions(+)
 create mode 100644 meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput
meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput new file +0 -0
new file mode 100644
index 0000000..a816d6d

meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput line 2

Quoted 2 lines
meta/recipes-graphics/xinput-calibrator/pointercal-xinput/pointercal-qemu.xinput new file +2 -0
@@ -0,0 +1,2 @@
+# Dummy pointercal.xinput file to prevent xinput_calibrator
+# from running on qemu startup

NAK

Just put this in qemuall subdirectory and don't change the recipe.

Quoted 27 lines
meta/recipes-graphics/xinput-calibrator/pointercal-xinput_0.0.bb +6 -0
index 65348c3..cab3d14 100644
@@ -5,8 +5,14 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384
 PR = "r7"
 
 SRC_URI = "file://pointercal.xinput"
+SRC_URI_append_qemuall = " file://pointercal-qemu.xinput"
 S = "${WORKDIR}"
 
+do_install_prepend_qemuall () {
+    install -d ${D}${sysconfdir}/
+    install -m 0644 ${S}/pointercal-qemu.xinput ${D}${sysconfdir}/pointercal.xinput
+}
+
 do_install() {
     # Only install file if it has a contents
     if [ -s ${S}/pointercal.xinput ] &&\
Signature · 7 lines
2.1.4

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]