Skip to contentSkip to conversation

Dynamic common utilities

PATCH Superseded Alejandro Joya 2 participants 6 messages Sep 18, 2015

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Dynamic common utilities

It provide a virtual reference for the common utilities.
it replace of the lock to busybox, it will be simple exchange between other common utilities like gnu core utils or toybox among others.

In order to enable its required to fill at the distro conf or local.conf

VIRTUAL-RUNTIME_login_manager ?= "busybox" PREFERRED_PROVIDER_virtual/base-utils?= "busybox" PREFERRED_RPROVIDER_virtual/base-utils?= "busybox" VIRTUAL-RUNTIME_base-utils?= "busybox" VIRTUAL-RUNTIME_base-utils-hwclock ?= "busybox-hwclock"

The following changes since commit 72682d72b52355c3fed947167ca3c6064340ead1:

  autotools.bbclass: mkdir ${B} -> mkdir -p ${B} (2015-09-16 22:17:19 +0100)

are available in the git repository at:

git://github.com/Ajoyacr/openembedded-core base-utils
https://github.com/Ajoyacr/openembedded-core/tree/base-utils

Alejandro Joya (3):
core-mage-minimal-initramfs: replace dependency initramfs-framework:add virtual reference packagegroup-core-boot:change to virtual reference

 meta/recipes-core/images/core-image-minimal-initramfs.bb   | 2 +-
 meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb | 2 +-
 meta/recipes-core/packagegroups/packagegroup-core-boot.bb  | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.1.0
#1 lore raw

PATCH v2 1/3 core-mage-minimal-initramfs: replace dependency

This recipe have a hardcoded dependency to busybox, in order to be able to have a flexible selection, instead of the hardcoded dependency,now is point to virtual reference.

---
 meta/recipes-core/images/core-image-minimal-initramfs.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/images/core-image-minimal-initramfs.bb +1 -1
index 1f0fa95..50eca53 100644
@@ -3,7 +3,7 @@ DESCRIPTION = "Small image capable of booting a device. The kernel includes \
 the Minimal RAM-based Initial Root Filesystem (initramfs), which finds the \
 first 'init' program more efficiently."
 
-PACKAGE_INSTALL = "initramfs-live-boot initramfs-live-install initramfs-live-install-efi busybox udev base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}"
+PACKAGE_INSTALL = "initramfs-live-boot initramfs-live-install initramfs-live-install-efi virtual/base-utils udev base-passwd ${ROOTFS_BOOTSTRAP_INSTALL}"
 
 # Do not pollute the initrd image with rootfs features
 IMAGE_FEATURES = ""
Signature · 1 line
2.1.0
#2 lore raw

PATCH v2 2/3 initramfs-framework:add virtual reference

In reply to Alejandro Joya

This recipe have a hardcoded dependency to busybox, in order to be able to have a flexible selection, instead of the hardcoded dependency,now is point to virtual reference base-utils.

---
 meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/initrdscripts/initramfs-framework_1.0.bb +1 -1
index 6c37b9a..5a6e254 100644
@@ -1,7 +1,7 @@
 SUMMARY = "Modular initramfs system"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-RDEPENDS_${PN} += "busybox"
+RDEPENDS_${PN} += "virtual/base-utils"
 
 PR = "r2"
 
Signature · 1 line
2.1.0
#3 lore raw

PATCH v2 3/3 packagegroup-core-boot:change to virtual reference

In reply to Alejandro Joya

This recipe have a hardcoded dependency to busybox, in order to be able to have a flexible selection, instead of the hardcoded dependency,now is point to virtual reference base-utils.

---
 meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
meta/recipes-core/packagegroups/packagegroup-core-boot.bb +3 -3
index 09f5373..38f29ce 100644
@@ -19,12 +19,12 @@ MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS ?= ""
 
 # Distro can override the following VIRTUAL-RUNTIME providers:
 VIRTUAL-RUNTIME_dev_manager ?= "udev"
-VIRTUAL-RUNTIME_login_manager ?= "busybox"
+VIRTUAL-RUNTIME_login_manager ?= "${VIRTUAL-RUNTIME_base-utils}"
 VIRTUAL-RUNTIME_init_manager ?= "sysvinit"
 VIRTUAL-RUNTIME_initscripts ?= "initscripts"
 VIRTUAL-RUNTIME_keymaps ?= "keymaps"
 
-SYSVINIT_SCRIPTS = "${@bb.utils.contains('MACHINE_FEATURES', 'rtc', 'busybox-hwclock', '', d)} \
+SYSVINIT_SCRIPTS = "${@bb.utils.contains('MACHINE_FEATURES', 'rtc', '${VIRTUAL-RUNTIME_base-utils-hwclock}', '', d)} \
                     modutils-initscripts \
                     init-ifupdown \
                     ${VIRTUAL-RUNTIME_initscripts} \
@@ -33,7 +33,7 @@ SYSVINIT_SCRIPTS = "${@bb.utils.contains('MACHINE_FEATURES', 'rtc', 'busybox-hwc
 RDEPENDS_${PN} = "\
     base-files \
     base-passwd \
-    busybox \
+    ${VIRTUAL-RUNTIME_base-utils} \
     ${@bb.utils.contains("DISTRO_FEATURES", "sysvinit", "${SYSVINIT_SCRIPTS}", "", d)} \
     ${@bb.utils.contains("MACHINE_FEATURES", "keyboard", "${VIRTUAL-RUNTIME_keymaps}", "", d)} \
     netbase \
Signature · 1 line
2.1.0
#4 lore raw
In reply to Alejandro Joya
Quoted 11 lines · Alejandro Joya

It provide a virtual reference for the common utilities.
it replace of the lock to busybox, it will be simple exchange between other common utilities like gnu core utils or toybox among others.

In order to enable its required to fill at the distro conf or local.conf

VIRTUAL-RUNTIME_login_manager ?= "busybox" PREFERRED_PROVIDER_virtual/base-utils?= "busybox" PREFERRED_RPROVIDER_virtual/base-utils?= "busybox" VIRTUAL-RUNTIME_base-utils?= "busybox" VIRTUAL-RUNTIME_base-utils-hwclock ?= "busybox-hwclock"

As I understand it, you don't actually define defaults anywhere. This means OE would break "out the box" which isn't acceptable and that alone means I can't merge this.

Secondly, the virtual/xxx namespace is *only* for DEPENDS/PROVIDES, not RDEPENDS or PACKAGE_INSTALL. For runtime packages, you need to use ${VIRTUAL-RUNTIME_base-utils}.

Cheers,

Richard

#5 lore raw
Quoted 13 lines · Richard Purdie
Quoted 11 lines · Alejandro Joya

It provide a virtual reference for the common utilities.
it replace of the lock to busybox, it will be simple exchange between other common utilities like gnu core utils or toybox among others.

In order to enable its required to fill at the distro conf or local.conf

VIRTUAL-RUNTIME_login_manager ?= "busybox" PREFERRED_PROVIDER_virtual/base-utils?= "busybox" PREFERRED_RPROVIDER_virtual/base-utils?= "busybox" VIRTUAL-RUNTIME_base-utils?= "busybox" VIRTUAL-RUNTIME_base-utils-hwclock ?= "busybox-hwclock"

Quoted 3 lines

As I understand it, you don't actually define defaults anywhere. This means OE would break "out the box" which isn't acceptable and that alone means I can't merge this.

you are totally right, one of my doubts still is, where is the most suitable place to defined this as single point?

Quoted 5 lines

Secondly, the virtual/xxx namespace is *only* for DEPENDS/PROVIDES, not RDEPENDS or PACKAGE_INSTALL. For runtime packages, you need to use ${VIRTUAL-RUNTIME_base-utils}.

thanks I appreciated the correction.

Quoted 4 lines

Cheers,

Richard