Skip to contentSkip to conversation

qemuarm enable virtio devices

PATCH In review Aníbal Limón 2 participants 4 messages Sep 29, 2015 – Sep 30, 2015

lore
Share & tools
lore
#0 lore raw

cover qemuarm enable virtio devices

Use virtio block device into qemuarm for avoid qemu SCSI device problem that is broken.

I tested (ran testimage) this patches using core-image-sato and core-image-lsb with kernels 3.14, 3.19 and 4.1.

[YOCTO #8060]

The following changes since commit f78f90240a3041be426c6ba9085849352164ee8b:

bitbake: prserv/serv.py: Better messaging when starting/stopping the server with port=0 (2015-09-28 12:00:33 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib alimon/qemuarm_virtio
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=alimon/qemuarm_virtio

Aníbal Limón (2):
linux-yocto_{3.14,3.19,4.1}: qemuarm enable virtio drivers
runqemu-internal: qemuarm enable usage of virtio devices

 meta/recipes-kernel/linux/linux-yocto_3.14.bb |  1 +
 meta/recipes-kernel/linux/linux-yocto_3.19.bb |  1 +
 meta/recipes-kernel/linux/linux-yocto_4.1.bb  |  1 +
 scripts/runqemu-internal                      | 14 ++++++++++++--
 4 files changed, 15 insertions(+), 2 deletions(-)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/2 linux-yocto_{3.14, 3.19, 4.1}: qemuarm enable virtio drivers

We are experimenting segfault in qemu arm SCSI driver because it's broken [1][2] so enable virtio drivers to use as default.

[YOCTO #8060]

[1] https://lists.gnu.org/archive/html/qemu-devel/2007-03/msg00093.html
[2] https://lists.nongnu.org/archive/html/qemu-devel/2010-07/msg01473.html

---
 meta/recipes-kernel/linux/linux-yocto_3.14.bb | 1 +
 meta/recipes-kernel/linux/linux-yocto_3.19.bb | 1 +
 meta/recipes-kernel/linux/linux-yocto_4.1.bb  | 1 +
 3 files changed, 3 insertions(+)
meta/recipes-kernel/linux/linux-yocto_3.14.bb +1 -0
index b6b2e5a..0a37cb6 100644
@@ -36,6 +36,7 @@ COMPATIBLE_MACHINE = "qemuarm|qemuarm64|qemux86|qemuppc|qemumips|qemumips64|qemu
 # Functionality flags
 KERNEL_EXTRA_FEATURES ?= "features/netfilter/netfilter.scc"
 KERNEL_FEATURES_append = " ${KERNEL_EXTRA_FEATURES}"
+KERNEL_FEATURES_append_qemuarm=" cfg/virtio.scc"
 KERNEL_FEATURES_append_qemux86=" cfg/sound.scc cfg/paravirt_kvm.scc"
 KERNEL_FEATURES_append_qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc"
 KERNEL_FEATURES_append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "" ,d)}"
meta/recipes-kernel/linux/linux-yocto_3.19.bb +1 -0
index e8c1640..4143a09 100644
@@ -36,6 +36,7 @@ COMPATIBLE_MACHINE = "qemuarm|qemuarm64|qemux86|qemuppc|qemumips|qemumips64|qemu
 # Functionality flags
 KERNEL_EXTRA_FEATURES ?= "features/netfilter/netfilter.scc"
 KERNEL_FEATURES_append = " ${KERNEL_EXTRA_FEATURES}"
+KERNEL_FEATURES_append_qemuarm=" cfg/virtio.scc"
 KERNEL_FEATURES_append_qemux86=" cfg/sound.scc cfg/paravirt_kvm.scc"
 KERNEL_FEATURES_append_qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc"
 KERNEL_FEATURES_append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "" ,d)}"
meta/recipes-kernel/linux/linux-yocto_4.1.bb +1 -0
index 0645134..f27e0de 100644
@@ -36,6 +36,7 @@ COMPATIBLE_MACHINE = "qemuarm|qemuarm64|qemux86|qemuppc|qemumips|qemumips64|qemu
 # Functionality flags
 KERNEL_EXTRA_FEATURES ?= "features/netfilter/netfilter.scc"
 KERNEL_FEATURES_append = " ${KERNEL_EXTRA_FEATURES}"
+KERNEL_FEATURES_append_qemuarm=" cfg/virtio.scc"
 KERNEL_FEATURES_append_qemux86=" cfg/sound.scc cfg/paravirt_kvm.scc"
 KERNEL_FEATURES_append_qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc"
 KERNEL_FEATURES_append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "" ,d)}"
Signature · 1 line
1.9.1
#2 lore raw

Re: [PATCH 1/2] linux-yocto_{3.14, 3.19, 4.1}: qemuarm enable virtio drivers

Quoted 2 lines · Aníbal Limón

We are experimenting segfault in qemu arm SCSI driver because it's broken [1][2] so enable virtio drivers to use as default.

This looks fine to me, and is consistent with the other features we are enabling for the default qemu* machines.

What (if any) message is thrown by a kernel that isn't configured with these features ? I suppose that since we aren't NFS booting, you simply don't have ethernet, and the user can look at the target's kernel config to diagnose that issue.

Cheers,

Bruce

Quoted 50 lines

[YOCTO #8060]

[1] https://lists.gnu.org/archive/html/qemu-devel/2007-03/msg00093.html
[2] https://lists.nongnu.org/archive/html/qemu-devel/2010-07/msg01473.html

---
  meta/recipes-kernel/linux/linux-yocto_3.14.bb | 1 +
  meta/recipes-kernel/linux/linux-yocto_3.19.bb | 1 +
  meta/recipes-kernel/linux/linux-yocto_4.1.bb  | 1 +
  3 files changed, 3 insertions(+)
meta/recipes-kernel/linux/linux-yocto_3.14.bb +1 -0
index b6b2e5a..0a37cb6 100644
@@ -36,6 +36,7 @@ COMPATIBLE_MACHINE = "qemuarm|qemuarm64|qemux86|qemuppc|qemumips|qemumips64|qemu
  # Functionality flags
  KERNEL_EXTRA_FEATURES ?= "features/netfilter/netfilter.scc"
  KERNEL_FEATURES_append = " ${KERNEL_EXTRA_FEATURES}"
+KERNEL_FEATURES_append_qemuarm=" cfg/virtio.scc"
  KERNEL_FEATURES_append_qemux86=" cfg/sound.scc cfg/paravirt_kvm.scc"
  KERNEL_FEATURES_append_qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc"
  KERNEL_FEATURES_append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "" ,d)}"
meta/recipes-kernel/linux/linux-yocto_3.19.bb +1 -0
index e8c1640..4143a09 100644
@@ -36,6 +36,7 @@ COMPATIBLE_MACHINE = "qemuarm|qemuarm64|qemux86|qemuppc|qemumips|qemumips64|qemu
  # Functionality flags
  KERNEL_EXTRA_FEATURES ?= "features/netfilter/netfilter.scc"
  KERNEL_FEATURES_append = " ${KERNEL_EXTRA_FEATURES}"
+KERNEL_FEATURES_append_qemuarm=" cfg/virtio.scc"
  KERNEL_FEATURES_append_qemux86=" cfg/sound.scc cfg/paravirt_kvm.scc"
  KERNEL_FEATURES_append_qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc"
  KERNEL_FEATURES_append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "" ,d)}"
meta/recipes-kernel/linux/linux-yocto_4.1.bb +1 -0
index 0645134..f27e0de 100644
@@ -36,6 +36,7 @@ COMPATIBLE_MACHINE = "qemuarm|qemuarm64|qemux86|qemuppc|qemumips|qemumips64|qemu
  # Functionality flags
  KERNEL_EXTRA_FEATURES ?= "features/netfilter/netfilter.scc"
  KERNEL_FEATURES_append = " ${KERNEL_EXTRA_FEATURES}"
+KERNEL_FEATURES_append_qemuarm=" cfg/virtio.scc"
  KERNEL_FEATURES_append_qemux86=" cfg/sound.scc cfg/paravirt_kvm.scc"
  KERNEL_FEATURES_append_qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc"
  KERNEL_FEATURES_append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "" ,d)}"
#3 lore raw

PATCH 2/2 runqemu-internal: qemuarm enable usage of virtio devices

In reply to Aníbal Limón

We are experiencing occasional segfaults in scsi sym53c8xx driver on qemuarm boot. There are some old discussions into the mailing lists [1] about the scsi problem and seems to be isn't fixed.

We use virtio blk/net devices into qemuarm64 also are supported into qemuarm so change to use it because virtio devices are the best choice.

[YOCTO #8060]

[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=8060#c10

---
 scripts/runqemu-internal | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
scripts/runqemu-internal +12 -2
index d6b1102..a77660f 100755
@@ -364,8 +364,18 @@ if [ "$MACHINE" = "qemuarm" -o "$MACHINE" = "qemuarmv6" -o "$MACHINE" = "qemuarm
     QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS"
     # QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS -force-pointer"
     if [ "${FSTYPE:0:3}" = "ext" -o "$FSTYPE" = "btrfs" ]; then
-        KERNCMDLINE="root=/dev/sda rw console=ttyAMA0,115200 console=tty $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY highres=off"
-        QEMUOPTIONS="$QEMU_NETWORK_CMD -M ${MACHINE_SUBTYPE} -drive file=$ROOTFS,format=raw -no-reboot $QEMU_UI_OPTIONS"
+        if [ "$MACHINE" = "qemuarm" ]; then
+            QEMU_NETWORK_CMD="-net nic,model=virtio $QEMU_TAP_CMD"
+            DROOT="/dev/vda"
+            ROOTFS_OPTIONS="-drive file=$ROOTFS,if=virtio,format=raw"
+        else
+            QEMU_NETWORK_CMD="-net nic,vlan=0 $QEMU_TAP_CMD"
+            DROOT="/dev/sda"
+            ROOTFS_OPTIONS="-drive file=$ROOTFS,format=raw"
+        fi
+
+        KERNCMDLINE="root=$DROOT rw console=ttyAMA0,115200 console=tty $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY highres=off"
+        QEMUOPTIONS="$QEMU_NETWORK_CMD -M ${MACHINE_SUBTYPE} $ROOTFS_OPTIONS -no-reboot $QEMU_UI_OPTIONS"
     fi
     if [ "$FSTYPE" = "nfs" ]; then
         if [ "$NFS_SERVER" = "192.168.7.1" -a ! -d "$NFS_DIR" ]; then
Signature · 1 line
1.9.1