Skip to contentSkip to conversation

Remove checkpatch warnings

PATCH In review Shivani Bhardwaj 2 participants 4 messages Oct 11, 2015 Staging

lore
Share & tools
lore

Shivani Bhardwaj

author
#0 lore raw

v3 cover Remove checkpatch warnings

This patch removes/adds extra/missing characters respectively. After applying this patch, the file has less warnings.

Shivani Bhardwaj (2):
Staging: vt6655: rxtx: Remove extra space character
Staging: vt6655: rxtx: Remove extra parentheses

 drivers/staging/vt6655/rxtx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.1.0
author
#1 lore raw

PATCH v3 1/2 Staging: vt6655: rxtx: Remove extra space character

Remove unnecessary space character after the variable RATE_16M preserving the alignment of all other variables and comments. Fixes the warning by checkpatch: space prohibited before that ',' (ctx:WxW)

Signed-off-by Shivani Bhardwaj <[email protected]>

---
Changes in v3:
-Make alignment of variables better.

 drivers/staging/vt6655/rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/rxtx.c +1 -1
index 5875d65..0c1f6a1 100644
@@ -78,7 +78,7 @@ static const unsigned short wFB_Opt0[2][5] = {
 };
 static const unsigned short wFB_Opt1[2][5] = {
 	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
-	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
+	{RATE_6M,  RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
 };
 
 #define RTSDUR_BB       0
Signature · 1 line
2.1.0
author
#3 lore raw

PATCH v3 2/2 Staging: vt6655: rxtx: Remove extra parentheses

In reply to Shivani Bhardwaj

Remove unnecessary parentheses around if test expressions. Fixes checkpatch warning : unnecessary parentheses

Signed-off-by Shivani Bhardwaj <[email protected]>

---
Changes in v3:
-Make alignment of variables better.

 drivers/staging/vt6655/rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vt6655/rxtx.c +2 -2
index 0c1f6a1..b668db6 100644
@@ -566,7 +566,7 @@ s_uFillDataHead(
 			return buf->duration_a;
 		} /* if (byFBOption == AUTO_FB_NONE) */
 	} else if (byPktType == PK_TYPE_11A) {
-		if ((byFBOption != AUTO_FB_NONE)) {
+		if (byFBOption != AUTO_FB_NONE) {
 			/* Auto Fallback */
 			struct vnt_tx_datahead_a_fb *buf = pTxDataHead;
 			/* Get SignalField, ServiceField & Length */

@@ -1008,7 +1008,7 @@ s_vGenerateTxParameter(
 			buf->rrv_time = vnt_rxtx_rsvtime_le16(pDevice, PK_TYPE_11A, cbFrameSize, wCurrentRate, bNeedACK);
 		}
 	} else if (byPktType == PK_TYPE_11B) {
-		if ((pvRTS != NULL)) {/* RTS_need, non PCF mode */
+		if (pvRTS != NULL) {/* RTS_need, non PCF mode */
 			struct vnt_rrv_time_ab *buf = pvRrvTime;
 
 			buf->rts_rrv_time = s_uGetRTSCTSRsvTime(pDevice, 0, byPktType, cbFrameSize, wCurrentRate);
Signature · 1 line
2.1.0
#2 lore raw

Re: [Outreachy kernel] [PATCH v3 1/2] Staging: vt6655: rxtx: Remove extra space character

In reply to Shivani Bhardwaj
Quoted 18 lines · Shivani Bhardwaj

Remove unnecessary space character after the variable RATE_16M preserving the alignment of all other variables and comments. Fixes the warning by checkpatch: space prohibited before that ',' (ctx:WxW)

Signed-off-by Shivani Bhardwaj <[email protected]>

---
Changes in v3:
-Make alignment of variables better.

 drivers/staging/vt6655/rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/rxtx.c +0 -0
index 5875d65..0c1f6a1 100644

drivers/staging/vt6655/rxtx.c static const unsigned short wFB_Opt0[2][5] = { · line 81

Quoted 5 lines
drivers/staging/vt6655/rxtx.c +1 -1
@@ -78,7 +78,7 @@ static const unsigned short wFB_Opt0[2][5] = {
 };
 static const unsigned short wFB_Opt1[2][5] = {
 	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
-	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
+	{RATE_6M,  RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */

It looks nice now :)

julia

Quoted 13 lines
drivers/staging/vt6655/rxtx.c +0 -0
 };
 
 #define RTSDUR_BB       0
Signature · 8 lines
2.1.0

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/43aba6a5182d22a3856fe326dfa8e69ff796f12d.1444590771.git.shivanib134%40gmail.com.
For more options, visit https://groups.google.com/d/optout.