Remove useless cast on void pointer
cover Remove useless cast on void pointer
This patchset removes multiple useless cast on void pointer.
Amitoj Kaur Chawla (3):
staging: rtl8712: Remove useless cast on void pointer
staging: rtl8712: Remove useless cast on void pointer
staging: rtl8712: Remove useless cast on void pointer
drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- drivers/staging/rtl8712/rtl8712_recv.c | 9 ++- drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 105 ++++++++++------------------- 3 files changed, 40 insertions(+), 76 deletions(-)
Signature · 1 line
1.9.1
PATCH 1/3 staging: rtl8712: Remove useless cast on void pointer
The semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by Amitoj Kaur Chawla <[email protected]>
--- drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl8712_cmd.c +1 -1
@@ -317,7 +317,7 @@ int r8712_cmd_thread(void *context)unsigned int cmdsz, wr_sz, *pcmdbuf;struct tx_desc *pdesc;void (*pcmd_callback)(struct _adapter *dev,struct cmd_obj *pcmd); -struct _adapter *padapter = (struct _adapter *)context; +struct _adapter *padapter = context;struct cmd_priv *pcmdpriv = &(padapter->cmdpriv);allow_signal (SIGTERM );
Signature · 1 line
1.9.1
PATCH 2/3 staging: rtl8712: Remove useless cast on void pointer
In reply to Amitoj Kaur ChawlaThe semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by Amitoj Kaur Chawla <[email protected]>
--- drivers/staging/rtl8712/rtl8712_recv.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/staging/rtl8712/rtl8712_recv.c +4 -5
@@ -434,7 +434,7 @@ void r8712_rxcmd_event_hdl(struct _adapter *padapter, void *prxcmdbuf) poffset = (u8 *)prxcmdbuf; voffset = *(uint *)poffset; - prxstat = (struct recv_stat *)prxcmdbuf; + prxstat = prxcmdbuf; drvinfo_sz = (le32_to_cpu (prxstat->rxdw0) &0x000f0000 ) >>16 ; drvinfo_sz <<=3 ; poffset +=RXDESC_SIZE + drvinfo_sz;
@@ -620,8 +620,7 @@ _err_exit:void r8712_reordering_ctrl_timeout_handler (void *pcontext) {unsigned long irql; -struct recv_reorder_ctrl *preorder_ctrl = - (struct recv_reorder_ctrl *)pcontext; +struct recv_reorder_ctrl *preorder_ctrl = pcontext;struct _adapter *padapter = preorder_ctrl->padapter;struct __queue *ppending_recvframe_queue = &preorder_ctrl->pending_recvframe_queue;
@@ -959,7 +958,7 @@ int recv_func(struct _adapter *padapter, void *pcontext)struct __queue *pfree_recv_queue = &padapter->recvpriv.free_recv_queue;struct mlme_priv *pmlmepriv = &padapter->mlmepriv; - prframe = (union recv_frame *)pcontext; + prframe = pcontext; orig_prframe = prframe; pattrib = &prframe->u.hdr.attrib;if (check_fwstate (pmlmepriv,WIFI_MP_STATE ) == true) {
@@ -1103,7 +1102,7 @@ _exit_recvbuf2recvframe:static void recv_tasklet (void *priv) {struct sk_buff *pskb; -struct _adapter *padapter = (struct _adapter *)priv; +struct _adapter *padapter = priv;struct recv_priv *precvpriv = &padapter->recvpriv;while (NULL != (pskb =skb_dequeue (&precvpriv->rx_skb_queue))) {
Signature · 1 line
1.9.1
PATCH 3/3 staging: rtl8712: Remove useless cast on void pointer
In reply to Amitoj Kaur ChawlaThe semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by Amitoj Kaur Chawla <[email protected]>
--- drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 105 ++++++++++------------------- 1 file changed, 35 insertions(+), 70 deletions(-)
drivers/staging/rtl8712/rtl871x_mp_ioctl.c +35 -70
@@ -41,8 +41,7 @@ uint oid_null_function(struct oid_par_priv *poid_par_priv)uint oid_rt_wireless_mode_hdl (struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid ==SET_OID ) {if (poid_par_priv->information_buf_len >=sizeof (u8))
@@ -66,8 +65,7 @@ uint oid_rt_wireless_mode_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_write_bb_reg_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);struct bb_reg_param *pbbreg;u16 offset;u32 value;
@@ -87,8 +85,7 @@ uint oid_rt_pro_write_bb_reg_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_read_bb_reg_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);struct bb_reg_param *pbbreg;u16 offset;u32 value;
@@ -109,8 +106,7 @@ uint oid_rt_pro_read_bb_reg_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_write_rf_reg_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);struct rf_reg_param *pbbreg;u8 path;u8 offset;
@@ -132,8 +128,7 @@ uint oid_rt_pro_write_rf_reg_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_read_rf_reg_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);struct rf_reg_param *pbbreg;u8 path;u8 offset;
@@ -260,8 +255,7 @@ int mp_start_joinbss(struct _adapter *padapter, struct ndis_802_11_ssid *pssid)uint oid_rt_pro_set_data_rate_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 ratevalue;if (poid_par_priv->type_of_oid !=SET_OID )
@@ -278,8 +272,7 @@ uint oid_rt_pro_set_data_rate_hdl(struct oid_par_privuint oid_rt_pro_start_test_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;u32 mode;u8 val8;
@@ -307,8 +300,7 @@ uint oid_rt_pro_start_test_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_stop_test_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;if (poid_par_priv->type_of_oid !=SET_OID )
@@ -321,8 +313,7 @@ uint oid_rt_pro_stop_test_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_set_channel_direct_call_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 Channel;if (poid_par_priv->type_of_oid !=SET_OID )
@@ -339,8 +330,7 @@ uint oid_rt_pro_set_channel_direct_call_hdl(struct oid_par_privuint oid_rt_pro_set_antenna_bb_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 antenna;if (poid_par_priv->type_of_oid !=SET_OID )
@@ -357,8 +347,7 @@ uint oid_rt_pro_set_antenna_bb_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_set_tx_power_control_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 tx_pwr_idx;if (poid_par_priv->type_of_oid !=SET_OID )
@@ -377,8 +366,7 @@ uint oid_rt_pro_query_tx_packet_sent_hdl( struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID ) { status =RNDIS_STATUS_NOT_ACCEPTED ;
@@ -397,8 +385,7 @@ uint oid_rt_pro_query_rx_packet_received_hdl( struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID ) { status =RNDIS_STATUS_NOT_ACCEPTED ;
@@ -417,8 +404,7 @@ uint oid_rt_pro_query_rx_packet_crc32_error_hdl( struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID ) { status =RNDIS_STATUS_NOT_ACCEPTED ;
@@ -436,8 +422,7 @@ uint oid_rt_pro_query_rx_packet_crc32_error_hdl(uint oid_rt_pro_reset_tx_packet_sent_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=SET_OID )return RNDIS_STATUS_NOT_ACCEPTED ;
@@ -449,8 +434,7 @@ uint oid_rt_pro_reset_rx_packet_received_hdl(struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=SET_OID )return RNDIS_STATUS_NOT_ACCEPTED ;
@@ -465,8 +449,7 @@ uint oid_rt_pro_reset_rx_packet_received_hdl(struct oid_par_privuint oid_rt_reset_phy_rx_packet_count_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=SET_OID )return RNDIS_STATUS_NOT_ACCEPTED ;
@@ -477,8 +460,7 @@ uint oid_rt_reset_phy_rx_packet_count_hdl(struct oid_par_privuint oid_rt_get_phy_rx_packet_received_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;
@@ -493,8 +475,7 @@ uint oid_rt_get_phy_rx_packet_received_hdl(struct oid_par_privuint oid_rt_get_phy_rx_packet_crc32_error_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;
@@ -509,8 +490,7 @@ uint oid_rt_get_phy_rx_packet_crc32_error_hdl(struct oid_par_privuint oid_rt_pro_set_modulation_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=SET_OID )return RNDIS_STATUS_NOT_ACCEPTED ;
@@ -522,8 +502,7 @@ uint oid_rt_pro_set_modulation_hdl(struct oid_par_privuint oid_rt_pro_set_continuous_tx_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 bStartTest;if (poid_par_priv->type_of_oid !=SET_OID )
@@ -536,8 +515,7 @@ uint oid_rt_pro_set_continuous_tx_hdl(struct oid_par_privuint oid_rt_pro_set_single_carrier_tx_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 bStartTest;if (poid_par_priv->type_of_oid !=SET_OID )
@@ -550,8 +528,7 @@ uint oid_rt_pro_set_single_carrier_tx_hdl(struct oid_par_privuint oid_rt_pro_set_carrier_suppression_tx_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 bStartTest;if (poid_par_priv->type_of_oid !=SET_OID )
@@ -564,8 +541,7 @@ uint oid_rt_pro_set_carrier_suppression_tx_hdl(struct oid_par_privuint oid_rt_pro_set_single_tone_tx_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 bStartTest;if (poid_par_priv->type_of_oid !=SET_OID )
@@ -578,8 +554,7 @@ uint oid_rt_pro_set_single_tone_tx_hdl(struct oid_par_privuint oid_rt_pro_read_register_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;struct mp_rw_reg *RegRWStruct;u16 offset;
@@ -618,8 +593,7 @@ uint oid_rt_pro_read_register_hdl(struct oid_par_privuint oid_rt_pro_write_register_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;struct mp_rw_reg *RegRWStruct;u16 offset;
@@ -678,8 +652,7 @@ uint oid_rt_pro_write_register_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_get_thermal_meter_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;
@@ -706,8 +679,7 @@ uint oid_rt_get_thermal_meter_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_read_efuse_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;
@@ -736,8 +708,7 @@ uint oid_rt_pro_read_efuse_hdl(struct oid_par_priv *poid_par_priv)/*------------------------------------------------------------------------*/ uint oid_rt_pro_write_efuse_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;
@@ -765,8 +736,7 @@ uint oid_rt_pro_write_efuse_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_get_efuse_current_size_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;
@@ -782,8 +752,7 @@ uint oid_rt_get_efuse_current_size_hdl(struct oid_par_privuint oid_rt_get_efuse_max_size_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;
@@ -808,8 +777,7 @@ uint oid_rt_pro_efuse_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_efuse_map_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;u8 *data;
@@ -840,8 +808,7 @@ uint oid_rt_pro_efuse_map_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_set_bandwidth_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 bandwidth;if (poid_par_priv->type_of_oid !=SET_OID )
@@ -859,8 +826,7 @@ uint oid_rt_set_bandwidth_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_set_rx_packet_type_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u8 rx_pkt_type;u32 rcr_val32;
@@ -915,8 +881,7 @@ uint oid_rt_set_power_down_hdl(struct oid_par_priv *poid_par_priv)/*-------------------------------------------------------------------------- */ uint oid_rt_get_power_mode_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;
Signature · 1 line
1.9.1
Re: [Outreachy kernel] [PATCH 3/3] staging: rtl8712: Remove useless cast on void pointer
Quoted 30 lines · Amitoj Kaur Chawla
The semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)Signed-off-by Amitoj Kaur Chawla <[email protected]>--- drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 105 ++++++++++------------------- 1 file changed, 35 insertions(+), 70 deletions(-)drivers/staging/rtl8712/rtl871x_mp_ioctl.c +0
-0
drivers/staging/rtl8712/rtl871x_mp_ioctl.c uint oid_null_function(struct oid_par_priv *poid_par_priv) · line 44
Quoted 6 lines
drivers/staging/rtl8712/rtl871x_mp_ioctl.c +1
-2@@ -41,8 +41,7 @@ uint oid_null_function(struct oid_par_priv *poid_par_priv)uint oid_rt_wireless_mode_hdl (struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);
The parentheses are not needed. Since they were probably put there because of the cast, it would be reasonable to also drop them.
Likewise elsewhere.
julia
Quoted 352 lines
drivers/staging/rtl8712/rtl871x_mp_ioctl.c +34
-69if (poid_par_priv->type_of_oid ==SET_OID ) {if (poid_par_priv->information_buf_len >=sizeof (u8))@@ -66,8 +65,7 @@ uint oid_rt_wireless_mode_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_write_bb_reg_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);struct bb_reg_param *pbbreg;u16 offset;u32 value;@@ -87,8 +85,7 @@ uint oid_rt_pro_write_bb_reg_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_read_bb_reg_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);struct bb_reg_param *pbbreg;u16 offset;u32 value;@@ -109,8 +106,7 @@ uint oid_rt_pro_read_bb_reg_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_write_rf_reg_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);struct rf_reg_param *pbbreg;u8 path;u8 offset;@@ -132,8 +128,7 @@ uint oid_rt_pro_write_rf_reg_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_read_rf_reg_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);struct rf_reg_param *pbbreg;u8 path;u8 offset;@@ -260,8 +255,7 @@ int mp_start_joinbss(struct _adapter *padapter, struct ndis_802_11_ssid *pssid)uint oid_rt_pro_set_data_rate_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 ratevalue;if (poid_par_priv->type_of_oid !=SET_OID )@@ -278,8 +272,7 @@ uint oid_rt_pro_set_data_rate_hdl(struct oid_par_privuint oid_rt_pro_start_test_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;u32 mode;u8 val8;@@ -307,8 +300,7 @@ uint oid_rt_pro_start_test_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_stop_test_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;if (poid_par_priv->type_of_oid !=SET_OID )@@ -321,8 +313,7 @@ uint oid_rt_pro_stop_test_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_set_channel_direct_call_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 Channel;if (poid_par_priv->type_of_oid !=SET_OID )@@ -339,8 +330,7 @@ uint oid_rt_pro_set_channel_direct_call_hdl(struct oid_par_privuint oid_rt_pro_set_antenna_bb_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 antenna;if (poid_par_priv->type_of_oid !=SET_OID )@@ -357,8 +347,7 @@ uint oid_rt_pro_set_antenna_bb_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_set_tx_power_control_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 tx_pwr_idx;if (poid_par_priv->type_of_oid !=SET_OID )@@ -377,8 +366,7 @@ uint oid_rt_pro_query_tx_packet_sent_hdl( struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID ) { status =RNDIS_STATUS_NOT_ACCEPTED ;@@ -397,8 +385,7 @@ uint oid_rt_pro_query_rx_packet_received_hdl( struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID ) { status =RNDIS_STATUS_NOT_ACCEPTED ;@@ -417,8 +404,7 @@ uint oid_rt_pro_query_rx_packet_crc32_error_hdl( struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID ) { status =RNDIS_STATUS_NOT_ACCEPTED ;@@ -436,8 +422,7 @@ uint oid_rt_pro_query_rx_packet_crc32_error_hdl(uint oid_rt_pro_reset_tx_packet_sent_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=SET_OID )return RNDIS_STATUS_NOT_ACCEPTED ;@@ -449,8 +434,7 @@ uint oid_rt_pro_reset_rx_packet_received_hdl(struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=SET_OID )return RNDIS_STATUS_NOT_ACCEPTED ;@@ -465,8 +449,7 @@ uint oid_rt_pro_reset_rx_packet_received_hdl(struct oid_par_privuint oid_rt_reset_phy_rx_packet_count_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=SET_OID )return RNDIS_STATUS_NOT_ACCEPTED ;@@ -477,8 +460,7 @@ uint oid_rt_reset_phy_rx_packet_count_hdl(struct oid_par_privuint oid_rt_get_phy_rx_packet_received_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;@@ -493,8 +475,7 @@ uint oid_rt_get_phy_rx_packet_received_hdl(struct oid_par_privuint oid_rt_get_phy_rx_packet_crc32_error_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;@@ -509,8 +490,7 @@ uint oid_rt_get_phy_rx_packet_crc32_error_hdl(struct oid_par_privuint oid_rt_pro_set_modulation_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=SET_OID )return RNDIS_STATUS_NOT_ACCEPTED ;@@ -522,8 +502,7 @@ uint oid_rt_pro_set_modulation_hdl(struct oid_par_privuint oid_rt_pro_set_continuous_tx_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 bStartTest;if (poid_par_priv->type_of_oid !=SET_OID )@@ -536,8 +515,7 @@ uint oid_rt_pro_set_continuous_tx_hdl(struct oid_par_privuint oid_rt_pro_set_single_carrier_tx_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 bStartTest;if (poid_par_priv->type_of_oid !=SET_OID )@@ -550,8 +528,7 @@ uint oid_rt_pro_set_single_carrier_tx_hdl(struct oid_par_privuint oid_rt_pro_set_carrier_suppression_tx_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 bStartTest;if (poid_par_priv->type_of_oid !=SET_OID )@@ -564,8 +541,7 @@ uint oid_rt_pro_set_carrier_suppression_tx_hdl(struct oid_par_privuint oid_rt_pro_set_single_tone_tx_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 bStartTest;if (poid_par_priv->type_of_oid !=SET_OID )@@ -578,8 +554,7 @@ uint oid_rt_pro_set_single_tone_tx_hdl(struct oid_par_privuint oid_rt_pro_read_register_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;struct mp_rw_reg *RegRWStruct;u16 offset;@@ -618,8 +593,7 @@ uint oid_rt_pro_read_register_hdl(struct oid_par_privuint oid_rt_pro_write_register_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;struct mp_rw_reg *RegRWStruct;u16 offset;@@ -678,8 +652,7 @@ uint oid_rt_pro_write_register_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_get_thermal_meter_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;@@ -706,8 +679,7 @@ uint oid_rt_get_thermal_meter_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_read_efuse_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;@@ -736,8 +708,7 @@ uint oid_rt_pro_read_efuse_hdl(struct oid_par_priv *poid_par_priv)/*------------------------------------------------------------------------*/ uint oid_rt_pro_write_efuse_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;@@ -765,8 +736,7 @@ uint oid_rt_pro_write_efuse_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_get_efuse_current_size_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;@@ -782,8 +752,7 @@ uint oid_rt_get_efuse_current_size_hdl(struct oid_par_privuint oid_rt_get_efuse_max_size_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ;@@ -808,8 +777,7 @@ uint oid_rt_pro_efuse_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_pro_efuse_map_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);uint status =RNDIS_STATUS_SUCCESS ;u8 *data;@@ -840,8 +808,7 @@ uint oid_rt_pro_efuse_map_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_set_bandwidth_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u32 bandwidth;if (poid_par_priv->type_of_oid !=SET_OID )@@ -859,8 +826,7 @@ uint oid_rt_set_bandwidth_hdl(struct oid_par_priv *poid_par_priv)uint oid_rt_set_rx_packet_type_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);u8 rx_pkt_type;u32 rcr_val32;@@ -915,8 +881,7 @@ uint oid_rt_set_power_down_hdl(struct oid_par_priv *poid_par_priv)/*-------------------------------------------------------------------------- */ uint oid_rt_get_power_mode_hdl (struct oid_par_priv *poid_par_priv) { -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);if (poid_par_priv->type_of_oid !=QUERY_OID )return RNDIS_STATUS_NOT_ACCEPTED ; --1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/55c502b96a27eaf4c78cbfdc373433e7cb898d42.1444723375.git.amitoj1606%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Re: [Outreachy kernel] [PATCH 3/3] staging: rtl8712: Remove useless cast on void pointer
Quoted 42 lines · Julia Lawall
Quoted 30 lines · Amitoj Kaur Chawla
The semantic patch used to find this is:
@r@
expression x;
void* e;
type T;
identifier f;
@@(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)Signed-off-by Amitoj Kaur Chawla <[email protected]>--- drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 105 ++++++++++------------------- 1 file changed, 35 insertions(+), 70 deletions(-)drivers/staging/rtl8712/rtl871x_mp_ioctl.c +0
-0drivers/staging/rtl8712/rtl871x_mp_ioctl.c uint oid_null_function(struct oid_par_priv *poid_par_priv) · line 44
Quoted 6 lines
drivers/staging/rtl8712/rtl871x_mp_ioctl.c +1
-2@@ -41,8 +41,7 @@ uint oid_null_function(struct oid_par_priv *poid_par_priv)uint oid_rt_wireless_mode_hdl (struct oid_par_priv *poid_par_priv) {uint status =RNDIS_STATUS_SUCCESS ; -struct _adapter *Adapter = (struct _adapter *) - (poid_par_priv->adapter_context); +struct _adapter *Adapter = (poid_par_priv->adapter_context);The parentheses are not needed. Since they were probably put there because of the cast, it would be reasonable to also drop them.
Quoted 3 lines
Likewise elsewhere.
julia
Will do. Sending v2.
Signature · 1 line
Amitoj