Skip to contentSkip to conversation

openssl: don't move libcrypto to base_libdir

PATCH Superseded Chen Qi 2 participants 4 messages Oct 16, 2015

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

cover openssl: don't move libcrypto to base_libdir

The following changes since commit e42d8eff9eed7d1454b4f331d96dcee6dea232df:

bash: Disable custom memory allocator (2015-10-12 14:35:42 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib ChenQi/openssl-libcrypto
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/openssl-libcrypto

Chen Qi (1):
openssl: don't move libcrypto to base_libdir

 meta/recipes-connectivity/openssl/openssl.inc | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 openssl: don't move libcrypto to base_libdir

For now, if 'openssl' is enabled for ntp, ntp would still be built without openssl & libcrypto. This is because that ntp thinks openssl and libcrypto locates under the same directory.

A patch more than two years ago moves libcrypto from libdir to base_libdir for the reason of /usr split. And I don't think this reason still stands.

This patch removes the codes of moving libcrypto to base_libdir.

---
 meta/recipes-connectivity/openssl/openssl.inc | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
meta/recipes-connectivity/openssl/openssl.inc +2 -9
index 8af423f..0145e3b 100644
@@ -34,12 +34,12 @@ export AS = "${CC} -c"
 inherit pkgconfig siteinfo multilib_header ptest
 
 PACKAGES =+ "libcrypto libssl ${PN}-misc openssl-conf"
-FILES_libcrypto = "${base_libdir}/libcrypto${SOLIBS}"
+FILES_libcrypto = "${libdir}/libcrypto${SOLIBS}"
 FILES_libssl = "${libdir}/libssl.so.*"
 FILES_${PN} =+ " ${libdir}/ssl/*"
 FILES_${PN}-misc = "${libdir}/ssl/misc ${bindir}/c_rehash"
 RDEPENDS_${PN}-misc = "${@bb.utils.contains('PACKAGECONFIG', 'perl', 'perl', '', d)}"
-FILES_${PN}-dev += "${base_libdir}/libcrypto${SOLIBSDEV}"
+FILES_${PN}-dev += "${libdir}/libcrypto${SOLIBSDEV}"
 
 # Add the openssl.cnf file to the openssl-conf package.  Make the libcrypto
 # package RRECOMMENDS on this package.  This will enable the configuration
@@ -167,13 +167,6 @@ do_install () {
 	oe_libinstall -so libcrypto ${D}${libdir}
 	oe_libinstall -so libssl ${D}${libdir}
 
-	# Moving libcrypto to /lib
-	if [ ! ${D}${libdir} -ef ${D}${base_libdir} ]; then
-		mkdir -p ${D}/${base_libdir}/
-		mv ${D}${libdir}/libcrypto* ${D}${base_libdir}/
-		sed -i s#libdir=\$\{exec_prefix\}\/lib#libdir=${base_libdir}# ${D}/${libdir}/pkgconfig/libcrypto.pc
-	fi
-
 	install -d ${D}${includedir}
 	cp --dereference -R include/openssl ${D}${includedir}
 
Signature · 1 line
1.9.1
#2 lore raw
Quoted 2 lines · Chen Qi

A patch more than two years ago moves libcrypto from libdir to base_libdir for the reason of /usr split. And I don't think this reason still stands.

Why not?

p.

author
#3 lore raw
Quoted 10 lines · Phil Blundell
Quoted 2 lines · Chen Qi

A patch more than two years ago moves libcrypto from libdir to base_libdir for the reason of /usr split. And I don't think this reason still stands.

Why not?

p.

1) There are a bunch of /usr split patches on the mailing list and they are not accepted.
2) It was moved to /lib because dhclient started before mounting the local filesystem on sysvinit. Now, mounting local filesystem happens before dhclient in sysvinit.

// Qi