Skip to contentSkip to conversation

remove SDKMACHINE variable

PATCH In review Ed Bartosh 3 participants 8 messages Nov 5, 2015 – Nov 6, 2015 1 message not in the archive

lore
Share & tools
lore

Ed Bartosh

author
#0 lore raw

v2 cover remove SDKMACHINE variable

Hi,

This patchset contains two identical changes for toasterconf.json: removing SDKMACHINE variable. Variable is not used in toaster anymore as it's removed by this change: https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html

The patchset logically belongs to my previous patchset: 8279: Provide a single way of starting Toaster I'm sending this in separate e-mail as below two patches should be send to different upstream projects:
openembedded-core and yocto.

Please, send them after my previous patchset is accepted.

Changes in v2: removed forgotten comma after "PACKAGE_CLASSES": "package_rpm"

The following changes since commit fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:

build-appliance-image: Update to jethro head revision (2015-11-03 14:03:03 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/remove-sdkmachine

Ed Bartosh (2):
toasterconf: remove SDKMACHINE variable
toasterconf: remove SDKMACHINE variable

 meta-yocto/conf/toasterconf.json | 3 +--
 meta/conf/toasterconf.json       | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

--
Regards,
Ed

author
#1 lore raw

PATCH v2 1/2 toasterconf: remove SDKMACHINE variable

This variable is not used in toaster anymore.

Signed-off-by Ed Bartosh <[email protected]>
---
 meta/conf/toasterconf.json | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/conf/toasterconf.json +1 -2
index c8e42ef..1987793 100644
@@ -4,8 +4,7 @@
         "DISTRO"       : "poky",
         "IMAGE_FSTYPES": "ext3 jffs2 tar.bz2",
         "IMAGE_INSTALL_append": "",
-        "PACKAGE_CLASSES": "package_rpm",
-        "SDKMACHINE"   : "x86_64"
+        "PACKAGE_CLASSES": "package_rpm"
     },
     "layersources": [
         {
Signature · 1 line
2.1.4
author
#2 lore raw

PATCH v2 2/2 toasterconf: remove SDKMACHINE variable

In reply to Ed Bartosh

This variable is not used in toaster anymore.

Signed-off-by Ed Bartosh <[email protected]>
---
 meta-yocto/conf/toasterconf.json | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta-yocto/conf/toasterconf.json +1 -2
index 3df1703..3f79f42 100644
@@ -4,8 +4,7 @@
         "DISTRO"       : "poky",
         "IMAGE_FSTYPES": "ext3 jffs2 tar.bz2",
         "IMAGE_INSTALL_append": "",
-        "PACKAGE_CLASSES": "package_rpm",
-        "SDKMACHINE"   : "x86_64"
+        "PACKAGE_CLASSES": "package_rpm"
     },
     "layersources": [
         {
Signature · 1 line
2.1.4
#3 lore raw
In reply to Ed Bartosh

Hi Ed,

Have you tested this patch against the project configure variables page?

Specifically, this variable is also coded into these two files:

views.py
templates/projectconf.html

Are these files being handled in a separate commit?

- David

Quoted 56 lines

-----Original Message-----
From: [email protected] [mailto:toaster- [email protected]] On Behalf Of Ed Bartosh
Sent: Thursday, November 05, 2015 9:23 AM
To: [email protected]
Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable

Hi,

This patchset contains two identical changes for toasterconf.json:
removing
SDKMACHINE variable. Variable is not used in toaster anymore as it's removed
by this change: https://lists.yoctoproject.org/pipermail/toaster/2015-
October/003234.html

The patchset logically belongs to my previous patchset: 8279: Provide a single way of starting Toaster
I'm sending this in separate e-mail as below two patches should be send to different upstream projects:
openembedded-core and yocto.

Please, send them after my previous patchset is accepted.

Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
"package_rpm"

The following changes since commit
fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:

build-appliance-image: Update to jethro head revision (2015-11-03
14:03:03 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
http://git.yoctoproject.org/cgit.cgi/poky-
contrib/log/?h=ed/toaster/remove-sdkmachine

Ed Bartosh (2):
toasterconf: remove SDKMACHINE variable
toasterconf: remove SDKMACHINE variable

 meta-yocto/conf/toasterconf.json | 3 +--
 meta/conf/toasterconf.json       | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

--
Regards,
Ed

--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

#5 lore raw
In reply to Ed Bartosh
Quoted 26 lines · On 05/11/2015 17:22, "[email protected] on behalf of Ed…

Hi,

This patchset contains two identical changes for toasterconf.json:
removing
SDKMACHINE variable. Variable is not used in toaster anymore as it's removed
by this change:
https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html

The patchset logically belongs to my previous patchset: 8279: Provide a single way of starting Toaster
I'm sending this in separate e-mail as below two patches should be send to different upstream projects:
openembedded-core and yocto.

Please, send them after my previous patchset is accepted.

Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
"package_rpm"

The following changes since commit
fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:

build-appliance-image: Update to jethro head revision (2015-11-03
14:03:03 +0000)

Quoted 6 lines

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine

http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/remove
-sdkmachine

No more complaints: both the meta and meta-yocto conf files load without issues.

Thanks!

Belén

Quoted 18 lines

Ed Bartosh (2):
toasterconf: remove SDKMACHINE variable
toasterconf: remove SDKMACHINE variable

meta-yocto/conf/toasterconf.json | 3 +--
meta/conf/toasterconf.json | 3 +--

2 files changed, 2 insertions(+), 4 deletions(-)

--
Regards,
Ed

Signature · 4 lines
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster
#7 lore raw
In reply to a message not in the archive
Quoted 9 lines · David

Hi Ed and Belén,

Quoted 3 lines

Specifically, this variable is also coded into these two files:
views.py
templates/projectconf.html

If you want, I can take this task on and remove references to SDKMACHINE from these files, given that I am the one who put them in in the first place.

Looks like we need some changes in the template. The variable does not display in the BitBake variables page (as expected, since it is no longer set in the default configuration), but if you add it, you cannot delete it (the 'delete' icon is missing). David: since you are familiar with that template, do you think you could take care of this? When SDKMACHINE is not defined, you should be able to add it and delete it like any other variable using the 'add variable' form and the delete icon.

I can open a Bugzilla entry to track the work if you want me to.

Thanks!

Belén

Quoted 83 lines

- David

Quoted 80 lines

-----Original Message-----
From: Reyna, David
Sent: Thursday, November 05, 2015 9:41 AM
To: 'Ed Bartosh'; [email protected]
Subject: RE: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable

Hi Ed,

Have you tested this patch against the project configure variables page?

Specifically, this variable is also coded into these two files:

views.py
templates/projectconf.html

Are these files being handled in a separate commit?

- David

Quoted 7 lines

-----Original Message-----
From: [email protected] [mailto:toaster- [email protected]] On Behalf Of Ed Bartosh
Sent: Thursday, November 05, 2015 9:23 AM
To: [email protected]
Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable

Quoted 7 lines

Hi,

This patchset contains two identical changes for toasterconf.json:
removing
SDKMACHINE variable. Variable is not used in toaster anymore as it's removed
by this change:

https://lists.yoctoproject.org/pipermail/toaster/2015-

Quoted 3 lines

October/003234.html

The patchset logically belongs to my previous patchset: 8279:

Provide

Quoted 13 lines

a single way of starting Toaster
I'm sending this in separate e-mail as below two patches should be send to different upstream projects:
openembedded-core and yocto.

Please, send them after my previous patchset is accepted.

Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
"package_rpm"

The following changes since commit
fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:

Quoted 6 lines

build-appliance-image: Update to jethro head revision (2015-11-03
14:03:03 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/toaster/remove-

sdkmachine

Quoted 20 lines

http://git.yoctoproject.org/cgit.cgi/poky-
contrib/log/?h=ed/toaster/remove-sdkmachine

Ed Bartosh (2):
toasterconf: remove SDKMACHINE variable
toasterconf: remove SDKMACHINE variable

 meta-yocto/conf/toasterconf.json | 3 +--
 meta/conf/toasterconf.json       | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

--
Regards,
Ed

--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

author
#4 lore raw
In reply to Reyna, David
Quoted 11 lines · David

Hi Ed,

Have you tested this patch against the project configure variables page?

Specifically, this variable is also coded into these two files:

views.py
templates/projectconf.html

Are these files being handled in a separate commit?

Yep, they're both taken care of in this commit:
https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html

BTW, I mentoned it in the cover letter of this patchset.

Regards,
Ed

Quoted 56 lines
Quoted 56 lines

-----Original Message-----
From: [email protected] [mailto:toaster- [email protected]] On Behalf Of Ed Bartosh
Sent: Thursday, November 05, 2015 9:23 AM
To: [email protected]
Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable

Hi,

This patchset contains two identical changes for toasterconf.json:
removing
SDKMACHINE variable. Variable is not used in toaster anymore as it's removed
by this change: https://lists.yoctoproject.org/pipermail/toaster/2015-
October/003234.html

The patchset logically belongs to my previous patchset: 8279: Provide a single way of starting Toaster
I'm sending this in separate e-mail as below two patches should be send to different upstream projects:
openembedded-core and yocto.

Please, send them after my previous patchset is accepted.

Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
"package_rpm"

The following changes since commit
fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:

build-appliance-image: Update to jethro head revision (2015-11-03
14:03:03 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/toaster/remove-sdkmachine
http://git.yoctoproject.org/cgit.cgi/poky-
contrib/log/?h=ed/toaster/remove-sdkmachine

Ed Bartosh (2):
toasterconf: remove SDKMACHINE variable
toasterconf: remove SDKMACHINE variable

 meta-yocto/conf/toasterconf.json | 3 +--
 meta/conf/toasterconf.json       | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

--
Regards,
Ed

--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Signature · 3 lines
--
Regards,
Ed
#8 lore raw
In reply to Barros Pena, Belen
Quoted 14 lines · Belen
Quoted 9 lines · David

Hi Ed and Belén,

Quoted 3 lines

Specifically, this variable is also coded into these two files:
views.py
templates/projectconf.html

If you want, I can take this task on and remove references to SDKMACHINE from these files, given that I am the one who put them in in the first place.

Quoted 7 lines

Looks like we need some changes in the template. The variable does not display in the BitBake variables page (as expected, since it is no longer set in the default configuration), but if you add it, you cannot delete it (the 'delete' icon is missing). David: since you are familiar with that template, do you think you could take care of this? When SDKMACHINE is not defined, you should be able to add it and delete it like any other variable using the 'add variable' form and the delete icon.

Just ignore me. This commit

https://lists.yoctoproject.org/pipermail/toaster/2015-October/003234.html

Does take care of the issue I described above.

Thanks!

Belén

Quoted 97 lines

I can open a Bugzilla entry to track the work if you want me to.

Thanks!

Belén

Quoted 83 lines

- David

Quoted 80 lines

-----Original Message-----
From: Reyna, David
Sent: Thursday, November 05, 2015 9:41 AM
To: 'Ed Bartosh'; [email protected]
Subject: RE: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable

Hi Ed,

Have you tested this patch against the project configure variables page?

Specifically, this variable is also coded into these two files:

views.py
templates/projectconf.html

Are these files being handled in a separate commit?

- David

Quoted 7 lines

-----Original Message-----
From: [email protected] [mailto:toaster- [email protected]] On Behalf Of Ed Bartosh
Sent: Thursday, November 05, 2015 9:23 AM
To: [email protected]
Subject: [Toaster] [PATCH v2 0/2] remove SDKMACHINE variable

Quoted 7 lines

Hi,

This patchset contains two identical changes for toasterconf.json:
removing
SDKMACHINE variable. Variable is not used in toaster anymore as it's removed
by this change:

https://lists.yoctoproject.org/pipermail/toaster/2015-

Quoted 3 lines

October/003234.html

The patchset logically belongs to my previous patchset: 8279:

Provide

Quoted 13 lines

a single way of starting Toaster
I'm sending this in separate e-mail as below two patches should be send to different upstream projects:
openembedded-core and yocto.

Please, send them after my previous patchset is accepted.

Changes in v2: removed forgotten comma after "PACKAGE_CLASSES":
"package_rpm"

The following changes since commit
fc45deac89ef63ca1c44e763c38ced7dfd72cbe1:

Quoted 6 lines

build-appliance-image: Update to jethro head revision (2015-11-03
14:03:03 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ed/toaster/remove-

sdkmachine

Quoted 20 lines

http://git.yoctoproject.org/cgit.cgi/poky-
contrib/log/?h=ed/toaster/remove-sdkmachine

Ed Bartosh (2):
toasterconf: remove SDKMACHINE variable
toasterconf: remove SDKMACHINE variable

 meta-yocto/conf/toasterconf.json | 3 +--
 meta/conf/toasterconf.json       | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

--
Regards,
Ed

--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Signature · 4 lines
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster