Skip to contentSkip to conversation

gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

PATCH In review Robert Yang 3 participants 5 messages Jan 15, 2016 – Jan 19, 2016

lore
Share & tools
lore
#0 lore raw

cover gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

The following changes since commit 901af5a00338fd8f1ace939123484ea91c090a7a:

libaio: don't disable linking to the system libraries (2016-01-14 15:18:16 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/jethro-next
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/jethro-next

Robert Yang (1):
gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

 .../gstreamer/gstreamer1.0-plugins-good.inc        |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 gstreamer1.0-plugins-good.inc: add gudev back to PACKAGECONFIG

The 66e32244aed8d33f1b49fbe78179f2442545c730 wrongly removed gudev from PACKAGECONFIG, now add it back.

---
 .../gstreamer/gstreamer1.0-plugins-good.inc        |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc +1 -1
index edaafe8..2f987b4 100644
@@ -11,7 +11,7 @@ inherit gettext
 PACKAGECONFIG ??= " \
     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)} \
-    orc cairo flac gdk-pixbuf jpeg libpng soup speex taglib v4l2\
+    orc cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib v4l2 \
     "
 
 X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 2 lines · Robert Yang

The 66e32244aed8d33f1b49fbe78179f2442545c730 wrongly removed gudev from PACKAGECONFIG, now add it back.

It was removed intentionally, because for systemd images there isn't libgudev provider in oe-core, only in meta-oe.

RP's fix:
http://git.openembedded.org/openembedded-core/commit/?h=jethro&id=bc458ae9586b45b11b6908eadb31e94d892e698f

breaks the dependencies again, because when systemd is used there won't be libgudev needed by gstreamer1.0-plugins-good

Please revert both "fixes"

Regards,

Quoted 27 lines
---
 .../gstreamer/gstreamer1.0-plugins-good.inc        |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good.inc +1 -1
index edaafe8..2f987b4 100644
@@ -11,7 +11,7 @@ inherit gettext
 PACKAGECONFIG ??= " \
     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)} \
-    orc cairo flac gdk-pixbuf jpeg libpng soup speex taglib v4l2\
+    orc cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib v4l2 \
     "
 
 X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
Signature · 7 lines
1.7.9.5

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw
Quoted 12 lines · Martin Jansa
Quoted 3 lines · Robert Yang

The 66e32244aed8d33f1b49fbe78179f2442545c730 wrongly removed gudev from
PACKAGECONFIG, now add it back.

It was removed intentionally, because for systemd images there isn't libgudev provider in oe-core, only in meta-oe.

RP's fix:
http://git.openembedded.org/openembedded-core/commit/?h=jethro&id=bc4
58ae9586b45b11b6908eadb31e94d892e698f

Quoted 5 lines

breaks the dependencies again, because when systemd is used there won't
be libgudev needed by gstreamer1.0-plugins-good

Please revert both "fixes"

The "backported" patch should have made mention of the changes compared to the version in master since otherwise, "intentionally" looked like a mistake :/.

What is the impact to gstreamer of removing libgudev?

Cheers,

Richard

#4 lore raw
Quoted 13 lines · Richard Purdie
Quoted 12 lines · Martin Jansa
Quoted 3 lines · Robert Yang

The 66e32244aed8d33f1b49fbe78179f2442545c730 wrongly removed gudev from
PACKAGECONFIG, now add it back.

It was removed intentionally, because for systemd images there isn't libgudev provider in oe-core, only in meta-oe.

RP's fix:
http://git.openembedded.org/openembedded-core/commit/?h=jethro&id=bc4
58ae9586b45b11b6908eadb31e94d892e698f

Quoted 5 lines
Quoted 5 lines

breaks the dependencies again, because when systemd is used there won't
be libgudev needed by gstreamer1.0-plugins-good

Please revert both "fixes"

Sorry, I wrongly thought it was a mistake, but was intention.

// Robert

Quoted 11 lines

The "backported" patch should have made mention of the changes compared to the version in master since otherwise, "intentionally" looked like a mistake :/.

What is the impact to gstreamer of removing libgudev?

Cheers,

Richard