Skip to contentSkip to conversation

insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

PATCH In review Robert Yang 5 participants 7 messages Jan 21, 2016

lore
Share & tools
lore

Robert Yang

author
#0 lore raw

cover insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

The following changes since commit 8084c185c43cb7e7f5e29d31939dfd308f8a0f93:

udev: Add 2 patches to support 4.4 kernel (2016-01-20 09:20:06 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/rerun
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/rerun

Robert Yang (1):
insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

 meta/classes/insane.bbclass |    1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

do_package_qa() should rerun when WARN_QA or ERROR_QA changed

[YOCTO #8445]

Signed-off-by Robert Yang <[email protected]>
---
 meta/classes/insane.bbclass |    1 +
 1 file changed, 1 insertion(+)
meta/classes/insane.bbclass +1 -0
index f7781ce..0ab756f 100644
@@ -1098,6 +1098,7 @@ python do_package_qa () {
 
 do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
 do_package_qa[rdeptask] = "do_packagedata"
+do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"
 addtask do_package_qa after do_packagedata do_package before do_build
 
 SSTATETASKS += "do_package_qa"
Signature · 1 line
1.7.9.5
#2 lore raw

meta/classes/insane.bbclass python do_package_qa () { · line 1101

Quoted 7 lines · Robert Yang
meta/classes/insane.bbclass +1 -0
@@ -1098,6 +1098,7 @@ python do_package_qa () {
 
 do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
 do_package_qa[rdeptask] = "do_packagedata"
+do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"

Shouldn't this be "WARN_QA ERROR_QA"? Or you'll get the expanded values of the variables.

Signature · 1 line
olofjn
author
#3 lore raw
Quoted 11 lines · Olof Johansson

meta/classes/insane.bbclass python do_package_qa () { · line 1101

Quoted 7 lines · Robert Yang
meta/classes/insane.bbclass +1 -0
@@ -1098,6 +1098,7 @@ python do_package_qa () {
 
  do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
  do_package_qa[rdeptask] = "do_packagedata"
+do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"

Shouldn't this be "WARN_QA ERROR_QA"? Or you'll get the expanded values of the variables.

Sorry, please drop this patch, need more work it.

// Robert

Quoted 1 line
#4 lore raw
Quoted 9 lines · On Thu, 21 Jan 2016 16:42:00 Robert Yang wrote:
Quoted 8 lines · Olof Johansson
Quoted 7 lines · Robert Yang
meta/classes/insane.bbclass +0 -0
@@ -1098,6 +1098,7 @@ python do_package_qa () {
 
  do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
  do_package_qa[rdeptask] = "do_packagedata"
Quoted 6 lines
Quoted 4 lines

meta/classes/insane.bbclass python do_package_qa () { · line 1101

Quoted 1 line
meta/classes/insane.bbclass +1 -0
+do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"

Shouldn't this be "WARN_QA ERROR_QA"? Or you'll get the expanded values of the variables.

Sorry, please drop this patch, need more work it.

Aside from that, didn't we already have a discussion on whether changing these variables should force do_package_qa to re-execute? Ross, I seem to recall you were involved last time.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#5 lore raw
Quoted 15 lines · Paul Eggleton
Quoted 14 lines · On Thu, 21 Jan 2016 16:42:00 Robert Yang wrote:
Quoted 12 lines · Olof Johansson

meta/classes/insane.bbclass python do_package_qa () { · line 1102

Quoted 8 lines · Robert Yang
meta/classes/insane.bbclass +1 -0
@@ -1098,6 +1098,7 @@ python do_package_qa () {
 
  do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
  do_package_qa[rdeptask] = "do_packagedata"
 
+do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"

Shouldn't this be "WARN_QA ERROR_QA"? Or you'll get the expanded values of the variables.

Quoted 7 lines
Quoted 1 line

Sorry, please drop this patch, need more work it.

Aside from that, didn't we already have a discussion on whether changing these
variables should force do_package_qa to re-execute? Ross, I seem to recall you
were involved last time.

Last time around we ended up with:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=f6ec8dfaf7f98ade05d6292d2fea42805c4d80a7

Cheers,

Richard