Skip to contentSkip to conversation

add dma mapping error and remove parantheses

PATCH New Haneen Mohammed 1 participant 3 messages Feb 9, 2016 Staging

lore
Share & tools
lore
#0 lore raw

v3 cover add dma mapping error and remove parantheses

This patchset fix check for dma mapping error, as well as removes unnecessary parantheses in the same scope.

Haneen Mohammed (2):
Staging: rts5208: fix check for dma mapping error
Staging: rts5208: remove unnecessary parantheses

 drivers/staging/rts5208/rtsx_transport.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.9.1
#1 lore raw

PATCH v3 1/2 Staging: rts5208: fix check for dma mapping error

use dma_mapping_error() instead of comparing the returned address with zero after dma_map_single().

---
Changes in v2: Make patchset to remove extra parantheses Changes in v3: Add acknowledgement.

 drivers/staging/rts5208/rtsx_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rts5208/rtsx_transport.c +1 -1
index f27491e..0c9549b 100644
@@ -653,7 +653,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
 		return -ENXIO;
 
 	addr = dma_map_single(&(rtsx->pci->dev), buf, len, dma_dir);
-	if (!addr)
+	if (dma_mapping_error(&rtsx->pci->dev, addr))
 		return -ENOMEM;
 
 	if (card == SD_CARD)
Signature · 1 line
1.9.1
#2 lore raw

PATCH v3 2/2 Staging: rts5208: remove unnecessary parantheses

In reply to Haneen Mohammed

This patch removes unnecessary parantheses around rtsx->pci->dev.

---
Changes in v3: Add acknowledgement.

 drivers/staging/rts5208/rtsx_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rts5208/rtsx_transport.c +1 -1
index 0c9549b..f2eb18e 100644
@@ -652,7 +652,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
 	else
 		return -ENXIO;
 
-	addr = dma_map_single(&(rtsx->pci->dev), buf, len, dma_dir);
+	addr = dma_map_single(&rtsx->pci->dev, buf, len, dma_dir);
 	if (dma_mapping_error(&rtsx->pci->dev, addr))
 		return -ENOMEM;
 
Signature · 1 line
1.9.1