Skip to contentSkip to conversation

Staging: wlan-ng: Remove unused functions.

PATCH New Bhumika Goyal 1 participant 3 messages Feb 17, 2016 Staging

lore
Share & tools
lore
#0 lore raw

v3 cover Staging: wlan-ng: Remove unused functions.

The functions hfa384x_drvr_commtallies and hfa384x_drvr_getconfig_async are not used anywhere in the kernel so remove it. Also remove the prototypes from the header file. Also remove function hfa384x_cb_rrid and its prototype as it was only used by hfa384x_drvr_getconfig_async.

Changes in v2:
* Combine patches 1 and 2 of v1 in a single patch to remove function hfa384x_drvr_commtallies and its prototype.
* Combine patches 3 and 4 of v1 in a single patch to remove function hfa384x_drvr_getconfig_async and its prototype .

Changes in v3:
* Remove function hfa384x_cb_rrid and its prototype as it was only used by hfa384x_drvr_getconfig_async.

Bhumika Goyal (2):
Staging: wlan-ng: Remove function hfa384x_drvr_commtallies
Staging: wlan-ng: Remove unused functions and prototypes

 drivers/staging/wlan-ng/hfa384x.h     |  4 --
 drivers/staging/wlan-ng/hfa384x_usb.c | 74 -----------------------------------
 2 files changed, 78 deletions(-)
Signature · 1 line
1.9.1
#1 lore raw

PATCH v3 1/2 Staging: wlan-ng: Remove function hfa384x_drvr_commtallies

The function hfa384x_drvr_commtallies is not used anywhere in the kernel so remove it. Also remove its prototype from the header file.

---
Changes in v2:
* Combine patches 1 and 2 of v1 in a single patch to remove both the function and its prototype.
Changes in v3:
* No change.

 drivers/staging/wlan-ng/hfa384x.h     |  1 -
 drivers/staging/wlan-ng/hfa384x_usb.c | 31 -------------------------------
 2 files changed, 32 deletions(-)
drivers/staging/wlan-ng/hfa384x.h +0 -1
index 3bc8439..cec6d0b 100644
@@ -1360,7 +1360,6 @@ void hfa384x_destroy(hfa384x_t *hw);
 
 int
 hfa384x_corereset(hfa384x_t *hw, int holdtime, int settletime, int genesis);
-int hfa384x_drvr_commtallies(hfa384x_t *hw);
 int hfa384x_drvr_disable(hfa384x_t *hw, u16 macport);
 int hfa384x_drvr_enable(hfa384x_t *hw, u16 macport);
 int hfa384x_drvr_flashdl_enable(hfa384x_t *hw);
drivers/staging/wlan-ng/hfa384x_usb.c +0 -31
index b6cf93d..4e4b6e3 100644
@@ -1708,37 +1708,6 @@ done:
 }
 
 /*----------------------------------------------------------------
-* hfa384x_drvr_commtallies
-*
-* Send a commtallies inquiry to the MAC.  Note that this is an async
-* call that will result in an info frame arriving sometime later.
-*
-* Arguments:
-*	hw		device structure
-*
-* Returns:
-*	zero		success.
-*
-* Side effects:
-*
-* Call context:
-*	process
-----------------------------------------------------------------*/
-int hfa384x_drvr_commtallies(hfa384x_t *hw)
-{
-	hfa384x_metacmd_t cmd;
-
-	cmd.cmd = HFA384x_CMDCODE_INQ;
-	cmd.parm0 = HFA384x_IT_COMMTALLIES;
-	cmd.parm1 = 0;
-	cmd.parm2 = 0;
-
-	hfa384x_docmd_async(hw, &cmd, NULL, NULL, NULL);
-
-	return 0;
-}
-
-/*----------------------------------------------------------------
 * hfa384x_drvr_disable
 *
 * Issues the disable command to stop communications on one of
Signature · 1 line
1.9.1
#2 lore raw

PATCH v3 2/2 Staging: wlan-ng: Remove unused functions and prototypes

In reply to Bhumika Goyal

hfa384x_drvr_getconfig_async is not used anywhere in the kernel so remove it. Also remove its prototype from the header file. Also the function hfa384x_cb_rrid was only used by hfa384x_drvr_getconfig_async so remove its definition and prototype as well.

---
Changes in v2:
* Combine patches 3 and 4 of v1 in a single patch to remove both the function and its prototype.
Changes in v3:
* Remove hfa384x_cb_rrid to avoid build warning.

 drivers/staging/wlan-ng/hfa384x.h     |  4 --
 drivers/staging/wlan-ng/hfa384x_usb.c | 74 -----------------------------------
 2 files changed, 78 deletions(-)
drivers/staging/wlan-ng/hfa384x.h +0 -4
index 4fd3145..cec6d0b 100644
@@ -1390,10 +1390,6 @@ static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
 }
 
 int
-hfa384x_drvr_getconfig_async(hfa384x_t *hw,
-			     u16 rid, ctlx_usercb_t usercb, void *usercb_data);
-
-int
 hfa384x_drvr_setconfig_async(hfa384x_t *hw,
 			     u16 rid,
 			     void *buf,
drivers/staging/wlan-ng/hfa384x_usb.c +0 -74

92 lines not on this page · raw message

Signature · 1 line
1.9.1