Skip to contentSkip to conversation

Yocto Bug #6945

PATCH Superseded [email protected] 2 participants 9 messages Feb 24, 2016 – Apr 5, 2016

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

[email protected]

author
#0 lore raw

v3 cover Yocto Bug #6945

From: He Zhe <[email protected]>

v1 to v2:
- Change KERNEL_OUTPUT to KERNEL_OUTPUT_DIR and update comments
- Update related doc files
- Replace all KERNEL_ALT_IMAGETYPEs with KERNEL_IMAGETYPES
- Link built vmlinuz to boot directory for reference

v2 to v3:
- Merge existing KERNEL_ALT_IMAGETYPE into KERNEL_IMAGETYPES in order that users can still use the old variables.
- Run oe_rummake in a loop for every types so that we can add different configurations to them easily in the future.
- Warn, intead of die, users if one of the types are over the size limit.
- Remove the replacement of KERNEL_ALT_IMAGETYPE in v2.
- Remove the doc parts. They will be submitted yocto-docs later.
- Change some grep usage to make it more clear.
- Correct a typo.

The following changes since commit 23056103c949b498c23b47579e8dd57ce78e6ed9:

uclibc: Do not use immediate expansion operator (2016-02-22 20:42:48 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib zhe/yocto-bug-6945
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=zhe/yocto-bug-6945

for you to fetch changes up to dc52a1efbb8248ea274a1cd0cca5734290b3025f:

kernel: Make symbol link to vmlinuz in boot directory (2016-02-24 07:08:16 -0500)

----------------------------------------------------------------
He Zhe (2):
kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time
kernel: Make symbol link to vmlinuz in boot directory

 meta/classes/kernel-fitimage.bbclass      |  20 ++++++++-------
 meta/classes/kernel-grub.bbclass          |  44 +++++++++++++++++++++-----------
 meta/classes/kernel-uimage.bbclass        |  22 ++++++++--------
 meta/classes/kernel.bbclass               | 187 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------
 meta/conf/documentation.conf              |   3 ++-
 meta/recipes-kernel/linux/linux-dtb.inc   |  49 ++++++++++++++++++++++--------------
 meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
 7 files changed, 218 insertions(+), 109 deletions(-)

He Zhe (2):
kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time
kernel: Make symbol link to vmlinuz in boot directory

 meta/classes/kernel-fitimage.bbclass      |  20 ++--
 meta/classes/kernel-grub.bbclass          |  44 ++++---
 meta/classes/kernel-uimage.bbclass        |  22 ++--
 meta/classes/kernel.bbclass               | 187 +++++++++++++++++++++---------
 meta/conf/documentation.conf              |   3 +-
 meta/recipes-kernel/linux/linux-dtb.inc   |  49 +++++---
 meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
 7 files changed, 218 insertions(+), 109 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH v3 1/2 kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time

From: He Zhe <[email protected]>

Add KERNEL_IMAGETYPES to support building packaging and installing multi types of kernel images, such as zImage uImage, at one time.

KERNEL_IMAGETYPE and KERNEL_ALT_IMAGETYPE work as before.

Signed-off-by He Zhe <[email protected]>
---
 meta/classes/kernel-fitimage.bbclass    |  20 ++--
 meta/classes/kernel-grub.bbclass        |  44 +++++---
 meta/classes/kernel-uimage.bbclass      |  22 ++--
 meta/classes/kernel.bbclass             | 174 +++++++++++++++++++++++---------
 meta/conf/documentation.conf            |   1 +
 meta/recipes-kernel/linux/linux-dtb.inc |  49 +++++----
 6 files changed, 208 insertions(+), 102 deletions(-)
meta/classes/kernel-fitimage.bbclass +11 -9
index f1b409c..633668f 100644
@@ -1,8 +1,8 @@
 inherit kernel-uboot
 
 python __anonymous () {
-    kerneltype = d.getVar('KERNEL_IMAGETYPE', True)
-    if kerneltype == 'fitImage':
+    kerneltypes = d.getVar('KERNEL_IMAGETYPES', True) or ""
+    if 'fitImage' in kerneltypes.split():
         depends = d.getVar("DEPENDS", True)
         depends = "%s u-boot-mkimage-native dtc-native" % depends
         d.setVar("DEPENDS", depends)

@@ -10,7 +10,9 @@ python __anonymous () {
 	# Override KERNEL_IMAGETYPE_FOR_MAKE variable, which is internal
 	# to kernel.bbclass . We have to override it, since we pack zImage
 	# (at least for now) into the fitImage .
-        d.setVar("KERNEL_IMAGETYPE_FOR_MAKE", "zImage")
+        typeformake = d.getVar("KERNEL_IMAGETYPE_FOR_MAKE", True) or ""
+        if 'fitImage' in typeformake.split():
+            d.setVar('KERNEL_IMAGETYPE_FOR_MAKE', typeformake.replace('fitImage', 'zImage'))
 
         image = d.getVar('INITRAMFS_IMAGE', True)
         if image:

@@ -154,7 +156,7 @@ EOF
 }
 
 do_assemble_fitimage() {
-	if test "x${KERNEL_IMAGETYPE}" = "xfitImage" ; then
+	if echo ${KERNEL_IMAGETYPES} | grep -wq "fitImage"; then
 		kernelcount=1
 		dtbcount=""
 		rm -f fit-image.its

@@ -217,14 +219,14 @@ addtask assemble_fitimage before do_install after do_compile
 
 kernel_do_deploy_append() {
 	# Update deploy directory
-	if test "x${KERNEL_IMAGETYPE}" = "xfitImage" ; then
+	if echo ${KERNEL_IMAGETYPES} | grep -wq "fitImage"; then
 		cd ${B}
 		echo "Copying fit-image.its source file..."
-		its_base_name="${KERNEL_IMAGETYPE}-its-${PV}-${PR}-${MACHINE}-${DATETIME}"
-		its_symlink_name=${KERNEL_IMAGETYPE}-its-${MACHINE}
+		its_base_name="fitImage-its-${PV}-${PR}-${MACHINE}-${DATETIME}"
+		its_symlink_name=fitImage-its-${MACHINE}
 		install -m 0644 fit-image.its ${DEPLOYDIR}/${its_base_name}.its
-		linux_bin_base_name="${KERNEL_IMAGETYPE}-linux.bin-${PV}-${PR}-${MACHINE}-${DATETIME}"
-		linux_bin_symlink_name=${KERNEL_IMAGETYPE}-linux.bin-${MACHINE}
+		linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-${DATETIME}"
+		linux_bin_symlink_name=fitImage-linux.bin-${MACHINE}
 		install -m 0644 linux.bin ${DEPLOYDIR}/${linux_bin_base_name}.bin
 
 		cd ${DEPLOYDIR}
meta/classes/kernel-grub.bbclass +29 -15

82 lines not on this page · raw message

meta/classes/kernel-uimage.bbclass +12 -10
index f73965b..a238ce4 100644
@@ -1,23 +1,25 @@
 inherit kernel-uboot
 
 python __anonymous () {
-    kerneltype = d.getVar('KERNEL_IMAGETYPE', True)
-    if kerneltype == 'uImage':
+    if "uImage" in (d.getVar('KERNEL_IMAGETYPES', True) or "").split():
         depends = d.getVar("DEPENDS", True)
         depends = "%s u-boot-mkimage-native" % depends
         d.setVar("DEPENDS", depends)
 
-	# Override KERNEL_IMAGETYPE_FOR_MAKE variable, which is internal
-	# to kernel.bbclass . We override the variable here, since we need
-	# to build uImage using the kernel build system if and only if
-	# KEEPUIMAGE == yes. Otherwise, we pack compressed vmlinux into
-	# the uImage .
-	if d.getVar("KEEPUIMAGE", True) != 'yes':
-            d.setVar("KERNEL_IMAGETYPE_FOR_MAKE", "zImage")
+        # Override KERNEL_IMAGETYPE_FOR_MAKE variable, which is internal
+        # to kernel.bbclass . We override the variable here, since we need
+        # to build uImage using the kernel build system if and only if
+        # KEEPUIMAGE == yes. Otherwise, we pack compressed vmlinux into
+        # the uImage .
+        if d.getVar("KEEPUIMAGE", True) != 'yes':
+            typeformake = d.getVar("KERNEL_IMAGETYPE_FOR_MAKE", True) or ""
+            if "uImage" in typeformake.split():
+                typeformake.replace('uImage', 'zImage')
+            d.setVar('KERNEL_IMAGETYPE_FOR_MAKE', typeformake)
 }
 
 do_uboot_mkimage() {
-	if test "x${KERNEL_IMAGETYPE}" = "xuImage" ; then
+	if echo "${KERNEL_IMAGETYPES}" | grep -Pq "\buImage\b"; then
 		if test "x${KEEPUIMAGE}" != "xyes" ; then
 			uboot_prep_kimage
meta/classes/kernel.bbclass +125 -49

279 lines not on this page · raw message

meta/conf/documentation.conf +1 -0
index 00a69da..b3969b0 100644
@@ -246,6 +246,7 @@ KERNEL_CLASSES[doc] = "A list of classes defining kernel image types that kernel
 KERNEL_EXTRA_ARGS[doc] = "Specifies additional make command-line arguments the OpenEmbedded build system passes on when compiling the kernel."
 KERNEL_FEATURES[doc] = "Includes additional metadata from the Yocto Project kernel Git repository. The metadata you add through this variable includes config fragments and features descriptions."
 KERNEL_IMAGETYPE[doc] = "The type of kernel to build for a device, usually set by the machine configuration files and defaults to 'zImage'."
+KERNEL_IMAGETYPES[doc] = "The list of types of kernel to build for a device, usually set by the machine configuration files and defaults to KERNEL_IMAGETYPE."
 KERNEL_MODULE_AUTOLOAD[doc] = "Lists kernel modules that need to be auto-loaded during boot"
 KERNEL_MODULE_PROBECONF[doc] = "Lists kernel modules for which the build system expects to find module_conf_* values that specify configuration for each of the modules"
 KERNEL_PATH[doc] = "The location of the kernel sources. This variable is set to the value of the STAGING_KERNEL_DIR within the module class (module.bbclass)."
meta/recipes-kernel/linux/linux-dtb.inc +30 -19

70 lines not on this page · raw message

Signature · 1 line
1.9.1
author
#2 lore raw

PATCH v3 2/2 kernel: Make symbol link to vmlinuz in boot directory

In reply to [email protected]

From: He Zhe <[email protected]>

Rename do_kernel_link_vmlinux to do_kernel_link_images and make a symbol link to vmlinuz(if exists) for reference in arch/$arch/boot directory.

Signen-off-by He Zhe <[email protected]>
---
 meta/classes/kernel.bbclass               | 13 ++++++++-----
 meta/conf/documentation.conf              |  2 +-
 meta/recipes-kernel/linux/linux-yocto.inc |  2 +-
 3 files changed, 10 insertions(+), 7 deletions(-)
meta/classes/kernel.bbclass +8 -5
index 3f92fdc..8cc944c 100644
@@ -474,15 +474,18 @@ python split_kernel_packages () {
 }
 
 # Many scripts want to look in arch/$arch/boot for the bootable
-# image. This poses a problem for vmlinux based booting. This 
-# task arranges to have vmlinux appear in the normalized directory
-# location.
-do_kernel_link_vmlinux() {
+# image. This poses a problem for vmlinux and vmlinuz based
+# booting. This task arranges to have vmlinux and vmlinuz appear
+# in the normalized directory location.
+do_kernel_link_images() {
 	if [ ! -d "${B}/arch/${ARCH}/boot" ]; then
 		mkdir ${B}/arch/${ARCH}/boot
 	fi
 	cd ${B}/arch/${ARCH}/boot
 	ln -sf ../../../vmlinux
+	if [ -f ../../../vmlinuz ]; then
+		ln -sf ../../../vmlinuz
+	fi
 }
 
 do_strip() {

@@ -512,7 +515,7 @@ do_strip() {
 }
 do_strip[dirs] = "${B}"
 
-addtask do_strip before do_sizecheck after do_kernel_link_vmlinux
+addtask do_strip before do_sizecheck after do_kernel_link_images
 
 # Support checking the kernel size since some kernels need to reside in partitions
 # with a fixed length or there is a limit in transferring the kernel to memory
meta/conf/documentation.conf +1 -1
index b3969b0..f0c2399 100644
@@ -28,7 +28,7 @@ do_install_ptest_base[doc] = "Copies the runtime test suite files from the compi
 do_kernel_checkout[doc] = "Checks out source/meta branches for a linux-yocto style kernel"
 do_kernel_configcheck[doc] = "Validates the kernel configuration for a linux-yocto style kernel"
 do_kernel_configme[doc] = "Assembles the kernel configuration for a linux-yocto style kernel"
-do_kernel_link_vmlinux[doc] = "Creates a symbolic link in arch/$arch/boot for vmlinux kernel images"
+do_kernel_link_images[doc] = "Creates a symbolic link in arch/$arch/boot for vmlinux and vmlinuz kernel images"
 do_listtasks[doc] = "Lists all defined tasks for a target"
 do_menuconfig[doc] = "Runs 'make menuconfig' for the kernel"
 do_package[doc] = "Analyzes the content of the holding area and splits it into subsets based on available packages and files"
meta/recipes-kernel/linux/linux-yocto.inc +1 -1
index 6b161fc..fd68786 100644
@@ -52,6 +52,6 @@ do_install_append(){
 }
 
 # extra tasks
-addtask kernel_link_vmlinux after do_compile before do_install
+addtask kernel_link_images after do_compile before do_install
 addtask validate_branches before do_patch after do_kernel_checkout
 addtask kernel_configcheck after do_configure before do_compile
Signature · 1 line
1.9.1
author
#3 lore raw
In reply to [email protected]

Any more comments?

Thanks,
Zhe

Quoted 57 lines · On 02/24/2016 08:20 PM, [email protected] wrote:

From: He Zhe <[email protected]>

v1 to v2:
- Change KERNEL_OUTPUT to KERNEL_OUTPUT_DIR and update comments
- Update related doc files
- Replace all KERNEL_ALT_IMAGETYPEs with KERNEL_IMAGETYPES
- Link built vmlinuz to boot directory for reference

v2 to v3:
- Merge existing KERNEL_ALT_IMAGETYPE into KERNEL_IMAGETYPES in order that users can still use the old variables.
- Run oe_rummake in a loop for every types so that we can add different configurations to them easily in the future.
- Warn, intead of die, users if one of the types are over the size limit.
- Remove the replacement of KERNEL_ALT_IMAGETYPE in v2.
- Remove the doc parts. They will be submitted yocto-docs later.
- Change some grep usage to make it more clear.
- Correct a typo.

The following changes since commit 23056103c949b498c23b47579e8dd57ce78e6ed9:

uclibc: Do not use immediate expansion operator (2016-02-22 20:42:48 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib zhe/yocto-bug-6945
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=zhe/yocto-bug-6945

for you to fetch changes up to dc52a1efbb8248ea274a1cd0cca5734290b3025f:

kernel: Make symbol link to vmlinuz in boot directory (2016-02-24 07:08:16 -0500)

----------------------------------------------------------------
He Zhe (2):
kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time
kernel: Make symbol link to vmlinuz in boot directory

 meta/classes/kernel-fitimage.bbclass      |  20 ++++++++-------
 meta/classes/kernel-grub.bbclass          |  44 +++++++++++++++++++++-----------
 meta/classes/kernel-uimage.bbclass        |  22 ++++++++--------
 meta/classes/kernel.bbclass               | 187 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------
 meta/conf/documentation.conf              |   3 ++-
 meta/recipes-kernel/linux/linux-dtb.inc   |  49 ++++++++++++++++++++++--------------
 meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
 7 files changed, 218 insertions(+), 109 deletions(-)

He Zhe (2):
kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time
kernel: Make symbol link to vmlinuz in boot directory

 meta/classes/kernel-fitimage.bbclass      |  20 ++--
 meta/classes/kernel-grub.bbclass          |  44 ++++---
 meta/classes/kernel-uimage.bbclass        |  22 ++--
 meta/classes/kernel.bbclass               | 187 +++++++++++++++++++++---------
 meta/conf/documentation.conf              |   3 +-
 meta/recipes-kernel/linux/linux-dtb.inc   |  49 +++++---
 meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
 7 files changed, 218 insertions(+), 109 deletions(-)
author
#4 lore raw

Ping.

Thanks,
Zhe

Quoted 63 lines · He Zhe

Any more comments?

Thanks,
Zhe

Quoted 57 lines · On 02/24/2016 08:20 PM, [email protected] wrote:

From: He Zhe <[email protected]>

v1 to v2:
- Change KERNEL_OUTPUT to KERNEL_OUTPUT_DIR and update comments
- Update related doc files
- Replace all KERNEL_ALT_IMAGETYPEs with KERNEL_IMAGETYPES
- Link built vmlinuz to boot directory for reference

v2 to v3:
- Merge existing KERNEL_ALT_IMAGETYPE into KERNEL_IMAGETYPES in order that users can still use the old variables.
- Run oe_rummake in a loop for every types so that we can add different configurations to them easily in the future.
- Warn, intead of die, users if one of the types are over the size limit.
- Remove the replacement of KERNEL_ALT_IMAGETYPE in v2.
- Remove the doc parts. They will be submitted yocto-docs later.
- Change some grep usage to make it more clear.
- Correct a typo.

The following changes since commit 23056103c949b498c23b47579e8dd57ce78e6ed9:

uclibc: Do not use immediate expansion operator (2016-02-22 20:42:48 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib zhe/yocto-bug-6945
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=zhe/yocto-bug-6945

for you to fetch changes up to dc52a1efbb8248ea274a1cd0cca5734290b3025f:

kernel: Make symbol link to vmlinuz in boot directory (2016-02-24 07:08:16 -0500)

----------------------------------------------------------------
He Zhe (2):
kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time
kernel: Make symbol link to vmlinuz in boot directory

 meta/classes/kernel-fitimage.bbclass      |  20 ++++++++-------
 meta/classes/kernel-grub.bbclass          |  44 +++++++++++++++++++++-----------
 meta/classes/kernel-uimage.bbclass        |  22 ++++++++--------
 meta/classes/kernel.bbclass               | 187 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------
 meta/conf/documentation.conf              |   3 ++-
 meta/recipes-kernel/linux/linux-dtb.inc   |  49 ++++++++++++++++++++++--------------
 meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
 7 files changed, 218 insertions(+), 109 deletions(-)

He Zhe (2):
kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time
kernel: Make symbol link to vmlinuz in boot directory

 meta/classes/kernel-fitimage.bbclass      |  20 ++--
 meta/classes/kernel-grub.bbclass          |  44 ++++---
 meta/classes/kernel-uimage.bbclass        |  22 ++--
 meta/classes/kernel.bbclass               | 187 +++++++++++++++++++++---------
 meta/conf/documentation.conf              |   3 +-
 meta/recipes-kernel/linux/linux-dtb.inc   |  49 +++++---
 meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
 7 files changed, 218 insertions(+), 109 deletions(-)
#5 lore raw
Quoted 3 lines · He Zhe

Ping.

This slipped through my filters. Sorry about that.

We are too late for the 2.1 release at this point, but I'll review the changes again in the
morning and send any comments that I may have.

Cheers,

Bruce

Quoted 86 lines

Thanks,
Zhe

Quoted 16 lines · He Zhe

Any more comments?

Thanks,
Zhe

Quoted 10 lines · On 02/24/2016 08:20 PM, [email protected] wrote:

From: He Zhe <[email protected]>

v1 to v2:
- Change KERNEL_OUTPUT to KERNEL_OUTPUT_DIR and update comments
- Update related doc files
- Replace all KERNEL_ALT_IMAGETYPEs with KERNEL_IMAGETYPES
- Link built vmlinuz to boot directory for reference

v2 to v3:
- Merge existing KERNEL_ALT_IMAGETYPE into KERNEL_IMAGETYPES in order

that users can still use the old variables.

Quoted 1 line
Quoted 1 line

- Run oe_rummake in a loop for every types so that we can add

different configurations to them easily in the future.

Quoted 1 line
Quoted 1 line

- Warn, intead of die, users if one of the types are over the size

limit.

Quoted 6 lines
Quoted 6 lines

- Remove the replacement of KERNEL_ALT_IMAGETYPE in v2.
- Remove the doc parts. They will be submitted yocto-docs later.
- Change some grep usage to make it more clear.
- Correct a typo.

The following changes since commit

23056103c949b498c23b47579e8dd57ce78e6ed9:

Quoted 2 lines
Quoted 2 lines

uclibc: Do not use immediate expansion operator (2016-02-22 20:42:48

+0000)

Quoted 5 lines
Quoted 5 lines

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib zhe/yocto-bug-6945

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=zhe/yocto-bug-6945

Quoted 4 lines
Quoted 4 lines

for you to fetch changes up to dc52a1efbb8248ea274a1cd0cca5734290b3025f:

kernel: Make symbol link to vmlinuz in boot directory (2016-02-24

07:08:16 -0500)

Quoted 4 lines
Quoted 4 lines

----------------------------------------------------------------
He Zhe (2):
kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one

time

Quoted 4 lines
Quoted 4 lines

kernel: Make symbol link to vmlinuz in boot directory

 meta/classes/kernel-fitimage.bbclass      |  20 ++++++++-------
 meta/classes/kernel-grub.bbclass          |  44

+++++++++++++++++++++-----------

Quoted 2 lines
Quoted 2 lines
 meta/classes/kernel-uimage.bbclass        |  22 ++++++++--------
 meta/classes/kernel.bbclass               | 187

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------

Quoted 2 lines
Quoted 2 lines
 meta/conf/documentation.conf              |   3 ++-
 meta/recipes-kernel/linux/linux-dtb.inc   |  49

++++++++++++++++++++++--------------

Quoted 11 lines
Quoted 11 lines
 meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
 7 files changed, 218 insertions(+), 109 deletions(-)

He Zhe (2):
kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time
kernel: Make symbol link to vmlinuz in boot directory

 meta/classes/kernel-fitimage.bbclass      |  20 ++--
 meta/classes/kernel-grub.bbclass          |  44 ++++---
 meta/classes/kernel-uimage.bbclass        |  22 ++--
 meta/classes/kernel.bbclass               | 187

+++++++++++++++++++++---------

Quoted 5 lines
Quoted 5 lines
 meta/conf/documentation.conf              |   3 +-
 meta/recipes-kernel/linux/linux-dtb.inc   |  49 +++++---
 meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
 7 files changed, 218 insertions(+), 109 deletions(-)

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
#6 lore raw
Quoted 4 lines · Bruce Ashfield

On Mon, Mar 21, 2016 at 10:31 PM, He Zhe <[email protected]> wrote:

Quoted 9 lines
Quoted 3 lines

Ping.

This slipped through my filters. Sorry about that.

We are too late for the 2.1 release at this point, but I'll review the changes again in the
morning and send any comments that I may have.

I reviewed this version, and it looks fine to me.

Bruce

Quoted 100 lines

Cheers,

Bruce

Quoted 81 lines

Thanks,
Zhe

Quoted 16 lines · He Zhe

Any more comments?

Thanks,
Zhe

Quoted 10 lines · On 02/24/2016 08:20 PM, [email protected] wrote:

From: He Zhe <[email protected]>

v1 to v2:
- Change KERNEL_OUTPUT to KERNEL_OUTPUT_DIR and update comments
- Update related doc files
- Replace all KERNEL_ALT_IMAGETYPEs with KERNEL_IMAGETYPES
- Link built vmlinuz to boot directory for reference

v2 to v3:
- Merge existing KERNEL_ALT_IMAGETYPE into KERNEL_IMAGETYPES in order

that users can still use the old variables.

Quoted 1 line
Quoted 1 line

- Run oe_rummake in a loop for every types so that we can add

different configurations to them easily in the future.

Quoted 1 line
Quoted 1 line

- Warn, intead of die, users if one of the types are over the size

limit.

Quoted 6 lines
Quoted 6 lines

- Remove the replacement of KERNEL_ALT_IMAGETYPE in v2.
- Remove the doc parts. They will be submitted yocto-docs later.
- Change some grep usage to make it more clear.
- Correct a typo.

The following changes since commit

23056103c949b498c23b47579e8dd57ce78e6ed9:

Quoted 2 lines
Quoted 2 lines

uclibc: Do not use immediate expansion operator (2016-02-22 20:42:48

+0000)

Quoted 5 lines
Quoted 5 lines

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib zhe/yocto-bug-6945

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=zhe/yocto-bug-6945

Quoted 2 lines
Quoted 2 lines

for you to fetch changes up to

dc52a1efbb8248ea274a1cd0cca5734290b3025f:

Quoted 2 lines
Quoted 2 lines

kernel: Make symbol link to vmlinuz in boot directory (2016-02-24

07:08:16 -0500)

Quoted 4 lines
Quoted 4 lines

----------------------------------------------------------------
He Zhe (2):
kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one

time

Quoted 4 lines
Quoted 4 lines

kernel: Make symbol link to vmlinuz in boot directory

 meta/classes/kernel-fitimage.bbclass      |  20 ++++++++-------
 meta/classes/kernel-grub.bbclass          |  44

+++++++++++++++++++++-----------

Quoted 2 lines
Quoted 2 lines
 meta/classes/kernel-uimage.bbclass        |  22 ++++++++--------
 meta/classes/kernel.bbclass               | 187

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------

Quoted 2 lines
Quoted 2 lines
 meta/conf/documentation.conf              |   3 ++-
 meta/recipes-kernel/linux/linux-dtb.inc   |  49

++++++++++++++++++++++--------------

Quoted 11 lines
Quoted 11 lines
 meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
 7 files changed, 218 insertions(+), 109 deletions(-)

He Zhe (2):
kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time
kernel: Make symbol link to vmlinuz in boot directory

 meta/classes/kernel-fitimage.bbclass      |  20 ++--
 meta/classes/kernel-grub.bbclass          |  44 ++++---
 meta/classes/kernel-uimage.bbclass        |  22 ++--
 meta/classes/kernel.bbclass               | 187

+++++++++++++++++++++---------

Quoted 5 lines
Quoted 5 lines
 meta/conf/documentation.conf              |   3 +-
 meta/recipes-kernel/linux/linux-dtb.inc   |  49 +++++---
 meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
 7 files changed, 218 insertions(+), 109 deletions(-)
Quoted 6 lines

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
author
#7 lore raw
Quoted 11 lines · Bruce Ashfield

On Mon, Mar 21, 2016 at 11:37 PM, Bruce Ashfield <[email protected] <mailto:[email protected]>>wrote:

On Mon, Mar 21, 2016 at 10:31 PM, He Zhe <[email protected] <mailto:[email protected]>>wrote:

Ping.

Quoted 8 lines

This slipped through my filters. Sorry about that.

We are too late for the 2.1 release at this point, but I'll review the changes again in the morning and send any comments that I may have.

I reviewed this version, and it looks fine to me.

Thank you Bruce. And which version do we expect this to be merged into? 2.1.1 or 2.2 M1?

Zhe

Quoted 94 lines

Bruce

    Cheers,

    Bruce
     

        Thanks,
        Zhe

        On 03/11/2016 11:32 AM, He Zhe wrote:
        > Any more comments?
        >
        > Thanks,
        > Zhe
        >
        > On 02/24/2016 08:20 PM, [email protected] <mailto:[email protected]>wrote:
        >> From: He Zhe <[email protected] <mailto:[email protected]>>
        >>
        >> v1 to v2:
        >>  - Change KERNEL_OUTPUT to KERNEL_OUTPUT_DIR and update comments
        >>  - Update related doc files
        >>  - Replace all KERNEL_ALT_IMAGETYPEs with KERNEL_IMAGETYPES
        >>  - Link built vmlinuz to boot directory for reference
        >>
        >> v2 to v3:
        >>  - Merge existing KERNEL_ALT_IMAGETYPE into KERNEL_IMAGETYPES in order that users can still use the old variables.
        >>  - Run oe_rummake in a loop for every types so that we can add different configurations to them easily in the future.
        >>  - Warn, intead of die, users if one of the types are over the size limit.
        >>  - Remove the replacement of KERNEL_ALT_IMAGETYPE in v2.
        >>  - Remove the doc parts. They will be submitted yocto-docs later.
        >>  - Change some grep usage to make it more clear.
        >>  - Correct a typo.
        >>
        >> The following changes since commit 23056103c949b498c23b47579e8dd57ce78e6ed9:
        >>
        >>   uclibc: Do not use immediate expansion operator (2016-02-22 20:42:48 +0000)
        >>
        >> are available in the git repository at:
        >>
        >>   git://git.yoctoproject.org/poky-contrib <http://git.yoctoproject.org/poky-contrib>zhe/yocto-bug-6945
        >>   http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=zhe/yocto-bug-6945
        >>
        >> for you to fetch changes up to dc52a1efbb8248ea274a1cd0cca5734290b3025f:
        >>
        >>   kernel: Make symbol link to vmlinuz in boot directory (2016-02-24 07:08:16 -0500)
        >>
        >> ----------------------------------------------------------------
        >> He Zhe (2):
        >>       kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time
        >>       kernel: Make symbol link to vmlinuz in boot directory
        >>
        >>  meta/classes/kernel-fitimage.bbclass      |  20 ++++++++-------
        >>  meta/classes/kernel-grub.bbclass          |  44 +++++++++++++++++++++-----------
        >>  meta/classes/kernel-uimage.bbclass        |  22 ++++++++--------
        >>  meta/classes/kernel.bbclass               | 187 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------
        >>  meta/conf/documentation.conf              |   3 ++-
        >>  meta/recipes-kernel/linux/linux-dtb.inc   |  49 ++++++++++++++++++++++--------------
        >>  meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
        >>  7 files changed, 218 insertions(+), 109 deletions(-)
        >>
        >> He Zhe (2):
        >>   kernel: Add KERNEL_IMAGETYPES to build multi types kernel at one time
        >>   kernel: Make symbol link to vmlinuz in boot directory
        >>
        >>  meta/classes/kernel-fitimage.bbclass      |  20 ++--
        >>  meta/classes/kernel-grub.bbclass          |  44 ++++---
        >>  meta/classes/kernel-uimage.bbclass        |  22 ++--
        >>  meta/classes/kernel.bbclass               | 187 +++++++++++++++++++++---------
        >>  meta/conf/documentation.conf              |   3 +-
        >>  meta/recipes-kernel/linux/linux-dtb.inc   |  49 +++++---
        >>  meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
        >>  7 files changed, 218 insertions(+), 109 deletions(-)
        >>

        --
        _______________________________________________
        Openembedded-core mailing list
        [email protected] <mailto:[email protected]>
        http://lists.openembedded.org/mailman/listinfo/openembedded-core




    -- 
    "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
Signature · 1 line
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
#8 lore raw
Quoted 20 lines · He Zhe
Quoted 3 lines · Bruce Ashfield

On Mon, Mar 21, 2016 at 11:37 PM, Bruce Ashfield <

Quoted 4 lines · [email protected] <mailto:[email protected]>>wrote:


    On Mon, Mar 21, 2016 at 10:31 PM, He Zhe <[email protected]
Quoted 7 lines · <mailto:[email protected]>>wrote:

Ping.

This slipped through my filters. Sorry about that.

We are too late for the 2.1 release at this point, but I'll review

the changes again in the

Quoted 9 lines
Quoted 5 lines

morning and send any comments that I may have.

I reviewed this version, and it looks fine to me.

Thank you Bruce. And which version do we expect this to be merged into? 2.1.1 or 2.2 M1?

In the end, it isn't up to me. But 2.2 M1 is the reasonable target. This isn't a bug fix, so backporting it to 2.1.1 is unlikely.

Also, since there's always a huge amount of churn, everyone is busy, etc,.. to avoid it slipping through the cracks, I'd
suggest that you re-send the series about a week after 2.1 releases (with a history of the submissions, so we'll know
that it has been fully reviewed).

Bruce

Quoted 124 lines

Zhe

Quoted 19 lines

Bruce

    Cheers,

    Bruce


        Thanks,
        Zhe

        On 03/11/2016 11:32 AM, He Zhe wrote:
        > Any more comments?
        >
        > Thanks,
        > Zhe
        >
        > On 02/24/2016 08:20 PM, [email protected] <mailto:
Quoted 1 line · [email protected]>wrote:

>> From: He Zhe <[email protected] <mailto:

[email protected]>>

Quoted 3 lines
        >>
        >> v1 to v2:
        >>  - Change KERNEL_OUTPUT to KERNEL_OUTPUT_DIR and update

comments

Quoted 6 lines
        >>  - Update related doc files
        >>  - Replace all KERNEL_ALT_IMAGETYPEs with KERNEL_IMAGETYPES
        >>  - Link built vmlinuz to boot directory for reference
        >>
        >> v2 to v3:
        >>  - Merge existing KERNEL_ALT_IMAGETYPE into KERNEL_IMAGETYPES

in order that users can still use the old variables.

Quoted 1 line

>> - Run oe_rummake in a loop for every types so that we can

add different configurations to them easily in the future.

Quoted 1 line

>> - Warn, intead of die, users if one of the types are over

the size limit.

Quoted 2 lines

>> - Remove the replacement of KERNEL_ALT_IMAGETYPE in v2. >> - Remove the doc parts. They will be submitted yocto-docs

later.

Quoted 4 lines

>> - Change some grep usage to make it more clear. >> - Correct a typo.
>>
>> The following changes since commit

23056103c949b498c23b47579e8dd57ce78e6ed9:

Quoted 2 lines

>>
>> uclibc: Do not use immediate expansion operator (2016-02-22

20:42:48 +0000)

Quoted 4 lines

>>
>> are available in the git repository at:
>>
>> git://git.yoctoproject.org/poky-contrib <

http://git.yoctoproject.org/poky-contrib>zhe/yocto-bug-6945

Quoted 1 line
        >>

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=zhe/yocto-bug-6945

Quoted 2 lines

>>
>> for you to fetch changes up to

dc52a1efbb8248ea274a1cd0cca5734290b3025f:

Quoted 2 lines

>>
>> kernel: Make symbol link to vmlinuz in boot directory

(2016-02-24 07:08:16 -0500)

Quoted 2 lines
        >>
        >>

----------------------------------------------------------------

Quoted 2 lines

>> He Zhe (2):
>> kernel: Add KERNEL_IMAGETYPES to build multi types

kernel at one time

Quoted 3 lines

>> kernel: Make symbol link to vmlinuz in boot directory
>>
>> meta/classes/kernel-fitimage.bbclass | 20

++++++++-------

Quoted 1 line
        >>  meta/classes/kernel-grub.bbclass          |  44

+++++++++++++++++++++-----------

Quoted 1 line
        >>  meta/classes/kernel-uimage.bbclass        |  22

++++++++--------

Quoted 1 line
        >>  meta/classes/kernel.bbclass               | 187

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------

Quoted 2 lines
        >>  meta/conf/documentation.conf              |   3 ++-
        >>  meta/recipes-kernel/linux/linux-dtb.inc   |  49

++++++++++++++++++++++--------------

Quoted 5 lines
        >>  meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
        >>  7 files changed, 218 insertions(+), 109 deletions(-)
        >>
        >> He Zhe (2):
        >>   kernel: Add KERNEL_IMAGETYPES to build multi types kernel

at one time

Quoted 6 lines

>> kernel: Make symbol link to vmlinuz in boot directory
>>
>> meta/classes/kernel-fitimage.bbclass | 20 ++--
>> meta/classes/kernel-grub.bbclass | 44 ++++---
>> meta/classes/kernel-uimage.bbclass | 22 ++--
>> meta/classes/kernel.bbclass | 187

+++++++++++++++++++++---------

Quoted 10 lines
        >>  meta/conf/documentation.conf              |   3 +-
        >>  meta/recipes-kernel/linux/linux-dtb.inc   |  49 +++++---
        >>  meta/recipes-kernel/linux/linux-yocto.inc |   2 +-
        >>  7 files changed, 218 insertions(+), 109 deletions(-)
        >>

        --
        _______________________________________________
        Openembedded-core mailing list
        [email protected] <mailto:

[email protected]>

Quoted 7 lines

http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
"Thou shalt not follow the NULL pointer, for chaos and madness await

thee at its end"

Quoted 6 lines

--
"Thou shalt not follow the NULL pointer, for chaos and madness await

thee at its end"

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"