Skip to contentSkip to conversation

Backport fix to devtool for readonly Git hooks

PATCH New Peter Kjellerstedt 1 participant 2 messages Mar 10, 2016

lore
Share & tools
lore

Peter Kjellerstedt

author
#0 lore raw

cover Backport fix to devtool for readonly Git hooks

This backports a change to devtool from master so that devtool can handle Git hooks that are readonly.

//Peter

The following changes since commit 1a52eceaa5df89914b6a711defdcf0046e74c7f6:

ref-manual: Corrected Note for CentOS package requirements (2016-03-03 17:40:20 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib pkj/jethro-devtool-hooks
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/jethro-devtool-hooks

Peter Kjellerstedt (1):
lib/oe/patch: Make GitApplyTree._applypatch() support read-only
.git/hooks

 meta/lib/oe/patch.py | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)
Signature · 1 line
2.1.0
author
#1 lore raw

PATCH 1/1 lib/oe/patch: Make GitApplyTree._applypatch() support read-only .git/hooks

From: Peter Kjellerstedt <[email protected]>

Rather than modifying files in .git/hooks, which can be read-only (e.g., if it is a link to a directory in /usr/share), move away the entire .git/hooks directory temporarily.

Signed-off-by Peter Kjellerstedt <[email protected]>
Signed-off-by Ross Burton <[email protected]>
Signed-off-by Richard Purdie <[email protected]>
---
 meta/lib/oe/patch.py | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)
meta/lib/oe/patch.py +12 -14
index 2bf501e..c25d3c7 100644
@@ -383,14 +383,15 @@ class GitApplyTree(PatchTree):
         reporoot = (runcmd("git rev-parse --show-toplevel".split(), self.dir) or '').strip()
         if not reporoot:
             raise Exception("Cannot get repository root for directory %s" % self.dir)
-        commithook = os.path.join(reporoot, '.git', 'hooks', 'commit-msg')
-        commithook_backup = commithook + '.devtool-orig'
-        applyhook = os.path.join(reporoot, '.git', 'hooks', 'applypatch-msg')
-        applyhook_backup = applyhook + '.devtool-orig'
-        if os.path.exists(commithook):
-            shutil.move(commithook, commithook_backup)
-        if os.path.exists(applyhook):
-            shutil.move(applyhook, applyhook_backup)
+        hooks_dir = os.path.join(reporoot, '.git', 'hooks')
+        hooks_dir_backup = hooks_dir + '.devtool-orig'
+        if os.path.lexists(hooks_dir_backup):
+            raise Exception("Git hooks backup directory already exists: %s" % hooks_dir_backup)
+        if os.path.lexists(hooks_dir):
+            shutil.move(hooks_dir, hooks_dir_backup)
+        os.mkdir(hooks_dir)
+        commithook = os.path.join(hooks_dir, 'commit-msg')
+        applyhook = os.path.join(hooks_dir, 'applypatch-msg')
         with open(commithook, 'w') as f:
             # NOTE: the formatting here is significant; if you change it you'll also need to
             # change other places which read it back

@@ -439,12 +440,9 @@ class GitApplyTree(PatchTree):
                     os.remove(tmpfile)
                 return output
         finally:
-            os.remove(commithook)
-            os.remove(applyhook)
-            if os.path.exists(commithook_backup):
-                shutil.move(commithook_backup, commithook)
-            if os.path.exists(applyhook_backup):
-                shutil.move(applyhook_backup, applyhook)
+            shutil.rmtree(hooks_dir)
+            if os.path.lexists(hooks_dir_backup):
+                shutil.move(hooks_dir_backup, hooks_dir)
 
 
 class QuiltTree(PatchSet):
Signature · 1 line
2.1.0