staging: dgnc: fix dgnc_Major_TransparentPrint_Registered camelcase
cover staging: dgnc: fix dgnc_Major_TransparentPrint_Registered camelcase
This patchset aims to fix dgnc_Major_TransparentPrint_Registered CamelCase issue on checkpatch.pl by renaming it in dgnc_driver.h and its calls in dgnc_tty.c.
Juliana Rodrigues (2):
staging: dgnc: renamed dgnc_Major_TransparentPrint_Registered to avoid
camelcase in dgnc_driver.h
staging: dgnc: fixed dgnc_major_transparent_print_registered calls in
dgnc_tty.c
drivers/staging/dgnc/dgnc_driver.h | 2 +- drivers/staging/dgnc/dgnc_tty.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.7.2
PATCH 1/2 staging: dgnc: renamed dgnc_Major_TransparentPrint_Registered to avoid camelcase in dgnc_driver.h
This patch fixes the following issue on checkpatch.pl:
CHECK: Avoid CamelCase: <dgnc_Major_TransparentPrint_Registered>
+ bool dgnc_Major_TransparentPrint_Registered;
--- drivers/staging/dgnc/dgnc_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_driver.h +1 -1
@@ -211,7 +211,7 @@ struct dgnc_board {char PrintName[200 ];bool dgnc_major_serial_registered; -bool dgnc_Major_TransparentPrint_Registered; +bool dgnc_major_transparent_print_registered;uint dgnc_Serial_Major;uint dgnc_TransparentPrint_Major;
Signature · 1 line
2.7.2
Re: [Outreachy kernel] [PATCH 1/2] staging: dgnc: renamed dgnc_Major_TransparentPrint_Registered to avoid camelcase in dgnc_driver.h
The subject is too complicated. It is not necessary to provide the variable name and the file name in the part after the final :.
Quoted 1 line · Juliana Rodrigues
This patch fixes the following issue on checkpatch.pl:
On the other hand, this is sort of too concise. Try to write a commit message that doesn't use the word "fix". Explain instead what you did to make the fix.
julia
Quoted 31 lines
CHECK: Avoid CamelCase: <
dgnc_Major_TransparentPrint_Registered>
+ booldgnc_Major_TransparentPrint_Registered;Signed-off-by Juliana Rodrigues <[email protected]>--- drivers/staging/dgnc/dgnc_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/dgnc/dgnc_driver.h +1
-1@@ -211,7 +211,7 @@ struct dgnc_board {char PrintName[200 ];bool dgnc_major_serial_registered; -bool dgnc_Major_TransparentPrint_Registered; +bool dgnc_major_transparent_print_registered;uint dgnc_Serial_Major;uint dgnc_TransparentPrint_Major;Signature · 8 lines
2.7.2 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/936d6cc0ebe887a86581f5d9af2c2832b1ec1698.1457838430.git.juliana.orod%40gmail.com. For more options, visit https://groups.google.com/d/optout.
PATCH 2/2 staging: dgnc: fixed dgnc_major_transparent_print_registered calls in dgnc_tty.c
In reply to Juliana RodriguesThis patch fixes dgnc_major_transparent_print_registered variable name in dgnc_tty.c that was previously camelcased.
--- drivers/staging/dgnc/dgnc_tty.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/dgnc/dgnc_tty.c +4 -4
@@ -273,7 +273,7 @@ int dgnc_tty_register(struct dgnc_board *brd)*/ tty_set_operations (&brd->PrintDriver, &dgnc_tty_ops); -if (!brd->dgnc_Major_TransparentPrint_Registered) { +if (!brd->dgnc_major_transparent_print_registered) {/* Register Transparent Print devices */ rc =tty_register_driver (&brd->PrintDriver);if (rc <0 ) {
@@ -282,7 +282,7 @@ int dgnc_tty_register(struct dgnc_board *brd) rc);return rc; } - brd->dgnc_Major_TransparentPrint_Registered = true; + brd->dgnc_major_transparent_print_registered = true; } dgnc_BoardsByMajor[brd->SerialDriver.major] = brd;
@@ -420,7 +420,7 @@ void dgnc_tty_uninit(struct dgnc_board *brd) brd->dgnc_major_serial_registered = false; } -if (brd->dgnc_Major_TransparentPrint_Registered) { +if (brd->dgnc_major_transparent_print_registered) { dgnc_BoardsByMajor[brd->PrintDriver.major] =NULL ; brd->dgnc_TransparentPrint_Major =0 ;for (i =0 ; i < brd->nasync; i++) {
@@ -430,7 +430,7 @@ void dgnc_tty_uninit(struct dgnc_board *brd)tty_unregister_device (&brd->PrintDriver, i); }tty_unregister_driver (&brd->PrintDriver); - brd->dgnc_Major_TransparentPrint_Registered = false; + brd->dgnc_major_transparent_print_registered = false; }kfree (brd->SerialDriver.ttys);
Signature · 1 line
2.7.2
Re: [Outreachy kernel] [PATCH 2/2] staging: dgnc: fixed dgnc_major_transparent_print_registered calls in dgnc_tty.c
Quoted 2 lines · Juliana Rodrigues
This patch fixes
dgnc_major_transparent_print_registeredvariable name indgnc_tty.cthat was previously camelcased.
The text in your commit message should be limited to 80 columns.
julia
Quoted 56 lines
Signed-off-by Juliana Rodrigues <[email protected]>--- drivers/staging/dgnc/dgnc_tty.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/dgnc/dgnc_tty.c +4
-4@@ -273,7 +273,7 @@ int dgnc_tty_register(struct dgnc_board *brd)*/ tty_set_operations (&brd->PrintDriver, &dgnc_tty_ops); -if (!brd->dgnc_Major_TransparentPrint_Registered) { +if (!brd->dgnc_major_transparent_print_registered) {/* Register Transparent Print devices */ rc =tty_register_driver (&brd->PrintDriver);if (rc <0 ) {@@ -282,7 +282,7 @@ int dgnc_tty_register(struct dgnc_board *brd) rc);return rc; } - brd->dgnc_Major_TransparentPrint_Registered = true; + brd->dgnc_major_transparent_print_registered = true; } dgnc_BoardsByMajor[brd->SerialDriver.major] = brd;@@ -420,7 +420,7 @@ void dgnc_tty_uninit(struct dgnc_board *brd) brd->dgnc_major_serial_registered = false; } -if (brd->dgnc_Major_TransparentPrint_Registered) { +if (brd->dgnc_major_transparent_print_registered) { dgnc_BoardsByMajor[brd->PrintDriver.major] =NULL ; brd->dgnc_TransparentPrint_Major =0 ;for (i =0 ; i < brd->nasync; i++) {@@ -430,7 +430,7 @@ void dgnc_tty_uninit(struct dgnc_board *brd)tty_unregister_device (&brd->PrintDriver, i); }tty_unregister_driver (&brd->PrintDriver); - brd->dgnc_Major_TransparentPrint_Registered = false; + brd->dgnc_major_transparent_print_registered = false; }kfree (brd->SerialDriver.ttys);Signature · 8 lines
2.7.2 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/589a3351f280163de7cbfd12a47335bc976a0d43.1457838430.git.juliana.orod%40gmail.com. For more options, visit https://groups.google.com/d/optout.
Quoted 2 lines · Juliana Rodrigues
This patchset aims to fix
dgnc_Major_TransparentPrint_RegisteredCamelCase issue on checkpatch.pl by renaming it indgnc_driver.hand its calls indgnc_tty.c.
Given the small size of the changes and the close relationship between them, this could have been just one patch.
Again, the commit message goes over 80 characters. Try to stop well before, so that when someone responds to your commit, the whole thing stll fits in 80 characters.
julia
Quoted 21 lines
Juliana Rodrigues (2):
staging: dgnc: renameddgnc_Major_TransparentPrint_Registeredto avoid
camelcase indgnc_driver.h
staging: dgnc: fixeddgnc_major_transparent_print_registeredcalls in
dgnc_tty.cdrivers/staging/dgnc/dgnc_driver.h | 2 +- drivers/staging/dgnc/dgnc_tty.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)Signature · 8 lines
2.7.2 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1457838430.git.juliana.orod%40gmail.com. For more options, visit https://groups.google.com/d/optout.