Staging: i4l: Fix coding style issues.
cover Staging: i4l: Fix coding style issues.
Fix coding style issues.This issue is found by checkpatch.pl.
Sandhya Bankar (4):
Staging: i4l: Add paranthesis to complex macro.
Staging: i4l: Use !x instead of x == NULL
Staging: i4l: Do not initialise statics to 0.
Staging: i4l: layer2: Add paranthesis to complex macro.
drivers/staging/i4l/pcbit/capi.h | 2 +- drivers/staging/i4l/pcbit/drv.c | 4 ++-- drivers/staging/i4l/pcbit/edss1.c | 2 +- drivers/staging/i4l/pcbit/layer2.h | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
1.8.3.4
PATCH 1/4 Staging: i4l: Add paranthesis to complex macro.
Add paranthesis to complex macro.
--- drivers/staging/i4l/pcbit/layer2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/i4l/pcbit/layer2.h +1 -1
@@ -109,7 +109,7 @@#define SCHED_READ 0x01#define SCHED_WRITE 0x02 -#define SET_RUN_TIMEOUT 2 * HZ/* 2 seconds */ +#define SET_RUN_TIMEOUT (2 * HZ)/* 2 seconds */ struct frame_buf {ulong msg;
Signature · 1 line
1.8.3.4
Re: [Outreachy kernel] [PATCH 1/4] Staging: i4l: Add paranthesis to complex macro.
Quoted 1 line · Sandhya Bankar
Add paranthesis to complex macro.
From the subject line, it looks like you are performing this change on all of i4l, but in another patch the subject line mentions the same kind of change, but ona subdirectory. Also, paranthesis -> parentheses.
julia
Quoted 29 lines
Signed-off-by Sandhya Bankar <[email protected]>--- drivers/staging/i4l/pcbit/layer2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/i4l/pcbit/layer2.h +1
-2@@ -109,7 +109,7 @@#define SCHED_READ 0x01#define SCHED_WRITE 0x02 -#define SET_RUN_TIMEOUT 2 * HZ/* 2 seconds */ +#define SET_RUN_TIMEOUT (2 * HZ)/* 2 seconds */ struct frame_buf {ulong msg; --1.8.3.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/8ea64620333b0c695ab3e67bbfd2949d2a071f2e.1458213062.git.bankarsandhya512%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
PATCH 2/4 Staging: i4l: Use !x instead of x == NULL.
In reply to Sandhya BankarUse !x instead of x == NULL.
--- drivers/staging/i4l/pcbit/edss1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/i4l/pcbit/edss1.c +1 -1
@@ -254,7 +254,7 @@ static void pcbit_fsm_timer(unsigned long data) dev =chan2dev (chan); -if (dev ==NULL ) { +if (!dev) {printk (KERN_WARNING "pcbit: timer for unknown device\n" );return ; }
Signature · 1 line
1.8.3.4
PATCH 3/4 Staging: i4l: Do not initialise statics to 0.
In reply to Sandhya BankarDo not initialise statics to 0.
--- drivers/staging/i4l/pcbit/drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/i4l/pcbit/drv.c +2 -2
@@ -699,8 +699,8 @@ void pcbit_l3_receive(struct pcbit_dev *dev, ulong msg,*/ static char statbuf[STATBUF_LEN ]; -static int stat_st =0 ; -static int stat_end =0 ; +static int stat_st; +static int stat_end;static int pcbit_stat (u_char __user *buf,int len,int driver,int channel) {
Signature · 1 line
1.8.3.4
PATCH 4/4 Staging: i4l: capi: Add paranthesis to complex macro.
In reply to Sandhya BankarAdd paranthesis to complex macro.
--- drivers/staging/i4l/pcbit/capi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/i4l/pcbit/capi.h +1 -1
@@ -17,7 +17,7 @@#define REQ_DISPLAY 0x04#define REQ_USER_TO_USER 0x08 -#define AppInfoMask REQ_CAUSE | REQ_DISPLAY | REQ_USER_TO_USER +#define AppInfoMask (REQ_CAUSE | REQ_DISPLAY | REQ_USER_TO_USER)/* Connection Setup */ extern int capi_conn_req(const char *calledPN, struct sk_buff **buf,
Signature · 1 line
1.8.3.4