Skip to contentSkip to conversation

Staging: rtl8188eu: Remove NULL comparision.

PATCH New Sandhya Bankar 1 participant 5 messages Mar 19, 2016 Staging

lore
Share & tools
lore

Sandhya Bankar

author
#0 lore raw

v3 cover Staging: rtl8188eu: Remove NULL comparision.

Remove NULL comparision.This issues is detected by checkpatch.pl script. changes in v3:
*correcting the heading.

Sandhya Bankar (4):
Staging: rtl8188eu: Hal8188ERateAdaptive: Use x instead of x != NULL.
Staging: rtl8188eu: hal_intf: Use x instead of x != NULL.
Staging: rtl8188eu: rtl8188e_rxdesc: Use !x instead of x == NULL.
Staging: rtl8188eu: usb_halinit: Use !x instead of x == NULL.

 drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
 drivers/staging/rtl8188eu/hal/hal_intf.c             | 2 +-
 drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c      | 2 +-
 drivers/staging/rtl8188eu/hal/usb_halinit.c          | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
1.8.3.4
author
#1 lore raw

PATCH v3 1/4 Staging: rtl8188eu: Hal8188ERateAdaptive: Use x instead of x != NULL.

Use x instead of x != NULL.

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c +1 -1
index a108e80..201c15b 100644
@@ -557,7 +557,7 @@ int ODM_RAInfo_Init(struct odm_dm_struct *dm_odm, u8 macid)
 	u8 WirelessMode = 0xFF; /* invalid value */
 	u8 max_rate_idx = 0x13; /* MCS7 */
 
-	if (dm_odm->pWirelessMode != NULL)
+	if (dm_odm->pWirelessMode)
 		WirelessMode = *(dm_odm->pWirelessMode);
 
 	if (WirelessMode != 0xFF) {
Signature · 1 line
1.8.3.4
author
#2 lore raw

PATCH v3 2/4 Staging: rtl8188eu: hal_intf: Use x instead of x != NULL.

In reply to Sandhya Bankar

Use x instead of x != NULL.

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/rtl8188eu/hal/hal_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/hal_intf.c +1 -1
index 85c17ef..fb7bacb 100644
@@ -186,7 +186,7 @@ s32 rtw_hal_mgnt_xmit(struct adapter *adapt, struct xmit_frame *pmgntframe)
 
 s32 rtw_hal_init_xmit_priv(struct adapter *adapt)
 {
-	if (adapt->HalFunc.init_xmit_priv != NULL)
+	if (adapt->HalFunc.init_xmit_priv)
 		return adapt->HalFunc.init_xmit_priv(adapt);
 	return _FAIL;
 }
Signature · 1 line
1.8.3.4
author
#3 lore raw

PATCH v3 3/4 Staging: rtl8188eu: rtl8188e_rxdesc: Use !x instead of x == NULL.

In reply to Sandhya Bankar

Use !x instead of x == NULL.

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c +1 -1
index 53cf3ba..c7e48f1 100644
@@ -45,7 +45,7 @@ static void process_link_qual(struct adapter *padapter,
 	struct rx_pkt_attrib *pattrib;
 	struct signal_stat *signal_stat;
 
-	if (prframe == NULL || padapter == NULL)
+	if (!prframe || !padapter)
 		return;
 
 	pattrib = &prframe->attrib;
Signature · 1 line
1.8.3.4
author
#4 lore raw

PATCH v3 4/4 Staging: rtl8188eu: usb_halinit: Use !x instead of x == NULL.

In reply to Sandhya Bankar

Use !x instead of x == NULL.

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/usb_halinit.c +1 -1
index 07a61b8..e25c38b 100644
@@ -2083,7 +2083,7 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt)
 
 
 	adapt->HalData = kzalloc(sizeof(struct hal_data_8188e), GFP_KERNEL);
-	if (adapt->HalData == NULL)
+	if (!adapt->HalData)
 		DBG_88E("cant not alloc memory for HAL DATA\n");
 
 	halfunc->hal_power_on = rtl8188eu_InitPowerOn;
Signature · 1 line
1.8.3.4