Skip to contentSkip to conversation

ia64: remove unused header files

PATCH New Jonas Rabenstein 1 participant 4 messages Apr 6, 2016

lore
Share & tools
lore
#0 lore raw

cover ia64: remove unused header files

From: Jonas Rabenstein <[email protected]>

This patchset removes three unreferenced and unused header files of the ia64 architecture. Also some #include directives would resolve to the files I propose for removal, the dependencies defined by kconfig for those files do not allow their usage together with ia64.

I detected the issue with chimaera, a tool I currently develop for my bachelor thesis extending the undertaker tool suite to take the relation of files based on #include directives into account (https://undertaker.cs.fau.de).

Jonas Rabenstein (3):
ia64: remove unused asm/segment.h
ia64: remove unused asm/idle.h
ia64: remove unused asm/mc146818rtc.h

 arch/ia64/include/asm/idle.h        |  7 -------
 arch/ia64/include/asm/mc146818rtc.h | 10 ----------
 arch/ia64/include/asm/segment.h     |  6 ------
 3 files changed, 23 deletions(-)
 delete mode 100644 arch/ia64/include/asm/idle.h
 delete mode 100644 arch/ia64/include/asm/mc146818rtc.h
 delete mode 100644 arch/ia64/include/asm/segment.h
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/3 ia64: remove unused asm/segment.h

From: Jonas Rabenstein <[email protected]>

The file arch/ia64/include/asm/segment.h contains only a comment that it is still in the source tree as it may be referenced from some files. Actually only 2 files that are not in an arch/* directory include <asm/segment.h>.
The first is drivers/lguest/x86/switcher_32.S and obviously is not used by ia64.
The second is include/asm-generic/uacess.h and also not used by ia64.

---
 arch/ia64/include/asm/segment.h | 6 ------
 1 file changed, 6 deletions(-)
 delete mode 100644 arch/ia64/include/asm/segment.h
arch/ia64/include/asm/segment.h deleted +0 -6
deleted file mode 100644
index b89e2b3..0000000
@@ -1,6 +0,0 @@
-#ifndef _ASM_IA64_SEGMENT_H
-#define _ASM_IA64_SEGMENT_H
-
-/* Only here because we have some old header files that expect it.. */
-
-#endif /* _ASM_IA64_SEGMENT_H */
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/3 ia64: remove unused asm/idle.h

In reply to Jonas Rabenstein

From: Jonas Rabenstein <[email protected]>

The file arch/ia64/include/asm/idle.h can not be included by any file and as a consequence may be removed from the source tree. Currently five files have #includes for asm/idle.h:
drivers/cpufreq/loongson2_cpufreq.c:
depends on LOONGSON2 (mips)
drivers/cpuidle/cpuidle-cps.c:
depends on MIPS_CPS_CPUIDLE (mips)
drivers/idle/i7300_idle.c:

        depends on X86_64

drivers/thermal/intel_powerclamp.c:
depends on X86
drivers/xen/events/events_base.c:
depends on XEN (arm/x86)

---
 arch/ia64/include/asm/idle.h | 7 -------
 1 file changed, 7 deletions(-)
 delete mode 100644 arch/ia64/include/asm/idle.h
arch/ia64/include/asm/idle.h deleted +0 -7
deleted file mode 100644
index b768501..0000000
@@ -1,7 +0,0 @@
-#ifndef _ASM_IA64_IDLE_H
-#define _ASM_IA64_IDLE_H
-
-static inline void enter_idle(void) { }
-static inline void exit_idle(void) { }
-
-#endif /* _ASM_IA64_IDLE_H */
Signature · 1 line
1.9.1
#3 lore raw

PATCH 3/3 ia64: remove unused asm/mc146818rtc.h

In reply to Jonas Rabenstein

From: Jonas Rabenstein <[email protected]>

The file arch/ia64/include/asm/mc146818rtc.h is not used anymore. It would be included by include/linuxmc146818rtc.h which in fact is included by the following files:
* sound/core/rtctimer.c:

       depends on SND_RTCTIMER -> RTC -> !IA64
* drivers/char/nvram.c:
       depends on NVRAM -> X86
* drivers/char/rtc.c:
       depends on RTC -> !IA64
* drivers/block/floppy.c:
       depends on BLK_DEV_FD -> ARCH_MAY_HAVE_PC_FDC (not defined for IA64)
* drivers/firmware/dcdbas.c:
       depends on DCDBAS -> X86
* include/asm/generic/rtc.h:
  - drivers/rtc/rtc-cmos.c
       depends on RTC_DRV_CMOS -> (X86||ARM||M32R||PPC||MIPS||SPARC64)
  - drivers/acpi/acpi/acpi_cmos_rtc.c:
       depends on X86
  - drivers/rtc/rtc/mrst.c:
       depends on RTC_DRV_VRTC -> X86_INTEL_MID (not defined for IA64)
* drivers/char/mwave/smapi.c
       depends on MWAVE -> X86
* drivers/input/misc/wistron_btns.c:
       depends on CONFIG_WISTRON_BTNS -> X86_32
* drivers/scsi/gdth.c
       depends on SCSI_GDTH -> ISA_DMA_API (not defined for IA64)
Fixes 7f30491ccd28 ("[IA64] Move include/asm-ia64 to arch/ia64/include/asm")
---
 arch/ia64/include/asm/mc146818rtc.h | 10 ----------
 1 file changed, 10 deletions(-)
 delete mode 100644 arch/ia64/include/asm/mc146818rtc.h
arch/ia64/include/asm/mc146818rtc.h deleted +0 -10
deleted file mode 100644
index 407787a2..0000000
@@ -1,10 +0,0 @@
-#ifndef _ASM_IA64_MC146818RTC_H
-#define _ASM_IA64_MC146818RTC_H
-
-/*
- * Machine dependent access functions for RTC registers.
- */
-
-/* empty include file to satisfy the include in genrtc.c */
-
-#endif /* _ASM_IA64_MC146818RTC_H */
Signature · 1 line
1.9.1