fix buildtools-tarball and meta.bbclass
cover fix buildtools-tarball and meta.bbclass
The following changes since commit 37aac647d510557323083c77c3114476440a325d:
fs-perms.txt: fix ROOT_HOME's permission (2016-04-15 06:58:49 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/meta
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/meta
Robert Yang (2):
buildtools-tarball.bb: fix unexpected operator
meta.bbclass: set INHIBIT_DEFAULT_DEPS
meta/classes/meta.bbclass | 2 ++ meta/recipes-core/meta/buildtools-tarball.bb | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.8.0
PATCH 1/2 buildtools-tarball.bb: fix unexpected operator
Fixed:
run.create_sdk_files.45747: 131: [: =: unexpected operator
The SDKMACHINE is not set by default.
--- meta/recipes-core/meta/buildtools-tarball.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/meta/buildtools-tarball.bb +1 -1
@@ -58,7 +58,7 @@ create_sdk_files_append () { echo 'export GIT_SSL_CAINFO="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' >>$script - if [ ${SDKMACHINE} = "i686" ]; then + if [ "${SDKMACHINE}" = "i686" ]; then echo 'export NO32LIBS="0"' >>$script echo 'echo "$BB_ENV_EXTRAWHITE" | grep -q "NO32LIBS"' >>$script echo '[ $? != 0 ] && export BB_ENV_EXTRAWHITE="NO32LIBS $BB_ENV_EXTRAWHITE"' >>$script
Signature · 1 line
2.8.0
PATCH 2/2 meta.bbclass: set INHIBIT_DEFAULT_DEPS
In reply to Robert YangThe recipe which inherits meta.bbclass doesn't require any default deps.
--- meta/classes/meta.bbclass | 2 ++ 1 file changed, 2 insertions(+)
meta/classes/meta.bbclass +2 -0
@@ -2,3 +2,5 @@ PACKAGES = "" do_build[recrdeptask] = "do_build" + +INHIBIT_DEFAULT_DEPS = "1"
Signature · 1 line
2.8.0
Re: [PATCH 2/2] meta.bbclass: set INHIBIT_DEFAULT_DEPS
Quoted 2 lines · Robert Yang
The recipe which inherits meta.bbclass doesn't require any default deps.
meta is only inherited by one class (populate_sdk_base.bbclass) and three recipes (two of which indirectly inherit populate_sdk_base) so do we really need this class? Maybe we should drop it in the 2.2 cycle.
Ross
Re: [PATCH 2/2] meta.bbclass: set INHIBIT_DEFAULT_DEPS
Quoted 9 lines · Ross
On 18 April 2016 at 03:57, Robert Yang <[email protected] <mailto:[email protected]>> wrote:
The recipe which inherits meta.bbclass doesn't require any default deps.
meta is only inherited by one class (populate_sdk_base.bbclass) and three recipes (two of which indirectly inherit
populate_sdk_base) so do we really need
The INHIBIT_DEFAULT_DEPS = "1" was for buildtools-tarball, I will move it into buildtools-tarball since meta.bbclass may go. And I noticed that another patch has been merged so I will send a new PULL for it.
// Robert
Quoted 3 lines
this class? Maybe we should drop it in the 2.2 cycle.
Ross
Re: [PATCH 2/2] meta.bbclass: set INHIBIT_DEFAULT_DEPS
In reply to Burton, RossQuoted 6 lines · Ross
Quoted 1 line · Robert Yang
The recipe which inherits meta.bbclass doesn't require any default deps.
meta is only inherited by one class (populate_sdk_base.bbclass) and three recipes (two of which indirectly inherit
populate_sdk_base) so do we really need this class? Maybe we should drop it in the 2.2 cycle.
I don't think we ought to be in too much of a hurry to remove this - it's still a handy class. Besides I was planning on using it to solve this issue:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=9257
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Re: [PATCH 2/2] meta.bbclass: set INHIBIT_DEFAULT_DEPS
Quoted 12 lines · Paul Eggleton
Quoted 10 lines · Ross
Quoted 2 lines · Robert Yang
The recipe which inherits meta.bbclass doesn't require any default deps.
meta is only inherited by one class (populate_sdk_base.bbclass) and three
recipes (two of which indirectly inheritpopulate_sdk_base) so do we really
need this class? Maybe we should drop it in the 2.2 cycle.
Quoted 6 lines
I don't think we ought to be in too much of a hurry to remove this - it's
still a handy class. Besides I was planning on using it to solve this issue:
I have the opposite view. Its pretty much impossible to tell what a "meta" class would do from its name or have any idea of whether a given change should be added to the class since its purpose is so vague.
I'l like to see it renamed to something more useful, or removed given its just two lines...
Cheers,
Richard