Skip to contentSkip to conversation

openssh upgrade and CVE fix

PATCH New Jussi Kukkonen 1 participant 3 messages May 18, 2016

lore
Share & tools
lore
#0 lore raw

cover openssh upgrade and CVE fix

The CVE fix should apply for at least Krogoth and Jethro as well.

The following changes since commit 7707cf6562e6a477ea953743a2d9aba682d90949:

sdk-manual: Fixed three broken links to sections within manual. (2016-05-17 21:35:00 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib jku/openssh
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/openssh

Jussi Kukkonen (2):
openssh: Upgrade 7.1p2 -> 7.2p2
openssh: Backport fix for CVE-2015-8325

 .../openssh/openssh/CVE-2015-8325.patch            |  39 +++
 .../openssh/openssh/CVE-2016-1907_2.patch          |  65 ----
 .../openssh/openssh/CVE-2016-1907_3.patch          | 329 ---------------------
 .../openssh/CVE-2016-1907_upstream_commit.patch    |  33 ---
 .../openssh/openssh/CVE-2016-3115.patch            |  84 ------
 .../openssh/{openssh_7.1p2.bb => openssh_7.2p2.bb} |   9 +-
 6 files changed, 42 insertions(+), 517 deletions(-)
 create mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2015-8325.patch
 delete mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2016-1907_2.patch
 delete mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2016-1907_3.patch
 delete mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2016-1907_upstream_commit.patch
 delete mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2016-3115.patch
 rename meta/recipes-connectivity/openssh/{openssh_7.1p2.bb => openssh_7.2p2.bb} (95%)
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/2 openssh: Upgrade 7.1p2 -> 7.2p2

Remove patches that are in the release.

---
 .../openssh/openssh/CVE-2016-1907_2.patch          |  65 ----
 .../openssh/openssh/CVE-2016-1907_3.patch          | 329 ---------------------
 .../openssh/CVE-2016-1907_upstream_commit.patch    |  33 ---
 .../openssh/openssh/CVE-2016-3115.patch            |  84 ------
 .../openssh/{openssh_7.1p2.bb => openssh_7.2p2.bb} |   8 +-
 5 files changed, 2 insertions(+), 517 deletions(-)
 delete mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2016-1907_2.patch
 delete mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2016-1907_3.patch
 delete mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2016-1907_upstream_commit.patch
 delete mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2016-3115.patch
 rename meta/recipes-connectivity/openssh/{openssh_7.1p2.bb => openssh_7.2p2.bb} (95%)
meta/recipes-connectivity/openssh/openssh/CVE-2016-1907_2.patch deleted +0 -65
deleted file mode 100644
index 9fac69c..0000000
@@ -1,65 +0,0 @@
-From f98a09cacff7baad8748c9aa217afd155a4d493f Mon Sep 17 00:00:00 2001
-From: "[email protected]" <[email protected]>
-Date: Tue, 20 Oct 2015 03:36:35 +0000
-Subject: [PATCH] upstream commit
-
-Replace a function-local allocation with stack memory.
-
-ok djm@
-
-Upstream-ID: c09fbbab637053a2ab9f33ca142b4e20a4c5a17e
-Upstream-Status: Backport
-CVE: CVE-2016-1907
-
-[YOCTO #8935]
-
-Signed-off-by: Armin Kuster <[email protected]>
-
----
- clientloop.c | 9 ++-------
- 1 file changed, 2 insertions(+), 7 deletions(-)
-
-diff --git a/clientloop.c b/clientloop.c
-index 87ceb3d..1e05cba 100644
---- a/clientloop.c
-+++ b/clientloop.c
-@@ -1,4 +1,4 @@
--/* $OpenBSD: clientloop.c,v 1.275 2015/07/10 06:21:53 markus Exp $ */
-+/* $OpenBSD: clientloop.c,v 1.276 2015/10/20 03:36:35 mmcc Exp $ */
- /*
-  * Author: Tatu Ylonen <[email protected]>
-  * Copyright (c) 1995 Tatu Ylonen <[email protected]>, Espoo, Finland
-@@ -311,11 +311,10 @@ client_x11_get_proto(const char *display, const char *xauth_path,
- 	static char proto[512], data[512];
- 	FILE *f;
- 	int got_data = 0, generated = 0, do_unlink = 0, i;
--	char *xauthdir, *xauthfile;
-+	char xauthdir[PATH_MAX] = "", xauthfile[PATH_MAX] = "";
- 	struct stat st;
- 	u_int now, x11_timeout_real;
- 
--	xauthdir = xauthfile = NULL;
- 	*_proto = proto;
- 	*_data = data;
- 	proto[0] = data[0] = '\0';
-@@ -343,8 +342,6 @@ client_x11_get_proto(const char *display, const char *xauth_path,
- 			display = xdisplay;
- 		}
- 		if (trusted == 0) {
--			xauthdir = xmalloc(PATH_MAX);
--			xauthfile = xmalloc(PATH_MAX);
- 			mktemp_proto(xauthdir, PATH_MAX);
- 			/*
- 			 * The authentication cookie should briefly outlive
-@@ -407,8 +404,6 @@ client_x11_get_proto(const char *display, const char *xauth_path,
- 		unlink(xauthfile);
- 		rmdir(xauthdir);
- 	}
--	free(xauthdir);
--	free(xauthfile);
- 
- 	/*
- 	 * If we didn't get authentication data, just make up some
--- 
-1.9.1
-
meta/recipes-connectivity/openssh/openssh/CVE-2016-1907_3.patch deleted +0 -329

329 lines not on this page · raw message

meta/recipes-connectivity/openssh/openssh/CVE-2016-1907_upstream_commit.patch deleted +0 -33
deleted file mode 100644
index f3d132e..0000000
@@ -1,33 +0,0 @@
-From d77148e3a3ef6c29b26ec74331455394581aa257 Mon Sep 17 00:00:00 2001
-From: "[email protected]" <[email protected]>
-Date: Sun, 8 Nov 2015 21:59:11 +0000
-Subject: [PATCH] upstream commit
-
-fix OOB read in packet code caused by missing return
- statement found by Ben Hawkes; ok markus@ deraadt@
-
-Upstream-ID: a3e3a85434ebfa0690d4879091959591f30efc62
-
-Upstream-Status: Backport
-CVE: CVE-2016-1907
-
-[YOCTO #8935]
-
-Signed-off-by: Armin Kuster <[email protected]>
-
----
- packet.c | 1 +
- 1 file changed, 1 insertion(+)
-
-Index: openssh-7.1p2/packet.c
-===================================================================
---- openssh-7.1p2.orig/packet.c
-+++ openssh-7.1p2/packet.c
-@@ -1855,6 +1855,7 @@ ssh_packet_process_incoming(struct ssh *
- 		if (len >= state->packet_discard) {
- 			if ((r = ssh_packet_stop_discard(ssh)) != 0)
- 				return r;
-+			return SSH_ERR_CONN_CORRUPT;
- 		}
- 		state->packet_discard -= len;
- 		return 0;
meta/recipes-connectivity/openssh/openssh/CVE-2016-3115.patch deleted +0 -84

84 lines not on this page · raw message

meta/recipes-connectivity/openssh/openssh_7.2p2.bb renamed from meta/recipes-connectivity/openssh/openssh_7.1p2.bb +2 -6
similarity index 95%
rename from meta/recipes-connectivity/openssh/openssh_7.1p2.bb
rename to meta/recipes-connectivity/openssh/openssh_7.2p2.bb
index 92bc006..173f80a 100644
@@ -21,16 +21,12 @@ SRC_URI = "http://ftp.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-${PV}.tar
            file://volatiles.99_sshd \
            file://add-test-support-for-busybox.patch \
            file://run-ptest \
-           file://CVE-2016-1907_upstream_commit.patch \
-           file://CVE-2016-1907_2.patch \
-           file://CVE-2016-1907_3.patch \
-           file://CVE-2016-3115.patch \
            "
 
 PAM_SRC_URI = "file://sshd"
 
-SRC_URI[md5sum] = "4d8547670e2a220d5ef805ad9e47acf2"
-SRC_URI[sha256sum] = "dd75f024dcf21e06a0d6421d582690bf987a1f6323e32ad6619392f3bfde6bbd"
+SRC_URI[md5sum] = "13009a9156510d8f27e752659075cced"
+SRC_URI[sha256sum] = "a72781d1a043876a224ff1b0032daa4094d87565a68528759c1c2cab5482548c"
 
 inherit useradd update-rc.d update-alternatives systemd
 
Signature · 1 line
2.1.4
#2 lore raw

PATCH 2/2 openssh: Backport fix for CVE-2015-8325

PAM environment vars must be ignored when UseLogin=yes

---
 .../openssh/openssh/CVE-2015-8325.patch            | 39 ++++++++++++++++++++++
 meta/recipes-connectivity/openssh/openssh_7.2p2.bb |  1 +
 2 files changed, 40 insertions(+)
 create mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2015-8325.patch
meta/recipes-connectivity/openssh/openssh/CVE-2015-8325.patch new file +39 -0
new file mode 100644
index 0000000..2263897
@@ -0,0 +1,39 @@
+From 85bdcd7c92fe7ff133bbc4e10a65c91810f88755 Mon Sep 17 00:00:00 2001
+From: Damien Miller <[email protected]>
+Date: Wed, 13 Apr 2016 10:39:57 +1000
+Subject: ignore PAM environment vars when UseLogin=yes
+
+If PAM is configured to read user-specified environment variables
+and UseLogin=yes in sshd_config, then a hostile local user may
+attack /bin/login via LD_PRELOAD or similar environment variables
+set via PAM.
+
+CVE-2015-8325, found by Shayan Sadigh, via Colin Watson
+
+
+
+https://anongit.mindrot.org/openssh.git/commit/session.c?id=85bdcd7c92fe7ff133bbc4e10a65c91810f88755
+
+CVE: CVE-2015-8325
+Upstream-Status: Backport
+Signed-off-by: Jussi Kukkonen <[email protected]>
+---
+ session.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/session.c b/session.c
+index 4859245..4653b09 100644
+--- a/session.c
++++ b/session.c
+@@ -1322,7 +1322,7 @@ do_setup_env(Session *s, const char *shell)
+ 	 * Pull in any environment variables that may have
+ 	 * been set by PAM.
+ 	 */
+-	if (options.use_pam) {
++	if (options.use_pam && !options.use_login) {
+ 		char **p;
+ 
+ 		p = fetch_pam_child_environment();
+-- 
+cgit v0.11.2
+
meta/recipes-connectivity/openssh/openssh_7.2p2.bb +1 -0
index 173f80a..7e04716 100644
@@ -21,6 +21,7 @@ SRC_URI = "http://ftp.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-${PV}.tar
            file://volatiles.99_sshd \
            file://add-test-support-for-busybox.patch \
            file://run-ptest \
+           file://CVE-2015-8325.patch \
            "
 
 PAM_SRC_URI = "file://sshd"
Signature · 1 line
2.1.4