Skip to contentSkip to conversation

Fix for progress handling

PATCH New Paul Eggleton 1 participant 2 messages Jul 15, 2016

lore
Share & tools
lore
#0 lore raw

cover Fix for progress handling

Fix an issue that shows up on the YP autobuilder during the uninative fetch process.

The following changes since commit cabe7e2459fcd561bced2d39ba5bd173576153e5:

toaster: tests Add selenium test for layerdetails page (2016-07-08 09:57:06 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib paule/bb-progressfix
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=paule/bb-progressfix

Paul Eggleton (1):
knotty: avoid errors when fetching outside of a task

 lib/bb/ui/uihelper.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Signature · 1 line
2.5.5
#1 lore raw

PATCH 1/1 knotty: avoid errors when fetching outside of a task

In a few places we use the fetcher code to fetch files outside of a task, for example uninative in OE. In that case the pid of the event is 0 and that was causing an error in BBUIHelper.eventHandler(). Check the pid and do nothing if it's 0.

---
 lib/bb/ui/uihelper.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
lib/bb/ui/uihelper.py +4 -3
index 1915e47..f64fa18 100644
@@ -54,9 +54,10 @@ class BBUIHelper:
             self.tasknumber_total = event.stats.total
             self.needUpdate = True
         if isinstance(event, bb.build.TaskProgress):
-            self.running_tasks[event.pid]['progress'] = event.progress
-            self.running_tasks[event.pid]['rate'] = event.rate
-            self.needUpdate = True
+            if event.pid > 0:
+                self.running_tasks[event.pid]['progress'] = event.progress
+                self.running_tasks[event.pid]['rate'] = event.rate
+                self.needUpdate = True
 
     def getTasks(self):
         self.needUpdate = False
Signature · 1 line
2.5.5