Skip to contentSkip to conversation

epiphany: inherit perlnative

PATCH In review Robert Yang 4 participants 12 messages Jul 24, 2016 – Aug 5, 2016

lore
Share & tools
lore

Robert Yang

author
#0 lore raw

cover epiphany: inherit perlnative

The following changes since commit 0a2df616a5c3316704742f1dcf37b450920e0280:

boost: fix CVE-2012-2677 (2016-07-21 07:45:01 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/epiphany
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/epiphany

Robert Yang (1):
epiphany: inherit perlnative

 meta/recipes-gnome/epiphany/epiphany_3.20.3.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Signature · 1 line
2.9.0
author
#1 lore raw

PATCH 1/1 epiphany: inherit perlnative

Fixed:
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool

The module is installed to sysroot, but need use native perl to find it.

Signed-off-by Robert Yang <[email protected]>
---
 meta/recipes-gnome/epiphany/epiphany_3.20.3.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
meta/recipes-gnome/epiphany/epiphany_3.20.3.bb +1 -2
index eba480b..a61e2cf 100644
@@ -5,7 +5,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 DEPENDS = "libsoup-2.4 webkitgtk gtk+3 iso-codes ca-certificates avahi libnotify gcr libwnck3 \
 	   gsettings-desktop-schemas gnome-desktop3 libxml2-native intltool-native"
 
-inherit gnomebase gsettings distro_features_check upstream-version-is-even
+inherit gnomebase gsettings distro_features_check upstream-version-is-even perlnative
 # libwnck3 is x11 only
 REQUIRED_DISTRO_FEATURES = "x11"
 

@@ -22,4 +22,3 @@ do_configure_prepend() {
 FILES_${PN} += "${datadir}/appdata ${datadir}/dbus-1 ${datadir}/gnome-shell/search-providers"
 RDEPENDS_${PN} = "iso-codes adwaita-icon-theme"
 RRECOMMENDS_${PN} = "ca-certificates"
-
Signature · 1 line
2.9.0
#2 lore raw
Quoted 6 lines · Robert Yang

Fixed:
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool

The module is installed to sysroot, but need use native perl to find it.

This is fixed by [PATCH 2/2] intltool: remove broken XML::Parser detection.

Ross

author
#3 lore raw
Quoted 4 lines · Ross

On 24 July 2016 at 06:16, Robert Yang <[email protected] <mailto:[email protected]>> wrote:

Quoted 8 lines

Fixed:
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool

The module is installed to sysroot, but need use native perl to find it.

This is fixed by [PATCH 2/2] intltool: remove broken XML::Parser detection.

Hi Ross,

I still get the same error after your patch applied:

configure:16513: checking for perl
configure:16531: found /usr/bin/perl
configure:16543: result: /usr/bin/perl
configure:16554: checking for perl >= 5.8.1
configure:16561: result: 5.18.2
configure:16565: checking for XML::Parser
configure:16571: error: XML::Parser perl module is required for intltool

// Robert

Quoted 2 lines

Ross

#4 lore raw
Quoted 23 lines · Robert Yang
Quoted 4 lines · Ross

On 24 July 2016 at 06:16, Robert Yang <[email protected] <mailto:[email protected]>> wrote:

Quoted 8 lines

Fixed:
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool

The module is installed to sysroot, but need use native perl to find it.

This is fixed by [PATCH 2/2] intltool: remove broken XML::Parser detection.

Hi Ross,

I still get the same error after your patch applied:

Quoted 7 lines

configure:16513: checking for perl
configure:16531: found /usr/bin/perl
configure:16543: result: /usr/bin/perl
configure:16554: checking for perl >= 5.8.1
configure:16561: result: 5.18.2
configure:16565: checking for XML::Parser
configure:16571: error: XML::Parser perl module is required for intltool

same here

http://errors.yoctoproject.org/Errors/Details/73330/

#5 lore raw
Quoted 10 lines · Khem Raj
Quoted 9 lines

I still get the same error after your patch applied:

configure:16513: checking for perl
configure:16531: found /usr/bin/perl
configure:16543: result: /usr/bin/perl
configure:16554: checking for perl >= 5.8.1
configure:16561: result: 5.18.2
configure:16565: checking for XML::Parser
configure:16571: error: XML::Parser perl module is required for intltool

Quoted 3 lines

same here

http://errors.yoctoproject.org/Errors/Details/73330/

[shakes fist at intltool]

So intltool is basically deprecated and I'm seriously considering spending the time porting to modern gettext instead of battling intltool.

Ross

#6 lore raw
In reply to Khem Raj
Quoted 10 lines · Khem Raj
Quoted 9 lines

I still get the same error after your patch applied:

configure:16513: checking for perl
configure:16531: found /usr/bin/perl
configure:16543: result: /usr/bin/perl
configure:16554: checking for perl >= 5.8.1
configure:16561: result: 5.18.2
configure:16565: checking for XML::Parser
configure:16571: error: XML::Parser perl module is required for intltool

Quoted 3 lines

same here

http://errors.yoctoproject.org/Errors/Details/73330/

I don't understand how as my patch literally removes that block of code from the intltool macros. Can you still replicate this, and if so can you save the build tree?

Ross

#7 lore raw

On Thu, 2016-08-04 at 16:17 +0100, Burton, Ross wrote:

Quoted 9 lines · On 27 July 2016 at 10:34, Khem Raj <[email protected]<mailto:[email protected]…

I still get the same error after your patch applied:

configure:16513: checking for perl
configure:16531: found /usr/bin/perl
configure:16543: result: /usr/bin/perl
configure:16554: checking for perl >= 5.8.1
configure:16561: result: 5.18.2
configure:16565: checking for XML::Parser
configure:16571: error: XML::Parser perl module is required for intltool

same here

http://errors.yoctoproject.org/Errors/Details/73330/

I don't understand how as my patch literally removes that block of code from the intltool macros. Can you still replicate this, and if so can you save the build tree?

Ross

Quoted 1 line

Here's the one that was on the Intel AB the other day: https://autobuilder.yoctoproject.org/intel/builders/nightly-meta-intel-world/builds/124/steps/BuildImages_1/logs/stdio . Search for "ERROR:" then scroll down a bit. The build tree is still on yocto-ab01.ostc.intel.com under nightly-meta-intel-world.

-Bill

author
#8 lore raw
In reply to Burton, Ross
Quoted 14 lines · Ross
Quoted 9 lines · On 27 July 2016 at 10:34, Khem Raj <[email protected]…

I still get the same error after your patch applied:

configure:16513: checking for perl
configure:16531: found /usr/bin/perl
configure:16543: result: /usr/bin/perl
configure:16554: checking for perl >= 5.8.1
configure:16561: result: 5.18.2
configure:16565: checking for XML::Parser
configure:16571: error: XML::Parser perl module is required forintltool

Quoted 8 lines
    same here

    http://errors.yoctoproject.org/Errors/Details/73330/

I don't understand how as my patch literally removes that block of code from the intltool macros. Can you still replicate this, and if so can you save the build tree?

I can reproduce the problem every time on my host Ubuntu 14.04 64bit:

local.conf:
MACHINE = "qemux86-64"
INHERIT += "packagefeed-stability"
PRSERV_HOST = "localhost:0"
require conf/multilib.conf
MULTILIBS = "multilib:lib32"
DEFAULTTUNE_virtclass-multilib-lib32 = "x86"

Error log:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=rbt/errlog&id=9e34fa2d6eed6332d376c341113d5dd386c5d200

I guess that you can't reproduce the problem is because you have XML::Parser installed on host ?

// Robert

Quoted 2 lines

Ross

#9 lore raw
Quoted 2 lines · Robert Yang

I can reproduce the problem every time on my host Ubuntu 14.04 64bit:

Just discovered that ephy for some reason ships its own copies of intltool.m4 (and a few others). We'll need to delete those. Patch incoming.

Ross

#10 lore raw
Quoted 10 lines · Ross

On 5 August 2016 at 03:47, Robert Yang <[email protected] <mailto:[email protected]>> wrote:

I can reproduce the problem every time on my host Ubuntu 14.04 64bit:

Just discovered that ephy for some reason ships its own copies of intltool.m4 (and a few others). We'll need to delete those. Patch incoming.

ah good find. I was still seeing the errors on my boxes.

Quoted 2 lines

Ross

#11 lore raw
Quoted 6 lines · Khem Raj
Quoted 3 lines

Just discovered that ephy for some reason ships its own copies of intltool.m4 (and a few others). We'll need to delete those. Patch incoming.

ah good find. I was still seeing the errors on my boxes.

I've now a few patches locally that I'll send shortly, and want to change autoconf a little too.

Ross