Minor build fixes
cover Minor build fixes
Fix for floating dependency in libdrm and a better fix for link issue in piglit.
Thanks,
Jussi
The following changes since commit 2679a347c576f5411fbe802d2f6201c94036ecb2:
maintainers.inc: rename gtk-doc-stub to gtk-doc, reassign to me (2016-09-09 12:12:59 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib jku/after-m3
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=jku/after-m3
Jussi Kukkonen (2):
piglit: Backport linker flag patch
libdrm: Explicitly disable cunit tests
...ac-Allow-explicit-enabling-of-cunit-tests.patch | 56 ++++++++++++++++++++++ meta/recipes-graphics/drm/libdrm_2.4.70.bb | 2 + .../0001-cmake-Link-test-utils-with-ldl.patch | 41 ++++++++++++++++ ...0001-cmake-Link-utils-with-xcb-explicitly.patch | 2 +- meta/recipes-graphics/piglit/piglit_git.bb | 3 +- 5 files changed, 101 insertions(+), 3 deletions(-) create mode 100644 meta/recipes-graphics/drm/libdrm/0001-configure.ac-Allow-explicit-enabling-of-cunit-tests.patch create mode 100644 meta/recipes-graphics/piglit/piglit/0001-cmake-Link-test-utils-with-ldl.patch
Signature · 1 line
2.1.4
PATCH 1/2 piglit: Backport linker flag patch
Use the correct build system patch instead of adding linker flags in recipe. Also update upstream status for the other build patch.
Fixes [YOCTO #9851].
--- .../0001-cmake-Link-test-utils-with-ldl.patch | 41 ++++++++++++++++++++++ ...0001-cmake-Link-utils-with-xcb-explicitly.patch | 2 +- meta/recipes-graphics/piglit/piglit_git.bb | 3 +- 3 files changed, 43 insertions(+), 3 deletions(-) create mode 100644 meta/recipes-graphics/piglit/piglit/0001-cmake-Link-test-utils-with-ldl.patch
meta/recipes-graphics/piglit/piglit/0001-cmake-Link-test-utils-with-ldl.patch new file +41 -0
@@ -0,0 +1,41 @@ +Backport patch to fix build with gold linker. + +Signed-off-by: Jussi Kukkonen <[email protected]> +Upstream-Status: Backport + + + +From 93a7113485cf1c55fd7076116faf5b3a690706b2 Mon Sep 17 00:00:00 2001 +From: Jussi Kukkonen <[email protected]> +Date: Tue, 30 Aug 2016 17:17:28 +0300 +Subject: [PATCH] cmake: Link test utils with "-ldl" + +Without this linking CXX executables (e.g. fbo-blit-stretch) fails +with gold linker: + +| libpiglitutil_gl.so.0: error: undefined reference to 'dlsym' +| libpiglitutil_gl.so.0: error: undefined reference to 'dlerror' +| libpiglitutil_gl.so.0: error: undefined reference to 'dlopen' + +Signed-off-by: Jussi Kukkonen <[email protected]> +Reviewed-by: Emil Velikov <[email protected]> +--- + tests/util/CMakeLists.txt | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/tests/util/CMakeLists.txt b/tests/util/CMakeLists.txt +index e1f8073..3d5bef5 100644 +--- a/tests/util/CMakeLists.txt ++++ b/tests/util/CMakeLists.txt +@@ -11,6 +11,8 @@ set_source_files_properties( + PROPERTIES GENERATED 1 + ) + ++link_libraries(${CMAKE_DL_LIBS}) ++ + if(HAVE_LIBCACA) + link_libraries(caca) + endif() +-- +2.9.3 +
meta/recipes-graphics/piglit/piglit/0001-cmake-Link-utils-with-xcb-explicitly.patch +1 -1
@@ -13,7 +13,7 @@ This may have appeared now because xcb-dri2 used to overlink publicly but now does not. Signed-off-by: Jussi Kukkonen <[email protected]> -Upstream-Status: Pending +Upstream-Status: Accepted --- CMakeLists.txt | 1 + tests/util/CMakeLists.txt | 2 ++
meta/recipes-graphics/piglit/piglit_git.bb +1 -2
@@ -6,6 +6,7 @@ SRC_URI = "git://anongit.freedesktop.org/piglit \ file://0001-cmake-install-bash-completions-in-the-right-place.patch \ file://0001-tests-Use-FE_UPWARD-only-if-its-defined-in-fenv.h.patch \ file://0001-cmake-Link-utils-with-xcb-explicitly.patch \ + file://0001-cmake-Link-test-utils-with-ldl.patch \ " # From 2016-07-07
@@ -30,8 +31,6 @@ do_compile[dirs] =+ "${B}/temp/" PACKAGECONFIG ??= "" PACKAGECONFIG[freeglut] = "-DPIGLIT_USE_GLUT=1,-DPIGLIT_USE_GLUT=0,freeglut," -LDFLAGS_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '-ldl', '', d)}" - do_configure_prepend() { if [ "${@bb.utils.contains('PACKAGECONFIG', 'freeglut', 'yes', 'no', d)}" = "no" ]; then sed -i -e "/^#.*include <GL\/freeglut_ext.h>$/d" ${S}/src/piglit/glut_wrap.h
Signature · 1 line
2.1.4
PATCH 2/2 libdrm: Explicitly disable cunit tests
Add patch to control building cunit-tests explicitly. Disable them in the recipe.
Fixes [YOCTO #9849].
--- ...ac-Allow-explicit-enabling-of-cunit-tests.patch | 56 ++++++++++++++++++++++ meta/recipes-graphics/drm/libdrm_2.4.70.bb | 2 + 2 files changed, 58 insertions(+) create mode 100644 meta/recipes-graphics/drm/libdrm/0001-configure.ac-Allow-explicit-enabling-of-cunit-tests.patch
meta/recipes-graphics/drm/libdrm/0001-configure.ac-Allow-explicit-enabling-of-cunit-tests.patch new file +56 -0
@@ -0,0 +1,56 @@ +From e6bd4205b0b546afe991ae6f72256645f4404ad4 Mon Sep 17 00:00:00 2001 +From: Jussi Kukkonen <[email protected]> +Date: Mon, 5 Sep 2016 14:41:37 +0300 +Subject: [PATCH libdrm] configure.ac: Allow explicit enabling of cunit tests + +Add --with-cunit to make it easier to do reproducible builds. Default +is still to probe cunit and build opportunistically. + +Signed-off-by: Jussi Kukkonen <[email protected]> +Upstream-Status: Submitted [mailing list] +--- + configure.ac | 14 ++++++++++++-- + 1 file changed, 12 insertions(+), 2 deletions(-) + +diff --git a/configure.ac b/configure.ac +index e3048c7..918d21d 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -137,6 +137,12 @@ AC_ARG_ENABLE(install-test-programs, + [Install test programs (default: no)]), + [INSTALL_TESTS=$enableval], [INSTALL_TESTS=no]) + ++AC_ARG_WITH([cunit], ++ [AS_HELP_STRING([--with-cunit], ++ [Build tests that use cunit (default: auto)])], ++ [], ++ [with_cunit=auto]) ++ + dnl =========================================================================== + dnl check compiler flags + AC_DEFUN([LIBDRM_CC_TRY_FLAG], [ +@@ -372,7 +378,7 @@ if test "x$RADEON" = xyes; then + AC_DEFINE(HAVE_RADEON, 1, [Have radeon support]) + fi + +-if test "x$AMDGPU" != xno; then ++if test "x$with_cunit" != xno -a "x$AMDGPU" != xno; then + # Detect cunit library + PKG_CHECK_MODULES([CUNIT], [cunit >= 2.1], [have_cunit=yes], [have_cunit=no]) + # If pkg-config does not find cunit, check it using AC_CHECK_LIB. We +@@ -399,7 +406,11 @@ if test "x$AMDGPU" = xyes; then + AC_DEFINE(HAVE_CUNIT, [test "x$have_cunit" != "xno"], [Enable CUNIT Have amdgpu support]) + + if test "x$have_cunit" = "xno"; then +- AC_MSG_WARN([Could not find cunit library. Disabling amdgpu tests]) ++ if test "x$with_cunit" = "xyes"; then ++ AC_MSG_ERROR([Could not find cunit library but --with-cunit was given]) ++ elif test "x$with_cunit" = "xauto"; then ++ AC_MSG_WARN([Could not find cunit library. Disabling amdgpu tests]) ++ fi + fi + fi + +-- +2.1.4 +
meta/recipes-graphics/drm/libdrm_2.4.70.bb +2 -0
@@ -13,6 +13,7 @@ DEPENDS = "libpthread-stubs udev libpciaccess" SRC_URI = "http://dri.freedesktop.org/libdrm/${BP}.tar.bz2 \ file://installtests.patch \ file://fix_O_CLOEXEC_undeclared.patch \ + file://0001-configure.ac-Allow-explicit-enabling-of-cunit-tests.patch \ " SRC_URI[md5sum] = "920957cfe25a80efb02be9bd90bf3c1e"
@@ -21,6 +22,7 @@ SRC_URI[sha256sum] = "b17d4b39ed97ca0e4cffa0db06ff609e617bac94646ec38e8e0579d530 inherit autotools pkgconfig EXTRA_OECONF += "--disable-cairo-tests \ + --without-cunit \ --enable-omap-experimental-api \ --enable-install-test-programs \ --disable-manpages \
Signature · 1 line
2.1.4