Skip to contentSkip to conversation

Staging: fsl-mc: Correct errors reported by checkpatch

PATCH New Ramiro Oliveira 1 participant 3 messages Sep 30, 2016 Staging

lore
Share & tools
lore
#0 lore raw

v2 cover Staging: fsl-mc: Correct errors reported by checkpatch

This set of patches corrects some errors reported by checkpatch in drivers/staging/fsl-mc

v2: Split the patch in 2 parts, one for unaligned * in block comments, other for multiple blank lines.

Ramiro Oliveira (2):
Staging: fsl-mc: Fix unaligned * in block comments
Staging: fsl-mc: Remove blank lines

 drivers/staging/fsl-mc/bus/dpbp.c         | 60 ++++++++++-----------
 drivers/staging/fsl-mc/bus/dpmcp.c        |  1 -
 drivers/staging/fsl-mc/bus/dpmng.c        | 60 ++++++++++-----------
 drivers/staging/fsl-mc/bus/dprc.c         | 88 +++++++++++++++----------------
 drivers/staging/fsl-mc/bus/fsl-mc-bus.c   |  5 +-
 drivers/staging/fsl-mc/include/dpbp-cmd.h | 60 ++++++++++-----------
 6 files changed, 136 insertions(+), 138 deletions(-)
Signature · 1 line
2.9.3
#2 lore raw

PATCH v2 2/2 Staging: fsl-mc: Remove blank lines

Remove multiple blank lines as reported by checkpatch

---
 drivers/staging/fsl-mc/bus/dpmcp.c      | 1 -
 drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 -
 2 files changed, 2 deletions(-)
drivers/staging/fsl-mc/bus/dpmcp.c +0 -1
index bd63baa..55766f7 100644
@@ -369,7 +369,6 @@ int dpmcp_set_irq_mask(struct fsl_mc_io *mc_io,
 	struct mc_command cmd = { 0 };
 	struct dpmcp_cmd_set_irq_mask *cmd_params;
 
-
 	/* prepare command */
 	cmd.header = mc_encode_cmd_header(DPMCP_CMDID_SET_IRQ_MASK,
 					  cmd_flags, token);
drivers/staging/fsl-mc/bus/fsl-mc-bus.c +0 -1
index 4ebc72f..44f64b6 100644
@@ -139,7 +139,6 @@ static struct attribute *fsl_mc_dev_attrs[] = {
 
 ATTRIBUTE_GROUPS(fsl_mc_dev);
 
-
 struct bus_type fsl_mc_bus_type = {
 	.name = "fsl-mc",
 	.match = fsl_mc_bus_match,
Signature · 1 line
2.9.3
#1 lore raw

PATCH v2 1/2 Staging: fsl-mc: Fix unaligned * in block comments

In reply to Ramiro Oliveira

Align the * in some block comments as reported by checkpatch.

---
 drivers/staging/fsl-mc/bus/dpbp.c         | 60 ++++++++++-----------
 drivers/staging/fsl-mc/bus/dpmng.c        | 60 ++++++++++-----------
 drivers/staging/fsl-mc/bus/dprc.c         | 88 +++++++++++++++----------------
 drivers/staging/fsl-mc/bus/fsl-mc-bus.c   |  4 +-
 drivers/staging/fsl-mc/include/dpbp-cmd.h | 60 ++++++++++-----------
 5 files changed, 136 insertions(+), 136 deletions(-)
drivers/staging/fsl-mc/bus/dpbp.c +30 -30
index fe271fb..5d4cd81 100644
@@ -1,34 +1,34 @@
 /* Copyright 2013-2016 Freescale Semiconductor Inc.
-*
-* Redistribution and use in source and binary forms, with or without
-* modification, are permitted provided that the following conditions are met:
-* * Redistributions of source code must retain the above copyright
-* notice, this list of conditions and the following disclaimer.
-* * Redistributions in binary form must reproduce the above copyright
-* notice, this list of conditions and the following disclaimer in the
-* documentation and/or other materials provided with the distribution.
-* * Neither the name of the above-listed copyright holders nor the
-* names of any contributors may be used to endorse or promote products
-* derived from this software without specific prior written permission.
-*
-*
-* ALTERNATIVELY, this software may be distributed under the terms of the
-* GNU General Public License ("GPL") as published by the Free Software
-* Foundation, either version 2 of that License or (at your option) any
-* later version.
-*
-* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
-* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
-* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
-* POSSIBILITY OF SUCH DAMAGE.
-*/
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of the above-listed copyright holders nor the
+ * names of any contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
 #include "../include/mc-sys.h"
 #include "../include/mc-cmd.h"
 #include "../include/dpbp.h"
drivers/staging/fsl-mc/bus/dpmng.c +30 -30

64 lines not on this page · raw message

drivers/staging/fsl-mc/bus/dprc.c +44 -44

98 lines not on this page · raw message

drivers/staging/fsl-mc/bus/fsl-mc-bus.c +2 -2
index 3d687b5..4ebc72f 100644
@@ -259,8 +259,8 @@ bool fsl_mc_bus_exists(void)
 EXPORT_SYMBOL_GPL(fsl_mc_bus_exists);
 
 /**
-* fsl_mc_get_root_dprc - function to traverse to the root dprc
-*/
+ * fsl_mc_get_root_dprc - function to traverse to the root dprc
+ */
 void fsl_mc_get_root_dprc(struct device *dev,
 			  struct device **root_dprc_dev)
 {
drivers/staging/fsl-mc/include/dpbp-cmd.h +30 -30

64 lines not on this page · raw message

Signature · 1 line
2.9.3