Skip to contentSkip to conversation

ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

PATCH In review Alexandrov Stansilav 4 participants 6 messages Jan 6, 2017 – Jan 16, 2017

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v3 cover ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.

Inside DSDT table there is record for this soundcard:

            Device (RTKC)
            {
                Name (_ADR, Zero)  // _ADR: Address
                Name (_HID, "10EC3276")  // _HID: Hardware ID
                Name (_CID, "10EC3276")  // _CID: Compatible ID
                Name (_DDN, "ALC3276")  // _DDN: DOS Device Name
                Name (_SUB, "103C827C")  // _SUB: Subsystem ID
                Name (_PR0, Package (0x01)  // _PR0: Power Resources for D0

original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621

v3: Fixed patch descriptions
v2: Splited patch to codec and sst parts

Alexandrov Stansilav (2):
ASoc: rt5640: Add "10EC3276" ACPI ID
ASoC: Intel: Atom: Add HP Pavilion x2 10 10-p000 machine entry

 sound/soc/codecs/rt5640.c           | 1 +
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 2 files changed, 3 insertions(+)
Signature · 1 line
2.10.2
#1 lore raw

PATCH v3 1/2 ASoC: rt5640: Add "10EC3276" ACPI ID

Add ACPI ID "10EC3276" for sound card found on notebook HP Pavilion X2 10-p000. ACPI DSDT Table on this device describes this card as ALC3276, but it is in fact rt5640.

---
 sound/soc/codecs/rt5640.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/rt5640.c +1 -0
index e29a6de..b857a71 100644
@@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match);
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id rt5640_acpi_match[] = {
 	{ "INT33CA", 0 },
+	{ "10EC3276", 0 },
 	{ "10EC5640", 0 },
 	{ "10EC5642", 0 },
 	{ "INTCCFFD", 0 },
Signature · 1 line
2.10.2
#2 lore raw

PATCH v3 2/2 ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry

In reply to Alexandrov Stansilav

Add machine entry for HP X2 Pavilion 10-p100.
This notebook contains rt5640 codec, but with ACPI ID "10EC3276".

---
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/intel/atom/sst/sst_acpi.c +2 -0
index f4d92bb..896ced2 100644
@@ -463,6 +463,8 @@ static struct sst_acpi_mach sst_acpi_chv[] = {
 	/* some CHT-T platforms rely on RT5640, use Baytrail machine driver */
 	{"10EC5640", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", cht_quirk,
 						&chv_platform_data },
+	{"10EC3276", "bytcr_rt5640", "intel/fw_sst_22a8.bin", "bytcr_rt5640", NULL,
+						&chv_platform_data },
 
 	{},
 };
Signature · 1 line
2.10.2
Acked-by on the v3 series
#3 lore raw
In reply to Alexandrov Stansilav
Quoted 11 lines · Alexandrov Stansilav

Inside DSDT table there is record for this soundcard:

            Device (RTKC)
            {
                Name (_ADR, Zero)  // _ADR: Address
                Name (_HID, "10EC3276")  // _HID: Hardware ID
                Name (_CID, "10EC3276")  // _CID: Compatible ID
                Name (_DDN, "ALC3276")  // _DDN: DOS Device Name
                Name (_SUB, "103C827C")  // _SUB: Subsystem ID
                Name (_PR0, Package (0x01)  // _PR0: Power Resources for D0
Quoted 1 line

original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621

Looks good to me, both:

Quoted 16 lines

v3: Fixed patch descriptions
v2: Splited patch to codec and sst parts

Alexandrov Stansilav (2):
ASoc: rt5640: Add "10EC3276" ACPI ID
ASoC: Intel: Atom: Add HP Pavilion x2 10 10-p000 machine entry

 sound/soc/codecs/rt5640.c           | 1 +
 sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
 2 files changed, 3 insertions(+)
Signature · 1 line
2.10.2
Signature · 1 line
~Vinod
#4 lore raw
Quoted 12 lines · Vinod Koul
Quoted 11 lines · Alexandrov Stansilav

Inside DSDT table there is record for this soundcard:

             Device (RTKC)
             {
                 Name (_ADR, Zero)  // _ADR: Address
                 Name (_HID, "10EC3276")  // _HID: Hardware ID
                 Name (_CID, "10EC3276")  // _CID: Compatible ID
                 Name (_DDN, "ALC3276")  // _DDN: DOS Device Name
                 Name (_SUB, "103C827C")  // _SUB: Subsystem ID
                 Name (_PR0, Package (0x01)  // _PR0: Power Resources for D0
Quoted 4 lines
Quoted 1 line

original bugreport: https://bugzilla.kernel.org/show_bug.cgi?id=187621

Looks good to me, both:

Mark was not CC:ed, not sure if he saw these two patches?
I have another patch to fix Bugzilla 156191 and add cht+rt5651 in the machine driver list, this will conflict if this set is not merged first. Thanks!

Quoted 16 lines
Quoted 16 lines

v3: Fixed patch descriptions
v2: Splited patch to codec and sst parts

Alexandrov Stansilav (2):
ASoc: rt5640: Add "10EC3276" ACPI ID
ASoC: Intel: Atom: Add HP Pavilion x2 10 10-p000 machine entry

  sound/soc/codecs/rt5640.c           | 1 +
  sound/soc/intel/atom/sst/sst_acpi.c | 2 ++
  2 files changed, 3 insertions(+)
Signature · 1 line
2.10.2
maintainer
#5 lore raw
Quoted 1 line · Pierre-Louis Bossart

Mark was not CC:ed, not sure if he saw these two patches?

Not if they weren't sent to me.