Skip to contentSkip to conversation

Staging: unisys: visorbus: style fix, using octal file permissions

PATCH In review Derek Robson 4 participants 6 messages Jan 7, 2017 – Jan 9, 2017 Staging

lore
Share & tools
lore

Derek Robson

author
#0 lore raw

cover Staging: unisys: visorbus: style fix, using octal file permissions

Two files change in style fix, changes are octal file permissions.

Derek Robson (2):
Staging: unisys: visorbus: style fix, using octal file permissions
Staging: unisys: visorbus: style fix, using octal file permissions

 drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
 drivers/staging/unisys/visorbus/visorchipset.c  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH 1/2 Staging: unisys: visorbus: style fix, using octal file permissions

Changed file permissions to octal style.
Found with checkpatch

Signed-off-by Derek Robson <[email protected]>
---
 drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/unisys/visorbus/visorbus_main.c +3 -3
index 3457ef338e1e..28ca291a4053 100644
@@ -984,7 +984,7 @@ create_bus_instance(struct visor_device *dev)
 		goto err_hdr_info;
 	}
 	dev->debugfs_client_bus_info =
-		debugfs_create_file("client_bus_info", S_IRUSR | S_IRGRP,
+		debugfs_create_file("client_bus_info", 0440,
 				    dev->debugfs_dir, dev,
 				    &client_bus_info_debugfs_fops);
 	if (!dev->debugfs_client_bus_info) {

@@ -1337,10 +1337,10 @@ visorbus_exit(void)
 	debugfs_remove_recursive(visorbus_debugfs_dir);
 }
 
-module_param_named(forcematch, visorbus_forcematch, int, S_IRUGO);
+module_param_named(forcematch, visorbus_forcematch, int, 0444);
 MODULE_PARM_DESC(visorbus_forcematch,
 		 "1 to force a successful dev <--> drv match");
 
-module_param_named(forcenomatch, visorbus_forcenomatch, int, S_IRUGO);
+module_param_named(forcenomatch, visorbus_forcenomatch, int, 0444);
 MODULE_PARM_DESC(visorbus_forcenomatch,
 		 "1 to force an UNsuccessful dev <--> drv match");
Signature · 1 line
2.11.0
author
#2 lore raw

PATCH 2/2 Staging: unisys: visorbus: style fix, using octal file permissions

In reply to Derek Robson

Changed file permissions to octal sytle.
Found using checkpatch.

Signed-off-by Derek Robson <[email protected]>
---
 drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/unisys/visorbus/visorchipset.c +1 -1
index d7148c351d3f..66944e7534e9 100644
@@ -2277,7 +2277,7 @@ static void exit_unisys(void)
 	acpi_bus_unregister_driver(&unisys_acpi_driver);
 }
 
-module_param_named(major, visorchipset_major, int, S_IRUGO);
+module_param_named(major, visorchipset_major, int, 0444);
 MODULE_PARM_DESC(visorchipset_major,
 		 "major device number to use for the device node");
Signature · 1 line
2.11.0
Acked-by on the v1 series
#3 lore raw
In reply to Derek Robson
Quoted 11 lines

-----Original Message-----
From: Derek Robson [mailto:[email protected]]
Sent: Friday, January 6, 2017 10:48 PM
To: Kershner, David A <[email protected]>; [email protected]; Sell, Timothy C <[email protected]>
Cc: *S-Par-Maintainer <[email protected]>; [email protected]; [email protected]; Derek Robson <[email protected]>
Subject: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions

Quoted 2 lines

Two files change in style fix, changes are octal file permissions.

Series looks fine to me and runs on top of the s-Par firmware.

Acked-by David Kershner <[email protected]>
Quoted 10 lines

Derek Robson (2):
Staging: unisys: visorbus: style fix, using octal file permissions
Staging: unisys: visorbus: style fix, using octal file permissions

 drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
 drivers/staging/unisys/visorbus/visorchipset.c  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

--
2.11.0

maintainer
#4 lore raw
In reply to Derek Robson
Quoted 5 lines · Derek Robson

Two files change in style fix, changes are octal file permissions.

Derek Robson (2):
Staging: unisys: visorbus: style fix, using octal file permissions
Staging: unisys: visorbus: style fix, using octal file permissions

You can't send different patches that do different things with identical subject lines, as that doesn't make sense, right?

Please resend making these subject unique, and add David's ack to them as well on the resend.

thanks,

greg k-h

#5 lore raw
In reply to Derek Robson
Quoted 1 line · Derek Robson

Two files change in style fix, changes are octal file permissions.

Does it make any sense? Or did I miss something?

Signature · 2 lines
With Best Regards,
Andy Shevchenko