Staging: comedi: comedi_fops: Header cleanup
cover Staging: comedi: comedi_fops: Header cleanup
This series does trivial header cleanup for comedi_fops.c
Cheah Kok Cheong (4):
Staging: comedi: comedi_fops: Remove unused kmod.h header
Staging: comedi: comedi_fops: Remove redundant init.h header
Staging: comedi: comedi_fops: Remove unused vmalloc.h header
Staging: comedi: comedi_fops: Remove unused stat.h header
drivers/staging/comedi/comedi_fops.c | 4 ---- 1 file changed, 4 deletions(-)
Signature · 1 line
2.7.4
PATCH 2/4 Staging: comedi: comedi_fops: Remove redundant init.h header
After commit 0fd972a7d91d ("module: relocate module_init from init.h to module.h"), including module.h will do and init.h is also thrown in.
--- drivers/staging/comedi/comedi_fops.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/comedi/comedi_fops.c +0 -1
@@ -29,7 +29,6 @@#include <linux/mm.h> #include <linux/slab.h> #include <linux/poll.h> -#include <linux/init.h> #include <linux/device.h> #include <linux/vmalloc.h> #include <linux/fs.h>
Signature · 1 line
2.7.4
PATCH 4/4 Staging: comedi: comedi_fops: Remove unused stat.h header
In reply to Cheah Kok CheongUnused after commit 6e3029397698 ("staging: comedi: comedi_fops:
coding style fixes") - Fixed coding style in comedi_fops.c Symbolic to octal permission.
Anyway it's included in module.h
--- drivers/staging/comedi/comedi_fops.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/comedi/comedi_fops.c +0 -1
@@ -33,7 +33,6 @@#include <linux/fs.h> #include "comedidev.h" #include <linux/cdev.h> -#include <linux/stat.h> #include <linux/io.h> #include <linux/uaccess.h>
Signature · 1 line
2.7.4
PATCH 3/4 Staging: comedi: comedi_fops: Remove unused vmalloc.h header
In reply to Cheah Kok CheongUnused after commit d18431325be0 ("staging: comedi:
deprecate loading firmware with comedi_config").
--- drivers/staging/comedi/comedi_fops.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/comedi/comedi_fops.c +0 -1
@@ -30,7 +30,6 @@#include <linux/slab.h> #include <linux/poll.h> #include <linux/device.h> -#include <linux/vmalloc.h> #include <linux/fs.h> #include "comedidev.h" #include <linux/cdev.h>
Signature · 1 line
2.7.4
PATCH 1/4 Staging: comedi: comedi_fops: Remove unused kmod.h header
In reply to Cheah Kok CheongUnused after commit f30f2c2d417b ("staging: comedi:
remove check for CONFIG_KMOD").
Anyway it's included in module.h
--- drivers/staging/comedi/comedi_fops.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/comedi/comedi_fops.c +0 -1
@@ -28,7 +28,6 @@#include <linux/delay.h> #include <linux/mm.h> #include <linux/slab.h> -#include <linux/kmod.h> #include <linux/poll.h> #include <linux/init.h> #include <linux/device.h>
Signature · 1 line
2.7.4
Quoted 11 lines · Cheah Kok Cheong
This series does trivial header cleanup for
comedi_fops.cCheah Kok Cheong (4):
Staging: comedi:comedi_fops: Remove unusedkmod.hheader
Staging: comedi:comedi_fops: Remove redundantinit.hheader
Staging: comedi:comedi_fops: Remove unusedvmalloc.hheader
Staging: comedi:comedi_fops: Remove unusedstat.hheaderdrivers/staging/comedi/comedi_fops.c | 4 ---- 1 file changed, 4 deletions(-)
I wasn't sure about the removal of the #include <linux/init.h>, but it seems to make sense. Thanks.
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=- -=( Web: http://www.mev.co.uk/ )=-