Skip to contentSkip to conversation

devtool: check locale and refuse to start if it isn't UTF-8

PATCH New Paul Eggleton 1 participant 2 messages Jan 19, 2017

lore
Share & tools
lore
#0 lore raw

cover devtool: check locale and refuse to start if it isn't UTF-8

The following changes since commit a7cb408dd784178197687a2129e936620bf6a0d3:

sanity.bbclass: Improved error message (2017-01-17 11:31:31 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib paule/devtool-utf8
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=paule/devtool-utf8

Paul Eggleton (1):
devtool: check locale and refuse to start if it isn't UTF-8

 scripts/devtool | 3 +++
 1 file changed, 3 insertions(+)
Signature · 1 line
2.5.5
#1 lore raw

PATCH 1/1 devtool: check locale and refuse to start if it isn't UTF-8

We need to ensure the locale is UTF-8 or otherwise strange errors will occur later on during execution - the same reason we check this in BitBake itself. Unfortunately this check has to be before command line parsing and therefore showing the help text in response to --help, since that relies upon parsing bitbake's configuration (as we need to load plugins in other layers).

Fixes [YOCTO #10908].

---
 scripts/devtool | 3 +++
 1 file changed, 3 insertions(+)
scripts/devtool +3 -0
index 0866be9..c9ad9dd 100755
@@ -215,6 +215,9 @@ def main():
     global config
     global context
 
+    if sys.getfilesystemencoding() != "utf-8":
+        sys.exit("Please use a locale setting which supports utf-8.\nPython can't change the filesystem locale after loading so we need a utf-8 when python starts or things won't work.")
+
     context = Context(fixed_setup=False)
 
     # Default basepath
Signature · 1 line
2.5.5