staging: wlan-ng: align else if statement to coding standard
v7 cover staging: wlan-ng: align else if statement to coding standard
PATCHv0:
- Spaces replaced with tabs
Maksymilian Piechota (1):
staging: wlan-ng: This patch fixes the checkpatch.pl warning:
else if statement still did not fulfill coding standard requirements.
PATCHv2:
- else if statement moved to single line
Maksymilian Piechota (1):
staging: wlan-ng: This patch fixes the checkpatch.pl warning:
Subject was not precise.
PATCHv3:
- Subject is more precise
- Changelog text describe every change
Maksymilian Piechota (1):
staging: lustre: align else if statement to coding standard
Too much changes for one patch.
PATCHv4:
- Previous patch breaked up to particular patches for every change
Maksymilian Piechota (2):
staging: lustre: move logical continuations at the end of line
staging: lustre: move else if statement to a single line
Continuation of the statement should be realigned
PATCHv5:
- Wrong prefixes in commits and patches titles changed
- Else if continuation realigned
Maksymilian Piechota (3):
staging: wlan-ng: move logical continuations at the end of line
staging: wlan-ng: move else if statement to a single line
staging: wlan-ng: realign else if continuation
Lack of patches history. No changelog text for particular patches
PATCHv6:
- changelog text for patches added
- patches history added
Maksymilian Piechota (3):
staging: wlan-ng: move logical continuations at the end of line
staging: wlan-ng: move else if statement to a single line
staging: wlan-ng: realign else if continuation
Checkpatch errors appears between patches.
PATCHv7:
- Changes made from scratch
- else if statement moved to a single line
- logical continuation moved at the end of line
Maksymilian Piechota (2):
staging: wlan-ng: move else if statement to a single line
staging: wlan-ng: move logical continuation at the end of line
drivers/staging/wlan-ng/prism2mgmt.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Signature · 1 line
2.1.4
PATCH v7 1/2 staging: wlan-ng: move else if statement to a single line
move else if statement to a single line
--- drivers/staging/wlan-ng/prism2mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/wlan-ng/prism2mgmt.c +1 -2
@@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) && (msg->prismheader.data == P80211ENUM_truth_true)) { hw->sniffhdr =0 ; wlandev->netdev->type =ARPHRD_IEEE80211_PRISM ; - } else - if ((msg->wlanheader.status == + } else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && (msg->wlanheader.data == P80211ENUM_truth_true)) { hw->sniffhdr =1 ;
Signature · 1 line
2.1.4
PATCH v7 2/2 staging: wlan-ng: move logical continuation at the end of line
In reply to Maksymilian Piechotamove logical continuations at the end of line
--- drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/wlan-ng/prism2mgmt.c +2 -2
@@ -1308,8 +1308,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) hw->sniffhdr =0 ; wlandev->netdev->type =ARPHRD_IEEE80211_PRISM ; }else if ((msg->wlanheader.status == - P80211ENUM_msgitem_status_data_ok) - && (msg->wlanheader.data == P80211ENUM_truth_true)) { + P80211ENUM_msgitem_status_data_ok) && + (msg->wlanheader.data == P80211ENUM_truth_true)) { hw->sniffhdr =1 ; wlandev->netdev->type =ARPHRD_IEEE80211_PRISM ; }else {
Signature · 1 line
2.1.4
Greg Kroah-Hartman
maintainerRe: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line
In reply to Maksymilian PiechotaQuoted 12 lines · Maksymilian Piechota
move else if statement to a single line
Signed-off-by Maksymilian Piechota <[email protected]>--- drivers/staging/wlan-ng/prism2mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/wlan-ng/prism2mgmt.c +0
-0
drivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) · line 1313
Quoted 9 lines
drivers/staging/wlan-ng/prism2mgmt.c +1
-2@@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) && (msg->prismheader.data == P80211ENUM_truth_true)) { hw->sniffhdr =0 ; wlandev->netdev->type =ARPHRD_IEEE80211_PRISM ; - } else - if ((msg->wlanheader.status == + } else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && (msg->wlanheader.data == P80211ENUM_truth_true)) { hw->sniffhdr =1 ;
This patch does not apply to my tree at all :(
Please rebase and resend the series.
thanks,
greg k-h
Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line
Quoted 25 lines · Greg Kroah-Hartman
Quoted 12 lines · Maksymilian Piechota
move else if statement to a single line
Signed-off-by Maksymilian Piechota <[email protected]>--- drivers/staging/wlan-ng/prism2mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/wlan-ng/prism2mgmt.c +0
-0drivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) · line 1313
Quoted 9 lines
drivers/staging/wlan-ng/prism2mgmt.c +1
-2@@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) && (msg->prismheader.data == P80211ENUM_truth_true)) { hw->sniffhdr =0 ; wlandev->netdev->type =ARPHRD_IEEE80211_PRISM ; - } else - if ((msg->wlanheader.status == + } else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && (msg->wlanheader.data == P80211ENUM_truth_true)) { hw->sniffhdr =1 ;This patch does not apply to my tree at all :(
Quoted 5 lines
Please rebase and resend the series.
thanks,
greg k-h
ok, I've got newest sources and this change is already applied. So what are the next steps suggested? I've heard there is a possibility to obtain mentor, right?
Greg Kroah-Hartman
maintainerRe: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line
Quoted 26 lines · Maksymilian Piechota
Quoted 25 lines · Greg Kroah-Hartman
Quoted 12 lines · Maksymilian Piechota
move else if statement to a single line
Signed-off-by Maksymilian Piechota <[email protected]>--- drivers/staging/wlan-ng/prism2mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/wlan-ng/prism2mgmt.c +0
-0drivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) · line 1313
Quoted 9 lines
drivers/staging/wlan-ng/prism2mgmt.c +1
-2@@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) && (msg->prismheader.data == P80211ENUM_truth_true)) { hw->sniffhdr =0 ; wlandev->netdev->type =ARPHRD_IEEE80211_PRISM ; - } else - if ((msg->wlanheader.status == + } else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && (msg->wlanheader.data == P80211ENUM_truth_true)) { hw->sniffhdr =1 ;This patch does not apply to my tree at all :(
Quoted 8 lines
Quoted 5 lines
Please rebase and resend the series.
thanks,
greg k-h
ok, I've got newest sources and this change is already applied. So what are the next steps suggested?
Suggested for what?
Quoted 1 line
I've heard there is a possibility to obtain mentor, right?
Mentor for what?
confused,
greg k-h