staging: sm750fb: Add braces around if statement.
Subsystems (2)
PATCH v4 1/7 staging: sm750fb: Add braces around if statement.
In reply to a message not in the archiveAdded braces around if statement. This patch fixes the following checkpatch issue:
CHECK: braces {} should be used on all arms of this statement
---
Changes in v4:
- Added proper version number to patch.
drivers/staging/sm750fb/ddk750_chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +2 -2
@@ -16,9 +16,9 @@ logical_chip_type_t sm750_get_chip_type(void)void sm750_set_chip_type (unsigned short devId,u8 revId) { -if (devId ==0x718 ) +if (devId ==0x718 ) { chip =SM718 ; -else if (devId ==0x750 ) { + }else if (devId ==0x750 ) { chip =SM750 ;/* SM750 and SM750LE are different in their revision ID only. */ if (revId ==SM750LE_REVISION_ID ) {
Signature · 1 line
2.9.3
PATCH v4 2/7 staging: sm750fb: Fix line over 80 characters.
In reply to a message not in the archiveLine over 80 characters are split to fix the following checkpatch issue:
WARNING: line over 80 characters
---
Changes in v4:
-Added proper version number to patch.
drivers/staging/sm750fb/ddk750_chip.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +5 -5
@@ -69,11 +69,11 @@ static void set_chip_clock(unsigned int frequency) pll.clockType =MXCLK_PLL ;/* -* Call sm750_calc_pll_value() to fill the other fields of the PLL -* structure. Sometimes, the chip cannot set up the exact -* clock required by the User. -* Return value of sm750_calc_pll_value gives the actual possible -* clock. +* Call sm750_calc_pll_value() to fill the other fields +* of the PLL structure. Sometimes, the chip cannot set +* up the exact clock required by the User. +* Return value of sm750_calc_pll_value gives the actual +* possible clock. */ ulActualMxClk =sm750_calc_pll_value (frequency, &pll);
Signature · 1 line
2.9.3
PATCH v4 3/7 staging: sm750fb: Add identifier to function definition argument.
In reply to a message not in the archiveAdded pinit_param as the identifier to function definition argument struct initchip_param and this patch fixes the checkpatch issue.
---
Changes in v4:
- Added proper version number to patch.
drivers/staging/sm750fb/ddk750_chip.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_chip.h +1 -1
@@ -98,6 +98,6 @@ void sm750_set_chip_type(unsigned short devId, u8 revId);unsigned int sm750_calc_pll_value (unsigned int request,struct pll_value *pll);unsigned int sm750_format_pll_reg (struct pll_value *pPLL);unsigned int ddk750_get_vm_size (void ); -int ddk750_init_hw (struct initchip_param *); +int ddk750_init_hw (struct initchip_param *pinit_param);#endif
Signature · 1 line
2.9.3
PATCH v4 4/7 staging: sm750fb: Remove unnecessary blank lines.
In reply to a message not in the archiveRemoved multiple blank lines, which are not required. This patch fixes the following check patch issues:
CHECK: Please don't use multiple blank lines
---
Changes in v4
-Added proper version number to patch.
drivers/staging/sm750fb/ddk750_display.h | 5 ----- drivers/staging/sm750fb/ddk750_dvi.c | 4 ---- drivers/staging/sm750fb/ddk750_mode.c | 5 ----- drivers/staging/sm750fb/ddk750_mode.h | 2 -- drivers/staging/sm750fb/ddk750_power.c | 5 ----- drivers/staging/sm750fb/ddk750_power.h | 1 - drivers/staging/sm750fb/ddk750_reg.h | 4 ---- 7 files changed, 26 deletions(-)
drivers/staging/sm750fb/ddk750_display.h +0 -5
@@ -12,7 +12,6 @@#define PNL_2_PRI ((0 << PNL_2_OFFSET) | PNL_2_USAGE)#define PNL_2_SEC ((2 << PNL_2_OFFSET) | PNL_2_USAGE) -/* * primary timing & plane enable bit * 1: 80000[8] & 80000[2] on
@@ -24,7 +23,6 @@#define PRI_TP_ON ((0x1 << PRI_TP_OFFSET) | PRI_TP_USAGE)#define PRI_TP_OFF ((0x0 << PRI_TP_OFFSET) | PRI_TP_USAGE) -/* * panel sequency status * 80000[27:24]
@@ -66,7 +64,6 @@#define CRT_2_PRI ((0x0 << CRT_2_OFFSET) | CRT_2_USAGE)#define CRT_2_SEC ((0x2 << CRT_2_OFFSET) | CRT_2_USAGE) -/* * DAC affect both DVI and DSUB * 4[20]
@@ -87,8 +84,6 @@#define DPMS_OFF ((3 << DPMS_OFFSET) | DPMS_USAGE)#define DPMS_ON ((0 << DPMS_OFFSET) | DPMS_USAGE) - -/* * LCD1 means panel path TFT1 & panel path DVI (so enable DAC) * CRT means crt path DSUB
drivers/staging/sm750fb/ddk750_dvi.c +0 -4
@@ -5,7 +5,6 @@#include "ddk750_dvi.h" #include "ddk750_sii164.h" -/* * This global variable contains all the supported driver and its corresponding * function API. Please set the function pointer to NULL whenever the function
@@ -30,7 +29,6 @@ static dvi_ctrl_device_t g_dcftSupportedDviController[] = {#endif }; - int dviInit( unsigned char edgeSelect, unsigned char busSelect,
@@ -56,5 +54,3 @@ int dviInit( }#endif - -
drivers/staging/sm750fb/ddk750_mode.c +0 -5
@@ -71,8 +71,6 @@ static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam,return dispControl; } - -/* only timing related registers will be programed */ static int programModeRegisters (mode_parameter_t *pModeParam,struct pll_value *pll)
@@ -112,7 +110,6 @@ static int programModeRegisters(mode_parameter_t *pModeParam, ((pModeParam->vertical_sync_start -1 ) & CRT_VERTICAL_SYNC_START_MASK)); - tmp =DISPLAY_CTRL_TIMING |DISPLAY_CTRL_PLANE ;if (pModeParam->vertical_sync_polarity) tmp |=DISPLAY_CTRL_VSYNC_PHASE ;
@@ -219,5 +216,3 @@ int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock)programModeRegisters (parm, &pll);return 0 ; } - -
drivers/staging/sm750fb/ddk750_mode.h +0 -2
@@ -9,7 +9,6 @@ typedef enum _spolarity_t { } spolarity_t; - typedef struct _mode_parameter_t { /* Horizontal timing. */ unsigned long horizontal_total;
@@ -37,5 +36,4 @@ mode_parameter_t;int ddk750_setModeTiming (mode_parameter_t *,clock_type_t ); -#endif
drivers/staging/sm750fb/ddk750_power.c +0 -5
@@ -24,7 +24,6 @@ static unsigned int get_power_mode(void)return peek32 (POWER_MODE_CTRL ) &POWER_MODE_CTRL_MODE_MASK ; } -/* * SM50x can operate in one of three modes: 0, 1 or Sleep. * On hardware reset, power mode 0 is default.
@@ -80,8 +79,6 @@ void sm750_set_current_gate(unsigned int gate)poke32 (MODE0_GATE , gate); } - -/* * This function enable/disable the 2D engine. */
@@ -145,5 +142,3 @@ void sm750_enable_i2c(unsigned int enable)sm750_set_current_gate (gate); } - -
drivers/staging/sm750fb/ddk750_power.h +0 -1
@@ -38,5 +38,4 @@ void sm750_enable_gpio(unsigned int enable);*/ void sm750_enable_i2c (unsigned int enable); -#endif
drivers/staging/sm750fb/ddk750_reg.h +0 -4
@@ -532,7 +532,6 @@#define GPIO_INTERRUPT_STATUS_26 BIT(17)#define GPIO_INTERRUPT_STATUS_25 BIT(16) -#define PANEL_DISPLAY_CTRL 0x080000#define PANEL_DISPLAY_CTRL_RESERVED_MASK 0xc0f08000#define PANEL_DISPLAY_CTRL_SELECT_SHIFT 28
@@ -1279,7 +1278,6 @@#define I2C_DATA14 0x010052#define I2C_DATA15 0x010053 -#define ZV0_CAPTURE_CTRL 0x090000#define ZV0_CAPTURE_CTRL_FIELD_INPUT BIT(27)#define ZV0_CAPTURE_CTRL_SCAN BIT(26)
@@ -1445,7 +1443,6 @@#define DEFAULT_I2C_SCL 30#define DEFAULT_I2C_SDA 31 -#define GPIO_DATA_SM750LE 0x020018#define GPIO_DATA_SM750LE_1 BIT(1)#define GPIO_DATA_SM750LE_0 BIT(0)
@@ -1454,5 +1451,4 @@#define GPIO_DATA_DIRECTION_SM750LE_1 BIT(1)#define GPIO_DATA_DIRECTION_SM750LE_0 BIT(0) -#endif
Signature · 1 line
2.9.3
PATCH v4 5/7 staging: sm750fb: Added spaces around arithmetic operators.
In reply to a message not in the archiveAdded spaces around arithmetic operators (/, *), to fix the checkpatch issue.
---
Changes in v4
- Added proper version number to patch.
drivers/staging/sm750fb/sm750.h | 2 +- drivers/staging/sm750fb/sm750_accel.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/sm750.h +1 -1
@@ -177,7 +177,7 @@ struct lynxfb_par {static inline unsigned long ps_to_hz (unsigned int psvalue) { -unsigned long long numerator =1000 *1000 *1000 *1000ULL ; +unsigned long long numerator =1000 *1000 *1000 *1000ULL ;/* 10^12 / picosecond period gives frequency in Hz */ do_div (numerator, psvalue);return (unsigned long )numerator;
drivers/staging/sm750fb/sm750_accel.c +1 -1
@@ -384,7 +384,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel,/* Write MONO data (line by line) to 2D Engine data port */ for (i =0 ; i < height; i++) {/* For each line, send the data in chunks of 4 bytes */ -for (j =0 ; j < (ul4BytesPerScan/4 ); j++) +for (j =0 ; j < (ul4BytesPerScan /4 ); j++)write_dpPort (accel, *(unsigned int *)(pSrcbuf + (j *4 )));if (ulBytesRemain) {
Signature · 1 line
2.9.3
PATCH v4 6/7 staging: sm750fb: Replace NULL comparison.
In reply to a message not in the archiveReplaced NULL comparison with pCurrentDviCtrl->pfnInit. This patch fixes the following checkpatch issue:
CHECK: Comparison to NULL could be written "pCurrentDviCtrl->pfnInit"
---
Changes in v4
-Added proper version number to patch.
drivers/staging/sm750fb/ddk750_dvi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_dvi.c +1 -1
@@ -45,7 +45,7 @@ int dviInit(dvi_ctrl_device_t *pCurrentDviCtrl; pCurrentDviCtrl = g_dcftSupportedDviController; -if (pCurrentDviCtrl->pfnInit !=NULL ) { +if (pCurrentDviCtrl->pfnInit) {return pCurrentDviCtrl->pfnInit (edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable, vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable, pllFilterEnable, pllFilterValue);
Signature · 1 line
2.9.3
PATCH v4 7/7 staging: sm750fb: Remove blank lines after { and before } braces.
In reply to a message not in the archiveRemoved unnecessary blank lines after open brace and before closed braces, to fix the check patch issue.
---
Changes in v4
-Added proper version number to patch.
drivers/staging/sm750fb/sm750.c | 1 - drivers/staging/sm750fb/sm750_accel.c | 4 ---- drivers/staging/sm750fb/sm750_cursor.c | 4 ---- 3 files changed, 9 deletions(-)
drivers/staging/sm750fb/sm750.c +0 -1
@@ -806,7 +806,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) }for (i =0 ; i <3 ; i++) { - ret =fb_find_mode (var, info, g_fbmode[index], pdb[i], cdb[i],NULL ,8 );
drivers/staging/sm750fb/sm750_accel.c +0 -4
@@ -259,8 +259,6 @@ unsigned int rop2) /* ROP value */if (accel->de_wait () !=0 )return -1 ; - { -write_dpr (accel,DE_SOURCE , ((sx <<DE_SOURCE_X_K1_SHIFT ) &DE_SOURCE_X_K1_MASK ) | (sy &DE_SOURCE_Y_K2_MASK ));/* dpr0 */
@@ -276,8 +274,6 @@ unsigned int rop2) /* ROP value */DE_CONTROL_COMMAND_BITBLT |DE_CONTROL_STATUS ;write_dpr (accel,DE_CONTROL , de_ctrl);/* dpr0c */ - } -return 0 ; }
drivers/staging/sm750fb/sm750_cursor.c +0 -4
@@ -131,10 +131,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, }else { pbuffer +=sizeof (u16); } - } - - }
@@ -178,6 +175,5 @@ void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, }else { pbuffer +=sizeof (u16); } - } }
Signature · 1 line
2.9.3
Re: [Outreachy kernel] [PATCH v4 7/7] staging: sm750fb: Remove blank lines after { and before } braces.
Quoted 30 lines · Varsha Rao
Removed unnecessary blank lines after open brace and before closed braces, to fix the check patch issue.
Signed-off-by Varsha Rao <[email protected]>---
Changes in v4(quoted diff) +0
-1-Added proper version number to patch. drivers/staging/sm750fb/sm750.c | 1 - drivers/staging/sm750fb/sm750_accel.c | 4 ---- drivers/staging/sm750fb/sm750_cursor.c | 4 ---- 3 files changed, 9 deletions(-)drivers/staging/sm750fb/sm750.c +0
-1@@ -806,7 +806,6 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) }for (i =0 ; i <3 ; i++) { - ret =fb_find_mode (var, info, g_fbmode[index], pdb[i], cdb[i],NULL ,8 );drivers/staging/sm750fb/sm750_accel.c +0
-0
drivers/staging/sm750fb/sm750_accel.c unsigned int rop2) /* ROP value */ · line 263
Quoted 5 lines
drivers/staging/sm750fb/sm750_accel.c +0
-2@@ -259,8 +259,6 @@ unsigned int rop2) /* ROP value */if (accel->de_wait () !=0 )return -1 ; - { -
The removal of the open and closed brace is not refleted in the log message.
julia
Quoted 44 lines
drivers/staging/sm750fb/sm750_accel.c +0
-2write_dpr (accel,DE_SOURCE , ((sx <<DE_SOURCE_X_K1_SHIFT ) &DE_SOURCE_X_K1_MASK ) | (sy &DE_SOURCE_Y_K2_MASK ));/* dpr0 */ @@ -276,8 +274,6 @@ unsigned int rop2) /* ROP value */DE_CONTROL_COMMAND_BITBLT |DE_CONTROL_STATUS ;write_dpr (accel,DE_CONTROL , de_ctrl);/* dpr0c */ - } -return 0 ; }drivers/staging/sm750fb/sm750_cursor.c +0
-5@@ -131,10 +131,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, }else { pbuffer +=sizeof (u16); } - } - - }@@ -178,6 +175,5 @@ void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, }else { pbuffer +=sizeof (u16); } - } } --2.9.3
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/58b2fbe1.43a3620a.b7aff.5a80%40mx.google.com.
For more options, visit https://groups.google.com/d/optout.