Skip to contentSkip to conversation

Use true/false instead of 1/0 for bool initialisations

PATCH Superseded sayli karnik 2 participants 5 messages Mar 12, 2017

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Use true/false instead of 1/0 for bool initialisations

The patch series uses true and false instead of 1 and 0 as bool variable values. Detected by coccinelle/misc/boolinit.cocci.

sayli karnik (2):
staging: media: mt9m114: Use true/false instead of 1/0 for bool
initialisations
staging: media: mt9m114: Use true/false instead of 1/0 for bool
initialisations

 drivers/staging/media/atomisp/i2c/mt9m114.c | 4 ++--
 drivers/staging/media/atomisp/i2c/mt9m114.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw
Quoted 8 lines · sayli karnik

The patch series uses true and false instead of 1 and 0 as bool variable values. Detected by coccinelle/misc/boolinit.cocci.

sayli karnik (2):
staging: media: mt9m114: Use true/false instead of 1/0 for bool
initialisations
staging: media: mt9m114: Use true/false instead of 1/0 for bool
initialisations

The two lines are identical?

julia

Quoted 15 lines
 drivers/staging/media/atomisp/i2c/mt9m114.c | 4 ++--
 drivers/staging/media/atomisp/i2c/mt9m114.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

--
2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1489329182.git.karniksayli1995%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
Quoted 7 lines · Julia Lawall
Quoted 3 lines · sayli karnik

The patch series uses true and false instead of 1 and 0 as bool variable values. Detected by coccinelle/misc/boolinit.cocci.

Quoted 8 lines
Quoted 5 lines

sayli karnik (2):
staging: media: mt9m114: Use true/false instead of 1/0 for bool
initialisations
staging: media: mt9m114: Use true/false instead of 1/0 for bool
initialisations

The two lines are identical?

Actually one is for mt9m114.c and the other for mt9m114.h Had sent 2 separate patches initially, but re-sent them as a series as suggested by Greg.

Quoted 17 lines

julia

Quoted 15 lines
 drivers/staging/media/atomisp/i2c/mt9m114.c | 4 ++--
 drivers/staging/media/atomisp/i2c/mt9m114.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

--
2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1489329182.git.karniksayli1995%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#3 lore raw
Quoted 14 lines · sayli karnik
Quoted 13 lines · Julia Lawall
Quoted 8 lines · sayli karnik

The patch series uses true and false instead of 1 and 0 as bool variable values. Detected by coccinelle/misc/boolinit.cocci.

sayli karnik (2):
staging: media: mt9m114: Use true/false instead of 1/0 for bool
initialisations
staging: media: mt9m114: Use true/false instead of 1/0 for bool
initialisations

Quoted 5 lines
Quoted 2 lines

The two lines are identical?

Actually one is for mt9m114.c and the other for mt9m114.h Had sent 2 separate patches initially, but re-sent them as a series as suggested by Greg.

OK, I haven't see the actual series yet for some reason, but every patch has to have a different subject line.

Maybe it would make sense to just merge them into one.

julia

Quoted 18 lines
Quoted 17 lines

julia

Quoted 15 lines
 drivers/staging/media/atomisp/i2c/mt9m114.c | 4 ++--
 drivers/staging/media/atomisp/i2c/mt9m114.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

--
2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1489329182.git.karniksayli1995%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#4 lore raw
Quoted 20 lines · Julia Lawall
Quoted 16 lines · sayli karnik
Quoted 15 lines · Julia Lawall
Quoted 8 lines · sayli karnik

The patch series uses true and false instead of 1 and 0 as bool variable values. Detected by coccinelle/misc/boolinit.cocci.

sayli karnik (2):
staging: media: mt9m114: Use true/false instead of 1/0 for bool
initialisations
staging: media: mt9m114: Use true/false instead of 1/0 for bool
initialisations

The two lines are identical?

Quoted 9 lines
Quoted 3 lines

Actually one is for mt9m114.c and the other for mt9m114.h Had sent 2 separate patches initially, but re-sent them as a series as suggested by Greg.

OK, I haven't see the actual series yet for some reason, but every patch has to have a different subject line.

Maybe it would make sense to just merge them into one.

Umm..okay I'll send one patch merging the two.

Quoted 27 lines

julia

Quoted 10 lines
Quoted 10 lines

julia

Quoted 8 lines
 drivers/staging/media/atomisp/i2c/mt9m114.c | 4 ++--
 drivers/staging/media/atomisp/i2c/mt9m114.h | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

--
2.7.4

Quoted 8 lines
Quoted 7 lines
Quoted 7 lines

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1489329182.git.karniksayli1995%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.20.1703121554350.2174%40hadrien.
For more options, visit https://groups.google.com/d/optout.