Skip to contentSkip to conversation

Drop Hob support commands and functions

PATCH New Paul Eggleton 1 participant 2 messages Jun 9, 2017

lore
Share & tools
lore
#0 lore raw

cover Drop Hob support commands and functions

Drop some obsolete code.

The following changes since commit 705ab252e631903e6d2e46202b419a9e8adcd861:

bitbake-layers: check layer dependencies before adding (2017-06-05 13:33:14 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib paule/bb-drob-hob-commands
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=paule/bb-drob-hob-commands

Paul Eggleton (1):
command / cooker: drop Hob support commands and functions

 lib/bb/command.py |  60 -----------------
 lib/bb/cooker.py  | 193 ------------------------------------------------------
 2 files changed, 253 deletions(-)
Signature · 1 line
2.9.4
#1 lore raw

PATCH 1/1 command / cooker: drop Hob support commands and functions

Drop a number of the commands and support functions that were created solely to support functionality in the now-removed Hob UI. In most cases we now have this functionality elsewhere e.g. to modify config files and recipes we have bb.utils.edit_metadata_file() and friends, and in OE we have oe.recipeutils.patch_recipe_file() and friends which build on top of the former. Additionally, some of it represented pretty egregious incursion of OE metadata-specific references into BitBake code.

For now I have left in the find*File functions and commands as they are relatively generic and possibly still useful, but they might be removed in future.

---
 lib/bb/command.py |  60 -----------------
 lib/bb/cooker.py  | 193 ------------------------------------------------------
 2 files changed, 253 deletions(-)
lib/bb/command.py +0 -60
index ab51d8e..34d0763 100644
@@ -233,60 +233,11 @@ class CommandsSync:
         command.cooker.configuration.postfile = postfiles
     setPrePostConfFiles.needconfig = False
 
-    def getCpuCount(self, command, params):
-        """
-        Get the CPU count on the bitbake server
-        """
-        return bb.utils.cpu_count()
-    getCpuCount.readonly = True
-    getCpuCount.needconfig = False
-
     def matchFile(self, command, params):
         fMatch = params[0]
         return command.cooker.matchFile(fMatch)
     matchFile.needconfig = False
 
-    def generateNewImage(self, command, params):
-        image = params[0]
-        base_image = params[1]
-        package_queue = params[2]
-        timestamp = params[3]
-        description = params[4]
-        return command.cooker.generateNewImage(image, base_image,
-                        package_queue, timestamp, description)
-
-    def ensureDir(self, command, params):
-        directory = params[0]
-        bb.utils.mkdirhier(directory)
-    ensureDir.needconfig = False
-
-    def setVarFile(self, command, params):
-        """
-        Save a variable in a file; used for saving in a configuration file
-        """
-        var = params[0]
-        val = params[1]
-        default_file = params[2]
-        op = params[3]
-        command.cooker.modifyConfigurationVar(var, val, default_file, op)
-    setVarFile.needconfig = False
-
-    def removeVarFile(self, command, params):
-        """
-        Remove a variable declaration from a file
-        """
-        var = params[0]
-        command.cooker.removeConfigurationVar(var)
-    removeVarFile.needconfig = False
-
-    def createConfigFile(self, command, params):
-        """
-        Create an extra configuration file
-        """
-        name = params[0]
-        command.cooker.createConfigFile(name)
-    createConfigFile.needconfig = False
-
     def setEventMask(self, command, params):
         handlerNum = params[0]
         llevel = params[1]
@@ -645,17 +596,6 @@ class CommandsAsync:
         command.finishAsyncCommand()
     generateTargetsTree.needcache = True
 
-    def findCoreBaseFiles(self, command, params):
-        """
-        Find certain files in COREBASE directory. i.e. Layers
-        """
-        subdir = params[0]
-        filename = params[1]
-
-        command.cooker.findCoreBaseFiles(subdir, filename)
-        command.finishAsyncCommand()
-    findCoreBaseFiles.needcache = False
-
     def findConfigFiles(self, command, params):
         """
         Find config files which provide appropriate values
lib/bb/cooker.py +0 -193

211 lines not on this page · raw message

Signature · 1 line
2.9.4